From nobody Thu Apr 2 12:22:45 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265AC231830 for ; Sun, 29 Mar 2026 03:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753802; cv=none; b=oSX2BDGHFjL/bjWxSZpLcIAlOjpoJF/bv6CHcyiIEl4vyWDVMvUhpXnsyUhviFGJJ4i6RNg6jJRcqX4BKoJ2eV1D/kPlfsV9R/xYUQZ6Oqrp7eppxIvAcPDQwvmtgv0v7eozL1hTaFaT0IkuBsad7OFHnPE1Bz2Oi4hZfLUPvO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753802; c=relaxed/simple; bh=baFH9LtatH2LSfZvgPaA8kqCvgtmmmCYOe717sjvqxE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TbyPJnobPG3CP3P8V+zmHuHCR01rO9rsGEzGJzFz4QQIoU40MawA88X4d6aFW3P283zpKE92l1A/Wx/GH7QjgEfxnrHJwEsGQciTgcdL/nAQr+UCoLvCC9iQWWV/p8lPqaQ8K+chowDuMLQXrDVgaTnAyPzj+NeLnRgfYwy9n6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-01 (Coremail) with SMTP id qwCowAAHsGv2l8hpdOd8Cw--.37861S2; Sun, 29 Mar 2026 11:09:43 +0800 (CST) From: Pengpeng Hou To: maddy@linux.ibm.com, mpe@ellerman.id.au Cc: npiggin@gmail.com, chleroy@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] powerpc/pseries/lparcfg: bound shared processor attribute parsing Date: Sun, 29 Mar 2026 11:09:42 +0800 Message-ID: <20260329030942.26639-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAAHsGv2l8hpdOd8Cw--.37861S2 X-Coremail-Antispam: 1UD129KBjvJXoW7XF15JFy8WF4xWryDuF15Arb_yoW8Jr17p3 Z8KF47Kr4kGa4FkasrJF17XF4j93Z0vF4UWw40yasxAa43Xrn0vFsagr1Fvr4xJr1fGw4r Z3sIgwn5Wr9rZ3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkC14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUYCJmUU UUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" parse_system_parameter_string() copies the shared processor attribute syspa= rm into a fixed local work buffer one byte at a time, but it never checks w= hether the next byte still fits. A long token without an early comma or NUL= can therefore run past SPLPAR_MAXLENGTH. Stop parsing once the local token buffer is full instead of writing past th= e fixed destination. Signed-off-by: Pengpeng Hou --- arch/powerpc/platforms/pseries/lparcfg.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platfo= rms/pseries/lparcfg.c index 8821c378bfff..1bf2312f3e04 100644 --- a/arch/powerpc/platforms/pseries/lparcfg.c +++ b/arch/powerpc/platforms/pseries/lparcfg.c @@ -418,6 +418,10 @@ static void parse_system_parameter_string(struct seq_f= ile *m) w_idx =3D 0; idx =3D 0; while ((*local_buffer) && (idx < splpar_strlen)) { + if (w_idx >=3D SPLPAR_MAXLENGTH - 1) { + pr_warn_once("lparcfg: shared processor attribute token is too long\n"= ); + break; + } workbuffer[w_idx++] =3D local_buffer[idx++]; if ((local_buffer[idx] =3D=3D ',') || (local_buffer[idx] =3D=3D '\0')) { --=20 2.50.1 (Apple Git-155)