From nobody Thu Apr 2 12:21:25 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6556C2475D0 for ; Sun, 29 Mar 2026 02:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752969; cv=none; b=QYPGXev/C+Q/tuBR3kispQEv3+g3shfKqXPoILC9YvWkGxAX2O2SELvcP3qTeU/6jN4g5HgBmvOSByhuQWmfOuzFV0Rqhcak0YDHYUlI9XXcRNnSKdieg5yvVdmJzIsCErfDBBTFp41sKYPUIZr687vibwZtO6iZk7Pz3icjrJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752969; c=relaxed/simple; bh=lm7CjHe8vPHyJKT9bHrJcEmkBQGxKAVk+32c4dZVU4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=esaOu9lM5El44vCJiaqUhQLXhRXzNCRZAAJic/GpnkRGHAa6lnsBebEiMn4fR0x2IUmmgLKeaMPA7HLUpXIPBLRRHuj9Pi151fgmQsCs1usYneDJEO+/p3EsN4f2X8eZtrtEmhuhBVtFsr8/Rra+jiwGW+oAUh8fgMKZJC4fae8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EZi+t/Ez; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EZi+t/Ez" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774752966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kk5wzbs8IQgTgCYcmMENff4wR4lLw4kugXJ7K5XPx8c=; b=EZi+t/Ezl2X9i3Ub6ii0zqB0mOSEgTZjJzXikO6uHupNbUsxFg3KEOwZJKGOjD+w0Dog3f Kvidh5qgUoNOw3rx33xduJYq2hEcpgUw9BBubKRi6YU7olhs/wlFQ4XdqPagKRrOouMFZC W13zE5Hgtnkek2PUpnHrzjO1zkFU6ks= From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, zhenwei pi Subject: [PATCH v2 1/4] RDMA/rxe: use RXE_PORT instead of magic number 1 Date: Sun, 29 Mar 2026 10:55:49 +0800 Message-ID: <20260329025552.122946-2-zhenwei.pi@linux.dev> In-Reply-To: <20260329025552.122946-1-zhenwei.pi@linux.dev> References: <20260329025552.122946-1-zhenwei.pi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Align with the existing code: static ... rxe_ib_device_get_netdev(struct ib_device *dev) { return ib_device_get_netdev(dev, RXE_PORT); } Use *RXE_PORT* instead of magic number 1 for all. Signed-off-by: zhenwei pi --- drivers/infiniband/sw/rxe/rxe_net.c | 6 +++--- drivers/infiniband/sw/rxe/rxe_verbs.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rx= e/rxe_net.c index 0bd0902b11f7..20338cb8e3c2 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -234,7 +234,7 @@ static int rxe_udp_encap_recv(struct sock *sk, struct s= k_buff *skb) =20 udph =3D udp_hdr(skb); pkt->rxe =3D rxe; - pkt->port_num =3D 1; + pkt->port_num =3D RXE_PORT; pkt->hdr =3D (u8 *)(udph + 1); pkt->mask =3D RXE_GRH_MASK; pkt->paylen =3D be16_to_cpu(udph->len) - sizeof(*udph); @@ -535,7 +535,7 @@ struct sk_buff *rxe_init_packet(struct rxe_dev *rxe, st= ruct rxe_av *av, struct sk_buff *skb =3D NULL; struct net_device *ndev; const struct ib_gid_attr *attr; - const int port_num =3D 1; + const int port_num =3D RXE_PORT; =20 attr =3D rdma_get_gid_attr(&rxe->ib_dev, port_num, av->grh.sgid_index); if (IS_ERR(attr)) @@ -630,7 +630,7 @@ static void rxe_port_event(struct rxe_dev *rxe, struct ib_event ev; =20 ev.device =3D &rxe->ib_dev; - ev.element.port_num =3D 1; + ev.element.port_num =3D RXE_PORT; ev.event =3D event; =20 ib_dispatch_event(&ev); diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/= rxe/rxe_verbs.c index fe41362c5144..bcd486e8668b 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.c +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c @@ -44,7 +44,7 @@ static int rxe_query_port(struct ib_device *ibdev, struct net_device *ndev; int err, ret; =20 - if (port_num !=3D 1) { + if (port_num !=3D RXE_PORT) { err =3D -EINVAL; rxe_dbg_dev(rxe, "bad port_num =3D %d\n", port_num); goto err_out; @@ -147,7 +147,7 @@ static int rxe_modify_port(struct ib_device *ibdev, u32= port_num, struct rxe_port *port; int err; =20 - if (port_num !=3D 1) { + if (port_num !=3D RXE_PORT) { err =3D -EINVAL; rxe_dbg_dev(rxe, "bad port_num =3D %d\n", port_num); goto err_out; @@ -180,7 +180,7 @@ static enum rdma_link_layer rxe_get_link_layer(struct i= b_device *ibdev, struct rxe_dev *rxe =3D to_rdev(ibdev); int err; =20 - if (port_num !=3D 1) { + if (port_num !=3D RXE_PORT) { err =3D -EINVAL; rxe_dbg_dev(rxe, "bad port_num =3D %d\n", port_num); goto err_out; @@ -200,7 +200,7 @@ static int rxe_port_immutable(struct ib_device *ibdev, = u32 port_num, struct ib_port_attr attr =3D {}; int err; =20 - if (port_num !=3D 1) { + if (port_num !=3D RXE_PORT) { err =3D -EINVAL; rxe_dbg_dev(rxe, "bad port_num =3D %d\n", port_num); goto err_out; --=20 2.43.0 From nobody Thu Apr 2 12:21:25 2026 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 890A52367D9 for ; Sun, 29 Mar 2026 02:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752973; cv=none; b=Q78nAMBt8/sbwQXbY4psMKQ6EasuyxCCqv60bBjQ6yDnaZ7DGCEtKdf4I27q9pAgu2CTKFN3riPZogcmuuNsogWgysBfFB3QqIUy8ojsiVX+znz789X355DwjytiySf9MIPPg3QtGWRtRbuMLvF0Mq76T2XYKsnanpElUmGCEn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752973; c=relaxed/simple; bh=pEcpNu/97z4wIwjxOudxG2IkzxcXZX6qKiFolAmAEWQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MyPwlps3/3G/+mTm6XbGtRAqJONvb5jpeOWVeFtD03ZM5WJACKBUhZXsk1ArwyMYXHt9yyCz5qWh5sFw8fVG7UDub/Ca9b3v/QYRQfOPnCbvlbsEaBp3bUHwCjgMfRYDTwvqJMrl2R8DZadMItpG7Kbnr7JLc8eR4YHER3ghhEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=t/YtAKcG; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="t/YtAKcG" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774752969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=La2Y59/O6uJYVNjE8wLPFiI8k2gy7IhgTeNJ+XJxkgk=; b=t/YtAKcGiglPRhVOO1HJZtwyhrTQVcFBEKpU1+IuobdarOihRFwvRvr7suRbnuptYlFf1R 0hKdkmTEfDYQA5h/tSehDIudqPWqBFmIjwWiSVwa7VcBQhMY6GdIck387VcEZDRHWn3OqG /79dwftto1T3VB+wA9VAR8PSLsc5iyU= From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, zhenwei pi Subject: [PATCH v2 2/4] RDMA/rxe: add SENT/RCVD bytes Date: Sun, 29 Mar 2026 10:55:50 +0800 Message-ID: <20260329025552.122946-3-zhenwei.pi@linux.dev> In-Reply-To: <20260329025552.122946-1-zhenwei.pi@linux.dev> References: <20260329025552.122946-1-zhenwei.pi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" There is a lack of sent/received counter in bytes. Signed-off-by: zhenwei pi --- drivers/infiniband/sw/rxe/rxe_hw_counters.c | 2 ++ drivers/infiniband/sw/rxe/rxe_hw_counters.h | 2 ++ drivers/infiniband/sw/rxe/rxe_net.c | 1 + drivers/infiniband/sw/rxe/rxe_recv.c | 1 + drivers/infiniband/sw/rxe/rxe_verbs.h | 6 ++++++ 5 files changed, 12 insertions(+) diff --git a/drivers/infiniband/sw/rxe/rxe_hw_counters.c b/drivers/infiniba= nd/sw/rxe/rxe_hw_counters.c index 437917a7d8f2..17edaa9a9b9b 100644 --- a/drivers/infiniband/sw/rxe/rxe_hw_counters.c +++ b/drivers/infiniband/sw/rxe/rxe_hw_counters.c @@ -22,6 +22,8 @@ static const struct rdma_stat_desc rxe_counter_descs[] = =3D { [RXE_CNT_LINK_DOWNED].name =3D "link_downed", [RXE_CNT_RDMA_SEND].name =3D "rdma_sends", [RXE_CNT_RDMA_RECV].name =3D "rdma_recvs", + [RXE_CNT_SENT_BYTES].name =3D "sent_bytes", + [RXE_CNT_RCVD_BYTES].name =3D "rcvd_bytes", }; =20 int rxe_ib_get_hw_stats(struct ib_device *ibdev, diff --git a/drivers/infiniband/sw/rxe/rxe_hw_counters.h b/drivers/infiniba= nd/sw/rxe/rxe_hw_counters.h index 051f9e1c3852..01b355103cbc 100644 --- a/drivers/infiniband/sw/rxe/rxe_hw_counters.h +++ b/drivers/infiniband/sw/rxe/rxe_hw_counters.h @@ -26,6 +26,8 @@ enum rxe_counters { RXE_CNT_LINK_DOWNED, RXE_CNT_RDMA_SEND, RXE_CNT_RDMA_RECV, + RXE_CNT_SENT_BYTES, + RXE_CNT_RCVD_BYTES, RXE_NUM_OF_COUNTERS }; =20 diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rx= e/rxe_net.c index 20338cb8e3c2..ec0ae7479fe7 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -519,6 +519,7 @@ int rxe_xmit_packet(struct rxe_qp *qp, struct rxe_pkt_i= nfo *pkt, } =20 rxe_counter_inc(rxe, RXE_CNT_SENT_PKTS); + rxe_counter_add(rxe, RXE_CNT_SENT_BYTES, skb->len); goto done; =20 drop: diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/r= xe/rxe_recv.c index 5861e4244049..b5522017852d 100644 --- a/drivers/infiniband/sw/rxe/rxe_recv.c +++ b/drivers/infiniband/sw/rxe/rxe_recv.c @@ -342,6 +342,7 @@ void rxe_rcv(struct sk_buff *skb) goto drop; =20 rxe_counter_inc(rxe, RXE_CNT_RCVD_PKTS); + rxe_counter_add(rxe, RXE_CNT_RCVD_BYTES, skb->len); =20 if (unlikely(bth_qpn(pkt) =3D=3D IB_MULTICAST_QPN)) rxe_rcv_mcast_pkt(rxe, skb); diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/= rxe/rxe_verbs.h index fb149f37e91d..2bcfb919a40b 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -460,6 +460,12 @@ static inline void rxe_counter_inc(struct rxe_dev *rxe= , enum rxe_counters index) atomic64_inc(&rxe->stats_counters[index]); } =20 +static inline void rxe_counter_add(struct rxe_dev *rxe, enum rxe_counters = index, + s64 val) +{ + atomic64_add(val, &rxe->stats_counters[index]); +} + static inline struct rxe_dev *to_rdev(struct ib_device *dev) { return dev ? container_of(dev, struct rxe_dev, ib_dev) : NULL; --=20 2.43.0 From nobody Thu Apr 2 12:21:25 2026 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0761DDC3F for ; Sun, 29 Mar 2026 02:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752976; cv=none; b=n/fPJlOzRh8sNcZpWDGoGvDqFkg0Y6kNFIiLpUR78jpaN6B4vptJS6tzRIAWoOJyJIasgQzYZHkHjbQMCwFqmMZYonNr4tPUGrWRvqkWIVP/apdAfvjV2tVVu6SHolD7yabFYhgjrksywKVl1cdC0TGbj2d1whrXlEPziI67JA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752976; c=relaxed/simple; bh=mjTbc53l51J3oFM85tFNnlFBJo9QzXYgUorjr8of/1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b6Tp7Qwe8Xf5PdVT+KWE2Nyg2tsu7aANWaUKOpb9yTdEYnpDrqfnuzIGPpzI9Xbm3uI0E2hK/Z7ik2GarA9FwG0p6HieNGonmKlk543G4k9QDIW+lrfGkyAfgVx4zsZt0KRZN1xbJyl95wxNqIUoHtOjwFE2D2ZLhohOjlzqGYQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=uHxicoCp; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="uHxicoCp" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774752972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uuQCSbogRbV1umDRpyBwQ5yFhByf8ySCWW7drNa8Cxo=; b=uHxicoCpylPjunJGsHg7PQgGETTZYg2zryrwNHmYc2nvTHUu/BeMWPjMWS65vrsjDvUsy0 ELaLVVg2v3f0GVANnAg7px4Z8Dzuflr6ddDCTCWco9uX9jZ+ZaKaS1ExMkqlMTlFoy1s8f 0m/9jQYxXpmoSTKVdXwW7XiPiaE7QL0= From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, zhenwei pi Subject: [PATCH v2 3/4] RDMA/rxe: support perf mgmt GET method Date: Sun, 29 Mar 2026 10:55:51 +0800 Message-ID: <20260329025552.122946-4-zhenwei.pi@linux.dev> In-Reply-To: <20260329025552.122946-1-zhenwei.pi@linux.dev> References: <20260329025552.122946-1-zhenwei.pi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" In RXE, hardware counters are already supported, but not in a standardized manner. For instance, user-space monitoring tools like atop only read from the *counters* directory. Therefore, it is necessary to add perf management support to RXE. Signed-off-by: zhenwei pi --- drivers/infiniband/sw/rxe/Makefile | 1 + drivers/infiniband/sw/rxe/rxe_loc.h | 6 ++ drivers/infiniband/sw/rxe/rxe_mad.c | 93 +++++++++++++++++++++++++++ drivers/infiniband/sw/rxe/rxe_verbs.c | 1 + drivers/infiniband/sw/rxe/rxe_verbs.h | 5 ++ 5 files changed, 106 insertions(+) create mode 100644 drivers/infiniband/sw/rxe/rxe_mad.c diff --git a/drivers/infiniband/sw/rxe/Makefile b/drivers/infiniband/sw/rxe= /Makefile index 93134f1d1d0c..3c47e5b982c2 100644 --- a/drivers/infiniband/sw/rxe/Makefile +++ b/drivers/infiniband/sw/rxe/Makefile @@ -22,6 +22,7 @@ rdma_rxe-y :=3D \ rxe_mcast.o \ rxe_task.o \ rxe_net.o \ + rxe_mad.o \ rxe_hw_counters.o =20 rdma_rxe-$(CONFIG_INFINIBAND_ON_DEMAND_PAGING) +=3D rxe_odp.o diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rx= e/rxe_loc.h index 7992290886e1..a8ce85147c1f 100644 --- a/drivers/infiniband/sw/rxe/rxe_loc.h +++ b/drivers/infiniband/sw/rxe/rxe_loc.h @@ -245,4 +245,10 @@ static inline int rxe_ib_advise_mr(struct ib_pd *pd, =20 #endif /* CONFIG_INFINIBAND_ON_DEMAND_PAGING */ =20 +/* rxe-mad.c */ +int rxe_process_mad(struct ib_device *ibdev, int mad_flags, u32 port_num, + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in, struct ib_mad *out, + size_t *out_mad_size, u16 *out_mad_pkey_index); + #endif /* RXE_LOC_H */ diff --git a/drivers/infiniband/sw/rxe/rxe_mad.c b/drivers/infiniband/sw/rx= e/rxe_mad.c new file mode 100644 index 000000000000..5e0567806c02 --- /dev/null +++ b/drivers/infiniband/sw/rxe/rxe_mad.c @@ -0,0 +1,93 @@ +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB +/* + * Copyright (c) 2026 zhenwei pi + */ + +#include +#include "rxe.h" +#include "rxe_hw_counters.h" + +static int rxe_get_pma_info(struct ib_mad *out) +{ + struct ib_class_port_info cpi =3D {}; + + cpi.capability_mask =3D IB_PMA_CLASS_CAP_EXT_WIDTH; + memcpy((out->data + 40), &cpi, sizeof(cpi)); + + return IB_MAD_RESULT_SUCCESS | IB_MAD_RESULT_REPLY; +} + +static int rxe_get_pma_counters(struct rxe_dev *rxe, struct ib_mad *out) +{ + struct ib_pma_portcounters *pma_cnt =3D (struct ib_pma_portcounters *)(ou= t->data + 40); + s64 val; + + /* IBA release 1.8, 16.1.3.5: During operation, instead of overflowing, t= hey shall stop + * at all ones. + */ + val =3D rxe_counter_get(rxe, RXE_CNT_LINK_DOWNED); + if (val > U8_MAX) + pma_cnt->link_downed_counter =3D U8_MAX; + else + pma_cnt->link_downed_counter =3D (u8)val; + + return IB_MAD_RESULT_SUCCESS | IB_MAD_RESULT_REPLY; +} + +static int rxe_get_pma_counters_ext(struct rxe_dev *rxe, struct ib_mad *ou= t) +{ + struct ib_pma_portcounters_ext *pma_cnt_ext =3D + (struct ib_pma_portcounters_ext *)(out->data + 40); + + pma_cnt_ext->port_xmit_data =3D cpu_to_be64(rxe_counter_get(rxe, RXE_CNT_= SENT_BYTES) >> 2); + pma_cnt_ext->port_rcv_data =3D cpu_to_be64(rxe_counter_get(rxe, RXE_CNT_R= CVD_BYTES) >> 2); + pma_cnt_ext->port_xmit_packets =3D cpu_to_be64(rxe_counter_get(rxe, RXE_C= NT_SENT_PKTS)); + pma_cnt_ext->port_rcv_packets =3D cpu_to_be64(rxe_counter_get(rxe, RXE_CN= T_RCVD_PKTS)); + + return IB_MAD_RESULT_SUCCESS | IB_MAD_RESULT_REPLY; +} + +static int rxe_get_perf_mgmt(struct rxe_dev *rxe, const struct ib_mad *in, + struct ib_mad *out) +{ + switch (in->mad_hdr.attr_id) { + case IB_PMA_CLASS_PORT_INFO: + return rxe_get_pma_info(out); + + case IB_PMA_PORT_COUNTERS: + return rxe_get_pma_counters(rxe, out); + + case IB_PMA_PORT_COUNTERS_EXT: + return rxe_get_pma_counters_ext(rxe, out); + + default: + break; + } + + return IB_MAD_RESULT_FAILURE; +} + +int rxe_process_mad(struct ib_device *ibdev, int mad_flags, u32 port_num, + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in, struct ib_mad *out, + size_t *out_mad_size, u16 *out_mad_pkey_index) +{ + struct rxe_dev *rxe =3D to_rdev(ibdev); + u8 mgmt_class =3D in->mad_hdr.mgmt_class; + u8 method =3D in->mad_hdr.method; + + if (port_num !=3D RXE_PORT) + return IB_MAD_RESULT_FAILURE; + + switch (mgmt_class) { + case IB_MGMT_CLASS_PERF_MGMT: + if (method =3D=3D IB_MGMT_METHOD_GET) + return rxe_get_perf_mgmt(rxe, in, out); + break; + + default: + break; + } + + return IB_MAD_RESULT_FAILURE; +} diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/= rxe/rxe_verbs.c index bcd486e8668b..7df0cb5a09a3 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.c +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c @@ -1509,6 +1509,7 @@ static const struct ib_device_ops rxe_dev_ops =3D { .post_recv =3D rxe_post_recv, .post_send =3D rxe_post_send, .post_srq_recv =3D rxe_post_srq_recv, + .process_mad =3D rxe_process_mad, .query_ah =3D rxe_query_ah, .query_device =3D rxe_query_device, .query_pkey =3D rxe_query_pkey, diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/= rxe/rxe_verbs.h index 2bcfb919a40b..1c4fa8eaa733 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -466,6 +466,11 @@ static inline void rxe_counter_add(struct rxe_dev *rxe= , enum rxe_counters index, atomic64_add(val, &rxe->stats_counters[index]); } =20 +static inline s64 rxe_counter_get(struct rxe_dev *rxe, enum rxe_counters i= ndex) +{ + return atomic64_read(&rxe->stats_counters[index]); +} + static inline struct rxe_dev *to_rdev(struct ib_device *dev) { return dev ? container_of(dev, struct rxe_dev, ib_dev) : NULL; --=20 2.43.0 From nobody Thu Apr 2 12:21:25 2026 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5971D24728F for ; Sun, 29 Mar 2026 02:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752978; cv=none; b=kbjsVJgRsDSWRJNg1gtHTEuO+wO7dRiBC/OiNQPxekeyDuyDHfncTc8aOE6dh8QQqoOF+L+wAWYGHtcfd2JuYUjmtaNXvzqTQVgWeVw8Nl90sEps7sZhE9Ob6gk2djMu/Gh/0RXSlyySHoIlRvl6nxRM/x2mQlO0aiJZlLePbyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774752978; c=relaxed/simple; bh=gHt2uVrQZ+RXG5jw+4DTyKLAgX4ajBlZhvZ+0RsUVl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PjlQtTWk6VZw26lCka+WfV/UycQNAW51zbeNZTm0yrucl0/LfzcV61wLj0IuzNuJCd6d8KSZgcJV1n96by/x4i9PPFXFTjA3w2Ghcn99EEWmzdDK/MXx8PcvICnu2Eck/G6WIL9UT1pAAuunR+tk4az1wor3m3CUbgmetUr/5lc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BwO2wAgt; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BwO2wAgt" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774752975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U/JCIft0jRdQEOBhC6+IC+hol8iiOXSHXWP7V4qbfks=; b=BwO2wAgt0kfTxImf3MYvgHVwGff0XhbABy17PEVsCHq69LneEkrWFZNEADvXEfn7nxRfTo CZ1aBrDM7kTY600/XlrqyFOINiXyLt+XxHAeqJ3Tw6n1Fi0XQQzlC+Ucw121ZsVgf3vVtl yEfDjEgcrnrwsJrOPhxsLJ+tD0lgfxg= From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, zhenwei pi Subject: [PATCH v2 4/4] RDMA/rxe: use rxe_counter_get Date: Sun, 29 Mar 2026 10:55:52 +0800 Message-ID: <20260329025552.122946-5-zhenwei.pi@linux.dev> In-Reply-To: <20260329025552.122946-1-zhenwei.pi@linux.dev> References: <20260329025552.122946-1-zhenwei.pi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" There is *rxe_counter_get* helper in RXE, use it instead of raw atomic64_read. Signed-off-by: zhenwei pi --- drivers/infiniband/sw/rxe/rxe_hw_counters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe_hw_counters.c b/drivers/infiniba= nd/sw/rxe/rxe_hw_counters.c index 17edaa9a9b9b..a612e96f7a88 100644 --- a/drivers/infiniband/sw/rxe/rxe_hw_counters.c +++ b/drivers/infiniband/sw/rxe/rxe_hw_counters.c @@ -37,7 +37,7 @@ int rxe_ib_get_hw_stats(struct ib_device *ibdev, return -EINVAL; =20 for (cnt =3D 0; cnt < ARRAY_SIZE(rxe_counter_descs); cnt++) - stats->value[cnt] =3D atomic64_read(&dev->stats_counters[cnt]); + stats->value[cnt] =3D rxe_counter_get(dev, cnt); =20 return ARRAY_SIZE(rxe_counter_descs); } --=20 2.43.0