From nobody Thu Apr 2 07:43:47 2026 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323A1391E76 for ; Mon, 30 Mar 2026 02:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837680; cv=none; b=WRj/+1rXcjlTTnDZynxpLLpGGrbGCQycftsjO4ViwTR7eWq4EDsLSxp8X+cbVJt7Khxbhnk/WK3NGMPDsfouI7TrKiYMTYQ3itoel3bxi6Qgno9rgzSoLnr+ryAhUNu5VbpmG0MnPn4/LWPfQNUa1bMgyO3q9aV+0nl+G8d4Lm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837680; c=relaxed/simple; bh=QDf16Y7vyxJr6CaPRWRkq0hvjTb2t+Mwk/4kS11e5G8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=swiY7vkNd6Th30mf62n2d1eM1qt/qUaS4/yH73x6W1NqZOgEwDPv+glwUBnQBdXSTvmPV8UgyrZ80Sij3VyqnBr6jB0dc60HTDInbUZYG8dij4kNrhC06PzGSCOpBHl6JVcipFBVnbXqaz7Wd3D90ISRGuo6yGUo50oiB16FLnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M24Nnnng; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M24Nnnng" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2c66eafc1easo554302eec.1 for ; Sun, 29 Mar 2026 19:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774837678; x=1775442478; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Gq4MIC18tzOF8Y9yYjqLKcBworY2R0LEwLR/J/vdJqc=; b=M24NnnngCdbbWFRJIAXGs9rOMgU9vpwJHy6eKIx7wetLpAmVu97WfCeBGQSj0oiOwa VRlu2L8M/6hZRgOyWxjhFPdH3LLfi5wNZjUSJU1v7mCckHdUv+cuQyg16u8ebFKavgyv 4zFRKIlsTE/BdWm3XtfnrtwyUo+KCj+00hAstxj6+OjrqOYUCw8cAudl3YNmqY2OgL14 UscTACGTOijvzFvKpPkQyVbXa8PP0COB1V1Rzi9JzloLlA1EpAw5qLxNNGtTe5b5xbEj 1ngpbViPsQRal7NbA+dJub6KUFsDN5SPM8AKCXLsEa+2gLtH4Q44In8Gm4DLh+TaXsJC eN0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774837678; x=1775442478; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Gq4MIC18tzOF8Y9yYjqLKcBworY2R0LEwLR/J/vdJqc=; b=PAlHnGUKt/gUI/xyYiVa/On4JjWEd2/PQs5v7w0VvXDzRCj8kTNL/GoFPZ/PNbMgrd gqpEFO3bJhIZbV3+cWVmgR8/9NRc/g/NB5fEDVxfBjlaNVSbJnTjER6l7R7QnZdSSARt dUbfBqva0IpUAL58sgWJxerI14eWJt5RjubcuvqP64JYPfIsKnO876AF58LTigF9bTuz HhjxyiXVhTxwb8GOLN31rb6+sYH2/JvNhg4ypHi6sbvFOxkT/kNHpUCv3hmKvAPgZk2O zpaw/Xh6wQ2A35hrGDpZwzExrksIw1edGM65NSYoU3eVPnqPe1nfOLzdS0g7lJKPtU3R YoKA== X-Gm-Message-State: AOJu0Yxa9cb1dK58cUTUkypTGFtufhB9yUAUaKrSEK/VgZlmzjSvCZVS RnHbgBsJQBBIU98TrEyXUZ4+JEFXDbZ4Fx5oDqs2EJILSgvqwKv+1O38jYq9gw== X-Gm-Gg: ATEYQzy6XF/6deSWANX5au1XGdSwZLG2rnKORpilZdaqOyzgeHyDjQpfeX1dcCUqKEE OFFEbTB9dw6h30n7cXMRcybAHumXC3c874SVux/9cZVDMOCghXtH5EM6lwVj7evrJK1eNQ+aleJ vn02mdSxZUaMKRchn4pjzDajA85DMrf/zSsVvqakiz8ozN9wsfxz9JS7xvYuRrYzXRtMnxmhcgf eNq7F51YxPJo9DICAhYTXY0IJP1fLLK5NFIMnHR+tor+0WYcDq21MKZy6uw9kEcrhcc3mHRf3eR XF+jAKf8CvAHBUBDi2zUUCMFjXD8sprF81IW0EueBy1Smcv/ss3tr1H2vXEnngabpLUY/WEV9dt 1KM73jQPtC6Ad30TDSEZHqJ3rDNkYVrBiY7CFEdOFaOEgn9bKPOvrD6gccfrWi1JXdP0c+F+gYP L7FSmVasQi8BlVjh1ErWp9gisno25V9suiOUSHV0mZRKSCgwtoDokOsziKckrlI43BO9evbr1xb kDfH5AmXrVfSqM= X-Received: by 2002:a05:7300:3b1a:b0:2c5:b23e:48a6 with SMTP id 5a478bee46e88-2c5b23e4f48mr1555198eec.23.1774837677943; Sun, 29 Mar 2026 19:27:57 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm6250673eec.30.2026.03.29.19.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 19:27:57 -0700 (PDT) From: Dmitry Torokhov Date: Sun, 29 Mar 2026 19:27:48 -0700 Subject: [PATCH v2 1/4] x86/geode: fix on-stack property data usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-property-gpio-fix-v2-1-3cca5ba136d8@gmail.com> References: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> In-Reply-To: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, stable@vger.kernel.org X-Mailer: b4 0.15-dev-a6826 The PROPERTY_ENTRY_GPIO macro (and by extension PROPERTY_ENTRY_REF) creates a temporary software_node_ref_args structure on the stack when used in a runtime assignment. This results in the property pointing to data that is invalid once the function returns. Fix this by ensuring the GPIO reference data is not stored on stack and using PROPERTY_ENTRY_REF_ARRAY_LEN() to point directly to the persistent reference data. Fixes: 298c9babadb8 ("x86/platform/geode: switch GPIO buttons and LEDs to s= oftware properties") Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov --- arch/x86/platform/geode/geode-common.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/arch/x86/platform/geode/geode-common.c b/arch/x86/platform/geo= de/geode-common.c index 05189c5f7d2a..1843ae385e2d 100644 --- a/arch/x86/platform/geode/geode-common.c +++ b/arch/x86/platform/geode/geode-common.c @@ -28,8 +28,10 @@ static const struct software_node geode_gpio_keys_node = =3D { .properties =3D geode_gpio_keys_props, }; =20 -static struct property_entry geode_restart_key_props[] =3D { - { /* Placeholder for GPIO property */ }, +static struct software_node_ref_args geode_restart_gpio_ref; + +static const struct property_entry geode_restart_key_props[] =3D { + PROPERTY_ENTRY_REF_ARRAY_LEN("gpios", &geode_restart_gpio_ref, 1), PROPERTY_ENTRY_U32("linux,code", KEY_RESTART), PROPERTY_ENTRY_STRING("label", "Reset button"), PROPERTY_ENTRY_U32("debounce-interval", 100), @@ -64,8 +66,7 @@ int __init geode_create_restart_key(unsigned int pin) struct platform_device *pd; int err; =20 - geode_restart_key_props[0] =3D PROPERTY_ENTRY_GPIO("gpios", - &geode_gpiochip_node, + geode_restart_gpio_ref =3D SOFTWARE_NODE_REFERENCE(&geode_gpiochip_node, pin, GPIO_ACTIVE_LOW); =20 err =3D software_node_register_node_group(geode_gpio_keys_swnodes); @@ -99,6 +100,7 @@ int __init geode_create_leds(const char *label, const st= ruct geode_led *leds, const struct software_node *group[MAX_LEDS + 2] =3D { 0 }; struct software_node *swnodes; struct property_entry *props; + struct software_node_ref_args *gpio_refs; struct platform_device_info led_info =3D { .name =3D "leds-gpio", .id =3D PLATFORM_DEVID_NONE, @@ -127,6 +129,12 @@ int __init geode_create_leds(const char *label, const = struct geode_led *leds, goto err_free_swnodes; } =20 + gpio_refs =3D kzalloc_objs(*gpio_refs, n_leds); + if (!gpio_refs) { + err =3D -ENOMEM; + goto err_free_props; + } + group[0] =3D &geode_gpio_leds_node; for (i =3D 0; i < n_leds; i++) { node_name =3D kasprintf(GFP_KERNEL, "%s:%d", label, i); @@ -135,9 +143,11 @@ int __init geode_create_leds(const char *label, const = struct geode_led *leds, goto err_free_names; } =20 + gpio_refs[i] =3D SOFTWARE_NODE_REFERENCE(&geode_gpiochip_node, + leds[i].pin, + GPIO_ACTIVE_LOW); props[i * 3 + 0] =3D - PROPERTY_ENTRY_GPIO("gpios", &geode_gpiochip_node, - leds[i].pin, GPIO_ACTIVE_LOW); + PROPERTY_ENTRY_REF_ARRAY_LEN("gpios", &gpio_refs[i], 1); props[i * 3 + 1] =3D PROPERTY_ENTRY_STRING("linux,default-trigger", leds[i].default_on ? @@ -171,6 +181,8 @@ int __init geode_create_leds(const char *label, const s= truct geode_led *leds, err_free_names: while (--i >=3D 0) kfree(swnodes[i].name); + kfree(gpio_refs); +err_free_props: kfree(props); err_free_swnodes: kfree(swnodes); --=20 2.53.0.1018.g2bb0e51243-goog From nobody Thu Apr 2 07:43:47 2026 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A78A3391E72 for ; Mon, 30 Mar 2026 02:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837682; cv=none; b=j7vsmvYiTjgDlErZxdJ1PYDJXeJV6kFAPd0QxIHuGta9CEV6YS3OtU8ozM7iA3k1GYpbft26ORXwmcAhbpbM/kM/R4FpL7PPE4A9ke6LrVsvxpPhUfyDRNb2zm2gi5tZ6HdLNDgyPQu2V/h54TjBrBGjDnL3xRbIBYWzi0iAzh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837682; c=relaxed/simple; bh=WAA48TAgXPKh6OTsM9jfu2LAkNr3B0EfohpnQi0pV2k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gN1tQRAcuJs1U9NOibpH7M/kpheIgK1zB91zaXXJFunw7RR/6M/ixJLMsBSolM5qDHH/OWZs7WqWBRRPf8GDMxBbVNm3cJelQa42tV2b/54zfmQB203a459opDTih2us3FTOidyjweA9F9cxmPiNFYAQocOXeLoSBFiQTQQ6E34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r58A0fyC; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r58A0fyC" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2c0c955a481so1096330eec.1 for ; Sun, 29 Mar 2026 19:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774837679; x=1775442479; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VMnha1VqvY6bmQXtBiFyEl6o1L0XqC/h5XlUXxbZCb0=; b=r58A0fyC4EgRvj1K6ixjPsSeRbJQtCpAUqcPv0FaJbb74ylmBOHQLNs+UqKJ0bUUz5 EnOYRpaGFvedeyBVMlcn7KjLQd2N886BXoGoVu+xVW+cXHzUXAvJ3pu0WOPUA7nDFtxm lzRBg3QL1ocW4Ax+X9RjzFoMV/ljkOZVRRNo1b6lE+DqnMYdcnbgH53iOrq6HKRDPRln MmoEk125io7XROzhqYvs/t8+Qzslx2VeRBCDOnyB5cHXzC8HIiy68E/C+hJ96o+gO6ot l+t3Tp1HfI2uhHU2296F2GuNpJuD6gj2axfMwkaGnoX9AHLZrBTxwMzNpp6LjK7uqYKH 7s8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774837679; x=1775442479; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VMnha1VqvY6bmQXtBiFyEl6o1L0XqC/h5XlUXxbZCb0=; b=Sp0BCIq1IsQNKnsXQNyPOh3E2z4CgpR0OFHrTB/L2x3QZOXBoTzkEs1hRzN1fDqxc8 ngR9mzNlJ7aDGaWS6l9M8XzJJDo4vVyfAkfGGQSq0IxEQotug3mN9c/Dm+sZT6VdFQ5V XrzIADTzWOTSA2KDWTKr1uuJh1vRTc2tjaACPixc8m9k9Ds2FwRT20x8ssWGXNHF2Rpd hbZ8eS57QccqUWdaYPK0+rLruzXohhP8aCGExldMCqhLJmCAStlhOi9UmoEysZkHMKKR 5QpxP3pHMYjM2uPX0acGz/aen0x0VyG0/w6Qs4BgTHwtyUpyYlV2b9oMS3WI0WzWYU+c LkyA== X-Gm-Message-State: AOJu0YxUKL5TB4wXDbApdXTXPaMhPavFjr24zb+vx9vlY2GrV/YNCQh/ wUOS706eQLElzEnWk3bGGP5/LNz3rPulrp5c9VDF6+kTb3Of+2Gv7xlSU75Oag== X-Gm-Gg: ATEYQzz8oLyAzN1PTGn24kB5jYir8w0O1HndLOlWTUpSIAOLgQ4CQmXx2WoKIRJnWTn 26G5mTad0vmHYjjVvJz7uS0APeiJelNeFnxBwtqDRy/9h09kWI7u/li55JVwu9Gic57ydzKDB9x YY60FGbBc7120uwBf0kiM7m79wI6Ii7SFphPFW46vs/XtOQ6LVFZOn0M36YWfv93tRwz7ZDMURQ sJzubJbudM2hOKaJ6e3s+UrIiEpDHlchc8VuBZCNaY0Hvt2DCAk6NKca2spo/DYxUr5b2vFBEYu gFJIgH91HFTSvGGnx19qr/aNuj1uP/+C/x97PmH+oDRL9+5Tmo/Utju14F32CirQeGPg/YUW8+O UTgWjWQwPkRPgX4u7uaFq+MDhCUYrqs7wGkuxCqicsRpXviCcHNWqycUuTcUwHQivfklxEXMpuc NhDxwByy4QZMPTr+8jChue5v5RYSvm0E1pRSK/ZC35n3LBgC418YLD6EyOgY1RPPSbQZ4isve/H gMA/89uWuGsvRM= X-Received: by 2002:a05:7300:6423:b0:2c0:d9e6:7eb0 with SMTP id 5a478bee46e88-2c185e169aemr6118335eec.16.1774837679449; Sun, 29 Mar 2026 19:27:59 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm6250673eec.30.2026.03.29.19.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 19:27:58 -0700 (PDT) From: Dmitry Torokhov Date: Sun, 29 Mar 2026 19:27:49 -0700 Subject: [PATCH v2 2/4] software node: allow passing reference args to PROPERTY_ENTRY_REF Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-property-gpio-fix-v2-2-3cca5ba136d8@gmail.com> References: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> In-Reply-To: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev X-Mailer: b4 0.15-dev-a6826 When dynamically creating software nodes and properties for subsequent use with software_node_register() current implementation of PROPERTY_ENTRY_REF is not suitable because it creates a temporary instance of struct software_node_ref_args on stack which will later disappear, and software_node_register() only does shallow copy of properties. Fix this by allowing to pass address of reference arguments structure directly into PROPERTY_ENTRY_REF(), so that caller can manage lifetime of the object properly. Signed-off-by: Dmitry Torokhov --- include/linux/property.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/linux/property.h b/include/linux/property.h index e30ef23a9af3..942657e76993 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -471,12 +471,19 @@ struct property_entry { #define PROPERTY_ENTRY_STRING(_name_, _val_) \ __PROPERTY_ENTRY_ELEMENT(_name_, str, STRING, _val_) =20 +#define __PROPERTY_ENTRY_REF_ARGS(_ref_, ...) \ + _Generic(_ref_, \ + const struct software_node_ref_args *: _ref_, \ + struct software_node_ref_args *: _ref_, \ + default: &SOFTWARE_NODE_REFERENCE(_ref_, \ + ##__VA_ARGS__)) + #define PROPERTY_ENTRY_REF(_name_, _ref_, ...) \ (struct property_entry) { \ .name =3D _name_, \ .length =3D sizeof(struct software_node_ref_args), \ .type =3D DEV_PROP_REF, \ - { .pointer =3D &SOFTWARE_NODE_REFERENCE(_ref_, ##__VA_ARGS__), }, \ + { .pointer =3D __PROPERTY_ENTRY_REF_ARGS(_ref_, ##__VA_ARGS__) }, \ } =20 #define PROPERTY_ENTRY_BOOL(_name_) \ --=20 2.53.0.1018.g2bb0e51243-goog From nobody Thu Apr 2 07:43:47 2026 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A9D3921D8 for ; Mon, 30 Mar 2026 02:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837683; cv=none; b=Xblv+ZdgwvS0olKRrzF4hntaqa2vOBkhdk+F1B0mIM8SRGg4+10SehKbTg5VVrdK2iOoC3vO4kRwLzmRZS6WFNI48eE22y/jvZvODpufQcHyeMYgwzB1IzqoBVhbZ05Svc7iap51HdIqQqC5OJXLTWCwTHtWQs2xBWNsCd4Bces= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837683; c=relaxed/simple; bh=bFqZrxIa+wAz0ne9hpWyd8utebsvCUq3EVc4FZvgjF4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yz+yCYMjXOuKq+dsDa8dZadjs9R2qn1HBj26jJDMshUFXAQLauVNUo1vobha3ozRYVnL9SuMqJ2rdWJGQaAnXeqPFJ3JHwYITfh7Z5mxoJNWrkvcXrETPi23GhonzLB8Km5cujqDkL4M9nlxfKRzUfGOS/mX3OSa6nRePYxsue4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W9Uk1jtU; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W9Uk1jtU" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2b4520f6b32so4254510eec.0 for ; Sun, 29 Mar 2026 19:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774837681; x=1775442481; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zqs1uUluer6Mf+lCXT25NfqzHgsGQt/gWHHebQbC4Q4=; b=W9Uk1jtUzfSwS+ApjDjt8P0n0Ww1/75z6hTaBql3scpt/hE1Bl6dqsb30zNPanLEaD Q58BZmuZ9rr4YvkFcx0c7M9iRh/lsyaWJYnbp4juvBTeQgmxGP/LniJHeGHuDwzD/6+y R8h8oc73Wxe2fCrO/3iS65sUCaTBDR6ODBl9l6joajSSjRUfECn1D80NNqEjy4zqImMv UMiIt0TUqY2w9oAO+7mGDVZAMU1Y3pE76q6t5K6qhxHw+Ppm7IpHNyMkZdRuHhSAXk3i UONFVUvYxGrqfLqmvezdu/Hi9qdOXmXve+K0vBlYDEHMSNzf4A5Z6HmV4YjEYO/w9a1A QvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774837681; x=1775442481; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Zqs1uUluer6Mf+lCXT25NfqzHgsGQt/gWHHebQbC4Q4=; b=ikZBBzqUcDdUK0BoEz3HO1QrCRUynpFPpkQ/RiYbTB/pScuLx00ILMywkBqQaML3m1 M9srJkwDZ1oknWvKCeYUn+tTOhkbTIe+Quu3UgyRpC8PqJMDpf4lxFzdOth4Ni3rXwp4 9ju7B6r4dT6KZrOZ2n7wnaGUA6vPr+OIrMgGndTRbK4Ir4LhacIvuYVWWK8T50kVf20F sTKtW53LsW6HWGAHMZGzj3Mg5ON7QdUQym0TXB0rcVLYq1X9szJGTeF8MQNFYIQvQhDH YvT0fKsH73Y/VtzKQrl++TXs3aMvlP+UEEr8POI0El54Vkf7sOPAzw88+FeSl7l1OwRN a2Fg== X-Gm-Message-State: AOJu0YzTg0uPp5Bh13XIxWYa2A4VhtFFnpmY7iZVCHbtKwyamqfWIBLw TzcxOidn+40wnu9jrIvRcd6MDLM/XRjxvXVMTDis4rPLWchp6dZ6ckWISdvz2g== X-Gm-Gg: ATEYQzw0BFFwklj3oMyXtU9cFpmiHhB9Zo5A+aKkPn3jZRDWzKtyQJvHMtEEGNBaaxQ yyATwIyrt8A9gsw2tz9RtKpU9Ia/+s1iBqqZI7afrm4wX1eWW0EafhvbTbhvOsz4jCwdV+dx+ND fGaYQgVCR0mF2oElW3S3tkf7VueuwolQswAtuPkRTWF8oh8O4pVDQ1oSZ0jcFcGZetgFfLxVm24 8uVmAqQgPViaMLbKpzc19LTSQgHNdG6g6m1HCNvYNCggvkwWcZsBqp6GqkqoOqFk+1fVAaV+TuA 7pBbN6oClfVVe3Flz0bSFB+wljORyMKqZygqmXuFOo7fqvRJSBmsXPxo+65Q0zrFcq1jFHUUxwe jJwlyIZelaEQbssirsKrVfEJ0ojezwKhmIfrrPc+jMybPGP/1Eytcta6N4AMonXl6cc3vZvQTMP f4dX+YwytZM8Gba2LaNfOknU61udzbgYNAjFNL6174qoOv82/QGjw7C0O9DvpjtrfDu0sPxVbmn oBW28A0gp73k4M= X-Received: by 2002:a05:7300:b58a:b0:2c5:d833:a4f3 with SMTP id 5a478bee46e88-2c5d833c673mr1330554eec.18.1774837681020; Sun, 29 Mar 2026 19:28:01 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm6250673eec.30.2026.03.29.19.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 19:28:00 -0700 (PDT) From: Dmitry Torokhov Date: Sun, 29 Mar 2026 19:27:50 -0700 Subject: [PATCH v2 3/4] software node: verify that property data is not on stack Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-property-gpio-fix-v2-3-3cca5ba136d8@gmail.com> References: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> In-Reply-To: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev X-Mailer: b4 0.15-dev-a6826 When registering a software node, ensure that the property data is not located on the stack, as it is expected to persist for the lifetime of the node. Signed-off-by: Dmitry Torokhov --- drivers/base/swnode.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 51320837f3a9..286eab02e8fb 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -917,6 +918,7 @@ EXPORT_SYMBOL_GPL(software_node_unregister_node_group); int software_node_register(const struct software_node *node) { struct swnode *parent =3D software_node_to_swnode(node->parent); + const struct property_entry *prop; =20 if (software_node_to_swnode(node)) return -EEXIST; @@ -924,6 +926,14 @@ int software_node_register(const struct software_node = *node) if (node->parent && !parent) return -EINVAL; =20 + for (prop =3D node->properties; prop && prop->name; prop++) { + if (!prop->is_inline && object_is_on_stack(prop->pointer)) { + pr_err("%s: property data can't be on stack ('%s')\n", + __func__, prop->name); + return -EINVAL; + } + } + return PTR_ERR_OR_ZERO(swnode_register(node, parent, 0)); } EXPORT_SYMBOL_GPL(software_node_register); --=20 2.53.0.1018.g2bb0e51243-goog From nobody Thu Apr 2 07:43:47 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0BC0392801 for ; Mon, 30 Mar 2026 02:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837685; cv=none; b=eJ+NdEki+12cSnyy0wYNqXl0xkmURzdnRah3sU+bKI44Y07eageABMZ/EIDkVKfFKS5gpaoyF3D/5uYEoteS65gHApmyEbwKdMNzwU/vfTOM3gmfnPFdqq/glBsC70isT1Dgz21Ioms+86JmKVg4YXyRlfdX4YQZ0lOecj+N7LQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774837685; c=relaxed/simple; bh=Gk/XhY40PWnO3LOxD5YjgUSYIokh9KUYlW7/pTRxeiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GQsAPjnBnanT+waMo9rH8QZatRSVJU+T7MttfIq2DJcnfK5Ya3P5Nd7kCiCXBYiRatjDQQvOUEuoY4+GbD9n+uXbPrIHOLfX7V04LzoD/YhsSmBKXK/YPMnFnTKZoGCY8m2g1+y0ZmNNU1qG7rxbH1dzlbEyvwD4Ze7oL67KcGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H/b1HB/J; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H/b1HB/J" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2c0c955a481so1096432eec.1 for ; Sun, 29 Mar 2026 19:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774837683; x=1775442483; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iu5Dic5CoGqaGahlCm060hwT3Wf5ekOnX3Fgg92paMs=; b=H/b1HB/JcxIsxcFzUtr9F0c5rPn6wZrccqxnNDU4GrNDLgdJNROKnDCqygupDb6f6w Yty04DEhmwqjHFA75nkDOZ4EUadLrlXM3pFkPGs1J2oaQePRGm73cZq8KQ2hYGgu7K4R wo1JEmRgj/8frN4ihuJo386C6i6N+wRLJRSFJEzkbBXKNt7+lwESg9SQiWYHVYcn1EXi IUVoZ6zL1mkkzpHZ9oO8PkNEuv9y0cL8Bd/u1lLntWbxXhRODh8wSB2PUX1UR7reby5U 5eb/Wx0tAY4TJlf0s4SIsptIH6liVqylBTzTecdhnmmtYw6u2PulgufSO0OGnXuUBild 5Cmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774837683; x=1775442483; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iu5Dic5CoGqaGahlCm060hwT3Wf5ekOnX3Fgg92paMs=; b=Oy/TUPFZapdueERqtJ3zHnfrePki7QJwqrSTKkN84oydeIwrYuFjce+O3D3Ijx/Zty wUt02sHDnTqYMtInHvULhU1SpK1aE8/tvOoUinKSm8ktaRkO6A7PqtaJuxZ7Wj9rZ7P9 5jJRCc/rA0OrqGZcxRRpMpSY/BWbqgQeb+XCBybtujchxd/irWgmKWKEwAPcgDaeYuAj T8tjuVfHzCmUo8GAUDZls2UnojOW0X7huhO4fRBFDkeg/jxLMYH99lxgzKISy5ZcWghB Ey3pVExBO1h4diCbwIpgTRxII/AAEd8A/i2kDF9MTEu6oRCmX6jykWvzd0mbxCML0BFw WRQA== X-Gm-Message-State: AOJu0YydKfEPKMBlxgfbZqcsTzlheDdNa54B2veoPMdXNoNSRqBexIz9 wcVbh7oQQk2OMTZbEDsrkS01aNP2297YzbyFeybkFyHX79SstXc/ChwfD3vfxQ== X-Gm-Gg: ATEYQzyAFy1LEys0f87dnlC2eGGHK9AwHEUkLs87FC1a3u5AdAHG/rxcf3xYRrCBeiu +tad0qypbmofiJEiMv2xKRXzCeTYxnkLJmqKSNEfVBLWDYdwFmxCspAFXDi6i0RBGJVqnUODkWj Xbpk06XLFJHEwa3YRQgQkQhFtj7uSljXt1ERIRdZtDrFbuRwYThTrcKrIlHLd2sbpvehXrIe6/E CizsLeO31HinS2a+EDG95/X8RNJ7AoEv33Or+w/Hl3PwWJPJ1Y6qyDoCO1PPTIv5EKsreL21rb5 iRssItiN+PBnkLGIJLpJSRejkvy9NRSQDc8UkkouQQVBRNT64fwoT4Jm5YGq9Yyz8xlr8nFteeo u0e56BTn6Z7GPnetiG+gAoNASx5sWwC3lBmrYXtQEsHHmfDLllA+V0UisCjko2GOMrqOeo9w1oG nflu2p082vnfokw7VfyDfssZH/pKcfKssNEbfJASq1UJMQHtvSO99N1azzMRTlWXM1WXBKBhNxs 2RffQPrZ/5d558= X-Received: by 2002:a05:7301:6781:b0:2c0:d690:7bc with SMTP id 5a478bee46e88-2c185e16735mr6142104eec.22.1774837682719; Sun, 29 Mar 2026 19:28:02 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm6250673eec.30.2026.03.29.19.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 19:28:02 -0700 (PDT) From: Dmitry Torokhov Date: Sun, 29 Mar 2026 19:27:51 -0700 Subject: [PATCH v2 4/4] x86/geode: use PROPERTY_ENTRY_REF for GPIO properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-property-gpio-fix-v2-4-3cca5ba136d8@gmail.com> References: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> In-Reply-To: <20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Hans de Goede , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev X-Mailer: b4 0.15-dev-a6826 Now that the PROPERTY_ENTRY_REF macro can accept a pointer to struct software_node_ref_args directly, we don't need to use the more cumbersome PROPERTY_ENTRY_REF_ARRAY_LEN(..., 1) variant. Signed-off-by: Dmitry Torokhov --- arch/x86/platform/geode/geode-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/platform/geode/geode-common.c b/arch/x86/platform/geo= de/geode-common.c index 1843ae385e2d..6572ae388d7d 100644 --- a/arch/x86/platform/geode/geode-common.c +++ b/arch/x86/platform/geode/geode-common.c @@ -31,7 +31,7 @@ static const struct software_node geode_gpio_keys_node = =3D { static struct software_node_ref_args geode_restart_gpio_ref; =20 static const struct property_entry geode_restart_key_props[] =3D { - PROPERTY_ENTRY_REF_ARRAY_LEN("gpios", &geode_restart_gpio_ref, 1), + PROPERTY_ENTRY_REF("gpios", &geode_restart_gpio_ref), PROPERTY_ENTRY_U32("linux,code", KEY_RESTART), PROPERTY_ENTRY_STRING("label", "Reset button"), PROPERTY_ENTRY_U32("debounce-interval", 100), @@ -147,7 +147,7 @@ int __init geode_create_leds(const char *label, const s= truct geode_led *leds, leds[i].pin, GPIO_ACTIVE_LOW); props[i * 3 + 0] =3D - PROPERTY_ENTRY_REF_ARRAY_LEN("gpios", &gpio_refs[i], 1); + PROPERTY_ENTRY_REF("gpios", &gpio_refs[i]); props[i * 3 + 1] =3D PROPERTY_ENTRY_STRING("linux,default-trigger", leds[i].default_on ? --=20 2.53.0.1018.g2bb0e51243-goog