From nobody Thu Apr 2 10:36:42 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B412D5A01 for ; Sun, 29 Mar 2026 11:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774782853; cv=none; b=QxetqxLSvtP4MusfA8ANOrUVjzfw2Rzo7yAKB2Mac5yZGbttam7At2O7GFndcnQmrr8ZKiajeErL2UxaYpMiddEV+XEE3+iX7kImkqxrW7fO5PvW4nnTVs9n6L8cJZyPf2BkO10kCU40zQg6pfy+FchXtg34kmJ9HTnEtBHgcZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774782853; c=relaxed/simple; bh=u+hbg2H3lOYYW1ebDQugMjdlCQVFZ+T5/ivVf6GLPhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mvgPgYFR2M2MMoBfhxCEL/kEkXOovgaylM9bkuJEw1PM8lEPbnusugdybokJzM14rIQyLaTpNj0HXbOULqkqIaIY64ypC24nIc49rF1txCbpEqJrJtTFcxBQfXiGvLg/3ZVwvZjovVsqIuCrM9YAoDqosgi0oP4j8EEORPB1Wp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VFB4ahsb; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VFB4ahsb" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82a07738118so2004777b3a.0 for ; Sun, 29 Mar 2026 04:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774782851; x=1775387651; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=QVjoQBkXiGI1oWD/lbihuPbS4PWSjwfos2KaFS/Ehss=; b=VFB4ahsbL4hP9rarNw17ILy0GK3Z61xPKH+2vGDAFBLI6V93xFuni46Euau4U/sNYx bkaIwqTPoxuhRy3ghgSjYqzJKgtRFUENyxdMDzTPKQ/l7Fv2YcluwfoLr5+EklPtjBcS 9ktSxziGIJrv5F1csjPQweOcoiIGYP+ySKnY7lp6P4yz2GNeKhXAkoWzTIJye9bxDFCl Yg+58pH7ERfyvKuKOQwkjvP9TQ3ry+J6ss7zfB+WNilEkSqRItHYCduIlyiPM8j57nrW 6vrxCwjT6Q6U9KDKJZ0eKdOBpGviUJkCSV8pgr76zDIaGP1HMVhNHhx0YPzDSjcuOZfr b9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774782851; x=1775387651; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QVjoQBkXiGI1oWD/lbihuPbS4PWSjwfos2KaFS/Ehss=; b=LD/sJvmCrsvx7tTtZbLxns+98M7G4M6beqVHGgkhIjtnzcTtBG0rtuVy+F7z41aQKR Y0/eCYGVEfLRs9klrokNJhnGNA3NkTrBSWP5flWL+FMJY7gzb1chlBIwBQ7TXodfaxjM myT+ZCU8IMo2cFY7A2vuPmNNV1qlRi2K5UsQghqzAJbb+z3GinIEl4w7Sx7a0udzAy3f RihXmImGEnYKl2P68J5BGpW2Bs45SGpGnk3WcIq2Ny1H3czdyDdlgGIOmB1i9i0gmB9m 68kxda/QNeFbGwZ8NYkCrfJxg/iAtjd2S5Bb7w7HzcaqnbyyjGXs7lZ9HGYE/yA5pU9/ VxKQ== X-Forwarded-Encrypted: i=1; AJvYcCW8045FJOCrNAtprUq3zXdbS6lzRPwKdypMQrymEAmyq0r11ShjKDuj3QkCjeBmB5MZMVi4oXepMnQoPwo=@vger.kernel.org X-Gm-Message-State: AOJu0YyDNzUK1vt0z3ZIH3PhzY+XfvRZOMyvKefuFP+8dHT86T8s/zRm rcF9X72G8XQ+glIZutgmgxvM0ggViymSQGKnhtDV/rSbNRTOex0p8eLg X-Gm-Gg: ATEYQzwVLN+T5YH5yv7oISh5AHly3ziFyFX1JRvOGn9hz8bJ+65qrFJrDGAW9TpMidh hBoNhh0wlJvrKHwQ76WLwNfZ7ofcpeRE44IY7mgvcRVjUEGtHxiWlxqIiY21uK9Aj/XDAIA+BHn vww2STAsVPrm9PfAZPwwMpSCa36FEooqNasMhxGdIZ304nsWkrylYo8htINT24vnm5TFrPjcD/H BZ2b57Ub1A36UyhFtNriWt5R+z/V/GBMNLwnmDowOK37kLMh1Vl193LdEFE89UwBNTrrTla38+Y OK0RlfIRUwpGoHgiMoBE5+xDt9OUmBjdhfvtvqsFmGJzSmelNFfhExOZKO1cu1i79zSGRjXvMw9 XDD8BM4qYxap5GnBUeGV0Up/xajreyczSB9+3frajrmPt9gvvqaKzJjVP3FvBnHDyVm791y2PQu bf7KLAuAIo+nxRxeT3LoRgvrG2mOG/k5kIBsWV X-Received: by 2002:a05:6a00:2395:b0:823:ad3:4ff4 with SMTP id d2e1a72fcca58-82c9605da6amr8434908b3a.37.1774782850914; Sun, 29 Mar 2026 04:14:10 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85fc72asm4266744b3a.48.2026.03.29.04.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 04:14:10 -0700 (PDT) From: Felix Gu Date: Sun, 29 Mar 2026 19:14:05 +0800 Subject: [PATCH] spi: stm32-ospi: Fix resource leak in remove() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-ospi-v1-1-cc8cf1c82c4a@gmail.com> X-B4-Tracking: v=1; b=H4sIAH0JyWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyNL3fzigkxds8REUwMzgzQDS4NUJaDSgqLUtMwKsDHRsbW1AK/8AIF WAAAA X-Change-ID: 20260329-ospi-6aa5060f090e To: Mark Brown , Maxime Coquelin , Alexandre Torgue , Patrice Chotard Cc: linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774782848; l=1157; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=u+hbg2H3lOYYW1ebDQugMjdlCQVFZ+T5/ivVf6GLPhs=; b=Wc+RgivG/glkyD6BlqKjX69NgtVzBwdBy7l8yiL6UpV2oi7bjj4Pt1hW9blTiLqjXXkYTkr2Q oNytratwqJCBjE2tZt6rpcUGtyqOf5tFXsRvhdA1IK+XuVfSZ9CeaiD X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The remove() callback returned early if pm_runtime_resume_and_get() failed, skipping the cleanup of spi controller and other resources. Remove the early return so cleanup completes regardless of PM resume result. Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver") Signed-off-by: Felix Gu Reviewed-by: Patrice Chotard --- drivers/spi/spi-stm32-ospi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index acf2d182e8b1..192a20de1ae6 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -984,11 +984,8 @@ static int stm32_ospi_probe(struct platform_device *pd= ev) static void stm32_ospi_remove(struct platform_device *pdev) { struct stm32_ospi *ospi =3D platform_get_drvdata(pdev); - int ret; =20 - ret =3D pm_runtime_resume_and_get(ospi->dev); - if (ret < 0) - return; + pm_runtime_resume_and_get(ospi->dev); =20 spi_unregister_controller(ospi->ctrl); /* Disable ospi */ --- base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 change-id: 20260329-ospi-6aa5060f090e Best regards, --=20 Felix Gu