From nobody Thu Apr 2 15:36:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAFA288D0 for ; Sun, 29 Mar 2026 00:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774744405; cv=none; b=b89/BT/uCor3hbtRjvBpF7/NTPfZgD/ffoJ/aT4p9U8ZNF3zFx4j53XlJE21c1aXjgEORp/nCksHZ2KRM3RNXyBzcjNV4UvtmJlv8ccs13D0K+AAmceKrwsPENr903I+b9hMY+JPH2r3GpdcHKVcgEQCZS50xWXkTg+VVDhreV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774744405; c=relaxed/simple; bh=R9G5DrWK7ZdreBHQ/NvwOHQkAkxN8nydMv+XrJUDCnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XCo13m7t9aGF6ThxWw5piJBKHIcWfoApzUjcfUW6/7cAebqBG+dgipO7nQV6hkNMscgGMyGR01XwoY4lN2CBv34xEO15PMhy7izvj2VxojwpfwADDfJ46jj3NF2qOWyag4RHk93xG2M0OQvhr0NmFjTYZRu5xLNS7Mv4+ppqVTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ya9djmdE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VDZwEGdt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ya9djmdE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VDZwEGdt" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62SKlj9F3928566 for ; Sun, 29 Mar 2026 00:33:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=Ya9djmdE5C2/pVnk u8qbOgyadgRG0/o8j+Tfrz6ohRU+idoQsVFu1J5YNNm8MiMTk6C5e9qjPLVEjoJx FQV05Gp7CkqEyuNhhWXsqMxFAmDQk95JuGl+9DlE+b03Wpq6tbSISZv1ucKxildY ywIKg8cORZYSRR2k0vuqLiB9xSH8isaz5zmJ7o5pMl3823iKb2RKvJEVQrQoICDy DP2UKojzjG5zHFGb9y/Funk8LWACbuqeei2Z4xbH3k/DkPcYgqRk1AsJvGbRb+Cp w2ytSCs+jYX7vBCPYE5IWArisztl6OjtZHonYSt2a8tQMQWAu2zAXEV7lUgPDuvD pi9UoA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d64bm24d1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 29 Mar 2026 00:33:22 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5093787e2fdso163738931cf.2 for ; Sat, 28 Mar 2026 17:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774744402; x=1775349202; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=VDZwEGdt1lVZUToXEilfWZ4GfVl9JIAnqIIXxsTBqxgV+imi1yYMMYOYc6LXo384Hy JpjPoaUMfDopVD5ys6YMSKYtjiPq6aI4andoTXUtBVOpvcJDrz7YAs/kSh1C74zNec4R Cr06Yz4zdlKc0mEoWU83hYbRq7fTEvkIN1ZoWCYannldlUSmdaxrCantUjy6t3z5ApWj hKetGFHhBCjCHSt7hMGes+SOZKFBsE4DXn/xn5b8scZqrUZ+zYwmH7r8tVvx7PGbDuTc iBbb7vx0cSxiuQSVF+93cGKqmup5wbJiF2HsLZaO7MOjCaolnrv5QouXiLUJQUwA4nSu Qu0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774744402; x=1775349202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Yu4Ju/BNMWhFePsUEYj76VBRHr5svFe8Za8zkvDfGq4=; b=i4alDTfQvgyaqbaXJPV8Pg/3NcfIiNgTCg7cdQfmCPjlznYVUzhFhC/aESWP9R1fwH AmeAzEdPodrG+s4FSoOB3vYU/D6NeK72kQxaEDiFlpkfs2HygDnduMX/+JOPtR736o32 RYNMxcUdNSJLpomQTYDdxye4S4EdeEoGUlPrQgbXqqOuY1u1UF4bV9NNDc+FNStxuSWj MvAMHs+VwpmaQPRzdcOzhRR+M5aOWA8NxOu/Fmf9/6MhsUyN1IYGq7NU2NtpLKlVu1em IXZ6Dbe4bK1CbzHLathzKuenerzsKxIFmFN1toVYF+O4hViE76ipwm2+WIR01fglmn0x jrNg== X-Forwarded-Encrypted: i=1; AJvYcCX7HPe9LuxG6oiE18J3r3UheL1iI0cHllq2ESwKoZ2QaTTU67dpO3g70r3jWYFQj4riEftJh/LbvyYS8bc=@vger.kernel.org X-Gm-Message-State: AOJu0YyvBqeKAFDwbN/d9p2+VRQc9QLiQTqTGyzpv4QRHHa/ar2c/lrH gvv9yvuxXDouucmwhIczX04zFrSydq3mVgbl7YK6BPUgxSCzLPuHs/CKIP+kw9q4NE8z42ObQkO peR87y/g2P4j+cxQ6PanHB7RFm4Dt47dUbnW8WQDV9d1GM9xS0BmbMlmDsQjKw7XXSk8= X-Gm-Gg: ATEYQzxfV+5RPjTzNHK7nyZOAyX0Aq+OaKuy7xOGrwaJqxeOUh5moq12hqi81q2GHCw QrxhJtVxupHD+k3psr3UlL5hUw15D8/+zkoZr29Roc+gOVx4KhcsGWqOBf6mMIbjaKx8jdatQUj grBCw/QmtStM66SKc8qOyncmrfN6GN21KcIsy5R3Nk6LHxa3jkhJs7jy509/tgNGe6YTWVrrSox KJGsCudHknrOr0lwotaUcUXUA3wIPIXCkW+2YwHKjaVc8LYwD+iu4o9vk2EG2cFmS5yjIILE0ru e2/+2Gxi8f3M6ZBM4xgjyVvAEi+qbqwr/vQZSm1yGZ4aNXO3StNNhcWmOmvefgYoFaAhgcL2xeB v1JffQKVKi/mMccRx7JI6zvlrI0uoJCcNphlelheup5gZR4amRAQ1Q/j9ym+qyesl8G43zayQhk pMq2N5oqDG9KG79GXE1G0BQ0n8+7DioJF7sDE= X-Received: by 2002:ac8:5802:0:b0:50b:3c78:ddef with SMTP id d75a77b69052e-50ba38c8fabmr103942271cf.41.1774744402094; Sat, 28 Mar 2026 17:33:22 -0700 (PDT) X-Received: by 2002:ac8:5802:0:b0:50b:3c78:ddef with SMTP id d75a77b69052e-50ba38c8fabmr103942101cf.41.1774744401625; Sat, 28 Mar 2026 17:33:21 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c83892035sm7024731fa.22.2026.03.28.17.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 17:33:19 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 29 Mar 2026 02:33:02 +0200 Subject: [PATCH v11 01/11] media: qcom: iris: drop pas_id from the iris_platform_data struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-iris-platform-data-v11-1-eea672b03a95@oss.qualcomm.com> References: <20260329-iris-platform-data-v11-0-eea672b03a95@oss.qualcomm.com> In-Reply-To: <20260329-iris-platform-data-v11-0-eea672b03a95@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6224; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=R9G5DrWK7ZdreBHQ/NvwOHQkAkxN8nydMv+XrJUDCnI=; b=kA0DAAoBizyKPgIpKNUByyZiAGnIc0egjt+DeQOTRkMh3QdYNg8EzID8ShgV8XCGmVqrAnQSk YkBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJpyHNHAAoJEIs8ij4CKSjVfB8H/12Z fKrCiMV4OEPb6QjVS1cuA+4VSpa8EXZpC9rmfReogfIBN/0xCO2Tw7UAXiHwfWKMoX7adY4N+wn 3cVWHtEmTnrrwc3Co6o7CwF1qSDBkbNZOoVdPzBUApnlyFDyWRal9iE5mEOUVEstKi4GLFCt6FW aFpF4hNcFlogqreA29UqMYtJkMGqyikBVsszyy00MrP0l9hBX1g5emOWJhyuCgkwSSP8wF/Ks1O GSenuOigxQuqsaOguIouEMRk3194EaIrtbleH3TaBDhZWgsQ0lNZ2gkN15xLu0nu3G3nDxGHCX1 vFi4U2gaiHqxLhf+z5zgscMBnrC3pU92Ruy5Eek= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: nMWXabLOJEV--ZMxq10IY0JOJOMlnDja X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDAwMiBTYWx0ZWRfX5brCz5CPud/v DVHzr0Q6P6fRIKnVjLnVIKP6Fbm0YTkRHwcO+fcikm7/ihLCHr4tc2iyMVVislBe+P8Uzl3otLH kjdf2phtQt8Nn6V4Z95bi4e594kEmh0VISdUKAI7QYac/vlghySX2nz8p80QDOYH/vxcCeFVjLE hTcWt2+oEhchIN8+i3XnEhTzG/JXESGJLg1Vjh84544Q96KiPgbeqi8SWmXRkVv9ImPZxfGttUH 23fzmnaeh3B7oBr35+i3ifgvKDjQaE2wHWO59K4TMrB4wYhuqWFJ2QnDnW9rpXX+uu2NxhKWe/x toicgQ4tvbwqmQ2pTh+QMTPrJ4hO/VOCjXvHEu36c/YaZ9E5/V1C8s9m06scyRjA4j+ZTdOIUNw cmfjTxi92Wu0LRTll3tPy/092ipaj1TZHc7G0bhqni8gC4C9PjIwDSniv/EhBjP1fjabJyVVvLr vzJ2/WUqGjjIvJK+zvg== X-Authority-Analysis: v=2.4 cv=eJAeTXp1 c=1 sm=1 tr=0 ts=69c87352 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=hYMYe-gnznq9qBW6PAEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: nMWXabLOJEV--ZMxq10IY0JOJOMlnDja X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-28_03,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290002 The PAS ID, the authentication service ID, used by the Iris is a constant and it is not expected to change anytime. Drop it from the platform data and use the constant instead. Reviewed-by: Dikshita Agarwal Reviewed-by: Konrad Dybcio Reviewed-by: Vikash Garodia Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_firmware.c | 11 ++++++----- drivers/media/platform/qcom/iris/iris_platform_common.h | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/med= ia/platform/qcom/iris/iris_firmware.c index 5f408024e967..bc6c5c3e00c3 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -12,11 +12,12 @@ #include "iris_core.h" #include "iris_firmware.h" =20 +#define IRIS_PAS_ID 9 + #define MAX_FIRMWARE_NAME_SIZE 128 =20 static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_n= ame) { - u32 pas_id =3D core->iris_platform_data->pas_id; const struct firmware *firmware =3D NULL; struct device *dev =3D core->dev; struct resource res; @@ -53,7 +54,7 @@ static int iris_load_fw_to_memory(struct iris_core *core,= const char *fw_name) } =20 ret =3D qcom_mdt_load(dev, firmware, fw_name, - pas_id, mem_virt, mem_phys, res_size, NULL); + IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); =20 memunmap(mem_virt); err_release_fw: @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) return -ENOMEM; } =20 - ret =3D qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); + ret =3D qcom_scm_pas_auth_and_reset(IRIS_PAS_ID); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret; @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) cp_config->cp_nonpixel_size); if (ret) { dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + qcom_scm_pas_shutdown(IRIS_PAS_ID); return ret; } } @@ -103,7 +104,7 @@ int iris_fw_load(struct iris_core *core) =20 int iris_fw_unload(struct iris_core *core) { - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + return qcom_scm_pas_shutdown(IRIS_PAS_ID); } =20 int iris_set_hw_state(struct iris_core *core, bool resume) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/driv= ers/media/platform/qcom/iris/iris_platform_common.h index f42e1798747c..e4eefc646c7f 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -12,7 +12,6 @@ struct iris_core; struct iris_inst; =20 -#define IRIS_PAS_ID 9 #define HW_RESPONSE_TIMEOUT_VALUE (1000) /* milliseconds */ #define AUTOSUSPEND_DELAY_VALUE (HW_RESPONSE_TIMEOUT_VALUE + 500) /* mil= liseconds */ =20 @@ -226,7 +225,6 @@ struct iris_platform_data { unsigned int controller_rst_tbl_size; u64 dma_mask; const char *fwname; - u32 pas_id; struct iris_fmt *inst_iris_fmts; u32 inst_iris_fmts_size; struct platform_inst_caps *inst_caps; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/driver= s/media/platform/qcom/iris/iris_platform_gen1.c index aa71f7f53ee3..07ed572e895b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -360,7 +360,6 @@ const struct iris_platform_data sm8250_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu-1.0/venus.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, @@ -413,7 +412,6 @@ const struct iris_platform_data sc7280_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu20_p1.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/driver= s/media/platform/qcom/iris/iris_platform_gen2.c index a526b50a1cd3..1f23ddb972f0 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -934,7 +934,6 @@ const struct iris_platform_data sm8550_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1038,7 +1037,6 @@ const struct iris_platform_data sm8650_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu33_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1133,7 +1131,6 @@ const struct iris_platform_data sm8750_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu35_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1232,7 +1229,6 @@ const struct iris_platform_data qcs8300_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4_s6.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_qcs8300, --=20 2.47.3