From nobody Thu Apr 2 12:33:35 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D80430DEB2 for ; Sat, 28 Mar 2026 21:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774735139; cv=none; b=imIHRvOq9x8t0y6kafBMlz3mbSYJiigwJA2QRiK0pMPms93SsLfHfUd9AF7Yk6xPLTNehzA9uwLhGTSpS/d+OC5yDmImMJUUDIKgrcp3wTGruq4v/6WLJCqfC4c+aE1AURyPdSeUE5Z8okU8TBiGYvQYrC/kYaZrYUeuRW5LJtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774735139; c=relaxed/simple; bh=w1OtwFSIIEFzlkWZVlPJH50aUgOjLaM4Wyv4g9zgn88=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=FqJCRKP1iu4vX6RMSSqoYFfavWdO0rp7C3qPV+EPNLjAByyLLyh8F1I/ZF8biIyRXfQTFl03K66Y+/HYItoK8MJquoPnodtf2ggXddlGGLB1xxxlNs+djUUUD57FHku1P+Twu/CqTBEyoKLsfAqKz800sHPd5KAE6vjG9cJ1FWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gdhLs8pz; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gdhLs8pz" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486fd3a577eso28202675e9.1 for ; Sat, 28 Mar 2026 14:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774735137; x=1775339937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GovFc/Quryn7Wrtc0cRqpho3m7htvaaEbNv4FAPywhk=; b=gdhLs8pzN4KgWuKwMOBKIfF2RBEaICGTNwYrXwU6m+D40/kr/+XbCsZp8i84fcmRTZ YzLYGuGM8A3VSNNaRy51lfmyjhGIthjIz5zXKWJX4As/ieh8Rya2/2v3CcDTVBwOOT34 4vUyEDiTwfCWtaPzxgOxiQUSZ7F3syThzuQagRnuELS8vfU1mfsBzBTpwfvIF+RicJSz Ei0Qb02X/pCoSc7Z9hCWIInZq4E/TE8LaXobGWYDmyR3r1pmJHjXPmnD8k1M+fhUOuXm y1KHuyyDEf07j1lylNOE8okNkIh3PH0cUekxrbCr60tkHkN+GHAuJo9F+OfBirlIez04 Pl3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774735137; x=1775339937; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GovFc/Quryn7Wrtc0cRqpho3m7htvaaEbNv4FAPywhk=; b=Rm8zQLEXdcd3yIGfOhlBUSB40ytazh0QKEUrirHu5L5KAjDUQtPKSYDHk1yO/Zy8/Z 1mMSmJoFMl2J6a2pJFqTfcJR+I9k0lifg3zpADjB4SevHM1J0I9Hb13tXWjHBVeYDgPO zl6pfUuXT6LVCQWhUhJLys2GkOdORlmizUMmm4vJj4hOgSbgLCT/LpHJR+KCGFPEvnF5 qDRoVLwEzIQwihG3XMrz3eRTRK5jTmVmd0CZxbIScezpCT0gcGnXlzYrFDKlN7AWDt/D mZ7eN7hbV8CMdbQtgmAMWsB6rUeYuYcyqCiSFo/LiVlmGVWbrZYCkeKl2s9CzoSA65Xm Kq7g== X-Forwarded-Encrypted: i=1; AJvYcCWIyvDKZPRie2K7500inwHPe1C8p1uSbw16M1vURkMsa1jdQ3KpI+WxUPz/5zpzUHfkHmU41rcD5SEzYO8=@vger.kernel.org X-Gm-Message-State: AOJu0YxPWJmVgchInzVYWRo9rFTV+8pypyPgzOjdMOTqex3VEZPmTjJm g9IkUy855m3a1YQw9KqNZT+eJc4LxnnQg2Uw9Aq6MxGrXv8Vt5acKGnN X-Gm-Gg: ATEYQzxs39yL7khne1N/vRcNSG9YJIOuNAFGEwlMkcfzdTdEoH5c3WvMChd3VqCDvGY DhfPrlv6yKdqG9+gng+405VdWNG5THpRXM0ESGayNfTc5Qwy9t8TfjXpova9zVL7OGv21ZT80NG zGaZ4/KHucr+SpVunrNyTXYcwnDYNrq4U7jQ5V/OFEII2H/Vhp+X2AfnWe2ll7esr/5An4Sy+Br hBi/0cYunaZ5dKLVX8E7g7jIWouoXyiuwvyQunas2MHappJ7U/9pTvq307DoXpv+olk7eaZDAi7 qt92nmiyUZ8vaIpCzSbOe6h+qav66a6BFNLCHNtDfx4+EyqZwdZv7KgssvCWPY+Uqp294ha+3z4 qaZZXnSVGC4W5e+rdlQ2EZeIeEursTkQBQR9zpr1Lj5tdbuKWlZCXvcsidasi9Rcp51+LQdcBey brtRgPojCki807rv7eRp1iKCmsYqvqvdGMjFnSXr1Gdo6dInHfd6DuaZxqdbDKB9jDIleBFTC4D dECzCcxl+Q9eN3H44aerhfeFg9DHXnDX06fm7u6YrNmg+qRGk8+k8BLtB0i5LqfOCg45ymFOE4B Y1f26Ip34ayGC9oh5dnsh6mK1gfUt5xRjc3nGwPzv8KkCO1yyt2KkhsV72s= X-Received: by 2002:a05:600c:3586:b0:487:1fbf:e0bb with SMTP id 5b1f17b1804b1-48727d5a17cmr130395765e9.6.1774735136501; Sat, 28 Mar 2026 14:58:56 -0700 (PDT) Received: from archlinux.kangaroo-newton.ts.net ([185.213.155.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c845b8sm158502225e9.4.2026.03.28.14.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 14:58:56 -0700 (PDT) From: Christos Longros To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Christos Longros Subject: [PATCH] vfio/pci: sanitize bogus INTx interrupt pin values Date: Sat, 28 Mar 2026 22:58:08 +0100 Message-ID: <20260328215808.16108-1-chris.longros@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Some PCI devices report invalid interrupt pin values in config space (e.g., 0xFF instead of the valid range 0-4). The VFIO PCI config virtualization layer passes these values through to userspace, causing QEMU to crash with an assertion failure in pci_irq_handler() when it computes irq_num =3D pin - 1, which exceeds PCI_NUM_PINS (4). The existing code already handles bogus VF interrupt pins (set to 0 per SR-IOV spec =C2=A73.4.1.18), but physical functions with out-of-range pin values are not caught. Extend the condition that clears the virtualized interrupt pin to also cover values outside 1-4. Observed on Realtek RTL8852CE (10ec:c852) which reports interrupt pin 0xFF in hardware config space. Signed-off-by: Christos Longros --- drivers/vfio/pci/vfio_pci_config.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci= _config.c index b4e39253f..ed75c1cc3 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1829,8 +1829,17 @@ int vfio_config_init(struct vfio_pci_core_device *vd= ev) cpu_to_le16(PCI_COMMAND_MEMORY); } =20 + /* + * Sanitize bogus interrupt pin values. Valid pins are 1 (INTA) + * through 4 (INTD); anything else disables legacy interrupts. + */ + if (vconfig[PCI_INTERRUPT_PIN] > 4) + pci_info(pdev, "Bogus INTx pin %d, disabling INTx virtualization\n", + vconfig[PCI_INTERRUPT_PIN]); + if (!IS_ENABLED(CONFIG_VFIO_PCI_INTX) || vdev->nointx || - !vdev->pdev->irq || vdev->pdev->irq =3D=3D IRQ_NOTCONNECTED) + !vdev->pdev->irq || vdev->pdev->irq =3D=3D IRQ_NOTCONNECTED || + vconfig[PCI_INTERRUPT_PIN] > 4) vconfig[PCI_INTERRUPT_PIN] =3D 0; =20 ret =3D vfio_cap_init(vdev); --=20 2.53.0