From nobody Thu Apr 2 12:20:43 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 343C7175A5 for ; Sat, 28 Mar 2026 19:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774725505; cv=none; b=Dei3yG0jVUp83Xd0+kdNAYowpnm1xG0fSxSDdRg4fXsq/9wz1BRDhKllRztEb5IaPdhsy0usd3gc1byO9TopJsBI4bQC5KmvuQguEExRxQ6wGAjgVNM5Xnrr2WjcbSy0Wv29oYmBfL75h1DbaBLeTSdU8bwHXB7Xh+WYtCjTo1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774725505; c=relaxed/simple; bh=TIUrJlohH7zzcX5wL9kNLLx0H8njEDL4nmQhrrq1NaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZeqUqQywd8fTmCNYd6ApIXgCumapbcBO8BkxL/LMTI3SX+kj23zBbTHGEIFEvXYqBULXFOWyVoBhfCHswjJa1FOMuYgAA9yMTPBm5XbfD5ADpUuJEwmzE72WOpqLk9PbRjv8HtloAcoB+vBZmoxkTN2zU2qeBVbXzw5JhQ3V2SQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZoDqehKT; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZoDqehKT" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35d9827661bso219969a91.3 for ; Sat, 28 Mar 2026 12:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774725502; x=1775330302; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X/Kc/rqS3O8FcnFqoMXkBJLowbwjhPQjCnPmNyfgP7g=; b=ZoDqehKTM7Df0VULo5ckJhalU41/QfXu2ZetmY57DoxkSTTpvY2b2Vjxftu1ZeCy3v 7a9N6ocwFKkokOfCZjpbg9mIQ+2DALjvDARimaD93CPa8S4o+9Yz8+SpHsLogU6kEkuN UroEfSFiDjSJbT5bIaiGm74k7ErbmeeguQZbeY7JcMyxF+4HwW4FAW5WvVoGR5whM6DK k43K9Uengqga4EgPANop7eb8L4hs1Zn3dKqGQU0jxVPfkUNEsANibblCv69Gavg44hsp 3AKvs04xGfmnxlHPD2bnULN5QcRH2xOgEWJzK+Q5f99q/a923BvP6V2uFJWczN1RNgUd mUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774725502; x=1775330302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X/Kc/rqS3O8FcnFqoMXkBJLowbwjhPQjCnPmNyfgP7g=; b=jKIke3oXUFtTMQnsvfN53zODgfA6mDv1zVVTzCm2BC9CKsDQaUnRnFVyHNemqYwxAD LCQQeRf/sJDWMLAG9MZYTd1NE6Sc/tqutjaOJU4DEH0eNf7vmeQiTadakqC9XUXaU83X 18OG6WS5bP8CEbOZ0quwzwNDEGMd1i69euO/dnvMuN1D4BcSdrg4bN2V96JdwYmn+qYt 3Pi4QECUWRZ/kDLKYKV2fj+tetKHMnP5QY6GQrngXTSg23T7J4wS8URTVVeOX8vTSL86 aO2+ovo7iMLFQH3Tt9xVDvdkF1+dhweUXdf/GRnqdPG8X2LoySMYRVvirK+P3TiYEzUa RMSQ== X-Forwarded-Encrypted: i=1; AJvYcCVG3uhqoIOYBKd0dlZJeHtV/BNC2ra/v7DNy0ydRuzpOzh0YCwBsxeVPBIrgvNBoh4Iufr4sHouGGqAZ/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxNQQIEpzFvx6wtK88tB1hQRomaEWlGSWRpory36047ODgRtBeR jf0Qw30CLxx0SL6NHr2KFJztGF//TRBYYxUSbxx9u4wttC2eSSV78HB+ X-Gm-Gg: ATEYQzwwWzrSLs7gqO/1cCRUhUXMt9awCMy83VYM36uUf7bqJuDGuV6/i/ivvZ8Pu1/ ih3EvpEA9rf1A8f++U8AeKL/UZl6FTpkUG6AbzFFzRq6NP0W4eZZppxWvo0p3B3+P88b5+yOeqB DVt7f/9jpcUH7+97yj3OsWTQEOHT352ewmOUeOreW/Hm3kbDJVk+uidKXjBKRv4X/7UAvbM+F8r twkArQ3ZB2vmMY190J8RONzma8qyUz8dbQBfcUNU51zy9/9ofnG/Zy05EV5IazA6RdV+cofbLFT oKUZNINhI9Gzt0uz9FBi2Go+MUkXz78qsNJ/oWdV1gqq60qNWCYjs2z6j5GKd4GddMbm5Y6d66K xPt/5mpCAsVCg/RiVXhrPr/XKskoAd3VKeTNu8j16z5hyRC1c47Ks5FgMt/QGC1fZ0nBcyBlA/w t7eKbtpy5qkan5oXs6jBsvhoGIeHb90jfpAyOTzmB6UEKhi5/+L47YoQ== X-Received: by 2002:a17:90b:3e81:b0:35b:a8cf:7969 with SMTP id 98e67ed59e1d1-35c30000104mr7222978a91.11.1774725502396; Sat, 28 Mar 2026 12:18:22 -0700 (PDT) Received: from debian.killsync.com ([103.38.13.110]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d9507d739sm2684165a91.11.2026.03.28.12.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 12:18:22 -0700 (PDT) From: aravindanilraj0702@gmail.com To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 1/2] thermal: intel: int340x: Fix potential shift overflow in ptc_mmio_write Date: Sat, 28 Mar 2026 15:18:05 -0400 Message-ID: <20260328191806.8675-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328191806.8675-1-aravindanilraj0702@gmail.com> References: <20260328191806.8675-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The value parameter is u32 but is shifted into a u64 register value without casting first. If the shift amount pushes bits beyond 32, they are lost. Cast value to u64 before shifting to ensure all bits are preserved. Signed-off-by: Aravind Anilraj --- .../intel/int340x_thermal/platform_temperature_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/platform_temperature_con= trol.c b/drivers/thermal/intel/int340x_thermal/platform_temperature_control= .c index 0ccc72c93499..18ac5014d8dc 100644 --- a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c +++ b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c @@ -138,7 +138,7 @@ static void ptc_mmio_write(struct pci_dev *pdev, u32 of= fset, int index, u32 valu =20 reg_val =3D readq((void __iomem *) (proc_priv->mmio_base + offset)); reg_val &=3D ~mask; - reg_val |=3D (value << ptc_mmio_regs[index].shift); + reg_val |=3D ((u64)value << ptc_mmio_regs[index].shift); writeq(reg_val, (void __iomem *) (proc_priv->mmio_base + offset)); } =20 --=20 2.47.3 From nobody Thu Apr 2 12:20:43 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F14933DEDD for ; Sat, 28 Mar 2026 19:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774725508; cv=none; b=rgBSFOojgKM/DfCuAm1DGVjgeak+CP8i/NqvFYmEyG4Jwc9btB21dfSXCU49fEoBEpC0KJ1prc+0a9kzbdmgXA6MB9Me9h7b5UoThgqxSKkO0thh1HUXUcOr3RRYF/e+fjUeL3QBSMTzTgE61sxmjG02Xw8Y5SJSlpVN6Hb9bCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774725508; c=relaxed/simple; bh=JZcLUYCLYEhZcBKzzSCYlJLv9uoFBvbrytjcn306C04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dXSEztnIlTKCfpi5vGlkYT3Shmzcj8x4EjTiG6rsBzCehGTzy4dRCZcLQV8hfvi6D9QuNdYZAxxPpb7rZnR7dpxH+xDAUSwItqjUB7UXIaTWMOUQ9AYGgECZ2rC21Vd2lfA1d2I8YjJbrb6tYXYzBMDpawPVkHx3YkLdxIb6cac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C8mvyrBR; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C8mvyrBR" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35d9c7bf9a1so250622a91.3 for ; Sat, 28 Mar 2026 12:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774725507; x=1775330307; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WA9Y0VWD6q8BWRqcW8ZuOdPM6JPIhso+ucpZhyQ2OAA=; b=C8mvyrBRrU49GTfLJAXWWCZRdy+aeykgcJ9h7TWos7zP8jX/gScPNAD8cb2iyens6t PY1o1VJL47l/nnXEx25hfMaZtO/MBhsPBzjEwiMR1Ye619d5iFQaNkV/YvOnYxrAk00n 3eE1rcYYmxah46170Ym+0bqQA1TnSDR6sJwFPZuQgrL182arqSgtjGjj/AbAYN3kcgNE OLTWYJVCuh1kXKIZTm90VVuKPBYfNccwcL7MUSyDQFoNMGy4OB7DpUlyGVIkA/TezL2m mDyNTkhXvxyjdzvvsWfAEZq/w7xiYXRw3kdYc5L6Q/uKZCibRilI4i/fuqYWFL3MZpeN BSyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774725507; x=1775330307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WA9Y0VWD6q8BWRqcW8ZuOdPM6JPIhso+ucpZhyQ2OAA=; b=XwALPOLxH5oYWVh6e1Fzr0r9X+OOTQqzqigLpIK1+BczsGeafp0Rkxl5YqL0SGB2j1 +jZgWszFmOcqKLBpMAmENPTSdfsYpxeIlZxCqXSrnYso9H+CCcVF7k+kls6kn8FzS9pd aUWvB9P2W7rtRvcHqumEzE2OikUiD81HoujoRTanV7OaECNseeBbmsP0NoK/5y4awtpC rb7p3+YslUOj/xRjfIlzIbscfXNwvPfiCtg9iT3+wwl3VedOF/XVfZrVNdcZpERNUVME tEqROXliPE/9JV4eKkNHxiAmo2WyQNtEYT/8xmkN66/QeZ4hyDCUGO7zGG8H3Gf+5Zwo w7eA== X-Forwarded-Encrypted: i=1; AJvYcCXs2JxDfCEO39Fbb8z0D0SFu00EWluwU6VOmOw3cZ9cuwGGPPQrTqcJIc/J9ze6+ESuGtkq7mkiikU8z30=@vger.kernel.org X-Gm-Message-State: AOJu0YxpI9arAJRXh4PloEUNff6ZwspmAVmdCMO5cCbwpGIGVr+esJUB BowwGX4Hn/UWvQ+cpmFxpiqgCYffgcWt1WBYG9AfqohDl+rBT8LxDsOv X-Gm-Gg: ATEYQzyDZm4OjrfPQTsCajxFuSgWtVWl0lX//GDIEkKHH2bmjsIN+TX515b1o4qugtc KRWFRaaUvfBxNwHKC7Ham1v5MBAmlnug/OkRkSPuf997sFLgoeckqi7BLDg6w9b8doqsDrkIlk7 cZCJ+W1yzJaCB2O/kbni4QFOmiJTkRlaislXVglQX88bUnywdF1Do7IPcGqyqqIukiX9EeSF5lL zzqR0GnJw99ELL6xXan9+iBLsS1IGfNJSRT7nQd32YPHlWKZ5cUnFZVYdBP+Us++cDibpc7ADRG XKWaf99HEYUXW03GECnmkapy01AxbxNMirx1oEPBWfcHq5kNBK/0KALyekf8AYt1fEEmA0DnkkH GyjvNQnvOFA/rWGRPJ92FgKOmiMIpcKSS1OWeKwloR00dw3JxqGEg3h6rM8TK5tXj8qaa2dr1Kv pvCYldzzbgeRYarvHHgOOwk20nArkdMkG1+qiG5QBRuZaAMfe1IDuZBg== X-Received: by 2002:a17:90a:dfce:b0:35d:9f60:827 with SMTP id 98e67ed59e1d1-35d9f6009acmr431713a91.29.1774725506725; Sat, 28 Mar 2026 12:18:26 -0700 (PDT) Received: from debian.killsync.com ([103.38.13.110]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d9507d739sm2684165a91.11.2026.03.28.12.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 12:18:26 -0700 (PDT) From: aravindanilraj0702@gmail.com To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 2/2] thermal: intel: int340x: Check return value of ptc_create_groups() Date: Sat, 28 Mar 2026 15:18:06 -0400 Message-ID: <20260328191806.8675-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328191806.8675-1-aravindanilraj0702@gmail.com> References: <20260328191806.8675-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj proc_thermal_ptc_add() ignores the return value of ptc_create_groups(), causing the driver to silenty continue even if sysfs group creation fails. The thermal control interface would be unavailable with no indication of failure. Check the return value and on failure clean up any sysfs groups that were successfully created before the error, then propagate the error to the caller which already handles it correctly via goto err_rem_rapl. Signed-off-by: Aravind Anilraj --- .../intel/int340x_thermal/platform_temperature_control.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/platform_temperature_con= trol.c b/drivers/thermal/intel/int340x_thermal/platform_temperature_control= .c index 18ac5014d8dc..caed572c6061 100644 --- a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c +++ b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c @@ -278,12 +278,14 @@ static void ptc_delete_debugfs(void) int proc_thermal_ptc_add(struct pci_dev *pdev, struct proc_thermal_device = *proc_priv) { if (proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_PTC) { - int i; + int i, ret; =20 for (i =3D 0; i < PTC_MAX_INSTANCES; i++) { ptc_instance[i].offset =3D ptc_offsets[i]; ptc_instance[i].pdev =3D pdev; - ptc_create_groups(pdev, i, &ptc_instance[i]); + ret =3D ptc_create_groups(pdev, i, &ptc_instance[i]); + if (ret) + return ret; } =20 ptc_create_debugfs(); --=20 2.47.3