From nobody Thu Apr 2 15:36:14 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8A6C34DCF9 for ; Sat, 28 Mar 2026 15:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712312; cv=none; b=S9HNCasQvyRsCSw13+ZzQwhICT3alsSQjycnImn3oSSOiwedfdrzBLOgNYY5wDmkKR3cUO+pcdZjLXNew9mgJrOD5+PU7D1TqYn+I+96dwearLOEDmVQoLUWI6VR9xXc3Usg+xwoodWD1PfDnUtm+dPNj29FzjlwYWupL7aeZVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712312; c=relaxed/simple; bh=jKFU9ClukmgrQPWCuZbiDz6loGcaVsfq+0devSW3yqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H6qvWnXTeaUUHnTbEOb3px59G7dchUIldJ03OBZq3JjDmmUJhSCTZPLNs/VQdCfuL+RMt8R2c0no8laWCYtKUQV+o0Uq8iy5lr13xEExFQeZ5X5VKo7fMlIcKtSQQfA8xfMOcyweguIZqkOOgR5X/lq0zDyY9rtWA3+UEOshh7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d54tlCLI; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d54tlCLI" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43b9f43a1feso1209616f8f.1 for ; Sat, 28 Mar 2026 08:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774712306; x=1775317106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VSDysc2SqFR5k0dxgouFFuDk3xltDf+gaI9kO7u+6DU=; b=d54tlCLIAxO4E5L9qkqidJsAsPupSKML+yLUH4Ea0tmotgjQ+5fJlWPR1aZvREBZNv Xbabun8tWx151fbaD37uc1qzDF+enXOUyLoTmRt0DOj6KSM6I/a+LjvjuAfDh+rxC/Lr tvYWv6HfoWj6ej9HRIiK7xMnzppcDa2YjyACH4GNyIhpynr/PxPL3lCt5qfMeCAOGXxD R5y2QWt8y7WBxptjVRTbNY1DpSetuDMC4N3MW7m/1tsivKWIZglMKxQZvH4s/s0IZXkw H963SUlvTQx5akZVrRwiqPoNXSBNCiXRGogH9myxYJm/ipsNTmq/2g0saDGK0Iim4B0V GoGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774712306; x=1775317106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VSDysc2SqFR5k0dxgouFFuDk3xltDf+gaI9kO7u+6DU=; b=M7nvExMvcLA8w1+EmGkoiaf5HgJ9AIuj+1+z5+ByMZEl+kM4ToAeKlIZwSneH8CGJ0 QroIQCEYkZ2Hjv12hLBgnrYKewfrdtuFQSOm3GN9k3dQMxx68ToLBtu+ZEyIW8/dLRC3 mTQS1/lczcIpzkIx+Rr65/D19zxdmC6jFoS+YuLZ3ho+EZkB+35I/GHhOOIJdA18R9Sz HHp9DoUtGWBQWLnmSsIckApQZeXTp8hY1glNFXYBGn5Y+LusJEERFNuMAn2tULAHqJVL yqM3wJS4vJ7CV24byiw/3TeHbAd1yEQhGfU2RBnOztpGjMzUmRo6bXezQmxbXeZtniFo J64A== X-Forwarded-Encrypted: i=1; AJvYcCU8Ztt5WoZlDJykYj/ukxXNzapAkUSpxZmUbEQytADKCnBWZ+mgl6JyEOM6oK+2ByEFc6KKTZp6bomLi/k=@vger.kernel.org X-Gm-Message-State: AOJu0YzKBrRM0siK/XhT0wgfRbTUGa2UCOIu9//zqmDvrP5WIfb0mk3i TezyoQuE5xoKJ9za53PRQyDOItXNV6dn4JWX1MzrkdqOfJ/w+kHCrRDd X-Gm-Gg: ATEYQzyTOiujkLg3UXOp+O8hU55MXSZkr/DzCW5uZmBha4AW1wzHpra06E1e+JN16AM HQlWmlKiM/mzdLk+D+arQxR5pl+5vyCoJQC0zVu7WmDH7NfGHq0u82Gv7oFbmBioX+hUkc51l6s U59wd9iHV7IHOMPoC9F4MZtKHOkLOyFCYPLmUc1BeLkwNr/zqj5cYUO2WURlPQwx1Ng9q0uORFb fEEuLqpZO4+PjbUbAv2f+eM/q9Tl1KukKmLH2uFrUTq7Wj6UDNLWrWkXWbv+eth7LH9ICYaX6kj 3wBytxEw/Di21hyLM0ycn0CqD0sfYDrCpkbkmUwaJYVFIiuZZRqaw4VgGDmU4JakCOz57G4N68Z 0YVGwvL7++ZVt4x/9eTGvt0it1aaTZ840H4iq0wMGEJT/K4Vtd8llhJokU96xIgB4EjTdSCPqbA EtWZAar7JHNexYSBKRWVtM+fkPmne/PWJ8Biy8ZSR/2q9ifOo1azbTpiDAQ/ZPXGrW6lYf0K5yW A== X-Received: by 2002:a05:6000:26d3:b0:439:ba4d:bf40 with SMTP id ffacd0b85a97d-43b9ea62f50mr10725997f8f.43.1774712306142; Sat, 28 Mar 2026 08:38:26 -0700 (PDT) Received: from f.. (cst-prg-89-171.cust.vodafone.cz. [46.135.89.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf247102dsm7196887f8f.27.2026.03.28.08.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 08:38:25 -0700 (PDT) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v2 4/5] fs: handle hypothetical filesystems hich use I_DONTCACHE and drop the lock in ->drop_inode Date: Sat, 28 Mar 2026 16:38:06 +0100 Message-ID: <20260328153807.3368975-5-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260328153807.3368975-1-mjguzik@gmail.com> References: <20260328153807.3368975-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" f2fs and ntfs play games where they transitiong the refcount 0->1 and relea= se the inode spinlock, allowing other threads to grab a ref of their own. They also return 0 in that case, making this problem harmless. Should they start using the I_DONTCACHE machinery down the road while retaining the above, iput_final() will get a race where it can proceed to teardown an inode with references. Future-proof it. Developing better ->drop_inode and sanitizing all users is left as en exercise for the reader. Signed-off-by: Mateusz Guzik --- fs/inode.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 1f5a383ccf27..fc6045e6d43f 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1933,20 +1933,29 @@ static void iput_final(struct inode *inode) else drop =3D inode_generic_drop(inode); =20 - if (!drop && - !(inode_state_read(inode) & I_DONTCACHE) && - (sb->s_flags & SB_ACTIVE)) { + /* + * XXXCRAP: there are ->drop_inode hooks playing nasty games releasing the + * spinlock and temporarily grabbing refs. This opens a possibility someo= ne + * else will sneak in and grab a ref while it happens. + * + * If such a hook returns 0 (=3D=3D don't drop) this happens to be harmle= ss as long + * as the inode is not marked with I_DONTCACHE. Otherwise we are proceedi= ng with + * teardown despite references being present. + * + * Damage-control the problem by including the count in the decision. How= ever, + * assert no refs showed up if the hook decided to drop the inode. + */ + if (drop) + VFS_BUG_ON_INODE(icount_read(inode) !=3D 0, inode); + + if (icount_read(inode) > 0 || + (!drop && !(inode_state_read(inode) & I_DONTCACHE) && + (sb->s_flags & SB_ACTIVE))) { __inode_lru_list_add(inode, true); spin_unlock(&inode->i_lock); return; } =20 - /* - * Re-check ->i_count in case the ->drop_inode() hooks played games. - * Note we only execute this if the verdict was to drop the inode. - */ - VFS_BUG_ON_INODE(icount_read(inode) !=3D 0, inode); - if (drop) { inode_state_set(inode, I_FREEING); } else { --=20 2.48.1