From nobody Thu Apr 2 15:36:15 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4494C70830 for ; Sat, 28 Mar 2026 15:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712689; cv=none; b=eYF35j0wmtoiyjKIfMye4yvHf+cHJC8FIwKufrAUIwEyA2qE6LJHXtVT0eu2vG5n95jIIGfK48XmgBCriZF2+I7TCI1IUon9z5aiHas/XrLJzBV2vvzvbaTeLrqpdA21ItyEaFGRKJh2lcbQb4kRyIcoqWIcdcgCank93bDYK1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712689; c=relaxed/simple; bh=HZYHztId16pgGQ1AA2UfRM6DJRt8s7EcWewCjcgDwxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DdNae2D3oTjipKi/o2FVHduco3V7NLHWKPJgmriGJioXGGSTkgF9QnYerKgRjfQxPew1CyoA8s04fdvfLFNkN9OaRMDWfJMD9//T8Kbp3t8jeEnc125aYhB6LLCfk8nlUdOrpoNjAUbWrnE4bajbcC7VqFqtgHFuotV3Vra0/kA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TYGLyi2U; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYGLyi2U" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48704db565eso42098015e9.1 for ; Sat, 28 Mar 2026 08:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774712685; x=1775317485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wqq43BIgVMA1uE3zJr5f2QtdxqeDEFGIZU0biEFlpEg=; b=TYGLyi2Uw4w66rcR/hhwRr4Z3OSlv0kHiLWNUwIYp3UszCKUeZFzqJbiyq44lQxtyA 2GUtruKK83mv/oxwUrIFqPkk6H1pizXEjdR9qzLIUJ+K5LWCmXONTxnhZv9AuTKdTUXJ 5Te+n58zWy8hgunWBjAXNxYmG3wld1pCxUUAlHGajLPgf3ryhpiagHMrj7iODtvtzHA8 vNl37qIoJVTkib1LYinJN1MjEusvt9WacMlz7pc3a4n5eHINsqNLCq5TZUm2NwN9nH5y pWqadh9KhODRC7WrhUDSK1mlfPGvCNjqz6WwuudWWMAFLQa0A2WM0dOI+M4XIu8j9FaY jpfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774712685; x=1775317485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wqq43BIgVMA1uE3zJr5f2QtdxqeDEFGIZU0biEFlpEg=; b=L3C+HFJr4m7IfMhXoQfQ5dC6hrV61igbNaqeM5DU9CB44GvECuHE0H1QJDKa2U0Bfy 3qJ0KHtxwKJPB7cY0borg4g3LdkuAaQS/n/WtJk2VTu0s9yStS6Ba6xyK0uGgs75cy1X r6FTIB44xZz7dwzPGD4G86OZ3m29XprZVwqZryIo1YSRVUWi0er2JOxxKNOWqe55bMQd I8MPsMWshj+69Ogogv+MHpTCsxWq38FeUuYMJfBajq0OzeboyHEghYxjYd/90Rrqm4Rc fUbgmapZ0OaYtKvgdWj7bAj3fRJhLspj6UFEnUVN08pElyt49EOD7w4TisrJ5HUgAAMq QqpQ== X-Forwarded-Encrypted: i=1; AJvYcCUeIhpe1XTp8Id1TjFYyrSoJ85JSuGZ47/O6HI8iVGx33cLl5oh6H9qU0vrKSjQa3iOabu/GpAufVud11o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+L9GIcKdFTuia3QOAdxE+eiUxTKeO63+UOU9NTxg7ziAC5JtW odsKjCKjg3XeuTsH9GKDfCvhA8RceKnMGekefpyvk5M1KTRbvNByrRwL6lcnkQ== X-Gm-Gg: ATEYQzyc0pVghqZ0NaC6tgi7XEdXi8FTN8aLyAARwB0dMZbC0fIjyGF3PIxqMw6DGUe Thr/B4KHxTDdbArFaV4Dcj0XTDkol29z1AnnYrVZibBKC0NSPCkmko5whDX8KB1dYW4tQ96JMO9 +7u46mL6KQvQ/Pyxsl/IDOvTPuwRZH9Krke6X8tgxkVuJK3YDjeKwsr5N7ToSi9UnSstIGEmByn JFtEOQe+Nn5R5X+dvU26IAEozkN1Q224CU8y55dwm719GSM2ud4ilTmQw3kvahP+1Zby2m7cOJm Ljvx2FEU/cGBoszPM0FZswCeV3VNCsDbTMXGd+0p4Uke3MWEqkawoUBPDW2Wn/N2taXbP+r5VzD RR6iIlxN0RVQ7UWAkIHUcSgW6qxXtuS+ECUWnyYxsaC9PncgJ54NA7Pg3Yz0/Wi7FnbHi8cGq4v 8WWfYsWUXDDpviupob6EP8cVngDj8fFl3Gt61ZRonO6x2M65/BjL582ncumdX9My6QH5Kg+F//E w== X-Received: by 2002:a05:600c:c8f:b0:487:21c7:2885 with SMTP id 5b1f17b1804b1-48727d45a8emr109339485e9.5.1774712304275; Sat, 28 Mar 2026 08:38:24 -0700 (PDT) Received: from f.. (cst-prg-89-171.cust.vodafone.cz. [46.135.89.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf247102dsm7196887f8f.27.2026.03.28.08.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 08:38:23 -0700 (PDT) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v2 3/5] fs: enforce locking in icount_read(), add some commentary Date: Sat, 28 Mar 2026 16:38:05 +0100 Message-ID: <20260328153807.3368975-4-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260328153807.3368975-1-mjguzik@gmail.com> References: <20260328153807.3368975-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Mateusz Guzik --- include/linux/fs.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/fs.h b/include/linux/fs.h index 0cf27085a579..07363fce4406 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2225,13 +2225,21 @@ static inline void mark_inode_dirty_sync(struct ino= de *inode) __mark_inode_dirty(inode, I_DIRTY_SYNC); } =20 +/* + * returns the refcount on the inode. it can change arbitrarily. + */ static inline int icount_read_once(const struct inode *inode) { return atomic_read(&inode->i_count); } =20 +/* + * returns the refcount on the inode. The lock guarantees no new references + * are added, but references can be dropped as long as the result is > 0. + */ static inline int icount_read(const struct inode *inode) { + lockdep_assert_held(&inode->i_lock); return atomic_read(&inode->i_count); } =20 --=20 2.48.1