From nobody Thu Apr 2 14:20:42 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA5A223EAAB for ; Sat, 28 Mar 2026 16:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774715928; cv=none; b=um0fo7xCG2y1MeYURN7Evu6LAgEDKEantIDzgLRUu4dKZ0APA+6Czay2jC6zDlFoBLJ/JbIlHBheWSsxA6BeagdftbT+/QPO2hmnRv3scLU72Md2x9pJ9/ukX2Wy8wsvn+QSSHHYpEaf8g8NyXVj/SpPrEnwYiQg5+RiK97MgJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774715928; c=relaxed/simple; bh=DDxcgTMqVStcQgFfJEtZCeD2KwTgSjwDBMGcMyfbmOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FCvfnWoN4pX2TH7ySXvHlL7UNTqTDuoL/9dvcvKSzJhMHVI7h/DtAk2YxWNCO0BFIjtuQfKIBeGY1d2WVTv+vtiLCLuzGz0xbDxmNf2lh8SGJmX1ZthGMkTqUGmmmFafbJjZIqf0tfqqmF9HIAgMieSJCZmIz57rUBAWsJVLn+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jC3e5xrm; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jC3e5xrm" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-66b32fd9f26so2155566a12.0 for ; Sat, 28 Mar 2026 09:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774715925; x=1775320725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6LWhF3uaArkhQK+8SH0+E8r9jK9foFcw9lUUPANL8Bg=; b=jC3e5xrmvDdJf0vtdSPn0TF8Rauxu4XfMCOETmsw0ly5HzaWHDyzRjz0D5ovt1+2Ba bg3TlwXMNxQ6po8vWXBNzgCOm8P3KrLpq+zuyqOPPWmJZS0haXL99eGZWxRVk7GfBuPR vruFMOTbnJOgJ2h97BVW0NlIUZXyj5d4X8SLe2XvqRn6p64sqydFcgQnQLiwNw3neDsm BBBDBOtnMxyPP96/QgiD1pFTEHUUNf48p0+EMpcqQz6rp8RC1V6CamBXwdHIlJ/Dsp9h lyvIDWpb8D1eTSlO4WxBI+R53RnENmexjXVMh2qUhTg/vBqsnEi1gfJLkrxHmE2B1c2V LDoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774715925; x=1775320725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6LWhF3uaArkhQK+8SH0+E8r9jK9foFcw9lUUPANL8Bg=; b=pri2C91PAiEJfD8WOZJyycHgiVfd8Q9ew6fVnCqEyzKOaJ6eC/QxjNukk4uP1/wcA9 z7xwxkK4NgsVdq519mMdo+EMJBleZIPa0T5TQqTM2RqO8xef8hts3LDUf63/HcQUz3zt tIDarkBltF0hK5ChLhQktlzT/9boFdu9KWvF/p6Jai8P/epJjVWHT79t+I43tVB/1FsP QR5H+CghdZUwy9r+9L28W0TvycrUzLmtxnIopiFp/Ufhw83DJrvCIAH1pQcBrsnkkixx w2GSNxM5zZq2aDMPPwkYoxjXRSWemdEBoWQGjfoP9YMXmEa9il/DJRm+8Ukrbd9OonCu gS0Q== X-Forwarded-Encrypted: i=1; AJvYcCVp5ZFHPxLaoxJ8YdRoFMthh3qJnNNaKRw0a/gaie3gZew73fUTZ2k3iW08F2Cy2dVqB0IY1CxNQ7m+Vno=@vger.kernel.org X-Gm-Message-State: AOJu0YzunGhVIPCaX6rdOYy/OHLvFdKoZJDQ6nAsKlHiZljnPCMrq2/0 TgJd7PmlfhgGbXHdYeBOL8JDw/gD1chdB43Hn0TTh7A/Jf1CH3zSj/IJGhaoRyYo4fGnOQ== X-Gm-Gg: ATEYQzyGpFJs9TJ86vAFiTxVKAoMX4+m+hRwZ+4D7/QnfrOUus0hosURQvjzgx4yGQp re8yl0uIj8knEiK/y7jII2HxbnuscC7OPpgeCA6VoV9IMRZ1MXcuY7ZqexgRW6LAZey4HL4b6RX Q9hCHe4h8mMAXhFp4x6/GmKNqof4+rpmJEp39ZumozG/ywuzlDvypSLBcygvEMqwPwBnb0Xv5gH hX+22PqK5wkgk3e2vpFcFMVbbv8ijII6Loua3F6eU1hUgz1Ir2koohW/xDFwCrr6WsRp7BzJWOD +EKl8MnOWTn/tIqpdpL8L6kZHro6M6lKq2jslRgyrpNIz7ze+GLrnMDZqA3/4cGGDi3hfWnwocg 13QI6dphbHqVL/7vJOvnSmv2UJKkdXdt2pB7FV5Xl8MM9rOaxoCtzRStrQFIkEBD+B07Zl5bT9U BT3JbuKm8AGtNOmkxeFC3u2HErIX4mlPBxGxa8qikCiWLYdbu/J+hZJbz2MaNTUoEzeXkGFK8FU SDIGh5y5xHB X-Received: by 2002:a05:600c:6986:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-48729109c35mr80167305e9.11.1774697013685; Sat, 28 Mar 2026 04:23:33 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487305da785sm41491685e9.0.2026.03.28.04.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 04:23:33 -0700 (PDT) From: David Carlier To: eajames@linux.ibm.com, mchehab@kernel.org Cc: joel@jms.id.au, andrew@codeconstruct.com.au, hverkuil@kernel.org, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH v2] media: aspeed: fix missing of_reserved_mem_device_release() on probe failure Date: Sat, 28 Mar 2026 11:23:30 +0000 Message-ID: <20260328112330.50726-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260327220827.266556-1-devnexen@gmail.com> References: <20260327220827.266556-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" aspeed_video_init() calls of_reserved_mem_device_init() to associate reserved memory regions with the device. When aspeed_video_setup_video() subsequently fails in aspeed_video_probe(), the error path frees the JPEG buffer and unprepares the clocks but does not release the reserved memory association, leaking the rmem_assigned_device entry on the global list. The normal remove path already calls of_reserved_mem_device_release() correctly; only the probe error path was missing it. Add the missing of_reserved_mem_device_release() call to the aspeed_video_setup_video() failure cleanup. Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") Signed-off-by: David Carlier --- drivers/media/platform/aspeed/aspeed-video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/p= latform/aspeed/aspeed-video.c index 41cb96f60110..a292275f6b7b 100644 --- a/drivers/media/platform/aspeed/aspeed-video.c +++ b/drivers/media/platform/aspeed/aspeed-video.c @@ -2343,6 +2343,7 @@ static int aspeed_video_probe(struct platform_device = *pdev) rc =3D aspeed_video_setup_video(video); if (rc) { aspeed_video_free_buf(video, &video->jpeg); + of_reserved_mem_device_release(&pdev->dev); clk_unprepare(video->vclk); clk_unprepare(video->eclk); return rc; --=20 2.53.0