From nobody Thu Apr 2 14:09:57 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313FE2C326F for ; Sat, 28 Mar 2026 09:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774688756; cv=none; b=ehMjV1roGcN4N48SHnWIAnAsecfp9iR4HoJO0slaf5xxThXuPytByyfBLLTFSEXt2GjeH0jpPhA1yQqI5RTUodbwFVrIj5Qryt9lOnKkWUPE/7z+9cnLc1vF5dAkSSr3wP2b7RRlOp8p36UujpGkEyokqdcu9ysP/b5aabpPCbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774688756; c=relaxed/simple; bh=MdQfG1i63z2+B8h+hGMucXuxr1uS0joRSYii9egx/pQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=fsRa+gJnAK0GqB6V1vWmFcxR+Vza0FK8hVUvfmJE5eddLoAxd1x0egAERjB1zut8g6yTsoP/Htx/5OwVzGd0Em2a/WzCm6ysxTpQOdFAxxiY+iM0KCntc6i/DTXYk0k93bx1Mr6unxMgHddqNa1nc+3IBgxSbOveUBFCGD9HtLQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YqPmzdDo; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YqPmzdDo" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48538c5956bso28261345e9.0 for ; Sat, 28 Mar 2026 02:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774688752; x=1775293552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mrtALhRQ+/dB+7gUCD8Q9TtNE8HoAMbogKYxXP9zCuc=; b=YqPmzdDoWVyGbzubSdUmNkPvOMkfpJvQL+ELeDRnMBM3wZcYkJhLsb67NVCv2gKb0E v6tMqr43iMvBOZeyuAEB+yf5sHK84JV6daMkv4LQ9igsqE7pNS6abQre8XortyEKQa3Z SXMZcDCtPelvJCXEy4STLdd5QJqlsF+bUYkqkNqWEfgnvvXLKyYXG9DZE1VqfZ0sgB6Z XPGmYpsZAerd8eaqrduDyrUNzI74TO93ppaFWToAuPYFFS3F1NTiQBJvaB4HlCLzYOHp vB+ARVVzU3h8+RSUV6TZnzSbxxf3643uamvhRw36ppH5L7/ctVFCdtEaYEqGtUle0wlH fZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774688752; x=1775293552; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mrtALhRQ+/dB+7gUCD8Q9TtNE8HoAMbogKYxXP9zCuc=; b=CiWRu1NQfPR/oxZlENq6ts5BvrDY5nMRyQM9fPpZhD92e+xXvfA+aWNnTYW6qpMaW6 jVrDy0AjoOvi20XbUlDZoFzS/waHuac/7J6RApxl7SS9epw3rfav1znGwx8iyDNf+XRm YYNhYty8gq0/+noQ5PLi7e8A6MmxWhSk1fqI0F1YKgxuO2x6Nmf2BpC8xlzFJt2KIlRF NA1zKSsQZ0Rc7mFRLdZdqdvz9oMMQH+8hS2O/28U2RItUsLjEDNWMDa1AAc5OsqTw9O9 Ycb39NaeC5i4aiq3S4HdLL7rpvr+wPDPivfSZUp4453Mt0Iis1FbH963y64SRUHwD9iC cOOg== X-Forwarded-Encrypted: i=1; AJvYcCW0/MUh0iBRT3A5DPw/FWJSfJletcrMl414kvSRguHikdOiyraw+VwRdcVGhH+NL34FrJPrOR5jPN2VywE=@vger.kernel.org X-Gm-Message-State: AOJu0YwX73MjMQcpXNtsIBE4y/PE/Ya2WNhfybajARNjb9xtuYRDopGl nD27fqUcMoAg9LrKBTqC4FHK6UnUnYLgKJSnomketoGBgZTFZC0ceGUp4uGGcg== X-Gm-Gg: ATEYQzzT1XXQvjvj/u2RH8NhyjsPGfWvpkb3LvPI+iOKrvh0KvGfTwlwbGIlsKJne0B mZmZiMgoCfiywhDPhbhajxJzKobs2LoCczk21Z+5D/CDiKaoE5qFyTZZUhPoHx8cmoyzt04V+Ld cuuiT7lHB99VRQV3Hd9tS2HiPh8Ih4NGucdBvxN4cSmngcvgapjSpEFsSPcx1nK9kkq3WfFqOcM vlCCzpEN5+ijDuU4ujsVuyHApoqT2fP8wsrvEsdnFZBXTxK/PsxZZ8475ZF0q05w392X4FsxTOO +h2YLTLfwweOjbdFBd9ckfgVY3gN9l7FLN1TDBfOnFEqWWXOX+rakfgel8/s7CUVpRFWjapBKN9 tT5T5VSNF/7wfwiWMYww/mjWGEHHFHZPa3inOGWq1rYh1QUHp3CO/wSjfnxYUE3RF8l/dP4/C6I Ahyhqo0qJATto0nON+dtWU3nNG5T8wuoktiP1f55dKC6oi6eBv X-Received: by 2002:a05:600c:6986:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-48729109c35mr75510485e9.11.1774688752254; Sat, 28 Mar 2026 02:05:52 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:8a55:5310:98fe:930d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48727bfc5ecsm77227735e9.1.2026.03.28.02.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 02:05:51 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Linus Walleij Cc: Biju Das , Lad Prabhakar , Claudiu Beznea , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das Subject: [PATCH] pinctrl: renesas: rzg2l: Fix incorrect PUPD register offset for high pins during suspend/resume Date: Sat, 28 Mar 2026 09:05:45 +0000 Message-ID: <20260328090548.84124-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Biju Das When saving/restoring pull-up/down register state during suspend/resume, the second PUPD register access was incorrectly using the same base offset as the first, effectively reading/writing the same register twice instead of the adjacent one. Add the correct + 4 byte offset to the second RZG2L_PCTRL_REG_ACCESS32 call so that pupd[1][port] is properly saved and restored from the next 32-bit register in the PUPD register pair, covering pins 4=E2=80=937 of por= ts with 4 or more pins. Fixes: b2bd65fbb617 ("pinctrl: renesas: rzg2l: Add suspend/resume support f= or pull up/down") Signed-off-by: Biju Das --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/rene= sas/pinctrl-rzg2l.c index 561e6018fd89..68b94c748f53 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -3049,7 +3049,7 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_= pinctrl *pctrl, bool suspen RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off), cache->pupd[0][port]); if (pincnt >=3D 4) { - RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off), + RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off) + 4, cache->pupd[1][port]); } } --=20 2.43.0