From nobody Thu Apr 2 14:06:37 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51BBA224FA for ; Sat, 28 Mar 2026 08:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774687623; cv=none; b=BTgZISa/GqT1J8aZEWcfFOgpMOlcgPQeSHoPrE+W0jmdiR7oT14iQHImm3xWQQtvYgOcFu4MuGiSHGa46ViT1lZKtgUOPG94oHPLWX7J2L7zi9NdYsUB47PwI7wqsdnrHyJ8TXOEWQwHSCHjJL4RubzArXU/lI4k9JF6Szj6bVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774687623; c=relaxed/simple; bh=S1/uGDiGHa9UOtjwyAnQrKq0EKeyJnfG9lOs8cWnkxA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aFtidksRFNq9FQ4o4Usz+7FJgrp+fOpnwRk6KSSDNghqRBXdYFtSOKgYIxHvD++Zl+FDqV+8I8L1AAnnfmcJaWVbiCvuq380vdALbkPUpJ7CxG4sWaclZmJxL/r3pJyNCermO4P7vj6jjFz07dmQQUYleO0U2EOa6M2m4IiZ+g4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NvCOQYXn; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NvCOQYXn" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35d94f4ee36so207828a91.3 for ; Sat, 28 Mar 2026 01:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774687621; x=1775292421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E49LiwD34CnxCZCtS2NlRCH3BBKW4NzoBsph9Hx9niI=; b=NvCOQYXntVEqGZI1hwh0k4PNZHjIY48/RB5V2FSay7BVtl2hOjMJmOZYiaufgwnUhL 4kTbi8NVk+QwzLbu0kUSwGrzpEQNIhBR1NLHb3K7aj6amPlwe6YkEHDjylGSZUcx9v/p r8m2gUF72md50AEfE69/5jNnCCTbAEC/eJutQL/DYPUQKD2bg+h8rC/qKDf/fDnVJkbh lQP/ZfnVriYExpJIjPo5Gg18XraMlpAJdL59jDsTm64Gn6FoU25BAZs7plsdxxO2EMVJ Z5RVZHEDxtRva/3eXAF6ejDhzXFtWlmcuANx0CkrF2sbwsBYq13jXB0GaAJTLcL3Svh+ JL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774687621; x=1775292421; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E49LiwD34CnxCZCtS2NlRCH3BBKW4NzoBsph9Hx9niI=; b=tHYaetci1P+bcYAnfsKAB+mPrfXRsYNDKCBtv2MvbWMu6prIcBbIhuLWPus/OP4diM 1c7Vsm9iAHUWdlNS+JB60VdchL/9AEDqlBnCSTlWtzHydfvgDiBqOJS9Yn+uEBEHUKHs oCZDWSK7y3AQWOW42FY1QavlkWD0ga4EcFeSfy5vWwW4BPhwsyH1mwAaFl7XxHvDBHjy iCcVlgIxSlpVbE8aBuBDt6FlefAC/ejk5UVo0YD83aJD1N9xak2/52qIPNq/ZjKTzzZN 2nXuyQ2KKLxDCpiixfLjCc51ogHbnmMEBV7fDGWej6RS2Dha+dNXdwbepVk+AOLCBFPB EkrQ== X-Forwarded-Encrypted: i=1; AJvYcCUl1hyUeDdSFw19oqsdXSiDfQ9EZaOZO0m5kHuv+4AY5+8FXUP3MxXYgKZ5w/HKqVPw52GJGbXqhzdMCPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwYVzpbI9pxmL7bcSgTizyNWL/XEEJnf9Qc9SLGn9EqkQYMdZUt hupm2Uxffg+PZWg9ihLJjj7fZoztMUtlUaWUHoWPlrCbIXhY6aZ6vuWo X-Gm-Gg: ATEYQzxmOZU+YBTJPyZaAjST//lxWAs06O59ZQBdpZj9qM1P4sT3VvFTG/0k7LuFgKi Md81UkSs1T3gXwX/py02AOPFRoFHDP/kG1NDPg1AU63FzWd2qMM0LCzwLuCEt2vH3ljyaAWZWhM pAqr3R+yh5pzkV391jb3w5kJgppvJYrGq6eIN5nr6tMZnWL9IJRhnmw9IqgwNq3th/R0rEJKnHq GiEK5ATRbU1/BUi3/Y2rvfXuSyWlnj/kqNvP3YqJNM55JcPUnS6eVCyESB+8h4sis8OAL1Zqgm+ E6Hxa4E0SLrcf3L/gqmNl2QJ8quW+nL5X4ZCsK2J2iozwpcoF/5zvUTz5QGw1byVFC5Ha/aKBrD ZLWFiPEE/CGe2rQ31/uH2BpWlnDH1+6bjzO4PjzhVeHqEo+4piB33YsQunlugPZvtdSaqqQqUUJ FSCo3f4NTm1JTw1I2ONG6CBtRrj6PJyTQrLmnRxP1ghCi9iIk50TRbFj5ZoXTPHTSt X-Received: by 2002:a17:90a:e70d:b0:341:88d5:a74e with SMTP id 98e67ed59e1d1-35c3011abbbmr5050568a91.29.1774687621419; Sat, 28 Mar 2026 01:47:01 -0700 (PDT) Received: from LAPTOP-KU1E7KI5.fudan.edu.cn ([202.120.235.189]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d950d9b12sm1689510a91.17.2026.03.28.01.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 01:47:00 -0700 (PDT) From: Keenan Dong To: linux-bluetooth@vger.kernel.org Cc: marcel@holtmann.org, luiz.dentz@gmail.com, linux-kernel@vger.kernel.org, Keenan Dong Subject: [PATCH] Bluetooth: MGMT: validate LTK enc_size on load Date: Sat, 28 Mar 2026 16:46:47 +0800 Message-ID: <20260328084648.51158-1-keenanat2000@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Load Long Term Keys stores the user-provided enc_size and later uses it to size fixed-size stack operations when replying to LE LTK requests. An enc_size larger than the 16-byte key buffer can therefore overflow the reply stack buffer. Reject oversized enc_size values while validating the management LTK record so invalid keys never reach the stored key state. Fixes: 346af67b8d11 ("Bluetooth: Add MGMT handlers for dealing with SMP LTK= 's") Reported-by: Keenan Dong Signed-off-by: Keenan Dong --- net/bluetooth/mgmt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index e5f9287fb..adcd86c15 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -7248,6 +7248,9 @@ static bool ltk_is_valid(struct mgmt_ltk_info *key) if (key->initiator !=3D 0x00 && key->initiator !=3D 0x01) return false; =20 + if (key->enc_size > sizeof(key->val)) + return false; + switch (key->addr.type) { case BDADDR_LE_PUBLIC: return true; --=20 2.43.0