From nobody Thu Apr 2 14:10:31 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A959930594E for ; Sat, 28 Mar 2026 06:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774680200; cv=none; b=CZ7mc9F7m+hxfNo0FpctfAqimG6+TEMirq76Ur4L/xfu0SuZMKDWjxbhsAmZS2H4W2AwzhwkzjiI+OLkbdUz56oFc975Sd/KAXaiqGKGLS/4id1jXTPz2wnKbTZtSFCkPcc9kyHqlvktYVZa/FaMR/rx5rQ4ymOGMEQyBo0aU98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774680200; c=relaxed/simple; bh=1MYwq7bz0OCL9OlG1OI2LZ8cBZ1/ORlZG7IEavHnNSk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sWhShEWa9GZdC9laffTunkq/nYuuLFUGiygoi/La4dhMuMQXlHlk//jcpn6gyRpu59zXDWQC09EcZR9Mvt8vu/b/qlQTpOHtt1NoVBeCl9CRl5PNmisv+km6wihBexGgmzqwTC5wjJDrP1qZHJIWFJSac11nopRhhtZbwfgS6rk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NWMHipfU; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NWMHipfU" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so26264805e9.1 for ; Fri, 27 Mar 2026 23:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774680197; x=1775284997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5FQB/XEvfVTZ5AFJg/genH5wPdnxS6mYQVlhCcxPoYU=; b=NWMHipfUiBSxIFzJnpZ8cpKm8FHGkkgx6S2YqZSq1djBtjyx8Syt9BqCaq1AyGX9d7 RVhrCajAiURDiUlqnWtJwGzoAvqw8FFb7Zw8lfeqjGaklEAuHJGS65RKj0+HVBjrl9Rz kVR6So6EvRTj3ex4G9emWcQhtT9kQODRR829Yxiwc0SVFzMUrgX9fYmfby7UXPa72YkA WfCNh1XGnyejUHXmvZ7HochfT4U3Im2D++fhxKM26+Qir7DyZ2AyjLkwL7sClthRWkiD 3yWSE5nxyGUYQO0du2/OAWB2w0EshbvlbSg9MWP0233ADzGeYQazFFQ01h2cCy4YVOD2 mjOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774680197; x=1775284997; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5FQB/XEvfVTZ5AFJg/genH5wPdnxS6mYQVlhCcxPoYU=; b=ajhmarMNZp7f09xQmyMsq2BgxI2h+EjP9lX51v4h1qZFzNNDXRksgtiUpGGJizIB5c raaG8oEbHc/Iz5Di/Co1TRrOFOTAjn88KCrJESPAynPVWEQEjF2Kmta0RbajJ8236GIM qz6Y+KMFCYhoM6a1D+31vpDqf0t49ls3L5bpzKYXLw8wWSLe/yQIn7L8xCMr0JiYO+cN EeQ6+bedJnONsKyIjkXUOP5MBeQhg9P5/DTI7o9SEP6y5KPTDXgOmWY3lVDHlv8cI/gP 1W2Ub0Elm0MrmGIVbLfLoRg2fnBsvX3Ll8YuQm9Oqe32/ypgisNNJhd5pKrvFCkTm5eZ PchA== X-Forwarded-Encrypted: i=1; AJvYcCXF6MlC9ybwbVRPD0NNu6Qwmyh/22hDV4xYC0MB6tNVfz/3BUe8ZwapxUWNhhSyYE5W8QkdorxJ4kYR718=@vger.kernel.org X-Gm-Message-State: AOJu0YxxOIsKikQtwumCigdbumqANIuBA3Yt0E4ctfB3FO9A7JWK0Xhd gY9ChNTaIfc5mx6VNZB830qIX4/YqTyDiOABM0mtpxvkPuuUlVqIl/C0Yp9CUh9IU7w= X-Gm-Gg: ATEYQzzE4VCes+E64NtkGXwZTldrXdcBk9GyoN6e7q1fGynNBLU2l2MNsTs1a41cdb0 CtQCJEPTnU+rDVUmTdYDbI1NjtrogfhwwTrrJ5q1Hr9H5VnwKkxA6mkWtXabXFNBPG+CcDYH61t 2a0VIgfLtoTUJZWSBRHZexTPtgQDrlOaSIZeitk6NcjAY8ig0TII7VDYMn83ejZwaN5RHh9CxVS heaWCaE4ivDjkxpDAln9FgmP+z+tUC/BrYe7hNFU94DjHpTuiR//pkrl1ZSqoHFAqORBAo7VAe7 Wk860G5HgMDxkUrqMet17EJbQGIFhzeFLaYpD4qve5m1zh9rf2oopw64CdQ9LZuPl06TZNkQfty mPbtfprZZISsovsqq2r8XgLvOfSKasG9KYMQ1v1oaXV2leoUJ+5HFTu5XbifvYVgPidq591UoZj lh6K5h5KJEnYfNL3Bi2iw+/uYMhv/cLb9C X-Received: by 2002:a05:600d:17:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-4872911c031mr56791325e9.12.1774680196939; Fri, 27 Mar 2026 23:43:16 -0700 (PDT) Received: from localhost ([145.40.214.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm270210865e9.2.2026.03.27.23.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 23:43:16 -0700 (PDT) From: Teng Liu <27rabbitlt@gmail.com> To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.com, clm@fb.com, wqu@suse.com, linux-kernel@vger.kernel.org, Teng Liu <27rabbitlt@gmail.com> Subject: [PATCH v2] btrfs: replace BUG_ON() with error return in cache_save_setup() Date: Sat, 28 Mar 2026 07:40:59 +0100 Message-ID: <20260328064306.2854437-1-27rabbitlt@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In cache_save_setup(), if create_free_space_inode() succeeds but the subsequent lookup_free_space_inode() still fails on retry, the BUG_ON(retries) will crash the kernel. This can happen due to I/O errors or transient failures, not just programming bugs. Replace the BUG_ON with proper error handling that returns the original error code through the existing cleanup path. The callers already handle this gracefully: disk_cache_state defaults to BTRFS_DC_ERROR, so the space cache simply won't be written for that block group. Signed-off-by: Teng Liu <27rabbitlt@gmail.com> Reviewed-by: Qu Wenruo --- Changes in v2: - Use btrfs_err() instead of btrfs_debug() (Qu Wenruo) - Use PTR_ERR(inode) instead of hardcoded -EIO (Qu Wenruo) - Include error code in the log message (Qu Wenruo) fs/btrfs/block-group.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index ebf507909..89bfc9db0 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -3343,7 +3343,13 @@ static int cache_save_setup(struct btrfs_block_group= *block_group, } =20 if (IS_ERR(inode)) { - BUG_ON(retries); + if (retries) { + ret =3D PTR_ERR(inode); + btrfs_err(fs_info, + "failed to lookup free space inode after creation for block group %l= lu: %d", + block_group->start, ret); + goto out_free; + } retries++; =20 if (block_group->ro) --=20 2.53.0