From nobody Thu Apr 2 15:37:29 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 402512AF1D for ; Sat, 28 Mar 2026 05:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675613; cv=none; b=Tz26+oeF4EW2jyDkZ6uSXOdxnEdqhVW9HknNUj3dQ+g+tZma+mqGy6ALkvLu5YZjU+NMmTvutIi9PyIEHB+JfSpZw6zpxv0ozmDujS3Id+TW5DLops9rP0K+d9ywCr1PN8ZgbEH43Ubjr7GE3pGVZ69rXuJ4H46cvHtVDnB8zHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675613; c=relaxed/simple; bh=fGkfc3UCRgoAi+qYnvnEhXgi07+BZm74HyQNwG9IeEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h+eaQlF3fB6juvzRvdwnFBEmCTeiR7VxELE5Rm3/UUd1nqK4XjWMY5ysuo7E2ju1Y2Q6nqNOk6l3iYeM4FeHukZxXfuu0YIyazWfPlEjPgkUm5m3HeX0ZPmSFwvIKOTa7AQCZtWurPMJSHttX9s+mHvWyvCOlGCfIcSIlLeg3cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BaIJ864l; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BaIJ864l" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82c20b9f989so1366565b3a.0 for ; Fri, 27 Mar 2026 22:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675611; x=1775280411; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UjT4f4n1BM6i4Zp48h42mUkpuWaNiLyW5S65Zt/5VyE=; b=BaIJ864lm+Tl/6P91195OD2ts2ywFoJQ/nuQr66HDNAwiUv6ui2zvd/igrbBCEjdSC 3+hs8O7rXbxPzqUHkdvxIRxuhgzSd/A3qULfN41aX9Gf/dxvjPgK+IIAXD3z05pUenYO CA1/Dq+cjGVLWQklWximkHqFo206wgm55sKHAaFWwIXSW3iW3kmjZvf0GBnCzNlgwdoO 8rRLCXW5YyeqVKT6snSPCn/06kw23Rj1KMviyEoFmKIACyApswdxFYX1Gxy5UqpOHfNP QVn1tMRMO0obyWV3bfUq2+RCGs7vY1An7u8vImqukBDLOtZoHT8ca2RRcFISWpnW7U8f sIoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675611; x=1775280411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UjT4f4n1BM6i4Zp48h42mUkpuWaNiLyW5S65Zt/5VyE=; b=amWrIZlvgSZk2VI5kSC2SzpB525sV1csKTg3ZTSE1HfzsQE/w5fdzM0F/xsaZtBLWY KpEuH4kkKgfsyYTf0Un1YEzbjYQZ3z7g74TIuEGe+wOKNFiEmXXBunorUrmReorEo/0k Aa6K6Zi0G5WUc124WD1VnamSa9kgZY4zrW5z0o9grcqlQTpYOpJkG0NjTwNgGgkBKOK7 JraZlD/URFVGFDxC9gQmMnnVKSJlLWphdAHuMh9BqpjsFtO5yOCO/QcJhAhdeK1T0xOL wEKksIHlKZRVldtypuZWBWNXQDd/9siu8PQ+PyHWdoFhUR3widyHA8HPTBxI8vB4mbwX xe+w== X-Forwarded-Encrypted: i=1; AJvYcCXOgt8DyOr7ZAvYn+Ay76yreZCiQgME1ExoOD50Nc3+L3A1uVj2DAZjIouChqTA+CLAg2sKzF5iikdusu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyCuldM8V5Z9nqGOqegh/Xpx8feNcyJzSdyvOTFdI3TZMBkqLXw qbsDgbxhOWDA9cqoAhRpmQDiNFz7QwOjsJFIpPSwzze/n0NjfNHFFME20O9kz9+i X-Gm-Gg: ATEYQzySlQ3cbeQ4Fv0mwiAE1FVmosruHYPx8KYo4Og2YBbl69RbebRneZOh2XUjLut xd82bR2XdI0nj38BNklscb9sHOL84ENAv/ekv0dbcCMVhwJ3XkUN2b1ZJGvUyo3dxJLoFEymTWr 9CGDA521GytbtJKpQGjI+Wtjamm2JeRI0RyaZWT6z0I+ra5sqekkfXfRZ4RNmINVeygOjNfNZH3 ViRraanncXbGUV9EtczPAgiDyow9Iz+NpRMdijknzURi47v5iBRkunwnOhtxn6MhhF4ODqMitJ1 kEQpOZcC/2IuU6U6OY1Q7ROIL8Kt2Y5rzkvTRoGSSan/a8fFeeM6gL1Q9izOfCahoZ54NaE8xqq AHJoTXxyGoAfMdGh4JcIgVHcvHjigTp2DrCMm6RKCsvHyjcFLR1oWHJIiLWMRBSsjtdgIDaShOM aGM6yH2oQDY5z70L/IOGrN6xEEDYAe54qoIQCkBu1w3Ro/0gQF X-Received: by 2002:a05:6a00:8593:b0:82c:9fe1:aa4d with SMTP id d2e1a72fcca58-82c9fe1abe8mr2838521b3a.13.1774675611543; Fri, 27 Mar 2026 22:26:51 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:51 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 4/4] ASoC: Intel: boards: Log error code in MCLK configuration failure Date: Sat, 28 Mar 2026 01:25:55 -0400 Message-ID: <20260328052556.434191-5-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The dev_err() calls in platform_clock_control() for the three Intel ASoC board drivers do not log the return code when clk_prepare_enable() fails, making it harder to diagonse failures. Add the error code to the log message. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index fce726a9c8c0..19d9e87df6c9 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 65944eb4be16..6d886684fb51 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index e5806dc16ff9..248ad3fd495d 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state\n"); + "could not configure MCLK state: %d\n", ret); return ret; } } --=20 2.47.3