From nobody Thu Apr 2 15:38:58 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5092AF1D for ; Sat, 28 Mar 2026 05:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675607; cv=none; b=LRDDrUK6uu9wEjr2ZeaJlR3ZMFreClJfT8vi4XD7WJEp/KPCWQW2GDEyedw4rPhcA1s/3i3Wqh5WPXpfNi+KRwfRD4qkAqAhF3AyKSz3OPlIJ5zArq9lgRPIw1X8bS0oCBwg6b59U5xFUljzZ6f8DWNu43YkFDLXtooVLZ7rNjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675607; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sktB3nIrvQ0HaNE6/0FQjcVdf5+BOPnz/CuNhIXLXgL93ivit/vJUSiMwHxei8lw7VXss0R+Twdx2TH9Vhan+fpgGpqT1hHg7qB9Blf6x9IhtPupekgeFp70+bNx9PpVQabvIOuqwuZDKZ7XfzZ6UT58rYoYOzY5MP8oKINgPWU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TuFwt+FM; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TuFwt+FM" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82c20f1e890so1908747b3a.3 for ; Fri, 27 Mar 2026 22:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675606; x=1775280406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=TuFwt+FM0plpQUNu/wiGRYGunwD4DsLqW+XUjk9m7UUBFk4ailwqLd3AU4ILKQDhDP dG3HCUKOkOGrVs4Uhh9XcSJxhPldN526qaff7yX7Q6GtdSG8dmqB96BQGLvsNBZixsHZ TaMCEc2/WzMGyaJ+OH09dIqb4+xGfC/qnnmiqIQ2nzsJMI/qHqOvBiJfBA/wZdXx62c6 0ZcSJs7C/JbXRjkERL3clpJtr1E7MUeZLYHKE1+f1GyyQTe7+iz8DvEXXsX5mg5KwjZx 0cbkrnLvTzKWxeRTT/a3n4pAJkY02UBGc2rvz+TddU/r7+MQdo6jffsWB1G/gzjoBbQy Xzlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675606; x=1775280406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=ScwjCIQwj6kGSvGJRMmqaUdnt5lPs+wSLmIz0XpL89zpRbcuuf7eJbVYqn1YkF/yki 4UIOPQutJ3l5/ggX5/J+vpuFplltN7wHTirWtOONruiVw/Qb9pGeWG4ZDvrLD+yf2erw T84yVNR3FqScrY7suI0dx2XCnGK2yNjgFLD0Svb2l3ADA296i+ye8hrpWdbNXl0rDszl h/qTmZm0Qu6yPNa5enTfhwpCJMQ4kZhsMahBftV3o1d24OxLHywDFE2d53J/Ut0JZrgC aQyreT9z/g6Bb9qiMDENJintZiLiw/fF5cQhbqK3SLRPYf6aCWfB82PhySvtCCgN9GaD SHcQ== X-Forwarded-Encrypted: i=1; AJvYcCUIvRl1VG9oQGl/H4DXCQpLWleUZ10IZQGeibg8DfC0AvVGdsTp+OPCZVBhg+HirhScfdIiSnJkXEjGur4=@vger.kernel.org X-Gm-Message-State: AOJu0YzYjYoASlgeOSxpVF+wqEm3kSNB1L7d9s0YAY4TQ+pQqEBl+KAa IL0yxUECpnWNaBhl9CN3LE+OWKtLBMaHcrmaQ9edmyZ92Zds/LuCb45C X-Gm-Gg: ATEYQzxd83N3+TP2FomPgN8FoHzIFXb8XwkboA9XPsizRFzqlcfwT+Uxb4kaQfuKkkm YajPe0MO7rHXJFrEKHK4BawHi0qkuQJGyH0i3q3xaG7b+LHVIUNso/gGKTGVYfQ29seOX9dhu45 RIuArZzEAhN+K7+SKMhtSGqm/SpWlA1RxtoMIndCT6vgt7na9TDRfcsfPikoditqn78VjnqwazO b9VTGMEKmiDNEf6IkKiYmyssEBi4Y63dPBObeZ1qdE+Nn9/pQbS5bXTVRTxYDPMNi+sCZ/kALPO cF2vddPN6a3A01JyDJT55o1NTaXrJAa3hJ//W+XIPovjdUhLZEMPOJP9Y2425NHash6zpPiA2Uk AQZ7xQ1XmfhMS+rc2abcMIxiN4RJ2+siQwAMyu8VzC8rM2UdmzWcGGeTtY1r4Mpt3EvHsdl/aPa vSANiY/ovTWlIODTOSTfwSU5nGnJjYUm4hLLfl12EAtx7Z6dx+ X-Received: by 2002:a05:6a00:1705:b0:829:8c23:f70d with SMTP id d2e1a72fcca58-82c96082491mr5258970b3a.56.1774675605713; Fri, 27 Mar 2026 22:26:45 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:45 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 3/4] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Sat, 28 Mar 2026 01:25:54 -0400 Message-ID: <20260328052556.434191-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3