From nobody Thu Apr 2 15:38:58 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C476A2AF1D for ; Sat, 28 Mar 2026 05:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675601; cv=none; b=rFJyNVM0T0kKOrF97raFMFDiu8kQqxRzqOWekQAl5DnUInYHshbCPKdr6pJhfaPNhtHHdZILqPG45uxFuHpZXf2i9jMg5P2LhHObfDgC/tU2jeaJ419cFcsVAc6KaTkjdoHgvF/NUi4DBjbIjiVZtGETmFBuH0q/1wRTv5SKJtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675601; c=relaxed/simple; bh=f+rrkJ/eFGfAceLcutWeIAOjkU73nC2yxLnBeMJdOaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mEwJr2ddDx18n9pYI1FZGyJwQwvyeUttwUAV6tYxM685sYDlfIu2ToAOPFuGrcznQu+en/uzD6Z07nYHn0dMLeyVv5J6svP8pNcv0SqT2ZvbZkAXDgJ4bJL02IJ5SkQcvDlAcWM/UT4jWxygujNdAR1n0lHJfMj5DNI+dlDpxZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ktQAivQx; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ktQAivQx" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-829b8b6c4d0so2474430b3a.0 for ; Fri, 27 Mar 2026 22:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675600; x=1775280400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=ktQAivQxbOZn7nJ0jc9WNcARYTVDPOEOfzLIWSOXrYf1cFVWvuw79PdIGxGNBYUrez V3zBdbdcztAV77rwe5FJMTyHD67g76+Hkcfwqpz3eXDceOGouuHUSOhX+PhmQ56eIU2l HvgrbnMtnrmHaaKBzxhHO9LAXygTDChSs3NtK1kKvDR0e/jn8cDJbLqsFuZm27lkpPmq TuLVWzabJlKoWqHCV5SpvNg3cyKqDIAYGUgkRbLzuJlQ69NLykYxnkqylt+kUbFZO2Ct iR4QXAdEdTMa6ZpiNrsVizp+EFYxMQVKWlCw0MwuTvdOXwGE44uS7ktNw1WAL+OfB8Us IN1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675600; x=1775280400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=XOSROMDh0L/Rr7efh5X77mTLFomrRsm6yNKCuXesNKEb/xp6SAKr5L1YzzRdydsHHh sROgghMo4FoFyZCadN5vX+mldKsARZ3xQD8Ao9yFKku56j1zAnx02NE9ZYxWsN1nG3Ts 6jATys5TJP/4IeLSvpzsYjA1yP2+QzOucpmjNPsD+6LwK0a1ju09LeZksRQMFuncG3yW KXN+jxv87xVFidAkZ4Q3wHXodkgVuT5tc3EOyE5YlaLRwAwcUwBuw0H5KilPuhE5IthP qLj2zMJdIdk3ZKmsMAIRJe5b2WzxgJfANFsvq8GIb2Ezf0tjoZFePbqgOl9oogPPy3wX TCMA== X-Forwarded-Encrypted: i=1; AJvYcCXa4EXfjCk53GLK9mFp2rYtHN4BuWRT5lbLKZ1CCHp/sUC2oiCeSm+cQOoXOR3rVgSSRlsIO3bp5s4dEOU=@vger.kernel.org X-Gm-Message-State: AOJu0YzEnLSzltm6ZHgvIp2Vjl1cC1KDMWbBivdulanjOMspKtoH7NCD 1az0qCSNxFiFaw6ylSmkT9KixT34QrnwERt44daKx8s+UXXrs3MRI5+q X-Gm-Gg: ATEYQzwzKbZ8s00NZWqisd5dm3P7cdn/AqxHzbOFbcjujz2mhIWXox66H6D1fLxrH15 1fCopw8cZsVSRES37vt+CptL231xEwVLCqLa0nZsbeVDQ1pGZiAhvNt2I2amTk1qFsdM2hHppa6 g4/AJ3jIV2bsdd+iNntLHQYRscWawaKxPYr7WfCK+pQUd+yyxxwjLbF6XVPZGEn0xGnileCRwj9 CJP7l7M178F/JvpuSj9ricN3eiU86zhOdgDe27eMYLjDK6QCn2K0Y1+qWMkXdFGQzXDSVueQBnV JAxOc0gxSu/ysEWZ26fzeqP4BeVTBAaYt1fvQIvt1nEyB8ISu3FtPLaDW/uDQgUcpx6WWNerxot k5sd52wxoZ3P+qATWmUGzcPTuGU6BXuU+phSyHLi912yKrOoYma+6tYKJ9O6mVU7hxlbglN+7m+ 516BPEr2q5+gQPDm5cSi5ODRS+LVQ9SbXYEJxpxzJavQxWdfW1lr51H8sY1cQ= X-Received: by 2002:a05:6a20:7d9c:b0:398:71f2:59d8 with SMTP id adf61e73a8af0-39c87b9ac04mr5625305637.56.1774675600070; Fri, 27 Mar 2026 22:26:40 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:39 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 2/4] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Sat, 28 Mar 2026 01:25:53 -0400 Message-ID: <20260328052556.434191-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..65944eb4be16 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); @@ -224,6 +224,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3