From nobody Thu Apr 2 15:39:01 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D3626D4E5 for ; Sat, 28 Mar 2026 05:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675595; cv=none; b=m7Q/tosa1KsBUdD00LnkwUd77E8lDk5Csgjm1n7s+6eBcqm87+AuCyO9IUfhLwgiWIqMrvrAbLLTXQlkR4BRXWLN5CSYHYM/zgHaRrqHAaehAke/HC0I96Klbl0rr+YxtrJv3/RUPU6w700tjgN1HZlDzNubmBo6ZBQdAys6PUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675595; c=relaxed/simple; bh=hV0PSRnR/bl4CdLuH0CGuwoqFy9Ab3KJAJrnQZux0Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oYbHM1xKH7z5RtSmIekZq4QoORZkXUfQxNMmfMjvNMocCeGOlU9nLTzzrmVPgNqDWLkIw7ot5Z1QtlzxDfESBb7lhPPco3Km8Ul1WwgHqe1yp/3yYGfkiAAF9HJsuelWJfYgneXoGHv6DA1JsfBcJRHJnU8tzU1W+qHxhvL0JaI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuqNlO69; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuqNlO69" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82a655cfab5so2646197b3a.1 for ; Fri, 27 Mar 2026 22:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675594; x=1775280394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=cuqNlO69zldCyE9N1IbWg33iBxDlvneU3zx0RnwO5rr26tEnZ3+f5i5mjIM3JfIQFD TnDRadImNYiKdGSdX5FmOFnalqeNBCwct3gkzTKeOVQ+bBMzaQDiWtxs40RQ9Z/lMokH 0ORcMiJPnDX+7Zdm+22Z/gosJeCyTdHsLua9dBv7Z7EYYeFJhHee5HYZbhV/mlHL643Z inB/cm79SEHOHBWg5kguYpvnv1C3He5uh2JTu8XcOIvBF1dvkJutLh1wRJpF7VG2pZPV amQ1Sl/VV2e4H6+KrOCEH3sbSmrA/7N4gXnFDM1nr1dxmszuW+k/iPsoqdRLTIVB3sid Xc/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675594; x=1775280394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=fEhdPoVjRGjHRcJ5yG5J6ZZW/fpC7ljC8nhIEKcp7VBEyL2ZbUDpxF1g6CDKpEGjfH Ar8DqTYKyjAx5EXEadcSa0KG0WUcN1tY2djltvtM3dHRoBOGP2SuowolWmbIiS8wQbjL vkxKIJvOwpYKCRIV84wbYMadsrAwy7k3G2i94xH4pr+bRRuMvtuTrkWavqsO7xwRMdKM zQCD7TsIdD4I5JVfYLAywR0jHH02yT17avX/jm9fIHqgtFzprSHOTMz12BahwFSmBd3h f7OGBDcghEcCeoLDPc4pTyzorH0FrFnt7/yoGXpzvOmGh7xzy68l6St+ufKzAIskkkWw l3fQ== X-Forwarded-Encrypted: i=1; AJvYcCW9AFzovK9sZmKMd3g5LQERTl/YQjBynCFlRnIfd17hpxrrNqNMGDxCKkE/4WBve1nlGhKbXN7TZ/Q8Bq8=@vger.kernel.org X-Gm-Message-State: AOJu0YwyLCer9bwrBQbP9PtZylm3ts4w/37N9XFTz0h+3+/OLidvJKn+ KRP9QwWL32xv9k+u6AUUPkKbonliXpbWgxobf1ziPEYw023cGuhh8xLv X-Gm-Gg: ATEYQzyDkbkubomtzgIAOiA1MmwDIq7wbnd5tQDTqaIVLK0skoS9eEyjyxl3fZjqqeo BCmPlCA2FQ0erWg+C9ER/LCwSoKOUR9KKpUmIkAq6xATkIzGCtIFoCh/MnuPjyn6hrbhgv6/Om4 zopWWadGf6v/gLieEWfVLmR0LiCGwodyvwiNZqTRERBNfnN7LTqdJtABqLH4M35pdrVE7LklfvS UlxFXgFiLb73IADwbmzD86yTR58Ozgvtzr2gbpdoUsv2G26n0rJjQlQig/LYi1x6OUU1yDLwvwd gfs72Ci6vQoAg90jTh0wt9dSP4PFD8dlzLiyJgNTPvaUVcWUaZeuzJrlXPVLTPQn3cgmobKpQvD hykk0ucqm8CZx2JRCAMEb97fzTAnwIDd5s2TpOBP6LBPuAeDRfTKadRw2ggu60tW+9QYolU3UOr e/kBEGfNQ3kKvYWHsqVJK7TA4W6zuqFKNaugplilV1kAcEm74R X-Received: by 2002:a05:6a00:1da4:b0:81a:857b:f944 with SMTP id d2e1a72fcca58-82c95e4f7c9mr5057522b3a.26.1774675593923; Fri, 27 Mar 2026 22:26:33 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:33 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 1/4] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Sat, 28 Mar 2026 01:25:52 -0400 Message-ID: <20260328052556.434191-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..fce726a9c8c0 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3