From nobody Thu Apr 2 14:08:57 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D3626D4E5 for ; Sat, 28 Mar 2026 05:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675595; cv=none; b=m7Q/tosa1KsBUdD00LnkwUd77E8lDk5Csgjm1n7s+6eBcqm87+AuCyO9IUfhLwgiWIqMrvrAbLLTXQlkR4BRXWLN5CSYHYM/zgHaRrqHAaehAke/HC0I96Klbl0rr+YxtrJv3/RUPU6w700tjgN1HZlDzNubmBo6ZBQdAys6PUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675595; c=relaxed/simple; bh=hV0PSRnR/bl4CdLuH0CGuwoqFy9Ab3KJAJrnQZux0Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oYbHM1xKH7z5RtSmIekZq4QoORZkXUfQxNMmfMjvNMocCeGOlU9nLTzzrmVPgNqDWLkIw7ot5Z1QtlzxDfESBb7lhPPco3Km8Ul1WwgHqe1yp/3yYGfkiAAF9HJsuelWJfYgneXoGHv6DA1JsfBcJRHJnU8tzU1W+qHxhvL0JaI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuqNlO69; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuqNlO69" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82a655cfab5so2646197b3a.1 for ; Fri, 27 Mar 2026 22:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675594; x=1775280394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=cuqNlO69zldCyE9N1IbWg33iBxDlvneU3zx0RnwO5rr26tEnZ3+f5i5mjIM3JfIQFD TnDRadImNYiKdGSdX5FmOFnalqeNBCwct3gkzTKeOVQ+bBMzaQDiWtxs40RQ9Z/lMokH 0ORcMiJPnDX+7Zdm+22Z/gosJeCyTdHsLua9dBv7Z7EYYeFJhHee5HYZbhV/mlHL643Z inB/cm79SEHOHBWg5kguYpvnv1C3He5uh2JTu8XcOIvBF1dvkJutLh1wRJpF7VG2pZPV amQ1Sl/VV2e4H6+KrOCEH3sbSmrA/7N4gXnFDM1nr1dxmszuW+k/iPsoqdRLTIVB3sid Xc/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675594; x=1775280394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=fEhdPoVjRGjHRcJ5yG5J6ZZW/fpC7ljC8nhIEKcp7VBEyL2ZbUDpxF1g6CDKpEGjfH Ar8DqTYKyjAx5EXEadcSa0KG0WUcN1tY2djltvtM3dHRoBOGP2SuowolWmbIiS8wQbjL vkxKIJvOwpYKCRIV84wbYMadsrAwy7k3G2i94xH4pr+bRRuMvtuTrkWavqsO7xwRMdKM zQCD7TsIdD4I5JVfYLAywR0jHH02yT17avX/jm9fIHqgtFzprSHOTMz12BahwFSmBd3h f7OGBDcghEcCeoLDPc4pTyzorH0FrFnt7/yoGXpzvOmGh7xzy68l6St+ufKzAIskkkWw l3fQ== X-Forwarded-Encrypted: i=1; AJvYcCW9AFzovK9sZmKMd3g5LQERTl/YQjBynCFlRnIfd17hpxrrNqNMGDxCKkE/4WBve1nlGhKbXN7TZ/Q8Bq8=@vger.kernel.org X-Gm-Message-State: AOJu0YwyLCer9bwrBQbP9PtZylm3ts4w/37N9XFTz0h+3+/OLidvJKn+ KRP9QwWL32xv9k+u6AUUPkKbonliXpbWgxobf1ziPEYw023cGuhh8xLv X-Gm-Gg: ATEYQzyDkbkubomtzgIAOiA1MmwDIq7wbnd5tQDTqaIVLK0skoS9eEyjyxl3fZjqqeo BCmPlCA2FQ0erWg+C9ER/LCwSoKOUR9KKpUmIkAq6xATkIzGCtIFoCh/MnuPjyn6hrbhgv6/Om4 zopWWadGf6v/gLieEWfVLmR0LiCGwodyvwiNZqTRERBNfnN7LTqdJtABqLH4M35pdrVE7LklfvS UlxFXgFiLb73IADwbmzD86yTR58Ozgvtzr2gbpdoUsv2G26n0rJjQlQig/LYi1x6OUU1yDLwvwd gfs72Ci6vQoAg90jTh0wt9dSP4PFD8dlzLiyJgNTPvaUVcWUaZeuzJrlXPVLTPQn3cgmobKpQvD hykk0ucqm8CZx2JRCAMEb97fzTAnwIDd5s2TpOBP6LBPuAeDRfTKadRw2ggu60tW+9QYolU3UOr e/kBEGfNQ3kKvYWHsqVJK7TA4W6zuqFKNaugplilV1kAcEm74R X-Received: by 2002:a05:6a00:1da4:b0:81a:857b:f944 with SMTP id d2e1a72fcca58-82c95e4f7c9mr5057522b3a.26.1774675593923; Fri, 27 Mar 2026 22:26:33 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:33 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 1/4] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Sat, 28 Mar 2026 01:25:52 -0400 Message-ID: <20260328052556.434191-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..fce726a9c8c0 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 14:08:57 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C476A2AF1D for ; Sat, 28 Mar 2026 05:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675601; cv=none; b=rFJyNVM0T0kKOrF97raFMFDiu8kQqxRzqOWekQAl5DnUInYHshbCPKdr6pJhfaPNhtHHdZILqPG45uxFuHpZXf2i9jMg5P2LhHObfDgC/tU2jeaJ419cFcsVAc6KaTkjdoHgvF/NUi4DBjbIjiVZtGETmFBuH0q/1wRTv5SKJtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675601; c=relaxed/simple; bh=f+rrkJ/eFGfAceLcutWeIAOjkU73nC2yxLnBeMJdOaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mEwJr2ddDx18n9pYI1FZGyJwQwvyeUttwUAV6tYxM685sYDlfIu2ToAOPFuGrcznQu+en/uzD6Z07nYHn0dMLeyVv5J6svP8pNcv0SqT2ZvbZkAXDgJ4bJL02IJ5SkQcvDlAcWM/UT4jWxygujNdAR1n0lHJfMj5DNI+dlDpxZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ktQAivQx; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ktQAivQx" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-829b8b6c4d0so2474430b3a.0 for ; Fri, 27 Mar 2026 22:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675600; x=1775280400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=ktQAivQxbOZn7nJ0jc9WNcARYTVDPOEOfzLIWSOXrYf1cFVWvuw79PdIGxGNBYUrez V3zBdbdcztAV77rwe5FJMTyHD67g76+Hkcfwqpz3eXDceOGouuHUSOhX+PhmQ56eIU2l HvgrbnMtnrmHaaKBzxhHO9LAXygTDChSs3NtK1kKvDR0e/jn8cDJbLqsFuZm27lkpPmq TuLVWzabJlKoWqHCV5SpvNg3cyKqDIAYGUgkRbLzuJlQ69NLykYxnkqylt+kUbFZO2Ct iR4QXAdEdTMa6ZpiNrsVizp+EFYxMQVKWlCw0MwuTvdOXwGE44uS7ktNw1WAL+OfB8Us IN1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675600; x=1775280400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=XOSROMDh0L/Rr7efh5X77mTLFomrRsm6yNKCuXesNKEb/xp6SAKr5L1YzzRdydsHHh sROgghMo4FoFyZCadN5vX+mldKsARZ3xQD8Ao9yFKku56j1zAnx02NE9ZYxWsN1nG3Ts 6jATys5TJP/4IeLSvpzsYjA1yP2+QzOucpmjNPsD+6LwK0a1ju09LeZksRQMFuncG3yW KXN+jxv87xVFidAkZ4Q3wHXodkgVuT5tc3EOyE5YlaLRwAwcUwBuw0H5KilPuhE5IthP qLj2zMJdIdk3ZKmsMAIRJe5b2WzxgJfANFsvq8GIb2Ezf0tjoZFePbqgOl9oogPPy3wX TCMA== X-Forwarded-Encrypted: i=1; AJvYcCXa4EXfjCk53GLK9mFp2rYtHN4BuWRT5lbLKZ1CCHp/sUC2oiCeSm+cQOoXOR3rVgSSRlsIO3bp5s4dEOU=@vger.kernel.org X-Gm-Message-State: AOJu0YzEnLSzltm6ZHgvIp2Vjl1cC1KDMWbBivdulanjOMspKtoH7NCD 1az0qCSNxFiFaw6ylSmkT9KixT34QrnwERt44daKx8s+UXXrs3MRI5+q X-Gm-Gg: ATEYQzwzKbZ8s00NZWqisd5dm3P7cdn/AqxHzbOFbcjujz2mhIWXox66H6D1fLxrH15 1fCopw8cZsVSRES37vt+CptL231xEwVLCqLa0nZsbeVDQ1pGZiAhvNt2I2amTk1qFsdM2hHppa6 g4/AJ3jIV2bsdd+iNntLHQYRscWawaKxPYr7WfCK+pQUd+yyxxwjLbF6XVPZGEn0xGnileCRwj9 CJP7l7M178F/JvpuSj9ricN3eiU86zhOdgDe27eMYLjDK6QCn2K0Y1+qWMkXdFGQzXDSVueQBnV JAxOc0gxSu/ysEWZ26fzeqP4BeVTBAaYt1fvQIvt1nEyB8ISu3FtPLaDW/uDQgUcpx6WWNerxot k5sd52wxoZ3P+qATWmUGzcPTuGU6BXuU+phSyHLi912yKrOoYma+6tYKJ9O6mVU7hxlbglN+7m+ 516BPEr2q5+gQPDm5cSi5ODRS+LVQ9SbXYEJxpxzJavQxWdfW1lr51H8sY1cQ= X-Received: by 2002:a05:6a20:7d9c:b0:398:71f2:59d8 with SMTP id adf61e73a8af0-39c87b9ac04mr5625305637.56.1774675600070; Fri, 27 Mar 2026 22:26:40 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:39 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 2/4] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Sat, 28 Mar 2026 01:25:53 -0400 Message-ID: <20260328052556.434191-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..65944eb4be16 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); @@ -224,6 +224,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 14:08:57 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5092AF1D for ; Sat, 28 Mar 2026 05:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675607; cv=none; b=LRDDrUK6uu9wEjr2ZeaJlR3ZMFreClJfT8vi4XD7WJEp/KPCWQW2GDEyedw4rPhcA1s/3i3Wqh5WPXpfNi+KRwfRD4qkAqAhF3AyKSz3OPlIJ5zArq9lgRPIw1X8bS0oCBwg6b59U5xFUljzZ6f8DWNu43YkFDLXtooVLZ7rNjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675607; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sktB3nIrvQ0HaNE6/0FQjcVdf5+BOPnz/CuNhIXLXgL93ivit/vJUSiMwHxei8lw7VXss0R+Twdx2TH9Vhan+fpgGpqT1hHg7qB9Blf6x9IhtPupekgeFp70+bNx9PpVQabvIOuqwuZDKZ7XfzZ6UT58rYoYOzY5MP8oKINgPWU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TuFwt+FM; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TuFwt+FM" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82c20f1e890so1908747b3a.3 for ; Fri, 27 Mar 2026 22:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675606; x=1775280406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=TuFwt+FM0plpQUNu/wiGRYGunwD4DsLqW+XUjk9m7UUBFk4ailwqLd3AU4ILKQDhDP dG3HCUKOkOGrVs4Uhh9XcSJxhPldN526qaff7yX7Q6GtdSG8dmqB96BQGLvsNBZixsHZ TaMCEc2/WzMGyaJ+OH09dIqb4+xGfC/qnnmiqIQ2nzsJMI/qHqOvBiJfBA/wZdXx62c6 0ZcSJs7C/JbXRjkERL3clpJtr1E7MUeZLYHKE1+f1GyyQTe7+iz8DvEXXsX5mg5KwjZx 0cbkrnLvTzKWxeRTT/a3n4pAJkY02UBGc2rvz+TddU/r7+MQdo6jffsWB1G/gzjoBbQy Xzlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675606; x=1775280406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=ScwjCIQwj6kGSvGJRMmqaUdnt5lPs+wSLmIz0XpL89zpRbcuuf7eJbVYqn1YkF/yki 4UIOPQutJ3l5/ggX5/J+vpuFplltN7wHTirWtOONruiVw/Qb9pGeWG4ZDvrLD+yf2erw T84yVNR3FqScrY7suI0dx2XCnGK2yNjgFLD0Svb2l3ADA296i+ye8hrpWdbNXl0rDszl h/qTmZm0Qu6yPNa5enTfhwpCJMQ4kZhsMahBftV3o1d24OxLHywDFE2d53J/Ut0JZrgC aQyreT9z/g6Bb9qiMDENJintZiLiw/fF5cQhbqK3SLRPYf6aCWfB82PhySvtCCgN9GaD SHcQ== X-Forwarded-Encrypted: i=1; AJvYcCUIvRl1VG9oQGl/H4DXCQpLWleUZ10IZQGeibg8DfC0AvVGdsTp+OPCZVBhg+HirhScfdIiSnJkXEjGur4=@vger.kernel.org X-Gm-Message-State: AOJu0YzYjYoASlgeOSxpVF+wqEm3kSNB1L7d9s0YAY4TQ+pQqEBl+KAa IL0yxUECpnWNaBhl9CN3LE+OWKtLBMaHcrmaQ9edmyZ92Zds/LuCb45C X-Gm-Gg: ATEYQzxd83N3+TP2FomPgN8FoHzIFXb8XwkboA9XPsizRFzqlcfwT+Uxb4kaQfuKkkm YajPe0MO7rHXJFrEKHK4BawHi0qkuQJGyH0i3q3xaG7b+LHVIUNso/gGKTGVYfQ29seOX9dhu45 RIuArZzEAhN+K7+SKMhtSGqm/SpWlA1RxtoMIndCT6vgt7na9TDRfcsfPikoditqn78VjnqwazO b9VTGMEKmiDNEf6IkKiYmyssEBi4Y63dPBObeZ1qdE+Nn9/pQbS5bXTVRTxYDPMNi+sCZ/kALPO cF2vddPN6a3A01JyDJT55o1NTaXrJAa3hJ//W+XIPovjdUhLZEMPOJP9Y2425NHash6zpPiA2Uk AQZ7xQ1XmfhMS+rc2abcMIxiN4RJ2+siQwAMyu8VzC8rM2UdmzWcGGeTtY1r4Mpt3EvHsdl/aPa vSANiY/ovTWlIODTOSTfwSU5nGnJjYUm4hLLfl12EAtx7Z6dx+ X-Received: by 2002:a05:6a00:1705:b0:829:8c23:f70d with SMTP id d2e1a72fcca58-82c96082491mr5258970b3a.56.1774675605713; Fri, 27 Mar 2026 22:26:45 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:45 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 3/4] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Sat, 28 Mar 2026 01:25:54 -0400 Message-ID: <20260328052556.434191-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj Reviewed-by: Cezary Rojewski --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3 From nobody Thu Apr 2 14:08:57 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 402512AF1D for ; Sat, 28 Mar 2026 05:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675613; cv=none; b=Tz26+oeF4EW2jyDkZ6uSXOdxnEdqhVW9HknNUj3dQ+g+tZma+mqGy6ALkvLu5YZjU+NMmTvutIi9PyIEHB+JfSpZw6zpxv0ozmDujS3Id+TW5DLops9rP0K+d9ywCr1PN8ZgbEH43Ubjr7GE3pGVZ69rXuJ4H46cvHtVDnB8zHY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675613; c=relaxed/simple; bh=fGkfc3UCRgoAi+qYnvnEhXgi07+BZm74HyQNwG9IeEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h+eaQlF3fB6juvzRvdwnFBEmCTeiR7VxELE5Rm3/UUd1nqK4XjWMY5ysuo7E2ju1Y2Q6nqNOk6l3iYeM4FeHukZxXfuu0YIyazWfPlEjPgkUm5m3HeX0ZPmSFwvIKOTa7AQCZtWurPMJSHttX9s+mHvWyvCOlGCfIcSIlLeg3cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BaIJ864l; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BaIJ864l" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82c20b9f989so1366565b3a.0 for ; Fri, 27 Mar 2026 22:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675611; x=1775280411; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UjT4f4n1BM6i4Zp48h42mUkpuWaNiLyW5S65Zt/5VyE=; b=BaIJ864lm+Tl/6P91195OD2ts2ywFoJQ/nuQr66HDNAwiUv6ui2zvd/igrbBCEjdSC 3+hs8O7rXbxPzqUHkdvxIRxuhgzSd/A3qULfN41aX9Gf/dxvjPgK+IIAXD3z05pUenYO CA1/Dq+cjGVLWQklWximkHqFo206wgm55sKHAaFWwIXSW3iW3kmjZvf0GBnCzNlgwdoO 8rRLCXW5YyeqVKT6snSPCn/06kw23Rj1KMviyEoFmKIACyApswdxFYX1Gxy5UqpOHfNP QVn1tMRMO0obyWV3bfUq2+RCGs7vY1An7u8vImqukBDLOtZoHT8ca2RRcFISWpnW7U8f sIoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675611; x=1775280411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UjT4f4n1BM6i4Zp48h42mUkpuWaNiLyW5S65Zt/5VyE=; b=amWrIZlvgSZk2VI5kSC2SzpB525sV1csKTg3ZTSE1HfzsQE/w5fdzM0F/xsaZtBLWY KpEuH4kkKgfsyYTf0Un1YEzbjYQZ3z7g74TIuEGe+wOKNFiEmXXBunorUrmReorEo/0k Aa6K6Zi0G5WUc124WD1VnamSa9kgZY4zrW5z0o9grcqlQTpYOpJkG0NjTwNgGgkBKOK7 JraZlD/URFVGFDxC9gQmMnnVKSJlLWphdAHuMh9BqpjsFtO5yOCO/QcJhAhdeK1T0xOL wEKksIHlKZRVldtypuZWBWNXQDd/9siu8PQ+PyHWdoFhUR3widyHA8HPTBxI8vB4mbwX xe+w== X-Forwarded-Encrypted: i=1; AJvYcCXOgt8DyOr7ZAvYn+Ay76yreZCiQgME1ExoOD50Nc3+L3A1uVj2DAZjIouChqTA+CLAg2sKzF5iikdusu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyCuldM8V5Z9nqGOqegh/Xpx8feNcyJzSdyvOTFdI3TZMBkqLXw qbsDgbxhOWDA9cqoAhRpmQDiNFz7QwOjsJFIpPSwzze/n0NjfNHFFME20O9kz9+i X-Gm-Gg: ATEYQzySlQ3cbeQ4Fv0mwiAE1FVmosruHYPx8KYo4Og2YBbl69RbebRneZOh2XUjLut xd82bR2XdI0nj38BNklscb9sHOL84ENAv/ekv0dbcCMVhwJ3XkUN2b1ZJGvUyo3dxJLoFEymTWr 9CGDA521GytbtJKpQGjI+Wtjamm2JeRI0RyaZWT6z0I+ra5sqekkfXfRZ4RNmINVeygOjNfNZH3 ViRraanncXbGUV9EtczPAgiDyow9Iz+NpRMdijknzURi47v5iBRkunwnOhtxn6MhhF4ODqMitJ1 kEQpOZcC/2IuU6U6OY1Q7ROIL8Kt2Y5rzkvTRoGSSan/a8fFeeM6gL1Q9izOfCahoZ54NaE8xqq AHJoTXxyGoAfMdGh4JcIgVHcvHjigTp2DrCMm6RKCsvHyjcFLR1oWHJIiLWMRBSsjtdgIDaShOM aGM6yH2oQDY5z70L/IOGrN6xEEDYAe54qoIQCkBu1w3Ro/0gQF X-Received: by 2002:a05:6a00:8593:b0:82c:9fe1:aa4d with SMTP id d2e1a72fcca58-82c9fe1abe8mr2838521b3a.13.1774675611543; Fri, 27 Mar 2026 22:26:51 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:51 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 4/4] ASoC: Intel: boards: Log error code in MCLK configuration failure Date: Sat, 28 Mar 2026 01:25:55 -0400 Message-ID: <20260328052556.434191-5-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328052556.434191-1-aravindanilraj0702@gmail.com> References: <20260328052556.434191-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The dev_err() calls in platform_clock_control() for the three Intel ASoC board drivers do not log the return code when clk_prepare_enable() fails, making it harder to diagonse failures. Add the error code to the log message. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index fce726a9c8c0..19d9e87df6c9 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -285,7 +285,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000); diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 65944eb4be16..6d886684fb51 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state\n"); + dev_err(card->dev, "could not configure MCLK state: %d\n", ret); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index e5806dc16ff9..248ad3fd495d 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state\n"); + "could not configure MCLK state: %d\n", ret); return ret; } } --=20 2.47.3