From nobody Thu Apr 2 14:14:42 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2834A1E531 for ; Sat, 28 Mar 2026 04:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774673197; cv=none; b=GnCHc8D9DT43dOiEKphH916U/Az3l7ZO8VXJ/jArGajo/tyAvEWSEoVGLF8cRoEQXHxyUxL9iTDJsY5JuxqCR6/8DxTV9X1rkppHMQRmRw+RVjW4xgUdIwzYU3F7ySkUQo3K+X9cXLgihBbPWz6NstDMEeA6suuXFRP7RCATrqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774673197; c=relaxed/simple; bh=nr93tEnrmBhvLiTiQMJBqbSKaB+q8gP6luPdCLfmm7A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ovJl/gwLPQjnJcftr9mHbHsZ6DgB3yF9PWcEQp1aYpySJ6+cO/ERdrzZzJF2nHVF7/PUp8tjRxg2Wa29EqtOf5gWIs9oaCn8QRO3slWcLrss/m1DcinCknD8W5fpPaLuMHwgGM7YDHp7CZKrCG/Wxc5EJQ0f5S/A6lk9CdNu8Is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g5JRysbf; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g5JRysbf" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35a094cc3e9so1783028a91.3 for ; Fri, 27 Mar 2026 21:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774673195; x=1775277995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tOQAY0QWafhJn0A51VpLeI70Zu09L6OxF6cr3nxplhc=; b=g5JRysbfP4tvcKd++B/MJnEZVFlavZDazMWtibM5GkT346ltnexkW8rhBqY5dGoY+M 6OK6f4lnkyhP3I3CI/lE/R43p3Us8aE0t6SHoSefr0GzigaxQjNmTyR+bdKlS2vUAUiQ OUdhI+yni0s0MDRST3Z3iBbNNFHzh5tGxpNop3o7l8enHPrIweuXvVYJO3qh7UvK2rXN n30BD1cfPoRhGh2AHZHPdX4F10NDYT73/wCD6c1RqjxLBfq1a7vQ1nVqfsU4ZBecdpoK uF/m0y5kcsNFkSDtdGzdhnDRtcjgbnAiNP//ksih78etgRf6hit3r3FUthpMjwZmvSn6 aeVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774673195; x=1775277995; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tOQAY0QWafhJn0A51VpLeI70Zu09L6OxF6cr3nxplhc=; b=rBsM7akz9A8SRZRTB1WR4t+wFxzwb2z5quyI8RHwYk/vca4Bx/OriU5YN2ENWwNUlY 4YWODchugR+U2Aidt7W6S8kQJQnsc6oKzjSNi5lxkwRfAvoCMBXOoJyHngy5vJc+kcTX EPxz/Zt+Ko5M83KnUKS4Id/Spl7EcdmPSMueC4frKZGnEOj9NxVW1mCX61HUNJih4NTS kmS0oXgoC8QG9W3y3I0aT14HiojAKBOF6BT/Pr+rp0C5585C5cC9FotqBZyPacwXIJv+ GgzE45+1u7+2Kal+8uXvAs03TNNEtJXLSm2TyBfhHoDtb1FYsxhJeIMtYerBZft0PWR2 aLMg== X-Forwarded-Encrypted: i=1; AJvYcCWYIjEiYjeaWbcdZP7eRnAUS0tt2JXnhUtM3hPeRCBwFEk3fDhi4JLGxuA4yYt6/a7EXb0LSOypaPxj07A=@vger.kernel.org X-Gm-Message-State: AOJu0YwOADuRszEhciOd9aPsJRlZ6gu0agpzOwTd/UhVQf6xcMUoJ5Rb 8hjA2Yt7mz7zHeqV3AeOT+5VIM3juA6mQvu26uhZOzC/d2Geb7OuLvqM X-Gm-Gg: ATEYQzxkCEAdWM1vry5YaV6XVAgBaYi4FrKg7W4faCmbbA461yeWKt1fNvCcWTJq9gK 2udsAeSp4IR6JDQ3nxIBASTOLCsSoNLE2ArNmtr9wC8z84+7Mpai3AAt405TAsk//gPwduAzjUi isEIyKL8r+r0NvoC1S2lAwQaHQK+sge5J6yaaZgKpipJw7udy4NLhZ76V6w1sd9KqymIsdb8OCQ eSr36K3FORU3bI7wbK1ptVSTZDpYN5T9mlMulOJpNBgycWQdx0/OAzwifDHHz7X+xAkDLGD8Ime Znd2kR4LKvOP0DhhCpbSsg005DQKN027quSv6MO9xlABfIsqNaQdY27bvgMXCo45u4qnxnPfGK+ uFco8FmBejESNC6Tl3qWnaftjbWPv5VWLVbzIJV5VGzVT6+qdlj3/IE6NBRQkIHNENXew8t8Qim LedyWdda5C/A1lkny9uqwMU/Z7om9KPLYdJEKAXHSE1pYcBABjhqmnby+2PGCqdEz4kzWOXGoGN OST22Lpg2hsAQo2FaxGW3NXVa6zuItmDg== X-Received: by 2002:a17:90b:3144:b0:35b:e4f8:78e1 with SMTP id 98e67ed59e1d1-35c30008d96mr5000359a91.11.1774673195291; Fri, 27 Mar 2026 21:46:35 -0700 (PDT) Received: from localhost.localdomain ([103.240.235.134]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35d9507d739sm745108a91.11.2026.03.27.21.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 21:46:34 -0700 (PDT) From: Shivam Gupta To: gregkh@linuxfoundation.org, johan@kernel.org, elder@kernel.org Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shivam Gupta Subject: [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs Date: Sat, 28 Mar 2026 10:15:27 +0530 Message-Id: <20260328044527.10489-1-shivgupta751157@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sysfs_emit outputs in audio_manager_module.c do not include a terminating newline, which is required for proper sysfs formatting. Add newline characters to all sysfs_emit format strings. Signed-off-by: Shivam Gupta --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.34.1