From nobody Thu Apr 2 14:08:22 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4124217AE11 for ; Sat, 28 Mar 2026 03:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774668699; cv=none; b=W5DhlzH19kOGn2I6WH7QnMteihih6nvjaVe2qR1Y/7LngjicPRxaILkjmhSJi9O5HctJY6QfQ1JRq87oW4kaobTYRVWjUGBPvGRITjbswvlMXJEGwA0jylMPUfpp2Px6+CS7vXJCTGKpbSjgX6wOlWeKiarcacVgu0Y6xuNYsXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774668699; c=relaxed/simple; bh=l0TA+U7sPyK8HmvbWwu9mXbUamGOj+FHMgI5WNsvCG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UbXyJXr0btMgzqBSHhVVhZEPRpvAHULJnhcjwxLLMz8Y9mvWYZOcmNmxZ43qwrqfcF6bmFr3pHkPfZ9G1z+Dh5ulSOkDBXtbBZB92fiXlYYLcPK7+u66Yy0sTDVTE80JKIzJU1ile/LlBqVtfwGrDZuW3lgxILkgGh+ZVhRBh+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dFEdDRAT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dFEdDRAT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35d932cc948so247287a91.2 for ; Fri, 27 Mar 2026 20:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774668697; x=1775273497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Om5+Mb7abasp4NXOBoWeswnA1ObOpepVUBkgmbLhNQ=; b=dFEdDRATk2TCibwrkLBxaHbmDrEdIJeh3sObKs5nNEB1v4csxtGC11uzyO1Mi8XdjE y2WepaWJtxoaAlXZjPifXs7ZeiCUAdU57xRd2pJW5CZF/J/8Zne3U+MmmMF/XO9h4ij5 HtIq+qvQmwL7HvI0s/FdpSfcFEg8Tfq7ZswCK4Zq+dot+0lT941kUbZyCWaGmBmQRZ4k 4pmLkr2lf+u4bp2TIHOCLIYetymvhBB62yPMl3od/8zrFMh3a179DdGx5eGo4gxc1IlB 83jDCwRJ5VsE2Qeyvjr/TqPshyEw+EBVrAuuJmvCSQyEGdA8lzXS03JkL8DQmZeb9UHV XW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774668697; x=1775273497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Om5+Mb7abasp4NXOBoWeswnA1ObOpepVUBkgmbLhNQ=; b=A9vpu+2/E7HhC+EsCfkVwDDEBsAllXcXtKLJMLPFnxqfugWaGVSmVpOzNDry2+u8BU +CP+AXq7BdpzB6X7Bwh/MHpKXR8AJZ7wwT6Dvnlxazg/xurygkQwnl7+CA3MB4iEtmD2 ya+ghgnJGpBrka9e7gC2ihbHx4EsB2If+kB3vsRFJlYM7wbZxIxYf+qx1rCOzof/qAT5 NVmvSHSB0U27H4H6NEp5/yfJDxUmvapvL8SGYKXVsDE7VzIlVNNW772dqENb/7gWhEnP stZH0Ys4K1M3g2mIIhbf7ypD6JAnlcR7fBe+pj117Vsjk9FOpIWrHGz5GhyKrobik+en pEWg== X-Forwarded-Encrypted: i=1; AJvYcCVLiwt5CbcbvMAe9z5axpWfMFrhvTJ98uuP087hdO4XL7nZcaAuAxCPnfnxkiGBlIwjj0TNqK6uxKHnWZA=@vger.kernel.org X-Gm-Message-State: AOJu0YxYhhMkiGgNOMFuzjeB2DZh2WTvJTsorHMonRRacKDSPV2iPL70 SOWNygb+w4fM5ySrwnjcu0WLDBftT61Dqsppjqgv5IhzETLZ6/2lttCz X-Gm-Gg: ATEYQzx2xcHErEVWLMHPYILKktj+cISudS0rkyc1E0fqxSTR6XORz+moHsAbKVOzSUN J0FfXJyl6GUpljU3roo8YHH9AK46M/BQLPgXKuJO1LNpPFckcrklcSgjLYRo+ecBtzJKmC2JDeC uk0Ry4R4pqUxEgW1ME3UyeZqtzdJFmdgyCbK9o2DlqLrSLK07C236hwAzBl8jTnaMK1/bHeSLSO luXd7N6y3DN/rJHCZe/mwQZifTePZ8j/8UwY/Z76PIzfNWw5InpPZI9NVYycjTAUj1jxtFst4e4 UIImLAPNoVkVAh1Lz1JKB0i675tnihsggzSLFlAYbsTy38cDju3mMC9aUQI0/jtCjjUq0oobHZZ MZCC8OA387Tr/QuLsffACjGT5mvgqGcA0Ss9AabMKCmPzwh02hIP9B/v3+KBfgnKB8JoofMBsby wEx63GQ56w8Br7hSqWcisZFrD8US+4dIlJ4CM= X-Received: by 2002:a17:90b:4c8d:b0:359:855f:ff96 with SMTP id 98e67ed59e1d1-35c300b29b3mr4485865a91.17.1774668697475; Fri, 27 Mar 2026 20:31:37 -0700 (PDT) Received: from aadarsh.lan ([2409:4090:801b:f416:bb8:1eba:738e:33f5]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-35c22db12f7sm6252751a91.13.2026.03.27.20.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 20:31:36 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v8] staging: rtl8723bs: remove commented-out code Date: Sat, 28 Mar 2026 09:01:28 +0530 Message-ID: <20260328033128.27946-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318021005.6346-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove code that is not used anywhere in driver. Signed-off-by: Aadarsh Mandal Reviewed-by: Luka Gejak --- v7: - Change in commit style. v6: - Change in commit style. v5: - Change in commit style. v4: - Remove extra space insertion. - Delete remaining commented-out code. v3: - Add the extra space that count as insertion. - Remove unwanted addition. v2: - Restore braces for standalone code blocks {}. - Delete reindented commented-out code and extra space. v1: - Reindented commented-out code;extra space remained. --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 31 +------------------- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index f2f73c65a636..d0b0e7adb68f 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -46,8 +46,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) u16 value16; u32 value32; u8 ret; -/* u8 bMacPwrCtrlOn; */ - =20 /* all of these MUST be configured before power on */ =20 @@ -69,10 +67,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) value16 |=3D EnPDN; /* Enable HW power down and RF on */ rtw_write16(padapter, REG_APS_FSMCO, value16); =20 - /* Enable CMD53 R/W Operation */ -/* bMacPwrCtrlOn =3D true; */ -/* rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */ - rtw_write8(padapter, REG_CR, 0x00); /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ value16 =3D rtw_read16(padapter, REG_CR); @@ -359,7 +353,6 @@ static void _InitNetworkType(struct adapter *padapter) value32 =3D rtw_read32(padapter, REG_CR); =20 /* TODO: use the other function to set network type */ -/* value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */ value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP); =20 rtw_write32(padapter, REG_CR, value32); @@ -410,9 +403,6 @@ static void _InitAdaptiveCtrl(struct adapter *padapter) value32 |=3D RATE_RRSR_CCK_ONLY_1M; rtw_write32(padapter, REG_RRSR, value32); =20 - /* CF-END Threshold */ - /* m_spIoBase->rtw_write8(REG_CFEND_TH, 0x1); */ - /* SIFS (used in NAV) */ value16 =3D _SPEC_SIFS_CCK(0x10) | _SPEC_SIFS_OFDM(0x10); rtw_write16(padapter, REG_SPEC_SIFS, value16); @@ -484,10 +474,7 @@ static void sdio_AggSettingRxUpdate(struct adapter *pa= dapter) =20 static void _initSdioAggregationSetting(struct adapter *padapter) { - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ + struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -640,9 +627,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } =20 - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -661,8 +645,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 rtl8723b_InitializeFirmwareVars(padapter); =20 -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; =20 @@ -704,8 +686,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->RfRegChnlVal[1] =3D PHY_QueryRFReg(padapter, (enum rf_path)1, RF_CHNLBW, bRFRegOffsetMask); =20 - - /* if (!pHalData->bMACFuncEnable) { */ _InitQueueReservedPage(padapter); _InitTxBufferBoundary(padapter); =20 @@ -745,11 +725,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET= _DONT_CARE); =20 - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx= ; */ - rtl8723b_InitAntenna_Selection(padapter); =20 /* */ @@ -791,8 +766,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TX= Q_CTRL) | BIT(12)); =20 -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HR= PWM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; =20 @@ -1080,8 +1053,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; =20 -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEP= ROM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } =20 --=20 2.43.0