From nobody Thu Apr 2 15:36:10 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C36361DC1 for ; Sat, 28 Mar 2026 02:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774666642; cv=none; b=LhStMwOrvTI/g9hFX4Mmyum52TpSIQS/VVabkIPgoYZnhRTVF7CyIyHGSOdDeK8fBWeClV98n7EtyWoBVZYCXDe/k2oNjMaQ2ExJ9jW310OI9trWuIHZQW/6JfLQAqw5/TUHudAZiPn4aIEgiJyZ1kU/7GexqWBQT6G7s0Q1nn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774666642; c=relaxed/simple; bh=lEmMFStHFCwVsgKZXQzMzKO0rGosEiMRtW2Qypi90Ag=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bPU975aYJ2GFLKvH7bN8c8tqjvU5iIC23cMTRgWAZ8rOfQeiRXjKY0Im+0hF3V8Ms0tw33+PMTGDXV0JFuHqrU8r4wdQcInjtquBXpOG2HiQokKKj/YHkUaupdbkzIKE6JGP/l0z2PbfaABb8tGpzzxVCoP/KPU4sTGfc9+yc0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OrbUkVoj; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OrbUkVoj" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b23fcf90b2so6033095ad.3 for ; Fri, 27 Mar 2026 19:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774666641; x=1775271441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=EtEVRFr5TjD+uQz9TD2YL6Kg9T6ihv6Kbhn0QKz5XCo=; b=OrbUkVojuN/vZerXObOZsIzZeNdbSCll5PBLUGWAPYXF9Npy4lT9VZboMZA/gAvbSt Jj6qKVqPzZwJBRfn4IXx4noCPm79qk1iDTu1vRiQ3SBMd0AF2KoaiIu9bePdmmXWx/Z/ p7l/VzEN1bI1iL9b1Nis5HRdjfFO6bvNFN5DlDtUvaBcpxiWd4ETznNYgqKutlK2ulaw 4danyljAJD8CZQ9VEgnhIV5obcn+A/GFfaoQyDgzHOs7WfCTQABk1Scv3+iMcrWHzUf3 fI8+mBwXu74gikCYzEUQc3r4OKWiJF0LlZo2qIZ7gDlwZBADPXSPAdHKUf/ZMGRRa+7d kKcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774666641; x=1775271441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EtEVRFr5TjD+uQz9TD2YL6Kg9T6ihv6Kbhn0QKz5XCo=; b=ktYazKSLU36W/Tgv7QJwrkgZhEga1Vsd307ksAt6CbLMmrARRLeV0XYTtRVU8ufadD PY53F0Bg9qEx6Gb4ul+hnhU0JuDhFLwRo2pcKLZvW1qqshbNvqTPS3gmhivCA5UrP8uw d5e8jsULJmOwxs+F4Tvsli4PBZFkMXnAbxc6M5ViPt2TvAxtX5B/uha8pDB2MEhwpd9O ml0mnLO5CysBNGC+tkHwhX4cVLpbmPWQByPsVenxyt94K4BRcPJRcDDff/WEXY33laXb ZK4pznZ0drTvQ1g0t4i9erk3v6aMzdJ4QLAmV2lary198j9kx0esAE8f1wzvwiY0I87F Ow9A== X-Forwarded-Encrypted: i=1; AJvYcCWDNOUY0dN1p7dZ1UQtTj43ucs0AcAi3tuo1EHm4R3p4FDL4NFuramzQ1gTePWp/9YJFfqk5J8TuHqIPLU=@vger.kernel.org X-Gm-Message-State: AOJu0YyKiD0g7nuv7xWwPjaLbftc8T6l6mUOsr9QZlfa98k9OnuiGIQb yLNJg6TX7T4y5TXaMvndKt85aj8dCsgs0z/Vrw0DVSeh3EfFv3DNUf7n X-Gm-Gg: ATEYQzyCEtEGjKE/MZq/XsUe/gvaYOQ1VerFdMVMnFyhiHJ3zj5tA18Pb5DzobA+vuE 8UHtBizHYho1Sj+gXk9bPZYOD61GBgCgzhsgvhXIKXy2beb1PfGddvV9AEd8LLscHjetaH0NJcg HgJWxtbMSmV3fRo/yCHnT0fXbQAsW3kOfkn5Cadffoa2RM7EaNM3EkX8J+6QAB2QWOjUyFak7Ub KwlBeHLEN4ta8mUkBh3ur6ubOggczxJeZEr7HivFOte053VcIz4RjF7vpEArauzjSRroof0bIPG RfyuBWTEPELg4g65E+R/hC3CJLq0krdzTF4xLxl/w76qYMDmIRhcwVEHBZpApYalpSbWqqbZn0F ycTxRcflp8M9q9G/hhMc1Yu1XKA11CI3At3jA+jzKrMrBtDYoDuYKBXVzpmbgG7Xi/VqOgZi9+I f27Gx2JIs1Az0OQkHvCh2mQG0rItlsNcINJXzLXD6g7OfoIUA= X-Received: by 2002:a17:903:19ee:b0:2b0:6e60:9586 with SMTP id d9443c01a7336-2b0cdc2badbmr50907315ad.17.1774666640587; Fri, 27 Mar 2026 19:57:20 -0700 (PDT) Received: from localhost.localdomain ([60.49.20.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24277fb50sm7194835ad.56.2026.03.27.19.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 19:57:20 -0700 (PDT) From: Khairul Anuar Romli To: Lars-Peter Clausen , Vinod Koul , Frank Li , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, Khairul Anuar Romli Subject: [PATCH 3/3] dmaengine: dw-axi-dmac: use logical NOT for NULL check on of_channels Date: Sat, 28 Mar 2026 10:56:57 +0800 Message-ID: <20260328025706.52722-4-karom.9560@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260328025706.52722-1-karom.9560@gmail.com> References: <20260328025706.52722-1-karom.9560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" checkpatch.pl --strict reports a CHECK warning in dw-axi-dmac.c: CHECK: Comparison to NULL could be written "!of_channels" Refactor the check for 'of_channels' to use the more idiomatic '!of_channels' instead of an explicit comparison to NULL. Fixes: 06b6e88c7ecf ("dmaengine: axi-dmac: wrap entire dt parse in a functi= on") Signed-off-by: Khairul Anuar Romli --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 49e59a534e22..1fb387e9338c 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -1056,7 +1056,7 @@ static int axi_dmac_parse_dt(struct device *dev, stru= ct axi_dmac *dmac) =20 struct device_node *of_channels __free(device_node) =3D of_get_child_by_n= ame(dev->of_node, "adi,channels"); - if (of_channels =3D=3D NULL) + if (!of_channels) return -ENODEV; =20 for_each_child_of_node_scoped(of_channels, of_chan) { --=20 2.43.0