From nobody Thu Apr 2 15:41:46 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7B26211290 for ; Sat, 28 Mar 2026 00:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658770; cv=none; b=WAIQ1gXPKydYoAyTN7GXbd+WiJYynzm7Smc7SJAFg03xc+j31nmKqCMg+q3jfPjAL/jV5BMPIHd991qwCK3mAjegosdbhlSarAhbqzS+ckNz6JNIeKepd8UKwapYhn0v6zm2X+qz4o3QEPCHwZASnusgus1y+wPJT5d87lzqA0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658770; c=relaxed/simple; bh=ew2kVzBJghsHpl+0SnT+1OeTu964CJrGri7qAmuoVpA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XQLhgSoqduhCFK2Ch1+ImOk5FT0jcJGekz/kwrrnWOshEVvihCY+rWeVqFDkVvCXT/7FZZU95GlkKgnysiMRkwOy7/xoaQ4MFDN0ZJj2eeJ4OTVfVzvZhj1rWC0ri21ajYeuOe7U22mc6wsh4q+GxyuRKsZCm3YExU6POgmbnGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=HPicmm0s; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="HPicmm0s" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2aecc6b0861so17398195ad.2 for ; Fri, 27 Mar 2026 17:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1774658758; x=1775263558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ob2hvujo7HUb7R0D4J+lODKhe78Bpwesdjiwn3j8SZY=; b=HPicmm0s499A0EXlSttmLfX+nxgdSt6jxn96xgaQwxQUv7nWctvogOs2qfOqvxLg3D /DhC8NfPJe1YAxCPZsBK63EFq0I0OuyZc88uufSqUaaqVEmYbnJF2/WPLUrp8w/hB+sY Jx6R8UXX27MoTpUeKkRkaAWR3IXvBkrD2Hm7WpIuCd2MLKDzPo/zDQ2ZZoM/ThoPTsMy eTxEUnJOEfDtzdHNvdT3bIjATLmXLbXrlzwp/leftM2VDHmsyxC6+VlPKSOBwL5RsEsI SZu9MdN+7HiMsAaL8bJl1xzXmv9kACXTfdOwPqr7J6zyGdx8326TmM4s7dlqLDwIy6GO m1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774658758; x=1775263558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ob2hvujo7HUb7R0D4J+lODKhe78Bpwesdjiwn3j8SZY=; b=s4+bGZFkNo6y14QiKBTucglYDJIgFZMWb2CIw0MnaaWhky/Y9vibjx5OFKbcZmsfRB Pauwz3ITG1pjyf5rD//yd7tlQ6C9ecNANV1WEFabWcPOv0yIes83n6xEBGccqHRvJ9Eo U2/5leYHOgF4XkfWD8YAaUU2s6pDNbedc/F2E9FyGMD1exhR+FV7ktCKe8rNkzESOKFc WbP2znCH2TBf6KZQQ3CgoVlCR1WB0jYpEUdQKm6rWcA+voK/42TfnTKDXxApfHhu+bDc tETI6beDAmw+UGEbzVE/hB62fxQIXF9i32LWG12N+aoRjcfnQfKe07LtGeYkOqTLQ6b1 j4Ww== X-Forwarded-Encrypted: i=1; AJvYcCV8vVq2Jhu7d9gzXd6aRW+PGKqNZodkR34tlZq3Dci0Q3E12/4KtCLOyQ2TmllIW/Ajm1JfPt9b77xXOVk=@vger.kernel.org X-Gm-Message-State: AOJu0YwWDzqGk1KWZB3PW+rFXsyd9bkwbvbgcHsl7zf/qn2bgyhEEeMz fFfNbWcbhvICtB6egRZxKLklTAvqCg0pl5XUP5X/WZRQRdVYu65OyRIIxNCW8Jsr9P0= X-Gm-Gg: ATEYQzz+xTSv/5DZWEssPhHxQKlilTo5UJK+lak6m3HMx4ekg/GcLn2GLbyn14XB1Cd N/6j9EsjDxlu3MGt4BE3f+d1IsLv8iTpqh92Jp1zUqnmLQ32mMRvFgSnOJunrzqzoMiGoqfNcNz vzNXXCx24rhgBX40XXAMXEPnrYlqICz6w9CdxxVXR05AeL8YHUo591Jgrai971XbX+NQmkb/ktQ qgnKfA4T47dsvsG/NWM67CvL4j0hQpTH5nTiOxEp0GJv2p3wL9ALfsTcwNeRS2noQb9BT/kw6+M ethFl5NX8PjiioTjo9ACUVuzVw2nTVgS4voO+1OZE/W6jRngiGJ3eVw/7mMThI2+toiXoFy6/l7 d6Uc6XS6MvaH/PT2QY8Zf4r54lZ1SbMqlq6wJnBHn/W1clelFqL+ZoVty2V2DfY1r1lXOiRvFdL lawRv74FpipFa+K+wzGw== X-Received: by 2002:a17:902:fc85:b0:2b0:5990:cf1e with SMTP id d9443c01a7336-2b0cdcc8706mr41302025ad.33.1774658758053; Fri, 27 Mar 2026 17:45:58 -0700 (PDT) Received: from ceto ([2601:640:8202:6fb0::9c63]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b242683064sm5342705ad.33.2026.03.27.17.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 17:45:57 -0700 (PDT) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v4 06/15] nvme: Rapid Path Failure Recovery read controller identify fields Date: Fri, 27 Mar 2026 17:43:37 -0700 Message-ID: <20260328004518.1729186-7-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260328004518.1729186-1-mkhalfella@purestorage.com> References: <20260328004518.1729186-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" TP8028 Rapid path failure added new fileds to controller identify response. Read CIU (Controller Instance Uniquifier), CIRN (Controller Instance Random Number), and CCRL (Cross-Controller Reset Limit) from controller identify response. Expose CIU and CIRN as sysfs attributes so the values can be used directrly by user if needed. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/host/core.c | 4 ++++ drivers/nvme/host/nvme.h | 10 ++++++++++ drivers/nvme/host/sysfs.c | 23 +++++++++++++++++++++++ 3 files changed, 37 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 766e9cc4ffca..7a07c23aefdb 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3567,6 +3567,10 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl) ctrl->crdt[1] =3D le16_to_cpu(id->crdt2); ctrl->crdt[2] =3D le16_to_cpu(id->crdt3); =20 + ctrl->ciu =3D id->ciu; + ctrl->cirn =3D le64_to_cpu(id->cirn); + atomic_set(&ctrl->ccr_limit, id->ccrl); + ctrl->oacs =3D le16_to_cpu(id->oacs); ctrl->oncs =3D le16_to_cpu(id->oncs); ctrl->mtfa =3D le16_to_cpu(id->mtfa); diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 9971045dbc05..234f3872a212 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -382,11 +382,14 @@ struct nvme_ctrl { u16 crdt[3]; u16 oncs; u8 dmrl; + u8 ciu; u32 dmrsl; + u64 cirn; u16 oacs; u16 sqsize; u32 max_namespaces; atomic_t abort_limit; + atomic_t ccr_limit; u8 vwc; u32 vs; u32 sgls; @@ -1280,4 +1283,11 @@ static inline bool nvme_multi_css(struct nvme_ctrl *= ctrl) return (ctrl->ctrl_config & NVME_CC_CSS_MASK) =3D=3D NVME_CC_CSS_CSI; } =20 +static inline unsigned long nvme_fence_timeout_ms(struct nvme_ctrl *ctrl) +{ + if (ctrl->ctratt & NVME_CTRL_ATTR_TBKAS) + return 3 * ctrl->kato * 1000; + return 2 * ctrl->kato * 1000; +} + #endif /* _NVME_H */ diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c index 16c6fea4b2db..f182a26b38b0 100644 --- a/drivers/nvme/host/sysfs.c +++ b/drivers/nvme/host/sysfs.c @@ -388,6 +388,27 @@ nvme_show_int_function(queue_count); nvme_show_int_function(sqsize); nvme_show_int_function(kato); =20 +static ssize_t nvme_sysfs_ciu_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct nvme_ctrl *ctrl =3D dev_get_drvdata(dev); + + return sysfs_emit(buf, "%02x\n", ctrl->ciu); +} +static DEVICE_ATTR(ciu, S_IRUSR, nvme_sysfs_ciu_show, NULL); + +static ssize_t nvme_sysfs_cirn_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct nvme_ctrl *ctrl =3D dev_get_drvdata(dev); + + return sysfs_emit(buf, "%016llx\n", ctrl->cirn); +} +static DEVICE_ATTR(cirn, S_IRUSR, nvme_sysfs_cirn_show, NULL); + + static ssize_t nvme_sysfs_delete(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -756,6 +777,8 @@ static struct attribute *nvme_dev_attrs[] =3D { &dev_attr_numa_node.attr, &dev_attr_queue_count.attr, &dev_attr_sqsize.attr, + &dev_attr_ciu.attr, + &dev_attr_cirn.attr, &dev_attr_hostnqn.attr, &dev_attr_hostid.attr, &dev_attr_ctrl_loss_tmo.attr, --=20 2.52.0