From nobody Thu Apr 2 15:41:43 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF62B1FF1B4 for ; Sat, 28 Mar 2026 00:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658765; cv=none; b=G2FMqHNkuE1JT2iHWayO2uWXkdmhGqALnKOF39t6RcH4qoAkSLLvoS6baBnPWdXa/24olStnFeZoXf/POUaLiGm6lcRrdZSfYrC+O3n/iFI1IK/1n8hqjG+EW5i0gh1+pdgXmz1BvNmGP8sbN9mufTZI16GArgx0OhTTpQ8Hjts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658765; c=relaxed/simple; bh=SBozTM/ZJJfjFjQbkRs3uYTNSltKV1TkjdjaGA65YT4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qKvBymzM8r+yXs/XuqWo9JDzar3MQGczuPgSa7FryVPv3iObyc9NbUYRJVqcIsBGPuxbHXAo8JOmb52RQO6IM18WRFIgDfm0fw0b9YstetDMdBOLFLfxMTubI1UorDzh7DwQaDZ8FIbR3xU1HP3yY4GgJNRa2nmVyhclZHZJRKs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=epd9LjMi; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="epd9LjMi" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so2574144a91.1 for ; Fri, 27 Mar 2026 17:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1774658757; x=1775263557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gNe2anjf3U+8vvrDpf4bS35uyUrfzt1FE8OQuJB51II=; b=epd9LjMi3zFwFdwCMzgjBvFxHDcxXtk763Ars90Xo3M5Epmhu/aw/N9gga9zVqHTBj BTO7sE1GUyaexR/5iSr1E+1WjlbayM8WvI54cI7UcvE6daILkRCitByU77IQoDjm2e4O LkghXkxBqegxt+hA0WSeWzsQAKg4/PLEUSDQNV0Omwls4HtSzTJuxInjxpczmVjh0/jd 1rfcpgnBNJYJqdzjXmh3i2r87eM5dzG+ojQFZbx+5a5aBB54q5Zox9jMsWgk6QqnCJBy f0jAK1fqfZY24eI64uMwSqLTqhWEwm9HAVyzBBdU3xBM1P3HkIYLMIoG2pnfo+XF9Mr2 Mr0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774658757; x=1775263557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gNe2anjf3U+8vvrDpf4bS35uyUrfzt1FE8OQuJB51II=; b=UYwYkk8m39hP8hV9+8odI1KS6dcf6mESBqlJYM8NmfHEqpoGHJv1UzgunLpmSod+wx ZUeZQz5P4X+6XkumXL8z4N4NUjAUi1kgXNTLD2LJ2qk0usYtVqu9+uktqfim3x8Snj+/ zB5Vqo6kiaRxw4vY2XoGErkjdqLnn1zIYkHMgscHx4PHsAFvTlpqLlSgD2hQIgQ+QG5H ZNgS1HiY0oLha2zXx5hrKDXT4Ong+ADoXDAEKZ1ShlLaG90lfc85UXOKYoiCYyJbrp8L np/Jgo2yGE+TkZSNRINgf5P60m+xjerUIZ7kTVRqJ7bIr4ts4QyeTIn9jDKS+aZoPgHq Jkyw== X-Forwarded-Encrypted: i=1; AJvYcCU4a7Ixt15xLMU7qWOCSdHA0TEiHQmQIo1DX8F6eev5spNDoCRmkw8nPqz8On3AoXiz6REE6KOrcUYJUck=@vger.kernel.org X-Gm-Message-State: AOJu0YzGu8WgdFPbgKpINaOU42Az3sXKJoSqYcCjXotCNer9IegmYJvd EnoHAEQ6Dqrcs13SMJ9PoBxrwgoAP3o0LYJUJDkrqCj6zd3SfBtYPBTW8Vhnqm++atk= X-Gm-Gg: ATEYQzyyfGypF4R3kajfml2ppWUrxTErVND3Z0SuTiJjzJnjrpdOCLuz6kV3/xFU7PK GNG0BDSmWb6d3xgU9+uJzEZMvo5uEdBZOnDTiLwEZDhWrt82n5RF/J71ieeyHl5sEL1015soIvv McTsK4QupoBNxGpNbsHIZeEyi+rZIc6yxegAZuaWDa4qsGEkeRTJz0VPZUttKYEQbGOj4Gar/Lz ivgnONhk+0KFty3c+Av4fNXN5myquJBR9udS6UzE60zXpnES6ycarXjGfSspNtTFIef3Wkj0iVa 8ESmRPSdtg6P86WU9CLM+q6kLlE5K6jOsPych2diAu8vCAwOCDTH0h9Qj5no/IHbrQgTTL6ThBm 9GJJF8d4oHnsjmqQA3apE9jmZbu6yub05znxPDhd583ULIJa9SOHi8IDcXI6V1E7Q4ttUbG15Qq D2xeAjq3HlKDTwnEZB7Q== X-Received: by 2002:a17:903:298d:b0:2ae:483f:b23c with SMTP id d9443c01a7336-2b0cdcc6c31mr46778695ad.36.1774658756823; Fri, 27 Mar 2026 17:45:56 -0700 (PDT) Received: from ceto ([2601:640:8202:6fb0::9c63]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b242683064sm5342705ad.33.2026.03.27.17.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 17:45:56 -0700 (PDT) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v4 05/15] nvmet: Send an AEN on CCR completion Date: Fri, 27 Mar 2026 17:43:36 -0700 Message-ID: <20260328004518.1729186-6-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260328004518.1729186-1-mkhalfella@purestorage.com> References: <20260328004518.1729186-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Send an AEN to initiator when impacted controller exists. The notification points to CCR log page that initiator can read to check which CCR operation completed. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/core.c | 25 ++++++++++++++++++++++--- drivers/nvme/target/nvmet.h | 3 ++- include/linux/nvme.h | 3 +++ 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 2e0c31d82bad..4f1f0562cef8 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -205,7 +205,7 @@ static void nvmet_async_event_work(struct work_struct *= work) nvmet_async_events_process(ctrl); } =20 -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event= _type, u8 event_info, u8 log_page) { struct nvmet_async_event *aen; @@ -218,13 +218,19 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u= 8 event_type, aen->event_info =3D event_info; aen->log_page =3D log_page; =20 - mutex_lock(&ctrl->lock); list_add_tail(&aen->entry, &ctrl->async_events); - mutex_unlock(&ctrl->lock); =20 queue_work(nvmet_aen_wq, &ctrl->async_event_work); } =20 +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, + u8 event_info, u8 log_page) +{ + mutex_lock(&ctrl->lock); + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); + mutex_unlock(&ctrl->lock); +} + static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 ns= id) { u32 i; @@ -1784,6 +1790,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_all= oc_ctrl_args *args) } EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); =20 +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) +{ + lockdep_assert_held(&ctrl->lock); + + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) + return; + + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, + NVME_AER_NOTICE_CCR_COMPLETED, + NVME_LOG_CCR); +} + static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) { struct nvmet_subsys *subsys =3D ctrl->subsys; @@ -1807,6 +1825,7 @@ static void nvmet_ctrl_complete_pending_ccr(struct nv= met_ctrl *ctrl) list_for_each_entry(ccr, &sctrl->ccr_list, entry) { if (ccr->ctrl =3D=3D ctrl) { ccr->ctrl =3D NULL; + nvmet_ctrl_notify_ccr(sctrl); break; } } diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index b9eb044ded19..6546be25901a 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -44,7 +44,8 @@ * Supported optional AENs: */ #define NVMET_AEN_CFG_OPTIONAL \ - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE) + (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE | \ + NVME_AEN_CFG_CCR_COMPLETE) #define NVMET_DISC_AEN_CFG_OPTIONAL \ (NVME_AEN_CFG_DISC_CHANGE) =20 diff --git a/include/linux/nvme.h b/include/linux/nvme.h index b792d488f72e..1fbb5b268303 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -860,12 +860,14 @@ enum { NVME_AER_NOTICE_FW_ACT_STARTING =3D 0x01, NVME_AER_NOTICE_ANA =3D 0x03, NVME_AER_NOTICE_DISC_CHANGED =3D 0xf0, + NVME_AER_NOTICE_CCR_COMPLETED =3D 0xf4, }; =20 enum { NVME_AEN_BIT_NS_ATTR =3D 8, NVME_AEN_BIT_FW_ACT =3D 9, NVME_AEN_BIT_ANA_CHANGE =3D 11, + NVME_AEN_BIT_CCR_COMPLETE =3D 20, NVME_AEN_BIT_DISC_CHANGE =3D 31, }; =20 @@ -873,6 +875,7 @@ enum { NVME_AEN_CFG_NS_ATTR =3D 1 << NVME_AEN_BIT_NS_ATTR, NVME_AEN_CFG_FW_ACT =3D 1 << NVME_AEN_BIT_FW_ACT, NVME_AEN_CFG_ANA_CHANGE =3D 1 << NVME_AEN_BIT_ANA_CHANGE, + NVME_AEN_CFG_CCR_COMPLETE =3D 1 << NVME_AEN_BIT_CCR_COMPLETE, NVME_AEN_CFG_DISC_CHANGE =3D 1 << NVME_AEN_BIT_DISC_CHANGE, }; =20 --=20 2.52.0