From nobody Thu Apr 2 15:39:04 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB8B39B95F for ; Fri, 27 Mar 2026 21:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645480; cv=none; b=WDoqh5jZT1PIWwFVYTKC/xl3lyfwy5BkO0dMuQiIevBnbkBhAIumvKU0W2cPdSmLCVihAsQGGt4GrDLo3s6JZrm37wyhK50+xMUlrJjEOktaarjgaclg/y8FL6VHqhYiM3kA5j/e/SUB54o9xU0/+0fP/ujCQkaQhXpckjbRAtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645480; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hlqoHuWvq+FiT86FUAxBGU2kWSs0Uf66+zDhSQ6SYxjJ4ngYCUsL5RM6ER9eC6Kbe6lZs6PwFRZHvoCQL9h61BeT+cuHPjkJ4Az5cEgG0wiqGyYpJUT5IQPFYN7LYY83dLtAbx4IOVABYo8dfNxic4xeOuY3n8xFpW7obRvUmtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Faxj7K/B; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Faxj7K/B" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b0c8362d93so13190535ad.3 for ; Fri, 27 Mar 2026 14:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774645478; x=1775250278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=Faxj7K/BMFQi9OF57Y9x2fedcTDa907an2IvkDswltm9JW/kKOx1uFdDSB7TjHqNmP D1PPgwH0s4Z2Tfzd6wZ3p3TDwQA/Nektq2i2onLtqpnerRew7d5h2wkSD5DOcz5Nc0Yw hOy5ldhFcVdOXYj+JMB+IiHfAuRuhhHb295Uh64PK6ia97b2aycr0TytY6jkUPSR5454 RjPgUhOYhoAvAnnxNn7EkLvHZlHZ6KsO/52FzPc2/pi/4jb8cCC4PZOspYbgLfG/c/Ca DT98dBuaBiz2HA6r1IIOG+1mbhT3ACeGFAASzax8XrvdVjEL8NZLA5qKzk3R6wv1ikiw kb1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774645478; x=1775250278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=XSzhZrRSJMFXhlWc0aKP7mQgXjOz/H5VbKoVW9CN767r5vzKBMmV2p9+bvFpD9aLTh VeqhqOnFj6j/Xo0iZKdHRyddnyxb7vqOHNpSGTi93l2qApEcUXtQ+dhqYRILMojeUX+Y E2tVUcZ65ys+T/BTqk4BsfiIitMCNJqr/kze7/Tad2xM2Ympoqyk3VGUjN/wAl+H/Agu SkmPfVkbOy4Q1i0VQX/qXa4rnioU0shMsGy72HCUd0UmxEEhnuzwFN9KksHY4iuinhBR fSl0TNQKwC+HXEgoQ1zw1Dij6qywQqXyIz7Q1eWmeFFvKgCFqnJfIAaHBnRFWusDzx8c aDTA== X-Forwarded-Encrypted: i=1; AJvYcCVeW6mN47mQ9vBUzhPbAPdlcPIAgAeKMrW6UFaohSKZ1V12ZB0sYTRKC0XYMemjRUbq0AXA0Lx0UK8cQYw=@vger.kernel.org X-Gm-Message-State: AOJu0YyMchIDpyYFpVoVghJqqyhkty5A1h9e55mHPWT8CiGGMb3IURUD GcmIEg4IBfO35YLE0xMNLivLZk8nxuvW/AbZzUYGae8/JxcK391w+x7P X-Gm-Gg: ATEYQzxHrD9QrYHCd21Aax7rleiVUEkbFkw8Jxa2TdruNB4SWQa2KdwwGVUCqK6ekOj 2pgl+v/1ECJtxCK1dFQ5hx6wKR5lU/G411feylSCGoyBZj4iDBd/tNYdH9olYNcWhV7wetTD2I8 ExrU0ofSqM+g3MGCf16p3CgkLFlXNiwXQmADIE8ediWEZwWb36IXd55+BIlw+x/saIx70Pl1Wo7 ObtzPq46yQgR+NzP/j6lCwRV0NGVFiUYcfZL8xL8QYof7NfAjwKlETvfdhmI08HbQjn+g5MQu54 1ifTYTLUHsIlq4Wd0OSebV371xNmwM1xzx88wJk8MIxpoMgQWlMi3x0vZWVDtHgLt9oOi/xudQK /nH8Ru8FZttz07ckwqOGnhK7y8bQLZKcfPuzGAMJ82LErXisJOavA4FIzDY6LuiLieqh5MyM4bx eK4+pLRg/xzRsHKVHxwz3lhEt+UGFnwmCXdyJ9pboJWg== X-Received: by 2002:a17:902:f54d:b0:2b0:5cb4:d894 with SMTP id d9443c01a7336-2b0cdc215ddmr39829125ad.13.1774645478266; Fri, 27 Mar 2026 14:04:38 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24250b15bsm2358125ad.0.2026.03.27.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:04:37 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v3 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Fri, 27 Mar 2026 17:04:08 -0400 Message-ID: <20260327210408.430908-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327210408.430908-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3