From nobody Thu Apr 2 15:36:26 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90235396B8D for ; Fri, 27 Mar 2026 21:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645468; cv=none; b=LLL4dclfun1iKcI73IEh8uIzV78H29frXLai+h64g74sl8ctupja11gwod/QP3ZUq8XXvA/L8LVEAHK2NMv9d9ygNWJyMjgZ2h2+0slqTEKnSzzk1yazbv/yl7etx9bqDb0NxSSYZosmMxViY7VVo029xaMfXFC+MJrok17IewM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645468; c=relaxed/simple; bh=hV0PSRnR/bl4CdLuH0CGuwoqFy9Ab3KJAJrnQZux0Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lbswyPkp75oqBEk5KuPl7+v88rHRYStjjnU5VkzAl3T5i7okpRr/ea1ssjXcMUij2mNxiqZVgrxFAjfahBtb+DyuTnbiSY43o3ORFzwm53aDcM1pjIoQTfpaUSu+YG77xDReh0RfVs6yYVZifHEHvqX8rsxZVJn+ufwz71Rt5fE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EMj8RxVB; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EMj8RxVB" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab077e3f32so11683755ad.3 for ; Fri, 27 Mar 2026 14:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774645467; x=1775250267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=EMj8RxVBqf/Go1u6blGshU+oF3b5xF+G5b6S3aZG6wegapRmGRDXF68RgbXnj3lrVQ OCvHllZENXBQpi6+OfDfOBw/ZiFWaaAO/jS7ZINy757h8uud4APPtp7+EcZ31U/kZe8j /ZdyrQXe+pfHwoZoveg+fUPRuEgGS8ETSTH3gaKM7oxVS8RetEzRzjnFErDx2wQ4d/Cc wjH1NMj1eBdDU3irT+Wa/mdl1fs5siNrBz1omJluFeiJ2s5Pkyp72DQggiOqqPF87L/E NaGx2+rbey+SMM5bsuUUGl1R4IbzqdKnCl0gXt9ZIpMMm5RxVhZvhdw892ShdiRhHNt+ 4AJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774645467; x=1775250267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=JINb3hp5h3dX03tIv2ak/SapV9YxhpzPHJ/o4I8dqAJfEpCLu6zZsFYsOtqG2+demg MwNuOypN0S7HbVh6Tj1xtSouJGXQ1W/JynhATVrwu2oYh4eTFFfOFg9xePMQArCVl2bN pkbG699Nss7RuspJSuaWHUMZwpLTCiCAYhnGxlUr3bxdMWnY9/XAhgSZ0MMgD0KWVfBm /L4L6ERqsTXKbVb/rvx9GKQoci2As5dvGMtJvU2Tzyb3okP4ebU6/48gyfp4tNdS3hNt tm5V8W0gbIjW0lvcxNzg8bc9mw4rXOKhdMtb922EHBcdArz40EeB1/coNeRg/0NQJXz/ t6xQ== X-Forwarded-Encrypted: i=1; AJvYcCXl3PMdPm59AsfI98hk+I7hiCgcLBMMdkpoDFbZLtvPDPf6mZi/XpKPDLPVK9C/M3qNU3F0hSYmc12ic1s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7xhEmLNeM+mZVWB1lbKFkA77u1RXht7N45GPgk95jAPJGu9gc yls+GEX39eLpuNgfW8O0LCaHhzUcKzNJXNRJaaCQ1vXwW9+rlHAPbD7m X-Gm-Gg: ATEYQzzkH5SykpBhC6zpo8rc991f7AonhQ228U9JDTjMLilfPQZvPKIIVcXxbSCyLva xyK8A3SAZ9TiZtMkz0+0sydEfHgfeJUZzHtXGThu+e6F13g61O7X5fD0O9UBvwpStaxJUQlSYQe xCZMfnJAvf+Go7q4wVmNmREWxUzJC3CAztAoU1hgdXS9yEuicqkexLlG4yAxsZV37z7JK3Shq8r VvJtWfWZSjd4TCakQ5uF6DIZDG/q1jw659rcGUqF/cSgIlg2oN7tqcvpvE6INXKX7mfd2/bXtI2 37RMIaaWK6vchWAqojMcWjHbvLSOnmqYj19Men8YnRVHwycqD63phMFUjFa0/tbfZO0o3P3/gKm 5NSs9mxsj0GHtBWbw9W+KONiXd+IYYDz3kiC8vaSXGpRcWg1PnaeqhnqvgMwZJtSj9AXurCG+mX U7NxmW4FxM+2aF7m3o//76GD+pu1OakJVCCTe2qkeWxA== X-Received: by 2002:a17:902:e889:b0:2b0:7d6f:4627 with SMTP id d9443c01a7336-2b0cdcd224dmr43059925ad.37.1774645466690; Fri, 27 Mar 2026 14:04:26 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24250b15bsm2358125ad.0.2026.03.27.14.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:04:26 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v3 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 17:04:06 -0400 Message-ID: <20260327210408.430908-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327210408.430908-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..fce726a9c8c0 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3