From nobody Thu Apr 2 14:08:20 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90235396B8D for ; Fri, 27 Mar 2026 21:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645468; cv=none; b=LLL4dclfun1iKcI73IEh8uIzV78H29frXLai+h64g74sl8ctupja11gwod/QP3ZUq8XXvA/L8LVEAHK2NMv9d9ygNWJyMjgZ2h2+0slqTEKnSzzk1yazbv/yl7etx9bqDb0NxSSYZosmMxViY7VVo029xaMfXFC+MJrok17IewM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645468; c=relaxed/simple; bh=hV0PSRnR/bl4CdLuH0CGuwoqFy9Ab3KJAJrnQZux0Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lbswyPkp75oqBEk5KuPl7+v88rHRYStjjnU5VkzAl3T5i7okpRr/ea1ssjXcMUij2mNxiqZVgrxFAjfahBtb+DyuTnbiSY43o3ORFzwm53aDcM1pjIoQTfpaUSu+YG77xDReh0RfVs6yYVZifHEHvqX8rsxZVJn+ufwz71Rt5fE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EMj8RxVB; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EMj8RxVB" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab077e3f32so11683755ad.3 for ; Fri, 27 Mar 2026 14:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774645467; x=1775250267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=EMj8RxVBqf/Go1u6blGshU+oF3b5xF+G5b6S3aZG6wegapRmGRDXF68RgbXnj3lrVQ OCvHllZENXBQpi6+OfDfOBw/ZiFWaaAO/jS7ZINy757h8uud4APPtp7+EcZ31U/kZe8j /ZdyrQXe+pfHwoZoveg+fUPRuEgGS8ETSTH3gaKM7oxVS8RetEzRzjnFErDx2wQ4d/Cc wjH1NMj1eBdDU3irT+Wa/mdl1fs5siNrBz1omJluFeiJ2s5Pkyp72DQggiOqqPF87L/E NaGx2+rbey+SMM5bsuUUGl1R4IbzqdKnCl0gXt9ZIpMMm5RxVhZvhdw892ShdiRhHNt+ 4AJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774645467; x=1775250267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=JINb3hp5h3dX03tIv2ak/SapV9YxhpzPHJ/o4I8dqAJfEpCLu6zZsFYsOtqG2+demg MwNuOypN0S7HbVh6Tj1xtSouJGXQ1W/JynhATVrwu2oYh4eTFFfOFg9xePMQArCVl2bN pkbG699Nss7RuspJSuaWHUMZwpLTCiCAYhnGxlUr3bxdMWnY9/XAhgSZ0MMgD0KWVfBm /L4L6ERqsTXKbVb/rvx9GKQoci2As5dvGMtJvU2Tzyb3okP4ebU6/48gyfp4tNdS3hNt tm5V8W0gbIjW0lvcxNzg8bc9mw4rXOKhdMtb922EHBcdArz40EeB1/coNeRg/0NQJXz/ t6xQ== X-Forwarded-Encrypted: i=1; AJvYcCXl3PMdPm59AsfI98hk+I7hiCgcLBMMdkpoDFbZLtvPDPf6mZi/XpKPDLPVK9C/M3qNU3F0hSYmc12ic1s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7xhEmLNeM+mZVWB1lbKFkA77u1RXht7N45GPgk95jAPJGu9gc yls+GEX39eLpuNgfW8O0LCaHhzUcKzNJXNRJaaCQ1vXwW9+rlHAPbD7m X-Gm-Gg: ATEYQzzkH5SykpBhC6zpo8rc991f7AonhQ228U9JDTjMLilfPQZvPKIIVcXxbSCyLva xyK8A3SAZ9TiZtMkz0+0sydEfHgfeJUZzHtXGThu+e6F13g61O7X5fD0O9UBvwpStaxJUQlSYQe xCZMfnJAvf+Go7q4wVmNmREWxUzJC3CAztAoU1hgdXS9yEuicqkexLlG4yAxsZV37z7JK3Shq8r VvJtWfWZSjd4TCakQ5uF6DIZDG/q1jw659rcGUqF/cSgIlg2oN7tqcvpvE6INXKX7mfd2/bXtI2 37RMIaaWK6vchWAqojMcWjHbvLSOnmqYj19Men8YnRVHwycqD63phMFUjFa0/tbfZO0o3P3/gKm 5NSs9mxsj0GHtBWbw9W+KONiXd+IYYDz3kiC8vaSXGpRcWg1PnaeqhnqvgMwZJtSj9AXurCG+mX U7NxmW4FxM+2aF7m3o//76GD+pu1OakJVCCTe2qkeWxA== X-Received: by 2002:a17:902:e889:b0:2b0:7d6f:4627 with SMTP id d9443c01a7336-2b0cdcd224dmr43059925ad.37.1774645466690; Fri, 27 Mar 2026 14:04:26 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24250b15bsm2358125ad.0.2026.03.27.14.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:04:26 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v3 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 17:04:06 -0400 Message-ID: <20260327210408.430908-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327210408.430908-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..fce726a9c8c0 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 14:08:20 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB4036B04B for ; Fri, 27 Mar 2026 21:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645474; cv=none; b=ZHSZZRJDs57GGk6lQzu+r1mHGxXWzzcbq8LbxXAWxEbXVw6VsYNHUWPMntWKf+Lb6nqXCwyGdk3l+vkDBQ1TeiWRVHwLL82dRhj5UCLG61d54ah8R/gk4RGvXkGXZ++nKught7T3NfzFRvdmOyMcbL2vK9IhHXb11sBoQXBp2cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645474; c=relaxed/simple; bh=f+rrkJ/eFGfAceLcutWeIAOjkU73nC2yxLnBeMJdOaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oPaXFva3HXOi7p3ulUtExz/Dq4h5kzSGWYOa/FHZm2slMAP9seALOGq2S8mhQGyeabcZf5LFtNNCLrjNv1a5yf/hCbl+czPO4u0aXCYyODrYI9Ul+5l0lvKsyruYltBSCKU2OiyGBEdpJEo7f9bJQvyd2kiy7WxPujeX37AMOt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RrSFr/eW; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RrSFr/eW" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35a04d6aeb0so2285357a91.0 for ; Fri, 27 Mar 2026 14:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774645472; x=1775250272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=RrSFr/eWNcU+j+i00x/ExWB5zOFYrGlf3sIhuCmRa9V/GtJajuMQVN4/MCH8kK7m9L MA9mTmRD8X0miQyeoDaI/lAnBiEe3ujV1LOPle4+PJLwWXjUAyGTpXw0DF6Ow/NLArt8 z7Cj1yuWmG6Mx/3V8JaS9Hxmeiy9roso8VNhLHpPP0B4lKFG3T/WpUFXdFf8M7MI0f6e PKJnvvqF9AAREuT1P4CYmcHejelT3eUm0U5IwKI5i9l8WkLdHfcDP16Ufo6yvdPN1Op3 chA/ZVqVE8LKJjRnprIU1pG1jJHZZYluW6df1UazRePpt+mfr5zbfHus7ZZxB9rC//eT UOTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774645472; x=1775250272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6H1z6H4hjpkn9YitKWLYuZELXb+HUGMdhzSORhOSFC0=; b=qkXLytXbOxlJam3Mvu7rxXpJ1FJUBG/84Q7zuQo32AEfgJ8+G4qWRZgs8G2hApLSnB hT7xt6g3sYm6xGyfEME2vojBSMkRHO0fV75pYu7m/DoD9Jc9WwJSF+PzcYnK0NfBoPFf /OEVgR2ApxmzVK2ikrhAwBtQIbREtA6Zt3pFwGYhpD6LbnaP6e3V///22eLevmywSsQJ /20nQ8c0GydLm3ug3hZTpe43+qrPiTIrPcKtTbqWkAShRpZJvN4631YQEqYSK4eRJzpH vgMO0pekDIXJh+c8/wcwOhXCSYBA/7f1tqsw8cs30K8YNcOb7JkYIInlonqf24aOXygm cgFA== X-Forwarded-Encrypted: i=1; AJvYcCV/SpE9Me4EFmRfJvuejgWZdJdt5jWhDlMo5+1BbyEiqrhj6A/so0M5XD2jo+CwykoGJPjyNpWpDNGcRdY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5RkhuS6qDTCyamrxyAfhRaNqsMeztBdsf2UVtxXNuWq9IAqUq Hr5YQjDCqf6jTsxrYNwGLGVDtwmnVZ/Lszv9Ueke8gNoz+kx/SWmk94i X-Gm-Gg: ATEYQzx42IsU/o+c/IU7tZAWNM7yl7wkQTyRtYwdyIpASedm/emF+Bw6VlCDymnLhOR MVeXOgaZj76FJdQQfqXRz0EeeRmghGsltU9RHECkDmCNxGLhnlWrMTq73ZkFB90rYUUNJaP5kuw bc4Rh7sNCTKueRx5SectJWTUKRgNTh+U3BWj582MzWAic0+D9aNuR5FUxAay8ibNyk+ct0DkzPU DcS3gG7etELfUiGxTeMrwZ26WKcKCqUJTRn/xKIZaMKQpYRm4WQaiDTCcdeT3c4Z3qMGjPuk9tp 6Rjf7JGKssb+9KZpO3QmpUJ8bzfLCr8FAdR8r31SkjEANy6j1Kpg+ar9ZmCIO3t71AXDYGMll70 98urKdRd80Gl42aYtty9xosmprVXetzhTrtePLhAZCYyEXwvw2SBdxfJ35h10TPBgU8wQUeMZd9 50ZkPwOnNQwvq9y/mlzfq9fJQeuqZi2bptlSSxCHPzEw== X-Received: by 2002:a17:902:dac7:b0:2ae:5464:7a4b with SMTP id d9443c01a7336-2b0cdc117a3mr44407995ad.14.1774645472261; Fri, 27 Mar 2026 14:04:32 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24250b15bsm2358125ad.0.2026.03.27.14.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:04:31 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v3 2/3] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 17:04:07 -0400 Message-ID: <20260327210408.430908-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327210408.430908-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..65944eb4be16 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); @@ -224,6 +224,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 14:08:20 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB8B39B95F for ; Fri, 27 Mar 2026 21:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645480; cv=none; b=WDoqh5jZT1PIWwFVYTKC/xl3lyfwy5BkO0dMuQiIevBnbkBhAIumvKU0W2cPdSmLCVihAsQGGt4GrDLo3s6JZrm37wyhK50+xMUlrJjEOktaarjgaclg/y8FL6VHqhYiM3kA5j/e/SUB54o9xU0/+0fP/ujCQkaQhXpckjbRAtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774645480; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hlqoHuWvq+FiT86FUAxBGU2kWSs0Uf66+zDhSQ6SYxjJ4ngYCUsL5RM6ER9eC6Kbe6lZs6PwFRZHvoCQL9h61BeT+cuHPjkJ4Az5cEgG0wiqGyYpJUT5IQPFYN7LYY83dLtAbx4IOVABYo8dfNxic4xeOuY3n8xFpW7obRvUmtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Faxj7K/B; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Faxj7K/B" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b0c8362d93so13190535ad.3 for ; Fri, 27 Mar 2026 14:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774645478; x=1775250278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=Faxj7K/BMFQi9OF57Y9x2fedcTDa907an2IvkDswltm9JW/kKOx1uFdDSB7TjHqNmP D1PPgwH0s4Z2Tfzd6wZ3p3TDwQA/Nektq2i2onLtqpnerRew7d5h2wkSD5DOcz5Nc0Yw hOy5ldhFcVdOXYj+JMB+IiHfAuRuhhHb295Uh64PK6ia97b2aycr0TytY6jkUPSR5454 RjPgUhOYhoAvAnnxNn7EkLvHZlHZ6KsO/52FzPc2/pi/4jb8cCC4PZOspYbgLfG/c/Ca DT98dBuaBiz2HA6r1IIOG+1mbhT3ACeGFAASzax8XrvdVjEL8NZLA5qKzk3R6wv1ikiw kb1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774645478; x=1775250278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=XSzhZrRSJMFXhlWc0aKP7mQgXjOz/H5VbKoVW9CN767r5vzKBMmV2p9+bvFpD9aLTh VeqhqOnFj6j/Xo0iZKdHRyddnyxb7vqOHNpSGTi93l2qApEcUXtQ+dhqYRILMojeUX+Y E2tVUcZ65ys+T/BTqk4BsfiIitMCNJqr/kze7/Tad2xM2Ympoqyk3VGUjN/wAl+H/Agu SkmPfVkbOy4Q1i0VQX/qXa4rnioU0shMsGy72HCUd0UmxEEhnuzwFN9KksHY4iuinhBR fSl0TNQKwC+HXEgoQ1zw1Dij6qywQqXyIz7Q1eWmeFFvKgCFqnJfIAaHBnRFWusDzx8c aDTA== X-Forwarded-Encrypted: i=1; AJvYcCVeW6mN47mQ9vBUzhPbAPdlcPIAgAeKMrW6UFaohSKZ1V12ZB0sYTRKC0XYMemjRUbq0AXA0Lx0UK8cQYw=@vger.kernel.org X-Gm-Message-State: AOJu0YyMchIDpyYFpVoVghJqqyhkty5A1h9e55mHPWT8CiGGMb3IURUD GcmIEg4IBfO35YLE0xMNLivLZk8nxuvW/AbZzUYGae8/JxcK391w+x7P X-Gm-Gg: ATEYQzxHrD9QrYHCd21Aax7rleiVUEkbFkw8Jxa2TdruNB4SWQa2KdwwGVUCqK6ekOj 2pgl+v/1ECJtxCK1dFQ5hx6wKR5lU/G411feylSCGoyBZj4iDBd/tNYdH9olYNcWhV7wetTD2I8 ExrU0ofSqM+g3MGCf16p3CgkLFlXNiwXQmADIE8ediWEZwWb36IXd55+BIlw+x/saIx70Pl1Wo7 ObtzPq46yQgR+NzP/j6lCwRV0NGVFiUYcfZL8xL8QYof7NfAjwKlETvfdhmI08HbQjn+g5MQu54 1ifTYTLUHsIlq4Wd0OSebV371xNmwM1xzx88wJk8MIxpoMgQWlMi3x0vZWVDtHgLt9oOi/xudQK /nH8Ru8FZttz07ckwqOGnhK7y8bQLZKcfPuzGAMJ82LErXisJOavA4FIzDY6LuiLieqh5MyM4bx eK4+pLRg/xzRsHKVHxwz3lhEt+UGFnwmCXdyJ9pboJWg== X-Received: by 2002:a17:902:f54d:b0:2b0:5cb4:d894 with SMTP id d9443c01a7336-2b0cdc215ddmr39829125ad.13.1774645478266; Fri, 27 Mar 2026 14:04:38 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24250b15bsm2358125ad.0.2026.03.27.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 14:04:37 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v3 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Fri, 27 Mar 2026 17:04:08 -0400 Message-ID: <20260327210408.430908-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327210408.430908-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3