From nobody Thu Apr 2 14:09:57 2026 Received: from sender4-of-o54.zoho.com (sender4-of-o54.zoho.com [136.143.188.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79525372EDF for ; Fri, 27 Mar 2026 20:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774643832; cv=pass; b=svonxUYFIUKSHFTowgSUwNS2P+9CRCbs0N/YvZhImM4Wqxhltscb/fiO7jeAbsxDqNo7DLPxyC/Nta83OM+kKROxwIctMQf7W+KzJ5sZrtFqCjf9yoDs957EbMwunJqnjAfDCNLP3cQ+K6/bvABqaN2EHW9fEun2Z3wfwhxTnsQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774643832; c=relaxed/simple; bh=WP2Z/8rOiq4D0PTpLTEzWPJTts1QUENUeFvmm+Ik7vo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZP3MmGZSct+I629eKiv8l37oorcRXXu2RPKK4aUv5FIdKEpDgGu+KGtB93huNPIfsRv53o0h8/BG6QAS22tDAXFHU86VbfVBl97AGnDjHd4hxXOgBh52YhFbUTiaClpLLhyImc9MDhup9eqRHQLdshdJyMT9syFtpnz/qJGO3hY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cardinalsystem.net; spf=pass smtp.mailfrom=cardinalsystem.net; dkim=pass (1024-bit key) header.d=cardinalsystem.net header.i=david@cardinalsystem.net header.b=BEM5eRtj; arc=pass smtp.client-ip=136.143.188.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cardinalsystem.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cardinalsystem.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cardinalsystem.net header.i=david@cardinalsystem.net header.b="BEM5eRtj" ARC-Seal: i=1; a=rsa-sha256; t=1774643816; cv=none; d=zohomail.com; s=zohoarc; b=Nw6sMvev+VM33/9trYQZG3sXONxfP25iLOKpSY5a0Mxc43GHqmFnTDLSNXwx8FmNAaNfOXA90y+Eu8Ys4MeKFLNUN35gmnmqVorGeq26snrtH32491N06V2ffFH6kbRXxl170CsFt/QTe1FT07O5Ms5Lx3/Lu/+PhJl8K1kglWE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774643816; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=7U0+DZVGCU8tY2Z6/TQTrDddnnmIFFua49CNx7zBDhA=; b=b/4WNL/eJxVK5quOtcgN4WyDFvWEETioYnY2tAxcEYSXCnlTReql662H9d3e12y69lzVHnXAOvi4QXutXVVtVibquWsnp2ZMGMb13QVqzMj7X5FbbvH4t/EVDK2D2pHyIwSmx+DVXtQxvh2ODga+nStrcv8aqnRAEhP1nzH/m1g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=cardinalsystem.net; spf=pass smtp.mailfrom=david@cardinalsystem.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1774643816; s=david; d=cardinalsystem.net; i=david@cardinalsystem.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=7U0+DZVGCU8tY2Z6/TQTrDddnnmIFFua49CNx7zBDhA=; b=BEM5eRtjuaZm3To/8JSlNmqD6qZtUHwwh0fHCbJHhAmYO6wGXRcf/06TG7sq2DNy 0XNzBg3yH1UQ5iw2taYBTKOAGepMyRnqmPMKx63jJ8LAPLooY1JT2fUajD/O/7gIYcj 2LW5/9JWiHtGMTDWX1oX8ifhsMYIE528xHZsHa4M= Received: by mx.zohomail.com with SMTPS id 1774643814333757.2610045670604; Fri, 27 Mar 2026 13:36:54 -0700 (PDT) From: david@cardinalsystem.net To: Greg Kroah-Hartman Cc: Michael Straube , Andy Shevchenko , Ethan Tidmore , Dan Carpenter , David Holland , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: rename variables to snake_case Date: Fri, 27 Mar 2026 16:36:36 -0400 Message-ID: <20260327203636.24891-1-david@cardinalsystem.net> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: David Holland The Linux kernel coding style guidelines prohibit the use of CamelCase variable names. All variables should be snakecase. Rename the 'ChipVersion' parameter to 'chip_version' and the 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to the standard snakecase naming convention. Signed-off-by: David Holland --- Hey everyone, This is my first attempt at submitting a patch into the Linux kernel. I alw= ays wanted to try to get my own patch submitted into the kernel so I was sc= rolling through the codebase and found some incorrect naming styles. I corr= ected the variables name that were using camelCase to use the traditional s= nakecase. Thanks for reviewing, David drivers/staging/rtl8723bs/hal/hal_com.c | 38 ++++++++++++------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 31b3e880ae6a..4bee338073c4 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -31,44 +31,44 @@ void rtw_hal_data_deinit(struct adapter *padapter) } =20 =20 -void dump_chip_info(struct hal_version ChipVersion) +void dump_chip_info(struct hal_version chip_version) { char buf[128]; size_t cnt =3D 0; =20 cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "Chip Version Info: CHIP= _8723B_%s_", - IS_NORMAL_CHIP(ChipVersion) ? "Normal_Chip" : "Test_Chip"); + IS_NORMAL_CHIP(chip_version) ? "Normal_Chip" : "Test_Chip"); =20 - if (IS_CHIP_VENDOR_TSMC(ChipVersion)) + if (IS_CHIP_VENDOR_TSMC(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "TSMC_"); - else if (IS_CHIP_VENDOR_UMC(ChipVersion)) + else if (IS_CHIP_VENDOR_UMC(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "UMC_"); - else if (IS_CHIP_VENDOR_SMIC(ChipVersion)) + else if (IS_CHIP_VENDOR_SMIC(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "SMIC_"); =20 - if (IS_A_CUT(ChipVersion)) + if (IS_A_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "A_CUT_"); - else if (IS_B_CUT(ChipVersion)) + else if (IS_B_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "B_CUT_"); - else if (IS_C_CUT(ChipVersion)) + else if (IS_C_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "C_CUT_"); - else if (IS_D_CUT(ChipVersion)) + else if (IS_D_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "D_CUT_"); - else if (IS_E_CUT(ChipVersion)) + else if (IS_E_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "E_CUT_"); - else if (IS_I_CUT(ChipVersion)) + else if (IS_I_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "I_CUT_"); - else if (IS_J_CUT(ChipVersion)) + else if (IS_J_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "J_CUT_"); - else if (IS_K_CUT(ChipVersion)) + else if (IS_K_CUT(chip_version)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "K_CUT_"); else cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, - "UNKNOWN_CUT(%d)_", ChipVersion.CUTVersion); + "UNKNOWN_CUT(%d)_", chip_version.CUTVersion); =20 cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "1T1R_"); =20 - cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVers= ion.ROMVer); + cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", chip_ver= sion.ROMVer); } =20 =20 @@ -86,7 +86,7 @@ void dump_chip_info(struct hal_version ChipVersion) * BIT[6:0] Channel Plan *sw_channel_plan channel plan from SW (registry/module param) *def_channel_plan channel plan used when HW/SW both invalid - *AutoLoadFail efuse autoload fail or not + *auto_load_fail efuse autoload fail or not * * Return: *Final channel plan decision @@ -97,7 +97,7 @@ u8 hal_com_config_channel_plan( u8 hw_channel_plan, u8 sw_channel_plan, u8 def_channel_plan, - bool AutoLoadFail + bool auto_load_fail ) { struct hal_com_data *pHalData; @@ -108,9 +108,9 @@ u8 hal_com_config_channel_plan( chnlPlan =3D def_channel_plan; =20 if (0xFF =3D=3D hw_channel_plan) - AutoLoadFail =3D true; + auto_load_fail =3D true; =20 - if (!AutoLoadFail) { + if (!auto_load_fail) { u8 hw_chnlPlan; =20 hw_chnlPlan =3D hw_channel_plan & (~EEPROM_CHANNEL_PLAN_BY_HW_MASK); --=20 2.53.0 [EXTERNAL EMAIL]