From nobody Thu Apr 2 15:36:27 2026 Received: from mail-ot1-f100.google.com (mail-ot1-f100.google.com [209.85.210.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0628239D6DF for ; Fri, 27 Mar 2026 20:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642526; cv=none; b=pJiILYidi6VAfztZBtMOtcna5wun0R0gmfpw2mqzyEtLJA48quWXsdKrPuf/vF/vX6YIz6ntiGOuKgVTV5P2R5V63GFiLEGLniEawtLfDHX5mTCQlbqZJw1ZX8fsKHQvOiEILlBzM/eflCecj6hsmkb1QcPdN40qBUZ0/9kAXCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642526; c=relaxed/simple; bh=RzaqFNKdVRTX/6fbKxbgoh8rdmg6EYIZDsbIZdlQBIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HnnkB9g3ZwblJvXxEWx66SFqzt0noK/t4dsAbvnQi8eM659ldtqhiWg4I1NjL7BRZVXKGcyLDx8oe/CS9TC7FYxlcUcjKQKbHhctLF1tSeUdHUFtdGkwfkFlz9cnZEiNN8KzGpU+nrCyryEJza5owwSmyxFNG7JdAG4x/W4hndA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=QyoZZODq; arc=none smtp.client-ip=209.85.210.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="QyoZZODq" Received: by mail-ot1-f100.google.com with SMTP id 46e09a7af769-7d7f592b8beso2062743a34.1 for ; Fri, 27 Mar 2026 13:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774642524; x=1775247324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AcrU2S3pwS1dF0Y8GuCFOSv27TX89aMT8zCjbmcIpD8=; b=p8NiYOBdyqTNFRRTphUcBUnNOtAzgcdLsrigECFRnk3ab8vKyE8m3v6MrfIgIp5zz+ 7szXsG/PD/jY7r7DyWgo6Ba61ujFRS80XtWjLmqvkw8IQu39aCqjNzP0QyUvTFnNbNbc Gn695yjCFVLvMNfz2YiamIBJDF7UNtT9W6ZHZWdXCUYOtliyuRInDuNYUG4lOhTb8K+k UGMrrUo9piqjfAdQuCtwSwHfzHhNcocFai04/eYP+LMYPGLAJf7DGS6Eq14h1YOggFlY l5dmV+n1oSLY4NZUG1KZ1/DwggQkH4p9/fnlOClZP5AwqXwv5G6adTcDH9Oa/EqGRXTB QGiA== X-Forwarded-Encrypted: i=1; AJvYcCXLLX2R0SqAV1dYndAu+gTUY6avBCe59ziAy2KauLKqTzT6iM9o9x8VyEQJR6Xz2hnXIbz5J8KlCVT1Fhc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1XmufwdQBHiskvhxwaJ8JdjonN8yDPG2G6L7fm5VaHFwjpS8s TO5ItmKtt852Dd27GmW47c/wKIJBhvDKI4/JfuFpnFnIQi6K6eZVtYza7b4WN4UFY06cyfSzZad /og4R9QBxTf1VrJIScdOWi8W6eUDjEh5yCOG+swKctCKZQ8YHtB0bBBqDWD1jlMGpg8kFHrOIMY eY+ysXiSY+A6qbSir6qKi94sET46vIqGeHcwZN6c+Hb2AGqXdF2a7pDsZpzzRgqvtqWM4OvTToh mtdNpYVgjxADA4iKzFTobDf151a X-Gm-Gg: ATEYQzwSQg3jkQvml4G1XNGEZ9KHub5TSYXiSeBxraiCkuZ5760DRFfVCuUaTRSyYF7 /P1yUuNz6RRcXucCJiGgu+vAmk21r/f/lcdgtTlWsH2D1SPPGSsL3VMSOz4P2G+LcxmZl0Ec9lY VaDitAvSM0AOdfdVanbFNy1ypCvnlSFO5JgYogs1eJxw+EL0SfC7K1aGuZ2+/U+1nXIWO2F3/4Y buXixCRoIfdMJsobRQhSCXMEyv65F5/2UsehP4Wy4HHeG0HTqwCUJc4deaOeViYCC0uiXqJmEDI 4U9qtvTZRgTzYQWlIv79Tlj5yEemTTDUJW+0gqY4EyGEk0wY3M08jVy50SS0N5BQX8zAUHU2GHR CD8fnBKTp2Ybbi51L5ZTipR2M43Bmo+VVgbRUOYtvFL9S45Sp7T0IzrduyyKNLPwBMO+wy7K593 IXHQKPaRtqsUm5DdLb6oITH9H1/8m1xDv2YB0ZeJWCEhV27N/6F4eh8EmJIYPXH34= X-Received: by 2002:a05:6820:308c:b0:67e:692:e71 with SMTP id 006d021491bc7-67e18705583mr1965234eaf.47.1774642523779; Fri, 27 Mar 2026 13:15:23 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-67e230f2b1esm30823eaf.4.2026.03.27.13.15.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2026 13:15:23 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-79bcff6d0easo31850627b3.0 for ; Fri, 27 Mar 2026 13:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774642523; x=1775247323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AcrU2S3pwS1dF0Y8GuCFOSv27TX89aMT8zCjbmcIpD8=; b=QyoZZODqZ1+se4BI/1+5vRzmq6xX6qO8t+Wvzgdyx7NxptBDRv0sCnfDqgZB3dsDQH XPzdIWdzs4cXLSCuLS2e46KAvLiSs06hJpbBOzG9AQ2V1AGMg0CC07xXMOpxLIPZtZTj /LyozzkdxoJaknVW7lxiAhnrZuPBAajdr8Mos= X-Forwarded-Encrypted: i=1; AJvYcCWkdVW5wXl0bo64y+SBREHBqJxcqkmfFAfuem3PoLR23E8qqzMVn8HHlpKYANufoemS4eyc54+FoimEFnQ=@vger.kernel.org X-Received: by 2002:a05:690c:c50f:b0:798:2629:85d7 with SMTP id 00721157ae682-79bddd7743emr36729087b3.9.1774642522623; Fri, 27 Mar 2026 13:15:22 -0700 (PDT) X-Received: by 2002:a05:690c:c50f:b0:798:2629:85d7 with SMTP id 00721157ae682-79bddd7743emr36728627b3.9.1774642521952; Fri, 27 Mar 2026 13:15:21 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79cb9a8f324sm119057b3.28.2026.03.27.13.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 13:15:21 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v10 08/10] bng_en: implement ndo_get_stats64 Date: Sat, 28 Mar 2026 01:43:41 +0530 Message-ID: <20260327201343.16146-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327201343.16146-1-bhargava.marreddy@broadcom.com> References: <20260327201343.16146-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 103 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 3 + 2 files changed, 106 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 3b9bcfbe6fdc..b5cc96d1ee0e 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2872,6 +2872,7 @@ static int bnge_open_core(struct bnge_net *bn) } =20 set_bit(BNGE_STATE_OPEN, &bd->state); + set_bit(BNGE_STATE_STATS_ENABLE, &bn->state); =20 bnge_enable_int(bn); =20 @@ -2910,6 +2911,99 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_STATS_ENABLE, &bn->state)) { + rcu_read_unlock(); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + u64 *rx =3D bn->port_stats.sw_stats; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2921,6 +3015,14 @@ static void bnge_close_core(struct bnge_net *bn) timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) + bnge_get_ring_stats(bd, &bn->net_stats_prev); + + clear_bit(BNGE_STATE_STATS_ENABLE, &bn->state); + synchronize_rcu(); + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2943,6 +3045,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 548c5a77e76a..c972567882bf 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -262,6 +262,7 @@ struct bnge_stats_mem { =20 enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_STATS_ENABLE, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -353,6 +354,8 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; + struct bnge_stats_mem port_stats; struct bnge_stats_mem rx_port_stats_ext; struct bnge_stats_mem tx_port_stats_ext; --=20 2.47.3