From nobody Thu Apr 2 15:41:43 2026 Received: from mail-ua1-f98.google.com (mail-ua1-f98.google.com [209.85.222.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A043B8BC8 for ; Fri, 27 Mar 2026 20:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642485; cv=none; b=fdlpu4C/GUqxeaYi7GJpME7vFNc3JBmRJEyt5O5zdboFdqZ7D2fc6HBukiDCMJbv0OX3i3vScUjRTQv5cdV5QuBGyVLTDrKu/RMiV5dT5F01u3NB1iapNtxPRLE4WrGI0gEII++dIwsuqMWxS7mn6gKVkd7ODj2rXaN88oa7s54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642485; c=relaxed/simple; bh=9BEpjmp9nOY5DRU+Jtpsc0UKBcTVnqB8P6BDC8FesrY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=acP9HjpJgyr7knkeixtcPOyYUU6sjg4AOUZf5IFMxIQm3pvbw9Y6QUlyGMKVP73mqoxDf2dwVLtJfucGH9S0DrKWEq9FWE3ZFP6Ahk7N9kt2kKIccAv1cAUgeP4JYBUgqjCX/+E3bvzqpV9o39ahyC5BAAysjtPYooc5s0Eiu7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=W5InJlgb; arc=none smtp.client-ip=209.85.222.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="W5InJlgb" Received: by mail-ua1-f98.google.com with SMTP id a1e0cc1a2514c-94b07fddecbso1527607241.1 for ; Fri, 27 Mar 2026 13:14:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774642483; x=1775247283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z3dsqbgzmgrM2syDH55uS3n72DeAQsAumcT48/HQSyA=; b=f3b8Nc//l2Fpm8mfm+AeaxYhE/bSk/YGdckZoxwwjrqWGlgrj7InWnw3x4bC6fWYt/ y4YMiJfTm9X2w7dQxciMR+awQJCCbQCWTyK4UZXVTQUxdFHNcoixu+cQmFyhwEecQIUp DPrYBNe/686lYvQa6lM/WqYVhhxYBTaqccxN04HFtm3KKCeGwlXTkH3azEsCrSlQpFkI 3kH2Cfr7caK5KmhDrTxM+jLRG/5ZXHQeT4VP6vZScP42ryFBL3dk/OGh2jvozb5zFoNc ZeQ/gLFrXrWJI/4tip6VJ0rRr8v5Fj3l0iKEO201JoSLeWqNPO3Su5JAdXKiT0KZH6AE 4Cew== X-Forwarded-Encrypted: i=1; AJvYcCV0qXwqbNPrTQYCxsBtZR5sgy/xHk733FymRIyqByThc6LZeCb/ERZKD809gfSMj1uS1C0NMC9YpBFRQOI=@vger.kernel.org X-Gm-Message-State: AOJu0YzlCfCQ9zVU/ImWeIR7dPkrompfHApFZKy0qsY1jk3/ykIpAPqV GcHMOOb0nU6QIXmas+Xpp2ELolv+qRLKXf/O0doXjI31jAhCnVi3U8v3Mie6l0ly1Tplkk3veyt bt7Ml/iKGCFuLWL2kd/6mPufZNwyAFkgkIQ4pqxeTB5LsKdQ8FGie9MiDyUTAmPAdsY95nowRAN vBJdTQKung30dDEY8WE3AnQtTdpWzlfF96kD8LAkBUdFurmAfR6Pc2yV1Fa+BC26vC6H5xOKNnk yyrzPbBfScBo1d8NGiZ/Ap50kEm X-Gm-Gg: ATEYQzyoO58xMcZwy3QNcR5vJrQZdKV0GONINOddUjYP4SzqDo/0HB1wjvU5FXyff2N voZbYfsk0mcTVd3S6502Pd+A44VJah1F0Jys5AONPb2sCKtU+C+CpupDXeuguJucafArf4Yk/7D v040Mv1eJ+kRlMwJ/EygrjxabeTSmIiX2Nb7aX6SRIj7Z6ORstvvD+HMydRF8QNXJIa/RdXfKdb SGmxD9rPmcFzch3BOn8+zfrqvZH3vV1pb/NX09T5P6ktXFlq53CblRoPs+2a1N9UgJipyGSA5cV 8zcWVgjtn2Adl9u2rJv4voF3aI/5teNxOD9DmAmOY1CaZKgnqRic+0TC8ZBrTCPEBcPW1vICQfq wtIA7fp6oLXPjL2ipVuQ20yikpqcXrQMmPhMUOUm1qFDgNP942/qaLuVOUKD1gOU1vp2bGz4e7L BIsYlewNojGP4cY5sAJmpPwrKPEpIlkWPR9Rszo4cjS/1CfbCfL/unhKg8v+9o1Mo= X-Received: by 2002:a05:6102:3e12:b0:5ff:dcb9:9222 with SMTP id ada2fe7eead31-604f90545dbmr1911323137.7.1774642482738; Fri, 27 Mar 2026 13:14:42 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-60512b3135dsm37981137.4.2026.03.27.13.14.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2026 13:14:42 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-798656130b0so56157037b3.1 for ; Fri, 27 Mar 2026 13:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774642482; x=1775247282; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z3dsqbgzmgrM2syDH55uS3n72DeAQsAumcT48/HQSyA=; b=W5InJlgbtlZz4/ijIQGgtGZhCtJ84CsU0Rfj4ecsyAItR3Qwt86yj1kTslYuS18tDA 4XqkZqshpsAN6VqtHVpCm0hX0bb2v3cPL8E8w52hKkS7gMF/7SaqEQr1ZAJFdqpgoHV3 271S1LWpccpAUmlpopbpR4o18lXXc2jlVBwjM= X-Forwarded-Encrypted: i=1; AJvYcCVNjejSQu3sj6l9S9e9iA69M4uV8mJMNLPfN8p+EeqR/vr7TmT/EvdfLVq78nViZaQq0riKWeExHxtpjlo=@vger.kernel.org X-Received: by 2002:a05:690c:e3cb:b0:79b:d2ea:8311 with SMTP id 00721157ae682-79bddcbaaf2mr41247347b3.1.1774642482101; Fri, 27 Mar 2026 13:14:42 -0700 (PDT) X-Received: by 2002:a05:690c:e3cb:b0:79b:d2ea:8311 with SMTP id 00721157ae682-79bddcbaaf2mr41247037b3.1.1774642481614; Fri, 27 Mar 2026 13:14:41 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79cb9a8f324sm119057b3.28.2026.03.27.13.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 13:14:41 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v10 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Date: Sat, 28 Mar 2026 01:43:34 +0530 Message-ID: <20260327201343.16146-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327201343.16146-1-bhargava.marreddy@broadcom.com> References: <20260327201343.16146-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. While the close path stops the timer to prevent new tasks from being scheduled, the sp_task and workqueue are preserved to maintain state continuity. Final draining and destruction of the workqueue are handled during PCI remove. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 74 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 12 ++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640c..edbb42efb70b 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,36 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + netdev_lock(bn->netdev); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + netdev_unlock(bn->netdev); + return; + } + + /* Event handling work added by later patches */ + + netdev_unlock(bn->netdev); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2507,6 +2537,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2542,6 +2575,8 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2690,6 +2725,23 @@ static void bnge_init_ring_params(struct bnge_net *b= n) bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2774,6 +2826,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2789,11 +2852,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2867,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c24814..d2ccee725454 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,12 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +287,17 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 --=20 2.47.3