From nobody Thu Apr 2 15:39:03 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23BEF38F629 for ; Fri, 27 Mar 2026 20:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642446; cv=none; b=QBHtam2k1YpiNzQGW1rrDL+p/Kdqoa2fcD1aquSROGvSZnmpauSjMxK/ow3i0SEAQE8OPstTtin4K6CoTb7nx9Ob44niBStS7KIB/tiO0NFX11AhZQnqcDPBmjJF2ZINVbTiUm5AgjLhvrsagYrlQgNlBT51rZA63kCZBMx/TCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642446; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=flm59KFnAaZrea4c5IX4RgHlHB/1iBSBE770+MsZbuF8mAt+TSP9jZBbFxrAMPuPNar89aGJDPGg/GkzLKqUy74nLDPh/7+ptj9p5FaLQKmyGWjTyFz2M0MU8PqKlH4tN5IUHOSJgt+mMVX1A9NHEX/T4rFCrGHJgMrbAgRblvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NDywv1qA; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NDywv1qA" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35c1a131946so1684231a91.0 for ; Fri, 27 Mar 2026 13:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774642444; x=1775247244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=NDywv1qAouOwyj2Ps5srk4Uf6rRppNSCFrdWelDm89jJq1cerwZT4Ir41MPlOo5HzW Oon7YT4GvFjP3PI89kMR7h4rhwSZmWTTE41z4j2LFJmKJJlzgtxTdHR6UjOpdylaoy5P v+WawE4LgQ+VI86o6bTEJF5L5H5cfncEy8AR/yqIJyoOoUoDlmlh1rD5n9ZW0zvh9kFt Goxl2UgBCbt1fwypKCyBm+SmIaCspXYTduNmoW6lkjCiTwq/2PK1+BjA27zvuHB2zgvA m0xzog1WeUx1mMheRdsrv/n80YurfQnpf69HTYD1w2Bp8ZsJB0w3UR3Im8sbc0/hzSYM MeYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774642444; x=1775247244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=bu81CT6ZDnKGxRanQhvJr76M+iSpX14w2SmHRCD1AXjBtLC2ravn74HPxYh+3jSTco ZvppSGE7Qom3BqGufw2dmaNltFyqXZiUWzl6MGSnEGFPli3uuRYMWAI+M49gSn+vv9x7 CIInUlzRLow+/fes8Ql6RcYh1Q0thh8hckZRxi8Xy4Dk8Ep/sDUJLABSk3CWyArC5E/+ zxOFPgjtq5zrix7xieykoeq7wY12ISy37KPzM9xYafX2RWIXRH0QezY9+xi8WqKohcAM qOw5aocBQVQM2DXeHyN8wU4j2MSl3pjzCfbvM5IbLQmmv+hIRw7nfAIT6dR9tFhfHYS4 9FhQ== X-Forwarded-Encrypted: i=1; AJvYcCWKCIU8aP+8SmPbC/NryKYMmW6VcY8N9lu4hhFrBk2pVgWCG8yu4b/fWvtWrwvBrO/CurFbX4VfVdIRZRo=@vger.kernel.org X-Gm-Message-State: AOJu0YysvfvNjCtEkzYAgLlxG36AgGYzAHUioV5qVKpbS8Z8F3i4fnbj ju1JYJEEzNxHXhKwHUEeJZYpYq+mvU66wSk8hcXFgvbaL7s4xUXKSu/M X-Gm-Gg: ATEYQzztGOW1r+Pqr+4ofw0pgmZ5W0a7vWA/7EFfw7UlHqP+7/cCiWq52kiO8RvgaaX 0SSaY86DEOktFlMZyyDZ082/nZxS+/7qWw0YJs5MJVC2Af0eAGOXW1dfrLMG62ljAIyjDbaVseN UJiN1NmxVFKiEXKuTGh4WMPZZG8syzSnMGOgGshrDua3akLguF9+yf53uQr/BuNaemYU86puOR9 zC8fdlbq/43ISfGfQOw43D+C101zS+yX8COPefXpCNH3+hLnh557KSiyTfYZFTl+LZoEKW3n+Xr ZnHzpDKxwtCID1EqP5X7BChbY7Xm7n4BvyaU/X4Fer1Ys/NkbYr6S2eIbnGR2PP2WZ0CWmUXcDL 5E17X/dinSPq4HzrGr1IY0OE/q/j3aX6ahpMYPscw421P2wulI5QczyAOVdN01u5XbGgV2vSAMq 5H1YENOcSpWnluFDhf/gi+nIBYe2mjYgwF0229Xh67jQ== X-Received: by 2002:a17:90b:2887:b0:359:8ca0:308d with SMTP id 98e67ed59e1d1-35c30dc50b6mr2812724a91.14.1774642444563; Fri, 27 Mar 2026 13:14:04 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2d8f96e9sm1534085a91.1.2026.03.27.13.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 13:14:04 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v2 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Fri, 27 Mar 2026 16:13:16 -0400 Message-ID: <20260327201316.427607-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327201316.427607-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327201316.427607-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3