From nobody Thu Apr 2 15:39:03 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9110A38F629 for ; Fri, 27 Mar 2026 20:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642440; cv=none; b=dqvnkTQgWUJyxmCp5cFTbFcfV/WScWxhRYMmt1pS5gkV8UrRLqQtJJKXGKnFd86ws1JDOTH22sN21w7XCYSiLMJ2REcdg3Pta1PuHjtUaKye6S+XnWWDkgUry36O8zz+Jw4Y+ggL8SRRbwzMho6mCcU1485lxPQz/EDKo0EDGkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642440; c=relaxed/simple; bh=7j8Moa59DkosVsxWFDavZ6weYRK8cTYFube+TQ8IPC0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JQ3Oz9Fni9G/8W14ScMdE5rSLg7J8NEv3OdIOFicgKOTJHeK+ka6PuKMtjcTbSJIf2P+9byQdJvue0dkw2mkn4pbQW6X+3uHDgcp1U9WTZfN4ZPUheJtlIrrZpWBKQqw+dWKgsxXVVGunoqg+dwlbUtFsD6BoCS7NnclTYR5ByU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CfINtM3e; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfINtM3e" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3567e2b4159so1619023a91.0 for ; Fri, 27 Mar 2026 13:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774642439; x=1775247239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/nuT9mfHoO1n2zOd/gsACVfEg2tIvD3nQVS0gGGSabM=; b=CfINtM3ex+Wpt3jR8wLNWHcm6lye8D+410cdkwhPjBv4FiR5R9PGuNeWKf5qWUSxeJ NzD+nLZw8t4/OWiL9M1C5R065HdfQxfsJqOqVMnGU6kj+dLmQ3pNSKjeUBAAGjQSN1wD FzNUHTr23wpY9hd8ytjXYDTpqqOnkPTnQG72hao5Uakak6kNbsdtVAiV1xetouJ7X30p 4gEucvHz+xoB7GgX4s/JF16qX1+m5eliJT2x/OHC9nEgc7BVeZxV1ZICerogyH/Q8QZy Cz2TGDWVwtunyb5zcHl3NU24xBMrEEP59Kbi2oWjbrmjd43S6Shd+7SJF9FYguVEzZjF 4oSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774642439; x=1775247239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/nuT9mfHoO1n2zOd/gsACVfEg2tIvD3nQVS0gGGSabM=; b=N9tIr3qojb+XQC5QQ9Kgu3begNexD3DaP1NP8gLH8PpcxDjGd7zqIFaSVlNCj5xBBy klSc/sS8Yz/dafN0QAuGyi5jKn05LrdYVGPnLGaCGKw4KW5UioM4WAsueGOfBBBXSzAY K81opOWW2qPAhi9nH4pDdCjOFHhqQdDJHo/JAaMPzGGiVsKVATPUgADWOzZ/jPrQESqX F9hAUxVFa1dQt/bmrGpkr6RLwWp/dxEZA3YyQOvo8O+8grvbcfSKFcYW7WAb5KRTO0lS feV0kBnFnIVuvKnBu9j3R8vWC3bVPlX50uHc1rwrfEiwixRdIH9CA+2jgpxhMVe57lfB rGwA== X-Forwarded-Encrypted: i=1; AJvYcCVhV/87hfIyeuznf7yo7yd2tKHhK95hYMYXpWShekqEs04m9cl9Bzuma2YJiguk2DZAVZtPsDx4M7DZxnA=@vger.kernel.org X-Gm-Message-State: AOJu0YwPgY7eHnUVqbPIMfmcTQo9JSjy1jvbLeOoq8Nhqfig6RUV1lZd 4l2QKD/pvHe77p5/kM3bR43v1ErFH2Ndzo0bTts7tmzoDiHstlGaFyIHHb8D4UAXro4= X-Gm-Gg: ATEYQzzCw7EQ/IbZYs3Ho/sJtZUh49yRMSAKjt++2Dzk+n7itc1atSaVV/FqLJc3tkQ o3pWk2GB7xRT3WGMyabYHmqNGzPbB9x21XgcmQWiz/wMfPuvghQRM/LPbBR9AMWISRLi4XjL6hJ y4AS8wMWmfnq0P6YDu9bQ5JEaQEoZuENFv/wPJZvrLGtrzKrhnM/fEorYk65S2A0mijRdHsw8Q4 rDyzq01dbMOKTPDwS3OygtEv33jXUZUNVC9QUAyMlLPyCYyFEAUtlSIv95+l5DGTfPhcCj/BrTC RoPEJC64rOzSwQFi+zroapX3H4W0WgG9FJuzAFWvQqSgK725kmdr/Txeff+pxRJcPhw7QTjY4n/ ktpTaDrqGITP0tC1NMljsNB3nQlV/DtzPycEJGyhOXaCf52/WZCJTR8C6OJNMiunxHHGQeoY/Gt KCA6OCS4Y2gj0Z0zaWsS4F0ntrgL5wS2mmGbbISXqyTqrF8QUGE/6H X-Received: by 2002:a17:90b:2d81:b0:35b:94db:fd97 with SMTP id 98e67ed59e1d1-35c300bd43bmr3243233a91.21.1774642438910; Fri, 27 Mar 2026 13:13:58 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2d8f96e9sm1534085a91.1.2026.03.27.13.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 13:13:58 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v2 2/3] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 16:13:15 -0400 Message-ID: <20260327201316.427607-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327201316.427607-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327201316.427607-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..9f19eb483c69 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); --=20 2.47.3