From nobody Thu Apr 2 15:36:25 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D8530DD1E for ; Fri, 27 Mar 2026 20:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642434; cv=none; b=q/8TOx646hJrMNnA2tZdj76pF2jjUr7lPoT9d7dL7GLEURE9xffzbsT3aLSLdGIw7EAz37E6ZkbAr1YwVWAShSmRIfcnPPFmrU2zW3g+UnjRlYlDADgWjhl2xXZN3qcHLTs1/p9JN8dfQwfLImdxvDY5uLUeKMPZp+m36RykLws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642434; c=relaxed/simple; bh=hV0PSRnR/bl4CdLuH0CGuwoqFy9Ab3KJAJrnQZux0Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n3XpDDAEJBCp3QfkgbSx/1dci/u9BbXeQ5QD/Zh1hyr7Ts7m9WUowcS84kLvOHFo2dui73JiG5A5RY3Tb1F/uFOWoXuopQA5mLoQwsPQU5RsBxAQjNoD/SJ9mmgOX27r8tCZs3zmTv5ExR+jaLUDoKGWP3ggL4B8p8wP1h+bPMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lc3u8Oh5; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lc3u8Oh5" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35a1d4a095bso1551644a91.0 for ; Fri, 27 Mar 2026 13:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774642433; x=1775247233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=Lc3u8Oh5LBw5DVc9oqg4neJ1FgBMvM91Za9PgYkmP5ggrhObj0hWMdJ2kfcnigcx1W vClJTbK+fmFz+52M+bLDvPveCERBWceo0vuOJcuU8gwstZSka5QVdo3w4lP4b22k7g2O 96a6Wmc/5hfR4l4BPm/GNgitj84p5rDuH/KCviLcconGp2fnwj9RbhIQsyz0ursOLjIl 8vjQO3qQsFEKgeduXSB+E2od5f6g2ShAjOocyZgEH3zMpwceadcYq2kHn+iHke/KMbT5 IKDUNulxBsfrKgnvtrRC1extSYYBnuo4Ij6UYMecwDBTLMOZ37dfTI0WAH0o1QrjcZUE weVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774642433; x=1775247233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N06TUEQJrWZFxO33UjJmD1NIhQS6pZplfv0sDwxN4UU=; b=r7TyTTM4X5K40nTlQ7JXfwX2q43ycojBHbmOlmOgFyv5NdMJ+Lt5TAQCvpaNUoX3Yr +iM8zAG38xJ+aa8bjjVML7RTg5UhSD1ek+phIq9TLyKy8N6rLslvmw8Gg9GyQVhq9u6N hpqtPexaxwYgd7GN4ZkzmqvsriUmBDA0c00gONgMdj5tudqw+OjCZsibeBUBe90KgZTw IhFxtvoGsKfTHbvoZKhV7av3gzwuP6OEbNcPcTQMM9MD7IRb8TgYv+hQHufxRnsVUFsz OduNZ3Ikkww0xwmSrHW/ZqaOcKZV7Ob0iNjWVQ+POo/ZGCTi8xIl+EwjtRrQI+vxejAf b+Fg== X-Forwarded-Encrypted: i=1; AJvYcCVthk6jkNC2wzELYxNDZXkqrpx+R9QSOBKORzuabrJovIwF2Yk8inIu/OESebwbksexwHZuzxlU7vSqT+o=@vger.kernel.org X-Gm-Message-State: AOJu0YzSg/IkSYoOJ+6P9wtkqNx5D8nBExZeOr4pepCqWC6apvwrfZAM iNqXoSVpMxqjO+v+qTWjRMfxgCoHPug0CfIqDVzxFZQHQ3H2ughiSjQe X-Gm-Gg: ATEYQzx9SQ00ll+d3k9s+cncyCEDzWwCKlfDhn32KgAuNAbg7tSn1cicsRdZK4u+kCw 2dkkbnqDEjXRtwc6UZIsl6Wly6ktQLeRqApb5fycZ1Zr2IuqiINbeIGOnFbNcLJmUrI2Z355PJ+ X3vA5iEBz43BAmGtT+s78GlVITS3ZSsKYD8ntPgBgvEDR6Fp18fW8fpL2XKH6uS3rHYlOg74n49 78NrH3Z8Vu/EbFOL8yJU1uEb8iGKak/f9jzXa9EsCzEkpBnYwOaVSBYrnLFVdKZcb9qsk8tdl3X jKjXFKp4AWs0Du+MsQUhkFcb5tQsouRbl9LQipUmQ6FWebvxDcr7DOVNJhjKCyIDXX8Atry38y/ V/qWfxI977LkfIuGQSQYUGnF3gtQJJ2zU5qOX0JIsZc73EvSK4VU2ol/oqwYGtTHsVn8IXHfPMe eZaHtRPBdF2bizdaIxknbl2U6I6ZFuHhGzYlN0FT3qFw== X-Received: by 2002:a17:90a:d44d:b0:35b:d795:cf5d with SMTP id 98e67ed59e1d1-35c30bc9833mr2769103a91.5.1774642433076; Fri, 27 Mar 2026 13:13:53 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2d8f96e9sm1534085a91.1.2026.03.27.13.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 13:13:52 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v2 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 16:13:14 -0400 Message-ID: <20260327201316.427607-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327201316.427607-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> <20260327201316.427607-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..fce726a9c8c0 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,8 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + if (SND_SOC_DAPM_EVENT_ON(event)) + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3