From nobody Thu Apr 2 17:16:38 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 301CC3806D9 for ; Fri, 27 Mar 2026 19:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639855; cv=none; b=NeZgMd1xGu9pXlzcgYEnskamI80PxDQq2S0SM0lkSrkdjr8afpKn0nIP2W4x8me3Fv43rLUSVbU1PgiqeTe1ekOdbsuDJfTberb7Oihiuq6lrs25NlOyfFkTDxzRYw6npthMzhh52d7G5/6eXhHd6wlR6Q6AwBFOV+WLxsFbZnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639855; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZUcSrCJpjzRUvvVTq60lMBK8S59sGjGoV+ZnQCNd/fUVB+gHt/A52LviRSyhMxbLmS8gMBr9CErvlYi+GB6wo2K9brY2o+Oq+6LcGhnn4GqXouKDx86jkmRRzoyGBv32n8ojDtCEg6Pi+rZcTVfVL+A+9XwRWVfGXdnxqGxP7EA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pz+uADq9; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pz+uADq9" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-829781b2b01so1417110b3a.2 for ; Fri, 27 Mar 2026 12:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639852; x=1775244652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=Pz+uADq9Y2Clt6SVgI8yp15SmEfUlRJOGzTEWbsniu+V1mdNI6+Z60Xc0Dmran1xxJ lA4KP2se74vdZxtRbkLbRZSP9qK1/BbuSgP9CB5Ci7e2QFQtB4upT+VxwtHEM7vgqFnB akMqT+zDZq3JhQF2B+/IMb8Sh7t1xbSafkJvWibuuf9FOGVXz/GTezVzljCodHq6tRTD b2jYeM0xWF72TaQKgxPjPquC6VTaTdUPzxsI+ZJwBNZ2XNzPY+LE154mcZDF41QX15Zs ia+7at0fNkQS8UWBXnvZe8hjfmRgKNVhZQYCSaupIXF3Ag4W3WTzzKF+0e4Pbp/gfF8+ QF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639852; x=1775244652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=J7hlYO7BuipxGp7UbNxSgs3k+fXwo0eII1pfK8U91lBYlPnUIG26wRSmA47G2bvD62 TkaaG2xYC9JxjTh3PKQI95x3t45sm6b6jedpRa3EElJKFAbTVfhH+KnKgrcPNDGvLNs/ 2ATVthRkoIyPFRe4FpVifIRQPBZp1OICXeN1yZn+kxRUaE+VtkW8W6NXdC23wRXibI2o 9eCUgXG+S2+CEzc/fpEV7eMp7Qp45q3U1pCj0ACBsRrLK5YKN3QFv6OvFXbAYFGibDEK FuSFaJDQsE54zwW8UErTpoGe314oJEQwuspKvo+J+gcXWDz8P/dN4cG7K4EWPLBjucE/ HqUg== X-Forwarded-Encrypted: i=1; AJvYcCW6XFruHs+mno+wPKzn1iYj4WypPnU61NXj+59nY708h/qunCjPeY+xRLq5JvMC+LEXQEEc9BQ7L5RVLx8=@vger.kernel.org X-Gm-Message-State: AOJu0YxEa7au6dKy3/aZoai+W4IQlylxSRNb9sWXY8GKw0BppXR9i/a0 g0TFzqnDGouIJJhHXwMpMt4qlXnFhdPo4vgQnXHCIqMhtkqiMbsXofsE X-Gm-Gg: ATEYQzwQQHpo1RSM8p7A0dcWq3Ix7y1zOi99h0PQ5GT3VY0NLcD4eKubOrFhq4xS3pD aBJOEqtwuu7C3NP5vHxV2Oodfgv+/yNBrGJObspnh4Rl4NRyeYllDkIif3G0Cqz+eRXiqdK8xjv OFXyMkHYG02ahfBQJUl6FC8GZ9VRtJouH8/s0McR0K/6l4VDEOwBGlwZqwyjEiIsXFPx+J+qqg/ DnTJP909HcwAdhdF9kAMLZ4fYOdzdBZFP5lidJfWT33jr65ypMeRykXCRlF8Hcl1OYRIAAFthr/ S53NpjiVJyuzOv9RlVcAj3xUPw+6x02BJmqP5zjRD+AzHf1KoYnr8Jcj2D4JxQTSuffNqjghWX+ IZLO6ycFf6uSxCzhAfRHNciKI7/YTdx+a26urH3uJXFyORs/doQuGL9ZWNgaUXLEdUHZja8fDie HbE9msAlXgiGLv8rFEDzPAVDDvHOlE3gt3+3O8dZnHkw== X-Received: by 2002:a05:6a00:c82:b0:827:2ed6:888f with SMTP id d2e1a72fcca58-82c96035be6mr3435922b3a.54.1774639852029; Fri, 27 Mar 2026 12:30:52 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:51 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Fri, 27 Mar 2026 15:30:02 -0400 Message-ID: <20260327193002.423897-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3