From nobody Thu Apr 2 17:16:38 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6383D3815C3 for ; Fri, 27 Mar 2026 19:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639851; cv=none; b=DYGwEJ392fxKIaIwdh2xq7yZWGvtFte8eRrEPjtPkiuBOLT+pypVHcZkPm3x4rDGfARYQxzOoKi8hFYp+O7Q3Xa+4mE2Q5dDlceNXeto+5u6ZWFN0ZFrGe8bpL3TToJ7/v65yb5kv8axTOwUj4cBIyL5I0RLg5oAGR9lQ8oRioA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639851; c=relaxed/simple; bh=gWTNa1Ru6FTWiYGuetqt8sQnphE1BsUU0ukTCJvdibE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o7R9v2fGFZDyC4bZDs7NeMvkP7U1HlUx5UeeJhTZ5Sm9A6kBloMfhrPl7J8eeDCumFvtx42LbjTvZecxuc/ftKwWcoEln1GXN8QrTyeO0UZ93hz8kTDGaBd5Qf7mFG2k+Rr9dg6xgFS7Nm4Y0ABYrkhaueC7QTlwBT+vKEuQpcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q5FVRoeB; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5FVRoeB" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8296dabef74so2378795b3a.1 for ; Fri, 27 Mar 2026 12:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639846; x=1775244646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d3FUlPSvuL6UwdVrhI2pf4kR3xrV47JWPOjNqQAkdaY=; b=Q5FVRoeBaq472siBGOxgDL3Znr8CJ4IoJnikp6hLAygXM4QO14pliq74ErwuLbszwH IQlNL0i01phwIV45CYXxddjjU4cHK3Hy+5EHXYyCANGt3GjFlvava8tcqcmj/ChLDClQ Ti3GZuAGSkbxoIRcVWVAfG8OFxNR0di3glJPZzm4SaFM2CB3uOhTcSVy81LfIOBWogTQ uLmIqfoKOHrNbKqM3fMdRBIbZUvb+hBo904YRA/8/cZGTBu9/xn29Quy2B9H0K5mZFqc xs3j6gn2e0UKRzPdU5Kws7YXFTX6adYYtDWzz96Fky9X5fpRVyrsm2kIOwXIzGG+FEIK AS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639846; x=1775244646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d3FUlPSvuL6UwdVrhI2pf4kR3xrV47JWPOjNqQAkdaY=; b=Wg2l5fcfSTqw6xezPxhLz/ynUoGqiDHCJQGSq+L7lBLL0c2SCM71oziMTZeUR7Wxr0 CtO5LzOH5nAAP6bRkhfdfvqLIVzu/wmAbs9jD7EUHaorJ3py84YuvEpFHDlFtd0b1PXy nrWuBwPOV877kFQMeqI112bsmsZ3DrpT3EnqdSDkNgTY7Mzd5Rg3FUSzfYaVIxM2Sk82 BewXr1A1Z+NANjvJhODJw5Jdxod4Q3MOk7gHVcMBNu/4/vNI3p4L7ZI0lCZhd+32GoA3 eZbD/PsfIBP5UFK6Dv+u9QR4sWv90osDFRBtdP3ePO5UFZMyyHExEghagxSCr0FfsKoK o/Mg== X-Forwarded-Encrypted: i=1; AJvYcCUxN6D8f2OuMON/TZY/zErB+o+gnLGl3kyXP/RTPpF6PSji7scSJPAOMSXuj04OXGxmuMZm9ju7dPN78jg=@vger.kernel.org X-Gm-Message-State: AOJu0YyDMbeFBV7P0y5dllVvlaDtPQhZip3MI3wKPWxxDIIl9FBVV5JX mRwvUlXvs6uxsKwrNpsOI+Empu8fsg5bxyY+Y1g98FQ7XFDomKd9O8yh X-Gm-Gg: ATEYQzwx5oSYLmFM8URbZExQ9kEOci1fI/xFDGNpKMB5TIxTgUFGW/p6zI3gM1g15S/ m7IMLQVN29xm75kg98EtTPkupWm32EhHtQijdjQLizuo0/e6wc7zMN4zwhjXBGSsij0MgfyeHh5 1GjTLeXjtlqW2ScGsDY4ziOau/p/h1j7OL7+rApXruKr6asmf/ESPBakZAcNK6h042tRezJvgee Ivgb+bSV9YYoD5T8gB23os7cEGvpp6n2Vi58VEDJyY8dSIQjdHsbnECDI/L2JsnXV9wlthjNXJC q6bsfgA4K+yh8V2MtulYpzs3JH7gr8X+NLS7AOj5T2hDsMAMsnEuiQ8PuCpCNT165SBi7gtIuFS R5JbwILBDeguzqWJvhUpIAhMEItXAQeNf0cSctK5Y5o+ZX1F49+BiN1Os3uvNJA58MuA5Gp65l4 NLIUgkJfoq6GfCJf4aPGW4FDYjbpIbIJWWzyHi1w6i3g== X-Received: by 2002:a05:6a00:a804:b0:81f:4769:6fec with SMTP id d2e1a72fcca58-82c95c27804mr3835422b3a.21.1774639846324; Fri, 27 Mar 2026 12:30:46 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:46 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 2/3] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 15:30:01 -0400 Message-ID: <20260327193002.423897-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..2eef9a6dc8f3 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); @@ -224,6 +224,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3