From nobody Thu Apr 2 17:16:41 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1323737FF7F for ; Fri, 27 Mar 2026 19:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639844; cv=none; b=AlwndAWXDgrghARk10HMWOpkLHiDhyM/v7pCISo8+/D93ckOzkppf4w0Dc90lqg6iU+KxBPLqztsB7hsxNgVin6gHGRBy9iP211/zuKjOqGdRZJAjF6MfuKP7MpP8X9K1e0BbN3vN05j37iQ9ZgNQHn8hEfToe/DlsjcHM5JTbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639844; c=relaxed/simple; bh=cMuVH60s0jC7glK4UAYNyd5esKa6O1q7zTzEgaJ2VTQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OoYxB3vJu/IABbugA1AAesNfBlOsI9/Dq9728OxfZQSkZrtxNsAc9UCPdCg28HMQ6IoEWpXwgI6FeoIQPKf+5O5P2PosW7rCuZxFs0JqQGFZmceOF+4zGG1BU1M+l50QHLBdYB7BzB3C4OH51Ykcf7CFAlLASe+oyu64JIVxW2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E9Pm2kkW; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9Pm2kkW" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82a655cfab5so2359413b3a.1 for ; Fri, 27 Mar 2026 12:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639841; x=1775244641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X7gFwspXAi/ZI+xh5ATLhwwUGscd+mp4HFWUIdYWFYk=; b=E9Pm2kkWRnyCmUN8CYybjYasj3edkQQZKnGjAPqBjkeqJcp5Z21CLJWQN0IkwDHaBT tL9MD/uj8QTiK+6r15LKtxb3VEQRFFf7RVHV5/9iK388I8lUxrRkDjg85wjbEiWTOtKQ w1zCwlsBEdDDrWESOs3sdAhMybTFc434OhulveUfrJD9VmYFLGfgTLaQuHyJPnKxO5zC LkKgyidbGQajTFTA4wX1VpoAAh/dPtdAKUb0Sua8TpASzczcYuqVBZKQz/ObGK8e96V4 dV4ZW7G0pHfVopwftorWA2iJnF/Yt62DHmdKfE5LwRDtDNxDKxbIAbTDhUdqvegPCqiX ShCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639841; x=1775244641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X7gFwspXAi/ZI+xh5ATLhwwUGscd+mp4HFWUIdYWFYk=; b=TH9ovEv4krU7GVV/UT7uIGzQoAqYif81mqTUDpH860C37O9igT3wFPZGgkzuGVzqwR Mje7c4NCq/Pmtk8sBuw9jioI3MTqYzgB8c9JbQLDie1TQkGhGbS77AvXiDOb/DEOgxNF +DWkmVuLdzUzlUkEXhtnaWrvrGZwsBbJu10ZoitOweYn5uZ4Ou1llqa2n192VJj7gi0L X67JIMBfMSD2jUvXiIKQWb1oPxD9hjGHO19yntpWtWe/tgK+R0m4wgFjA44IlwJFvepW wq8WYAmRucCXsrqKh3xan7wtAKYexVNUdtF0Bfe6+xmho+n4U0Q5lpXVc6qwB1mrOPpe kjBw== X-Forwarded-Encrypted: i=1; AJvYcCXEeckqq8QnIQsGauwJl6/SuJoiOZQqQJOEY+EwDPMVOELfETuuIG2Njff7peWV/LUL9YnJXvzaLrSjSBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0eidvbmd2mkCjyNvPrv9FZVBdOimTRdpvggTYNG7d92XfuJT1 fNJmKbXz2BdMcEIgTEXHlyUlKWFBhLZnESIS6iVJQgC6X/TQeDDD2iyv X-Gm-Gg: ATEYQzyUdmecdUM6jh5bV+Mq9tAd6QSUCj8Tvt/2BwSDz521+vrMmitGO2d5FogAp3p oAXcEsKOksS6heyj8+7D/uTESf1jgG3aSnk73cGjG1m8RYmd305Faed0u1jZlxA4VS/jVmGEaY6 HfAvlIUjmb6cR1nUJVExOhNa+hRPMkvW/zoeYayYjxZ5B/g9wSe6e2mU5vL3MHDZJyIYaDrQqXK Xuws9wDrl1V1bSjmPjwBe/nhrwX43MaLCfA+giQY1VrqvMZStmu9cUUnMQRJhP648KbsZO6Tyqb vzw1OYrPBwS2p9AC4zCBHOaePTFg8Km0cUEJvyuh50/Ddbb/6iYIxhkLXnyDL4/rRS+aRRR0bUD a0B5io3zkl+9B3dZ/gmUSnb28mEQOy211HEJQNBx9tGz/fBX9bblZWr2WI0CxtrAsaNiSdd8GM/ YGErjGu6bvI+YMmRC5ZKTURlFvr8t4yDyJ5WVXgSEFHg== X-Received: by 2002:a05:6a00:1398:b0:81f:52d4:a5ec with SMTP id d2e1a72fcca58-82c96001522mr3672771b3a.43.1774639840906; Fri, 27 Mar 2026 12:30:40 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:40 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 15:30:00 -0400 Message-ID: <20260327193002.423897-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..3ecfba161e56 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3