From nobody Thu Apr 2 15:38:59 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1323737FF7F for ; Fri, 27 Mar 2026 19:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639844; cv=none; b=AlwndAWXDgrghARk10HMWOpkLHiDhyM/v7pCISo8+/D93ckOzkppf4w0Dc90lqg6iU+KxBPLqztsB7hsxNgVin6gHGRBy9iP211/zuKjOqGdRZJAjF6MfuKP7MpP8X9K1e0BbN3vN05j37iQ9ZgNQHn8hEfToe/DlsjcHM5JTbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639844; c=relaxed/simple; bh=cMuVH60s0jC7glK4UAYNyd5esKa6O1q7zTzEgaJ2VTQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OoYxB3vJu/IABbugA1AAesNfBlOsI9/Dq9728OxfZQSkZrtxNsAc9UCPdCg28HMQ6IoEWpXwgI6FeoIQPKf+5O5P2PosW7rCuZxFs0JqQGFZmceOF+4zGG1BU1M+l50QHLBdYB7BzB3C4OH51Ykcf7CFAlLASe+oyu64JIVxW2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E9Pm2kkW; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9Pm2kkW" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82a655cfab5so2359413b3a.1 for ; Fri, 27 Mar 2026 12:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639841; x=1775244641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X7gFwspXAi/ZI+xh5ATLhwwUGscd+mp4HFWUIdYWFYk=; b=E9Pm2kkWRnyCmUN8CYybjYasj3edkQQZKnGjAPqBjkeqJcp5Z21CLJWQN0IkwDHaBT tL9MD/uj8QTiK+6r15LKtxb3VEQRFFf7RVHV5/9iK388I8lUxrRkDjg85wjbEiWTOtKQ w1zCwlsBEdDDrWESOs3sdAhMybTFc434OhulveUfrJD9VmYFLGfgTLaQuHyJPnKxO5zC LkKgyidbGQajTFTA4wX1VpoAAh/dPtdAKUb0Sua8TpASzczcYuqVBZKQz/ObGK8e96V4 dV4ZW7G0pHfVopwftorWA2iJnF/Yt62DHmdKfE5LwRDtDNxDKxbIAbTDhUdqvegPCqiX ShCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639841; x=1775244641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X7gFwspXAi/ZI+xh5ATLhwwUGscd+mp4HFWUIdYWFYk=; b=TH9ovEv4krU7GVV/UT7uIGzQoAqYif81mqTUDpH860C37O9igT3wFPZGgkzuGVzqwR Mje7c4NCq/Pmtk8sBuw9jioI3MTqYzgB8c9JbQLDie1TQkGhGbS77AvXiDOb/DEOgxNF +DWkmVuLdzUzlUkEXhtnaWrvrGZwsBbJu10ZoitOweYn5uZ4Ou1llqa2n192VJj7gi0L X67JIMBfMSD2jUvXiIKQWb1oPxD9hjGHO19yntpWtWe/tgK+R0m4wgFjA44IlwJFvepW wq8WYAmRucCXsrqKh3xan7wtAKYexVNUdtF0Bfe6+xmho+n4U0Q5lpXVc6qwB1mrOPpe kjBw== X-Forwarded-Encrypted: i=1; AJvYcCXEeckqq8QnIQsGauwJl6/SuJoiOZQqQJOEY+EwDPMVOELfETuuIG2Njff7peWV/LUL9YnJXvzaLrSjSBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0eidvbmd2mkCjyNvPrv9FZVBdOimTRdpvggTYNG7d92XfuJT1 fNJmKbXz2BdMcEIgTEXHlyUlKWFBhLZnESIS6iVJQgC6X/TQeDDD2iyv X-Gm-Gg: ATEYQzyUdmecdUM6jh5bV+Mq9tAd6QSUCj8Tvt/2BwSDz521+vrMmitGO2d5FogAp3p oAXcEsKOksS6heyj8+7D/uTESf1jgG3aSnk73cGjG1m8RYmd305Faed0u1jZlxA4VS/jVmGEaY6 HfAvlIUjmb6cR1nUJVExOhNa+hRPMkvW/zoeYayYjxZ5B/g9wSe6e2mU5vL3MHDZJyIYaDrQqXK Xuws9wDrl1V1bSjmPjwBe/nhrwX43MaLCfA+giQY1VrqvMZStmu9cUUnMQRJhP648KbsZO6Tyqb vzw1OYrPBwS2p9AC4zCBHOaePTFg8Km0cUEJvyuh50/Ddbb/6iYIxhkLXnyDL4/rRS+aRRR0bUD a0B5io3zkl+9B3dZ/gmUSnb28mEQOy211HEJQNBx9tGz/fBX9bblZWr2WI0CxtrAsaNiSdd8GM/ YGErjGu6bvI+YMmRC5ZKTURlFvr8t4yDyJ5WVXgSEFHg== X-Received: by 2002:a05:6a00:1398:b0:81f:52d4:a5ec with SMTP id d2e1a72fcca58-82c96001522mr3672771b3a.43.1774639840906; Fri, 27 Mar 2026 12:30:40 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:40 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 15:30:00 -0400 Message-ID: <20260327193002.423897-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5640_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards= /bytcr_rt5640.c index 103e0b445603..3ecfba161e56 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -304,6 +304,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 15:38:59 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6383D3815C3 for ; Fri, 27 Mar 2026 19:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639851; cv=none; b=DYGwEJ392fxKIaIwdh2xq7yZWGvtFte8eRrEPjtPkiuBOLT+pypVHcZkPm3x4rDGfARYQxzOoKi8hFYp+O7Q3Xa+4mE2Q5dDlceNXeto+5u6ZWFN0ZFrGe8bpL3TToJ7/v65yb5kv8axTOwUj4cBIyL5I0RLg5oAGR9lQ8oRioA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639851; c=relaxed/simple; bh=gWTNa1Ru6FTWiYGuetqt8sQnphE1BsUU0ukTCJvdibE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o7R9v2fGFZDyC4bZDs7NeMvkP7U1HlUx5UeeJhTZ5Sm9A6kBloMfhrPl7J8eeDCumFvtx42LbjTvZecxuc/ftKwWcoEln1GXN8QrTyeO0UZ93hz8kTDGaBd5Qf7mFG2k+Rr9dg6xgFS7Nm4Y0ABYrkhaueC7QTlwBT+vKEuQpcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q5FVRoeB; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5FVRoeB" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8296dabef74so2378795b3a.1 for ; Fri, 27 Mar 2026 12:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639846; x=1775244646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d3FUlPSvuL6UwdVrhI2pf4kR3xrV47JWPOjNqQAkdaY=; b=Q5FVRoeBaq472siBGOxgDL3Znr8CJ4IoJnikp6hLAygXM4QO14pliq74ErwuLbszwH IQlNL0i01phwIV45CYXxddjjU4cHK3Hy+5EHXYyCANGt3GjFlvava8tcqcmj/ChLDClQ Ti3GZuAGSkbxoIRcVWVAfG8OFxNR0di3glJPZzm4SaFM2CB3uOhTcSVy81LfIOBWogTQ uLmIqfoKOHrNbKqM3fMdRBIbZUvb+hBo904YRA/8/cZGTBu9/xn29Quy2B9H0K5mZFqc xs3j6gn2e0UKRzPdU5Kws7YXFTX6adYYtDWzz96Fky9X5fpRVyrsm2kIOwXIzGG+FEIK AS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639846; x=1775244646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d3FUlPSvuL6UwdVrhI2pf4kR3xrV47JWPOjNqQAkdaY=; b=Wg2l5fcfSTqw6xezPxhLz/ynUoGqiDHCJQGSq+L7lBLL0c2SCM71oziMTZeUR7Wxr0 CtO5LzOH5nAAP6bRkhfdfvqLIVzu/wmAbs9jD7EUHaorJ3py84YuvEpFHDlFtd0b1PXy nrWuBwPOV877kFQMeqI112bsmsZ3DrpT3EnqdSDkNgTY7Mzd5Rg3FUSzfYaVIxM2Sk82 BewXr1A1Z+NANjvJhODJw5Jdxod4Q3MOk7gHVcMBNu/4/vNI3p4L7ZI0lCZhd+32GoA3 eZbD/PsfIBP5UFK6Dv+u9QR4sWv90osDFRBtdP3ePO5UFZMyyHExEghagxSCr0FfsKoK o/Mg== X-Forwarded-Encrypted: i=1; AJvYcCUxN6D8f2OuMON/TZY/zErB+o+gnLGl3kyXP/RTPpF6PSji7scSJPAOMSXuj04OXGxmuMZm9ju7dPN78jg=@vger.kernel.org X-Gm-Message-State: AOJu0YyDMbeFBV7P0y5dllVvlaDtPQhZip3MI3wKPWxxDIIl9FBVV5JX mRwvUlXvs6uxsKwrNpsOI+Empu8fsg5bxyY+Y1g98FQ7XFDomKd9O8yh X-Gm-Gg: ATEYQzwx5oSYLmFM8URbZExQ9kEOci1fI/xFDGNpKMB5TIxTgUFGW/p6zI3gM1g15S/ m7IMLQVN29xm75kg98EtTPkupWm32EhHtQijdjQLizuo0/e6wc7zMN4zwhjXBGSsij0MgfyeHh5 1GjTLeXjtlqW2ScGsDY4ziOau/p/h1j7OL7+rApXruKr6asmf/ESPBakZAcNK6h042tRezJvgee Ivgb+bSV9YYoD5T8gB23os7cEGvpp6n2Vi58VEDJyY8dSIQjdHsbnECDI/L2JsnXV9wlthjNXJC q6bsfgA4K+yh8V2MtulYpzs3JH7gr8X+NLS7AOj5T2hDsMAMsnEuiQ8PuCpCNT165SBi7gtIuFS R5JbwILBDeguzqWJvhUpIAhMEItXAQeNf0cSctK5Y5o+ZX1F49+BiN1Os3uvNJA58MuA5Gp65l4 NLIUgkJfoq6GfCJf4aPGW4FDYjbpIbIJWWzyHi1w6i3g== X-Received: by 2002:a05:6a00:a804:b0:81f:4769:6fec with SMTP id d2e1a72fcca58-82c95c27804mr3835422b3a.21.1774639846324; Fri, 27 Mar 2026 12:30:46 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:46 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 2/3] ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error Date: Fri, 27 Mar 2026 15:30:01 -0400 Message-ID: <20260327193002.423897-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If byt_rt5651_prepare_and_enable_pll1() fails, the function returns without calling clk_disable_unprepare() on priv->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() call before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/bytcr_rt5651.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards= /bytcr_rt5651.c index 68cf463f1d50..2eef9a6dc8f3 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -205,7 +205,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, if (SND_SOC_DAPM_EVENT_ON(event)) { ret =3D clk_prepare_enable(priv->mclk); if (ret < 0) { - dev_err(card->dev, "could not configure MCLK state"); + dev_err(card->dev, "could not configure MCLK state\n"); return ret; } ret =3D byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50); @@ -224,6 +224,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, =20 if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } =20 --=20 2.47.3 From nobody Thu Apr 2 15:38:59 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 301CC3806D9 for ; Fri, 27 Mar 2026 19:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639855; cv=none; b=NeZgMd1xGu9pXlzcgYEnskamI80PxDQq2S0SM0lkSrkdjr8afpKn0nIP2W4x8me3Fv43rLUSVbU1PgiqeTe1ekOdbsuDJfTberb7Oihiuq6lrs25NlOyfFkTDxzRYw6npthMzhh52d7G5/6eXhHd6wlR6Q6AwBFOV+WLxsFbZnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639855; c=relaxed/simple; bh=92+MxE9SEiqswIswB1QejRLUIDn30JoIRpdlHoppd08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZUcSrCJpjzRUvvVTq60lMBK8S59sGjGoV+ZnQCNd/fUVB+gHt/A52LviRSyhMxbLmS8gMBr9CErvlYi+GB6wo2K9brY2o+Oq+6LcGhnn4GqXouKDx86jkmRRzoyGBv32n8ojDtCEg6Pi+rZcTVfVL+A+9XwRWVfGXdnxqGxP7EA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pz+uADq9; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pz+uADq9" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-829781b2b01so1417110b3a.2 for ; Fri, 27 Mar 2026 12:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774639852; x=1775244652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=Pz+uADq9Y2Clt6SVgI8yp15SmEfUlRJOGzTEWbsniu+V1mdNI6+Z60Xc0Dmran1xxJ lA4KP2se74vdZxtRbkLbRZSP9qK1/BbuSgP9CB5Ci7e2QFQtB4upT+VxwtHEM7vgqFnB akMqT+zDZq3JhQF2B+/IMb8Sh7t1xbSafkJvWibuuf9FOGVXz/GTezVzljCodHq6tRTD b2jYeM0xWF72TaQKgxPjPquC6VTaTdUPzxsI+ZJwBNZ2XNzPY+LE154mcZDF41QX15Zs ia+7at0fNkQS8UWBXnvZe8hjfmRgKNVhZQYCSaupIXF3Ag4W3WTzzKF+0e4Pbp/gfF8+ QF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639852; x=1775244652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kTEZ8G0K2uJjezFm/TO5VfHbEE9noX99ahkzaPJskNY=; b=J7hlYO7BuipxGp7UbNxSgs3k+fXwo0eII1pfK8U91lBYlPnUIG26wRSmA47G2bvD62 TkaaG2xYC9JxjTh3PKQI95x3t45sm6b6jedpRa3EElJKFAbTVfhH+KnKgrcPNDGvLNs/ 2ATVthRkoIyPFRe4FpVifIRQPBZp1OICXeN1yZn+kxRUaE+VtkW8W6NXdC23wRXibI2o 9eCUgXG+S2+CEzc/fpEV7eMp7Qp45q3U1pCj0ACBsRrLK5YKN3QFv6OvFXbAYFGibDEK FuSFaJDQsE54zwW8UErTpoGe314oJEQwuspKvo+J+gcXWDz8P/dN4cG7K4EWPLBjucE/ HqUg== X-Forwarded-Encrypted: i=1; AJvYcCW6XFruHs+mno+wPKzn1iYj4WypPnU61NXj+59nY708h/qunCjPeY+xRLq5JvMC+LEXQEEc9BQ7L5RVLx8=@vger.kernel.org X-Gm-Message-State: AOJu0YxEa7au6dKy3/aZoai+W4IQlylxSRNb9sWXY8GKw0BppXR9i/a0 g0TFzqnDGouIJJhHXwMpMt4qlXnFhdPo4vgQnXHCIqMhtkqiMbsXofsE X-Gm-Gg: ATEYQzwQQHpo1RSM8p7A0dcWq3Ix7y1zOi99h0PQ5GT3VY0NLcD4eKubOrFhq4xS3pD aBJOEqtwuu7C3NP5vHxV2Oodfgv+/yNBrGJObspnh4Rl4NRyeYllDkIif3G0Cqz+eRXiqdK8xjv OFXyMkHYG02ahfBQJUl6FC8GZ9VRtJouH8/s0McR0K/6l4VDEOwBGlwZqwyjEiIsXFPx+J+qqg/ DnTJP909HcwAdhdF9kAMLZ4fYOdzdBZFP5lidJfWT33jr65ypMeRykXCRlF8Hcl1OYRIAAFthr/ S53NpjiVJyuzOv9RlVcAj3xUPw+6x02BJmqP5zjRD+AzHf1KoYnr8Jcj2D4JxQTSuffNqjghWX+ IZLO6ycFf6uSxCzhAfRHNciKI7/YTdx+a26urH3uJXFyORs/doQuGL9ZWNgaUXLEdUHZja8fDie HbE9msAlXgiGLv8rFEDzPAVDDvHOlE3gt3+3O8dZnHkw== X-Received: by 2002:a05:6a00:c82:b0:827:2ed6:888f with SMTP id d2e1a72fcca58-82c96035be6mr3435922b3a.54.1774639852029; Fri, 27 Mar 2026 12:30:52 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm25136b3a.20.2026.03.27.12.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:30:51 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control Date: Fri, 27 Mar 2026 15:30:02 -0400 Message-ID: <20260327193002.423897-4-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327193002.423897-1-aravindanilraj0702@gmail.com> References: <20260327193002.423897-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj If snd_soc_dai_set_pll() or snd_soc_dai_set_sysclk() fail inside the EVENT_ON path, the function returns without calling clk_disable_unprepare() on ctx->mclk, which was already enabled earlier in the same code path. Add the missing clk_disable_unprepare() calls before returning the error. Signed-off-by: Aravind Anilraj --- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/cht_bsw_rt5672.c b/sound/soc/intel/boar= ds/cht_bsw_rt5672.c index 359723f2700e..e5806dc16ff9 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5672.c +++ b/sound/soc/intel/boards/cht_bsw_rt5672.c @@ -67,7 +67,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, ret =3D clk_prepare_enable(ctx->mclk); if (ret < 0) { dev_err(card->dev, - "could not configure MCLK state"); + "could not configure MCLK state\n"); return ret; } } @@ -77,6 +77,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, CHT_PLAT_CLK_3_HZ, 48000 * 512); if (ret < 0) { dev_err(card->dev, "can't set codec pll: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } =20 @@ -85,6 +86,7 @@ static int platform_clock_control(struct snd_soc_dapm_wid= get *w, 48000 * 512, SND_SOC_CLOCK_IN); if (ret < 0) { dev_err(card->dev, "can't set codec sysclk: %d\n", ret); + clk_disable_unprepare(ctx->mclk); return ret; } } else { --=20 2.47.3