From nobody Thu Apr 2 17:16:41 2026 Received: from spark.kcore.it (spark.kcore.it [49.13.27.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D0D3624C2; Fri, 27 Mar 2026 18:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.13.27.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774635038; cv=none; b=YluyFLFXRWZXzlCYzsdjoVq4qDIG5OS3XBebPILuxndxogy2jvaw8mm9vP+WNnQ+5V50Q2c8vGDzk/EoAPSpzSfIO7n04cpgf7GF1lKEAdLhbpMQLVmQbw4jex8JbVn7NGkkJ+bcZM/kDmj+sUaI2ftwEK09d2Y+D2+MUDnTGjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774635038; c=relaxed/simple; bh=GPBmiZS7ve18pxlg6BxIAXv/Vv66+opA+KYdFpG0Hlc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NrPgVCcRO4/ubHxi/HIjikMnaa22vGQ1qV9c+QwXQcjjRVtiKxfhu3fvdJW23Xqn13OQJBW2OC8oSOPKx6CNbsSwRxWIMTL3ymqwrhShpSyrHVJuzqbQaIJiiwR3m0DyvXQ0XdzKQjvTVkGvG/nYMrB5NbdFdT6/wMAWGsM/PfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it; spf=pass smtp.mailfrom=kcore.it; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b=i2aDwtmd; arc=none smtp.client-ip=49.13.27.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kcore.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b="i2aDwtmd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kcore.it; s=spark; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QGC7ldH3ILLghnQtQzgtvz8BDZPw0m49fZl+qO4/4kM=; b=i2aDwtmd7m6eqTDez1hg90gh7w pxLWt61xIRBewPK4qHEeh3+MFKgSztJOKL2cQPw+FAnvGcoQHRihdWQbZfHz8/dzWbcsso2KQ/Bh1 cwDmlVESHlMKiJk0W5CBCOhHRhCPYGJyvL1nj6O4YQDauuZ8a3jCLUwUB8d/8V2DVQMw=; Received: from mnencia by spark.kcore.it with local (Exim 4.96) (envelope-from ) id 1w6Bdf-006FSD-2Z; Fri, 27 Mar 2026 19:10:31 +0100 From: Marco Nenciarini To: Daniel Scally , Sakari Ailus , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Nenciarini Subject: [PATCH v5 2/4] platform/x86: int3472: Rename pled to led in LED registration code Date: Fri, 27 Mar 2026 19:10:29 +0100 Message-Id: <20260327181031.1489365-3-mnencia@kcore.it> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260327181031.1489365-1-mnencia@kcore.it> References: <20260327181031.1489365-1-mnencia@kcore.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the privacy LED functions, struct type and member from pled/int3472_pled/register_pled to led/int3472_led/register_led to prepare for supporting additional LED types (e.g. strobe/IR flood). No functional change. Signed-off-by: Marco Nenciarini --- Cc: Andy Shevchenko drivers/platform/x86/intel/int3472/discrete.c | 4 +- drivers/platform/x86/intel/int3472/led.c | 48 +++++++++---------- include/linux/platform_data/x86/int3472.h | 8 ++-- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platfo= rm/x86/intel/int3472/discrete.c index 1505fc3..cb24763 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -348,7 +348,7 @@ static int skl_int3472_handle_gpio_resources(struct acp= i_resource *ares, =20 break; case INT3472_GPIO_TYPE_PRIVACY_LED: - ret =3D skl_int3472_register_pled(int3472, gpio); + ret =3D skl_int3472_register_led(int3472, gpio); if (ret) err_msg =3D "Failed to register LED\n"; =20 @@ -422,7 +422,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_d= evice *int3472) gpiod_remove_lookup_table(&int3472->gpios); =20 skl_int3472_unregister_clock(int3472); - skl_int3472_unregister_pled(int3472); + skl_int3472_unregister_led(int3472); skl_int3472_unregister_regulator(int3472); } EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE"); diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x8= 6/intel/int3472/led.c index 4c52f99..8e92e8e 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -6,57 +6,57 @@ #include #include =20 -static int int3472_pled_set(struct led_classdev *led_cdev, - enum led_brightness brightness) +static int int3472_led_set(struct led_classdev *led_cdev, + enum led_brightness brightness) { - struct int3472_pled *pled =3D container_of(led_cdev, struct int3472_pled,= classdev); + struct int3472_led *led =3D container_of(led_cdev, struct int3472_led, cl= assdev); =20 - gpiod_set_value_cansleep(pled->gpio, brightness); + gpiod_set_value_cansleep(led->gpio, brightness); return 0; } =20 -int skl_int3472_register_pled(struct int3472_discrete_device *int3472, str= uct gpio_desc *gpio) +int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio) { - struct int3472_pled *pled =3D &int3472->pled; + struct int3472_led *led =3D &int3472->led; char *p; int ret; =20 - if (pled->classdev.dev) + if (led->classdev.dev) return -EBUSY; =20 - pled->gpio =3D gpio; + led->gpio =3D gpio; =20 /* Generate the name, replacing the ':' in the ACPI devname with '_' */ - snprintf(pled->name, sizeof(pled->name), + snprintf(led->name, sizeof(led->name), "%s::privacy_led", acpi_dev_name(int3472->sensor)); - p =3D strchr(pled->name, ':'); + p =3D strchr(led->name, ':'); if (p) *p =3D '_'; =20 - pled->classdev.name =3D pled->name; - pled->classdev.max_brightness =3D 1; - pled->classdev.brightness_set_blocking =3D int3472_pled_set; + led->classdev.name =3D led->name; + led->classdev.max_brightness =3D 1; + led->classdev.brightness_set_blocking =3D int3472_led_set; =20 - ret =3D led_classdev_register(int3472->dev, &pled->classdev); + ret =3D led_classdev_register(int3472->dev, &led->classdev); if (ret) return ret; =20 - pled->lookup.provider =3D pled->name; - pled->lookup.dev_id =3D int3472->sensor_name; - pled->lookup.con_id =3D "privacy"; - led_add_lookup(&pled->lookup); + led->lookup.provider =3D led->name; + led->lookup.dev_id =3D int3472->sensor_name; + led->lookup.con_id =3D "privacy"; + led_add_lookup(&led->lookup); =20 return 0; } =20 -void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472) +void skl_int3472_unregister_led(struct int3472_discrete_device *int3472) { - struct int3472_pled *pled =3D &int3472->pled; + struct int3472_led *led =3D &int3472->led; =20 - if (IS_ERR_OR_NULL(pled->classdev.dev)) + if (IS_ERR_OR_NULL(led->classdev.dev)) return; =20 - led_remove_lookup(&pled->lookup); - led_classdev_unregister(&pled->classdev); - gpiod_put(pled->gpio); + led_remove_lookup(&led->lookup); + led_classdev_unregister(&led->classdev); + gpiod_put(led->gpio); } diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/plat= form_data/x86/int3472.h index b1b8375..7af6731 100644 --- a/include/linux/platform_data/x86/int3472.h +++ b/include/linux/platform_data/x86/int3472.h @@ -121,12 +121,12 @@ struct int3472_discrete_device { u8 imgclk_index; } clock; =20 - struct int3472_pled { + struct int3472_led { struct led_classdev classdev; struct led_lookup_data lookup; char name[INT3472_LED_MAX_NAME_LEN]; struct gpio_desc *gpio; - } pled; + } led; =20 struct int3472_discrete_quirks quirks; =20 @@ -160,7 +160,7 @@ int skl_int3472_register_regulator(struct int3472_discr= ete_device *int3472, const char *second_sensor); void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3= 472); =20 -int skl_int3472_register_pled(struct int3472_discrete_device *int3472, str= uct gpio_desc *gpio); -void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472); +int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio); +void skl_int3472_unregister_led(struct int3472_discrete_device *int3472); =20 #endif --=20 2.47.3