From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4B22D7DC4; Fri, 27 Mar 2026 18:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634771; cv=none; b=MNTosP00n5kcTHKeXC61gj98YJ5HPdKgTasMu+M30g8z7nF7RBRD8zZW76KF2hEyV/EgcTj0zMUicgFOU9ao4fi3ba0J5WCK8MR7Em555ikaeuO4hd5Gecpw8WlrPdJdWD4Ek4L21H0JcycbhB/aQRfwUdf7tL7KTkVGasXTwRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634771; c=relaxed/simple; bh=ExYu4MocTJ/m1GTF+9uD6AaFYfgRkiFOMtaD+oQsvJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Up+OyCCJYxRxWEw7E8yi3WhONYqr/R3bZgJifO6DR8XUsk7pHMH53cvSPnsn7twNINqv11YcN/qfT5q87zV12esa1DTnR2NTSf+DMBIPQQymU4DDa0R/TS1Rhvboq/wy4jor1eAjAPi6FUnNMIPSbDEpOOgdARrzOaVbBHTbZcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rK8ANFM4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rK8ANFM4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EB19C19424; Fri, 27 Mar 2026 18:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634770; bh=ExYu4MocTJ/m1GTF+9uD6AaFYfgRkiFOMtaD+oQsvJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rK8ANFM4BAL1hIC9sfKsJYzdwehNcOzQwqOMlalkfUfOIXWFry+LU0YGXCGaxOY3u X44QjXE9SH3Mjg7RhVZ2o2P0qQfdTrNKl2hfdMRMNwSvjcCGGakOe6uir5CBdr0xnK zWcVKB3G5/MEho8UFNtdmtwsvkyaXNQki52Ut3AvGYC0y+8c7OSjFSjWlH2VqODF93 10KWWpL0yDLRu3N7trRaVbN1uylhI8qc46grthBUg693owEBaLQWvKHKj0ZTvQK+Ri hu0m0bmyiusF+Sdo2sw/Qgd2SY3kVhZRlHdIalsYRIbk23k2NfVf23jRaBe8I9P6zV wL7ezdmXggvTA== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org, Daniel Lezcano , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bryan O'Donoghue , Rob Herring , Greg Kroah-Hartman , Arnd Bergmann , Stephen Boyd , linux-arch@vger.kernel.org (open list:GENERIC INCLUDE/ASM HEADER FILES) Subject: [PATCH resend v1 1/7] clocksource/drivers/timer-probe: Create a platform_device before the framework is initialized Date: Fri, 27 Mar 2026 19:05:53 +0100 Message-ID: <20260327180600.8150-2-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Daniel Lezcano In the context of the time keeping and the timers, some platforms have timers which need to be initialized very early. It is the case of the ARM platform which do not have the architected timers. The macro TIMER_OF_DECLARE adds an entry in the timer init functions array at compile time and the function timer_probe is called from the timer_init() function in kernel/time.c This array contains a tuple with the init function and the compatible string. The init function has a device node pointer parameter. The timer_probe() function browses the of nodes and find the ones matching the compatible string given when using the TIMER_OF_DECLARE macro. It then calls the init function with the device node as a pointer. But there are some platforms where there are multiple timers like the ARM64 with the architected timers. Those are always initialized very early and the other timers can be initialized later. For this reason we find timer drivers with the platform_driver incarnation. Consequently their init functions are different, they have a platform_device pointer parameter and rely on the devm_ function for rollbacking. To summarize, we have: - TIMER_OF_DECLARE with init function prototype: int (*init)(struct device_node *np); - module_platform_driver (and variant) with the probe function prototype: int (*init)(struct platform_device *pdev); The current situation with the timers is the following: - Two platforms can have the same timer hardware, hence the same driver but one without alternate timers and the other with multiple timers. For example, the Exynos platform has only the Exynos MCT on ARM but has the architeched timers in addition on the ARM64. - The timer drivers can be modules now which was not the case until recently. TIMER_OF_DECLARE do not allow the build as a module. It results in duplicate init functions (one with rollback and one with devm_) and different way to declare the driver (TIMER_OF_DECLARE and module_platform_driver). This proposed change is to unify the prototyping of the init functions to receive a platform_device pointer as parameter. Consequently, it will allow a smoother and nicer module conversion and a huge cleanup of the init functions by removing all the rollback code from all the timer drivers. It introduces a TIMER_PDEV_DECLARE() macro. If the macro is used a platform_device is manually allocated and initialized with the needed information for the probe function. Otherwise module_platform_driver can be use instead with the same probe function without the timer_probe() initialization. The plan is to have all timers to use TIMER_PDEV_DECLARE with all the init functions optimized and then remove the TIMER_OF_DECLARE macro. Signed-off-by: Daniel Lezcano Cc: Hans de Goede Cc: Ilpo J=C3=A4rvinen Cc: Bryan O'Donoghue Cc: Rob Herring Cc: Greg Kroah-Hartman --- drivers/clocksource/timer-probe.c | 66 +++++++++++++++++++++++++++++-- include/asm-generic/vmlinux.lds.h | 10 +++++ include/linux/clocksource.h | 21 ++++++++++ 3 files changed, 93 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-= probe.c index b7860bc0db4b..cdaceb68d356 100644 --- a/drivers/clocksource/timer-probe.c +++ b/drivers/clocksource/timer-probe.c @@ -7,13 +7,11 @@ #include #include #include +#include =20 extern struct of_device_id __timer_of_table[]; =20 -static const struct of_device_id __timer_of_table_sentinel - __used __section("__timer_of_table_end"); - -void __init timer_probe(void) +static int __init timer_of_probe(void) { struct device_node *np; const struct of_device_id *match; @@ -38,6 +36,66 @@ void __init timer_probe(void) timers++; } =20 + return timers; +} + +static int __init __timer_pdev_probe(struct platform_driver *drv) +{ + struct device_node *np; + struct platform_device *pdev; + const struct of_device_id *match; + unsigned int timers =3D 0; + int ret; + + for_each_matching_node_and_match(np, drv->driver.of_match_table, &match) { + if (!of_device_is_available(np)) + continue; + + pdev =3D platform_device_alloc(of_node_full_name(np), -1); + if (!pdev) + continue; + + ret =3D device_add_of_node(&pdev->dev, np); + if (ret) { + platform_device_put(pdev); + continue; + } + + dev_set_name(&pdev->dev, pdev->name); + + ret =3D drv->probe(pdev); + if (!ret) { + timers++; + continue; + } + + if (ret !=3D -EPROBE_DEFER) + pr_err("Failed to initialize '%pOF': %d\n", np, ret); + + device_remove_of_node(&pdev->dev); + + platform_device_put(pdev); + } + + return timers; +} + +static int __init timer_pdev_probe(void) +{ + struct platform_driver **drv; + + for_each_pdev_timer_table(drv) + __timer_pdev_probe(*drv); + + return 0; +} + +void __init timer_probe(void) +{ + unsigned timers =3D 0; + + timers +=3D timer_of_probe(); + timers +=3D timer_pdev_probe(); timers +=3D acpi_probe_device_table(timer); =20 if (!timers) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinu= x.lds.h index eeb070f330bd..5d619e831dce 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -359,6 +359,15 @@ #define THERMAL_TABLE(name) #endif =20 +#ifdef CONFIG_TIMER_OF +#define TIMER_TABLE(name) \ + . =3D ALIGN(8); \ + BOUNDED_SECTION_POST_LABEL(__##name##_timer_table, \ + __##name##_timer_table,, _end) +#else +#define TIMER_TABLE(name) +#endif + #define KERNEL_DTB() \ STRUCT_ALIGN(); \ __dtb_start =3D .; \ @@ -738,6 +747,7 @@ ACPI_PROBE_TABLE(irqchip) \ ACPI_PROBE_TABLE(timer) \ THERMAL_TABLE(governor) \ + TIMER_TABLE(pdev) \ EARLYCON_TABLE() \ LSM_TABLE() \ EARLY_LSM_TABLE() \ diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 65b7c41471c3..6e05b78e64b8 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -18,6 +18,7 @@ #include #include #include +#include #include #include =20 @@ -295,6 +296,26 @@ extern void timer_probe(void); static inline void timer_probe(void) {} #endif =20 +extern struct platform_driver *__pdev_timer_table[]; +extern struct platform_driver *__pdev_timer_table_end[]; + +#define TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) \ + static struct platform_driver __pdev_timer_table_entry_##__name =3D { \ + .probe =3D __probe, \ + .remove =3D __remove, \ + .driver =3D { \ + .name =3D #__name, \ + .of_match_table =3D __match \ + }, \ + }; \ + static struct platform_driver *___pdev_timer_table_entry_##__name \ + __used __section("__pdev_timer_table") =3D &__pdev_timer_table_entry_##__= name + +#define for_each_pdev_timer_table(__pdev) \ + for (__pdev =3D __pdev_timer_table; \ + __pdev < __pdev_timer_table_end; \ + __pdev++) + #define TIMER_ACPI_DECLARE(name, table_id, fn) \ ACPI_DECLARE_PROBE_ENTRY(timer, name, table_id, 0, NULL, 0, fn) =20 --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E1F340293 for ; Fri, 27 Mar 2026 18:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634772; cv=none; b=U5KIL4BLKfaIoPlOZiiROedIzIcmhrmfR0SrG4Z0DaBz6s95f19OmxnMNZJZaVM7ejUXNMfPrH8d9cxfaB58jeLW5oyIpkve1YaJl47Pk4YnhfBw3ut+znjuWh984P3BGlJmAtzf8fJZYUjVzUx4MIRWwdvOcNrm7xUFsWU7CFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634772; c=relaxed/simple; bh=m63W0gv+X0rmLX4ADUZdodixmhiFM20HW0wib0b4iYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hDnMyaZiVRPjQZp1RVWO7mDnLW/EItLJYSVdrrrRa1aGOVkNU7cWzjUw6OUKeQGadOx1zwdARalTrHOBS1DYOYMqKdqV259Fx/QnIOk68qpb1ahVS9twUQMvcXvdbrIuaGqs5MjUPiE+ugh6OF0Se9HNIarXBz9jXJEGWkWOhmA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MLxK2LsJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MLxK2LsJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E968C19423; Fri, 27 Mar 2026 18:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634772; bh=m63W0gv+X0rmLX4ADUZdodixmhiFM20HW0wib0b4iYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MLxK2LsJdsyhCmqAyR14zyspOy1W90SM55/YrXc4M1SD2TAG1Ut1iFa4d3aHY9DF5 PdtInzO52aym1MnojBXK9iNJFYX1cIANJcHDyGh5WGfSx3uu3IkaqbV1+wOrxEYT9s 6D6l9d6JtZMutc4SjUZVKpSRZcBWeVcx03GjAq4cJI8/8WsKpE3VIOGD3hJvqVdusu omUtQpnO3/v3ikMdCNEr7kxoQg7VVRz5KhD6ZlFT5Q1+I167ZP6cBkeZGyEmPMaqxE Bk9v5IMqb97rHmmubxt8L7VVP4d3LUB00hbb7RZ64QDNeM6v1ysGp0cs2/4z6TxqQX V6KxrtWgnrN1Q== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org Subject: [PATCH resend v1 2/7] clocksource/drivers/mmio: Make the code compatible with modules Date: Fri, 27 Mar 2026 19:05:54 +0100 Message-ID: <20260327180600.8150-3-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The next changes will bring the module support on the timer drivers. Those use the API exported by the mmio clocksource which are not exporting their symbols. Fix that by adding EXPORT_SYMBOL_GPL(). Signed-off-by: Daniel Lezcano Acked-by: John Stultz --- drivers/clocksource/mmio.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c index cd5fbf49ac29..0fee8edb837a 100644 --- a/drivers/clocksource/mmio.c +++ b/drivers/clocksource/mmio.c @@ -21,21 +21,25 @@ u64 clocksource_mmio_readl_up(struct clocksource *c) { return (u64)readl_relaxed(to_mmio_clksrc(c)->reg); } +EXPORT_SYMBOL_GPL(clocksource_mmio_readl_up); =20 u64 clocksource_mmio_readl_down(struct clocksource *c) { return ~(u64)readl_relaxed(to_mmio_clksrc(c)->reg) & c->mask; } +EXPORT_SYMBOL_GPL(clocksource_mmio_readl_down); =20 u64 clocksource_mmio_readw_up(struct clocksource *c) { return (u64)readw_relaxed(to_mmio_clksrc(c)->reg); } +EXPORT_SYMBOL_GPL(clocksource_mmio_readw_up); =20 u64 clocksource_mmio_readw_down(struct clocksource *c) { return ~(u64)readw_relaxed(to_mmio_clksrc(c)->reg) & c->mask; } +EXPORT_SYMBOL_GPL(clocksource_mmio_readw_down); =20 /** * clocksource_mmio_init - Initialize a simple mmio based clocksource @@ -46,9 +50,9 @@ u64 clocksource_mmio_readw_down(struct clocksource *c) * @bits: Number of valid bits * @read: One of clocksource_mmio_read*() above */ -int __init clocksource_mmio_init(void __iomem *base, const char *name, - unsigned long hz, int rating, unsigned bits, - u64 (*read)(struct clocksource *)) +int clocksource_mmio_init(void __iomem *base, const char *name, + unsigned long hz, int rating, unsigned bits, + u64 (*read)(struct clocksource *)) { struct clocksource_mmio *cs; =20 @@ -68,3 +72,4 @@ int __init clocksource_mmio_init(void __iomem *base, cons= t char *name, =20 return clocksource_register_hz(&cs->clksrc, hz); } +EXPORT_SYMBOL_GPL(clocksource_mmio_init); --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65C232BF41 for ; Fri, 27 Mar 2026 18:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634775; cv=none; b=nU+FEa57nj4JE5O6+z4reiD+X5rlB0UNvJ1/I3UVYp8ByyJvNRpcYJLRmfBItNt/UZ8rUrVeG6AHjJrx6D0Fj/BMGXPSnvFza31wbPCpP3+Ste4kgtQDutX+OLeDxeyE5+Q6BN7KJGu720DKlmc/NDATnvtj3v2AVgZbxXDUID8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634775; c=relaxed/simple; bh=Z2BA3YqAghsU/JejqCzKkjwpMzA7NGZMhKsDjlTJIog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mtydpdsbvGu4t9IuAMPassrw+ySH9+kNTIgiesuLLgwUO76sSyhEcQ07+I+ZIxDLiAQOjFraPkQFuBMgLLbQewcupzYpFPr+ZSEETcdKWf3bua7eMATYwkSZImml08hbIfdTiDe4XRp5exglWlRO50NZm/kx8LvkPff80dISxF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d4TH3XHD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d4TH3XHD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0891CC2BCB3; Fri, 27 Mar 2026 18:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634774; bh=Z2BA3YqAghsU/JejqCzKkjwpMzA7NGZMhKsDjlTJIog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d4TH3XHDOFxdnCuF2SF9KuW1in99lLc08PMgVZs2oaVOC0Ksm+kwoW+P6yXLfoasg uXnAuqpnzYoVrj9BvVChxBtBsttauS9OIqC34GjDSGCPJfenkbcS4sSOuB+GpIgmwg Oz37NeCUJswxv1WLymCkYFOP/bhhY8gkqpLG9j4FzaZEiqsHaDvFnPnK77u0LfEHyq yYKiQPt7AsG5mcQ8uKoTkiKSmZ7VPi3ewUY0T7POlMU7RGmD0/mQoeox+6wIiY8nKQ eV6vmEOfAwFVD6bMIYTIDB6gSg3ILulbNKnIjduXVFxr2WlgzpEa/nZ7R1/u9N3QZO 2o0vJsm5OT8eg== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org Subject: [PATCH resend v1 3/7] clocksource/drivers/timer-of: Make the code compatible with modules Date: Fri, 27 Mar 2026 19:05:55 +0100 Message-ID: <20260327180600.8150-4-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-of.c | 24 +++++++++++++----------- drivers/clocksource/timer-of.h | 5 ++--- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c index 420202bf76e4..ba63433211b0 100644 --- a/drivers/clocksource/timer-of.c +++ b/drivers/clocksource/timer-of.c @@ -19,7 +19,7 @@ * * Free the irq resource */ -static __init void timer_of_irq_exit(struct of_timer_irq *of_irq) +static void timer_of_irq_exit(struct of_timer_irq *of_irq) { struct timer_of *to =3D container_of(of_irq, struct timer_of, of_irq); =20 @@ -41,8 +41,8 @@ static __init void timer_of_irq_exit(struct of_timer_irq = *of_irq) * * Returns 0 on success, < 0 otherwise */ -static __init int timer_of_irq_init(struct device_node *np, - struct of_timer_irq *of_irq) +static int timer_of_irq_init(struct device_node *np, + struct of_timer_irq *of_irq) { int ret; struct timer_of *to =3D container_of(of_irq, struct timer_of, of_irq); @@ -82,7 +82,7 @@ static __init int timer_of_irq_init(struct device_node *n= p, * * Disables and releases the refcount on the clk */ -static __init void timer_of_clk_exit(struct of_timer_clk *of_clk) +static void timer_of_clk_exit(struct of_timer_clk *of_clk) { of_clk->rate =3D 0; clk_disable_unprepare(of_clk->clk); @@ -98,8 +98,8 @@ static __init void timer_of_clk_exit(struct of_timer_clk = *of_clk) * * Returns 0 on success, < 0 otherwise */ -static __init int timer_of_clk_init(struct device_node *np, - struct of_timer_clk *of_clk) +static int timer_of_clk_init(struct device_node *np, + struct of_timer_clk *of_clk) { int ret; =20 @@ -137,13 +137,13 @@ static __init int timer_of_clk_init(struct device_nod= e *np, goto out; } =20 -static __init void timer_of_base_exit(struct of_timer_base *of_base) +static void timer_of_base_exit(struct of_timer_base *of_base) { iounmap(of_base->base); } =20 -static __init int timer_of_base_init(struct device_node *np, - struct of_timer_base *of_base) +static int timer_of_base_init(struct device_node *np, + struct of_timer_base *of_base) { of_base->base =3D of_base->name ? of_io_request_and_map(np, of_base->index, of_base->name) : @@ -156,7 +156,7 @@ static __init int timer_of_base_init(struct device_node= *np, return 0; } =20 -int __init timer_of_init(struct device_node *np, struct timer_of *to) +int timer_of_init(struct device_node *np, struct timer_of *to) { int ret =3D -EINVAL; int flags =3D 0; @@ -200,6 +200,7 @@ int __init timer_of_init(struct device_node *np, struct= timer_of *to) timer_of_base_exit(&to->of_base); return ret; } +EXPORT_SYMBOL_GPL(timer_of_init); =20 /** * timer_of_cleanup - release timer_of resources @@ -208,7 +209,7 @@ int __init timer_of_init(struct device_node *np, struct= timer_of *to) * Release the resources that has been used in timer_of_init(). * This function should be called in init error cases */ -void __init timer_of_cleanup(struct timer_of *to) +void timer_of_cleanup(struct timer_of *to) { if (to->flags & TIMER_OF_IRQ) timer_of_irq_exit(&to->of_irq); @@ -219,3 +220,4 @@ void __init timer_of_cleanup(struct timer_of *to) if (to->flags & TIMER_OF_BASE) timer_of_base_exit(&to->of_base); } +EXPORT_SYMBOL_GPL(timer_of_cleanup); diff --git a/drivers/clocksource/timer-of.h b/drivers/clocksource/timer-of.h index 01a2c6b7db06..74a632b85b47 100644 --- a/drivers/clocksource/timer-of.h +++ b/drivers/clocksource/timer-of.h @@ -65,9 +65,8 @@ static inline unsigned long timer_of_period(struct timer_= of *to) return to->of_clk.period; } =20 -extern int __init timer_of_init(struct device_node *np, - struct timer_of *to); +int timer_of_init(struct device_node *np, struct timer_of *to); =20 -extern void __init timer_of_cleanup(struct timer_of *to); +void timer_of_cleanup(struct timer_of *to); =20 #endif --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0AC3F54CC for ; Fri, 27 Mar 2026 18:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634776; cv=none; b=hhJU0lOLiqQz3GfGCo4/TED6VZzRlZJRkLt7uFyWGFESYuH9+9QUHwnEt4xOqQ7z4YlTwN45MvPJy1SpqbpvBiku1f3TrKmfMKNEjQ0SVtMYRwQgLj/sPdnpeaKtNPHwkQ71KxzVckgQFc+RTLytJx3FVL7kZzVm3/35/NSitrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634776; c=relaxed/simple; bh=97lDUidSE9o63Ge6U3LwrVURpGigQQLUwAM/FVrascc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KjhvYbu7P0PIQajTfdZuS97buP/1gN+MkQFVxxbvYdiZbZZXWKcWeJb6nhTH5PoAD66oqrBs91l5/ounTwUYwZ0tXwUa2JbwE+/G0wVvFcotNbxLAC8C7JcgjsIF1IlrIjD92lSDVOoIWslVVEAhkya9CjnHSgV7zncorF1PSkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DgBKR2eD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DgBKR2eD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC542C19424; Fri, 27 Mar 2026 18:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634776; bh=97lDUidSE9o63Ge6U3LwrVURpGigQQLUwAM/FVrascc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DgBKR2eD4oUMDeDvC2Bvy5r/zEx0EqN7DPF027z4/YKh3OJHDcqu1ZVJcwVXvNjJ+ REJyPBKXJJ6RZjvzbYxFCLTN3ljcEiZh3Cz8eM6Jrdi+/vn69AkuLcePtgiHsWMwGm 0t974SkoD81WlBCGhQ/pRD1g5uB25PuoJVf5BQXQ+5p2A9GG6Zk0TSGQm3O2uRujtM uTb+/SoRmQtZJ0YYAIRr+mH2cdYwh/kHE7yiGegMIelvRr5OaRzg1Eib8a6GmFk3+o lVtRsqpjxUr2c84iBFDjM2EQw0V/JwnkkgGnWZ/i2SRXtZ6NpG+G5rHB1zwmhk3aIi hTSLMqymoCNMQ== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org, Stephen Boyd Subject: [PATCH resend v1 4/7] clocksource/drivers/timer-probe: Add the module support for the TIMER_PDEV_DECLARE() macro Date: Fri, 27 Mar 2026 19:05:56 +0100 Message-ID: <20260327180600.8150-5-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A driver using the macro TIMER_PDEV_DECLARE can now be compiled as a module. When it is the case the TIMER_PDEV_DECLARE() macro will add module_platform_driver() and MODULE_DEVICE_TABLE() automatically. However if the early timer initialization is needed in place of the module init section like what we have now, we should enable CONFIG_EARLY_TIMER. When all drivers will be converted to TIMER_PDEV_DECLARE(), the TIMER_OF_DECLARE() can be removed and we will end up with the following configuration: * On ARM architecture, we enable automatically CONFIG_EARLY_TIMER, no timer can be compiled as a module * On ARM64 architecture, we can enable as a module, otherwise it will be compiled-in. The CONFIG_EARLY_TIMER is not needed on this arch because the architected timers are always present * On other architecture, that needs to be defined but I suspect we have the same scheme Signed-off-by: Daniel Lezcano --- drivers/clocksource/Kconfig | 7 ++++++- drivers/clocksource/timer-probe.c | 3 +++ include/linux/clocksource.h | 12 +++++++++++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index fd9112706545..ee2372f21e78 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -2,6 +2,11 @@ menu "Clock Source drivers" depends on GENERIC_CLOCKEVENTS =20 +config EARLY_TIMER + bool "Early driver initialization" + help + Enables early timer driver loading + config TIMER_OF bool select TIMER_PROBE @@ -100,7 +105,7 @@ config IXP4XX_TIMER Enables support for the Intel XScale IXP4xx SoC timer. =20 config ROCKCHIP_TIMER - bool "Rockchip timer driver" if COMPILE_TEST + bool "Rockchip timer driver" if COMPILE_TEST depends on ARM || ARM64 select TIMER_OF select CLKSRC_MMIO diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-= probe.c index cdaceb68d356..0fc582e4afde 100644 --- a/drivers/clocksource/timer-probe.c +++ b/drivers/clocksource/timer-probe.c @@ -84,6 +84,9 @@ static int __init timer_pdev_probe(void) { struct platform_driver **drv; =20 + if (!IS_ENABLED(CONFIG_EARLY_TIMER)) + return 0; + for_each_pdev_timer_table(drv) __timer_pdev_probe(*drv); =20 diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 6e05b78e64b8..6b09fe67d37f 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -299,7 +299,7 @@ static inline void timer_probe(void) {} extern struct platform_driver *__pdev_timer_table[]; extern struct platform_driver *__pdev_timer_table_end[]; =20 -#define TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) \ +#define __TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) \ static struct platform_driver __pdev_timer_table_entry_##__name =3D { \ .probe =3D __probe, \ .remove =3D __remove, \ @@ -311,6 +311,16 @@ extern struct platform_driver *__pdev_timer_table_end[= ]; static struct platform_driver *___pdev_timer_table_entry_##__name \ __used __section("__pdev_timer_table") =3D &__pdev_timer_table_entry_##__= name =20 +#if !defined(CONFIG_EARLY_TIMER) || defined(MODULE) +#define TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) \ + MODULE_DEVICE_TABLE(of, __match); \ + __TIMER_PDEV_DECLARE(__name, __probe, __remove, __match); \ + module_platform_driver(__pdev_timer_table_entry_##__name); +#else +#define TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) \ + __TIMER_PDEV_DECLARE(__name, __probe, __remove, __match) +#endif + #define for_each_pdev_timer_table(__pdev) \ for (__pdev =3D __pdev_timer_table; \ __pdev < __pdev_timer_table_end; \ --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C788A3FE653 for ; Fri, 27 Mar 2026 18:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634778; cv=none; b=ol3wkqMP2mH6O2e+uRf12NqhUSPt54hla4H/ajRi/fnfU9k97bhSrpyIJ42ZYk82fDhZDDX5f2ocvx6kcE0kJEB61eIy+v1LGGCTej+oyVCPS1yCyGuJpiASCLjDsW6ArlMvlp0R/uepIWOiTSUsa6nObzFZNlm04v/wY8sNeUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634778; c=relaxed/simple; bh=NF+8zTAwUcyuWSbqAv5EfRD6h1aQWSDUVa0i+26A4WM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bO47lxC/Q8u8GvWFkTBAHoBwPzg7o5fUcxry4CZrqEHejQrAW50X6Jf6haTyboFXAddaaDsRYBuVPo4Kp+zWvNq+p1av//o9OL2jIQRsXKMmxekddD2/0/Z6Rw5kIQJF/AylPVXV/ESVKPx+IJtojaPbbDMY6A9dUxX0vb4/btQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gvZc/nD9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gvZc/nD9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAC35C19424; Fri, 27 Mar 2026 18:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634778; bh=NF+8zTAwUcyuWSbqAv5EfRD6h1aQWSDUVa0i+26A4WM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gvZc/nD9BrA4qpcVkqOmHYxig1qW4hyPs4RDjioeYgAxOM4RvzT8E2bvR7FosWKhd 6P/5xf245Sk3Fn58PRL1A514YqTS2foc1U8P38QjfjJ4/1meEI8B8YRsDIQYckXT3V NgFTgRUKrNVRhgDcRuAl+uiCNUy+QQ79m7G6w+aHC4I8l3XKOQc8nZiL6U38LJumQx l3wSEdsQuEN51nqKlP8oNgsMNZrfhznWNLPTt7tHD+M7vXvMoGVb0ElmdD11hR85W9 Ho+uJqTXTNkMBlxsWhD6nTqgblEtOX5/doBKTnwQTaBS1lUNvAkphnG6wTKqE4I8Je A/FCt4C6AmxAA== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org, Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: [PATCH resend v1 5/7] clocksource/drivers/rockchip: Use the TIMER_PDEV_DECLARE() macro Date: Fri, 27 Mar 2026 19:05:57 +0100 Message-ID: <20260327180600.8150-6-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The previous changes introduced the TIMER_PDEV_DECLARE() macro which allows to use the platform driver to initialize a timer driver with the benefit of having the devres to rollback automatically in case of error. Use this macro and change the function to rely on the devm_ variants, allowing to cleanup the code. Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-rockchip.c | 99 ++++++++++------------------ 1 file changed, 34 insertions(+), 65 deletions(-) diff --git a/drivers/clocksource/timer-rockchip.c b/drivers/clocksource/tim= er-rockchip.c index 540a16667145..486bbffba464 100644 --- a/drivers/clocksource/timer-rockchip.c +++ b/drivers/clocksource/timer-rockchip.c @@ -124,18 +124,18 @@ static u64 notrace rk_timer_sched_read(void) return ~readl_relaxed(rk_clksrc->base + TIMER_CURRENT_VALUE0); } =20 -static int __init -rk_timer_probe(struct rk_timer *timer, struct device_node *np) +static int rk_timer_init(struct rk_timer *timer, struct device *dev) { + struct device_node *np =3D dev->of_node; struct clk *timer_clk; struct clk *pclk; - int ret =3D -EINVAL, irq; + int irq; u32 ctrl_reg =3D TIMER_CONTROL_REG3288; =20 - timer->base =3D of_iomap(np, 0); - if (!timer->base) { + timer->base =3D devm_of_iomap(dev, np, 0, NULL); + if (IS_ERR(timer->base)) { pr_err("Failed to get base address for '%s'\n", TIMER_NAME); - return -ENXIO; + return PTR_ERR(timer->base); } =20 if (of_device_is_compatible(np, "rockchip,rk3399-timer")) @@ -143,31 +143,17 @@ rk_timer_probe(struct rk_timer *timer, struct device_= node *np) =20 timer->ctrl =3D timer->base + ctrl_reg; =20 - pclk =3D of_clk_get_by_name(np, "pclk"); + pclk =3D devm_clk_get_enabled(dev, "pclk"); if (IS_ERR(pclk)) { - ret =3D PTR_ERR(pclk); pr_err("Failed to get pclk for '%s'\n", TIMER_NAME); - goto out_unmap; - } - - ret =3D clk_prepare_enable(pclk); - if (ret) { - pr_err("Failed to enable pclk for '%s'\n", TIMER_NAME); - goto out_unmap; + return PTR_ERR(pclk); } timer->pclk =3D pclk; =20 - timer_clk =3D of_clk_get_by_name(np, "timer"); + timer_clk =3D devm_clk_get_enabled(dev, "timer"); if (IS_ERR(timer_clk)) { - ret =3D PTR_ERR(timer_clk); pr_err("Failed to get timer clock for '%s'\n", TIMER_NAME); - goto out_timer_clk; - } - - ret =3D clk_prepare_enable(timer_clk); - if (ret) { - pr_err("Failed to enable timer clock\n"); - goto out_timer_clk; + return PTR_ERR(timer_clk); } timer->clk =3D timer_clk; =20 @@ -175,47 +161,32 @@ rk_timer_probe(struct rk_timer *timer, struct device_= node *np) =20 irq =3D irq_of_parse_and_map(np, 0); if (!irq) { - ret =3D -EINVAL; pr_err("Failed to map interrupts for '%s'\n", TIMER_NAME); - goto out_irq; + return -EINVAL; } timer->irq =3D irq; =20 rk_timer_interrupt_clear(timer); rk_timer_disable(timer); - return 0; - -out_irq: - clk_disable_unprepare(timer_clk); -out_timer_clk: - clk_disable_unprepare(pclk); -out_unmap: - iounmap(timer->base); - - return ret; -} =20 -static void __init rk_timer_cleanup(struct rk_timer *timer) -{ - clk_disable_unprepare(timer->clk); - clk_disable_unprepare(timer->pclk); - iounmap(timer->base); + return 0; } =20 -static int __init rk_clkevt_init(struct device_node *np) +static int rk_clkevt_init(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct clock_event_device *ce; int ret =3D -EINVAL; =20 - rk_clkevt =3D kzalloc_obj(struct rk_clkevt); + rk_clkevt =3D devm_kzalloc(dev, sizeof(*rk_clkevt), GFP_KERNEL); if (!rk_clkevt) { ret =3D -ENOMEM; goto out; } =20 - ret =3D rk_timer_probe(&rk_clkevt->timer, np); + ret =3D rk_timer_init(&rk_clkevt->timer, dev); if (ret) - goto out_probe; + goto out; =20 ce =3D &rk_clkevt->ce; ce->name =3D TIMER_NAME; @@ -233,36 +204,33 @@ static int __init rk_clkevt_init(struct device_node *= np) if (ret) { pr_err("Failed to initialize '%s': %d\n", TIMER_NAME, ret); - goto out_irq; + goto out; } =20 clockevents_config_and_register(&rk_clkevt->ce, rk_clkevt->timer.freq, 1, UINT_MAX); return 0; =20 -out_irq: - rk_timer_cleanup(&rk_clkevt->timer); -out_probe: - kfree(rk_clkevt); out: /* Leave rk_clkevt not NULL to prevent future init */ rk_clkevt =3D ERR_PTR(ret); return ret; } =20 -static int __init rk_clksrc_init(struct device_node *np) +static int rk_clksrc_init(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; int ret =3D -EINVAL; =20 - rk_clksrc =3D kzalloc_obj(struct rk_timer); + rk_clksrc =3D devm_kzalloc(dev, sizeof(*rk_clksrc), GFP_KERNEL); if (!rk_clksrc) { ret =3D -ENOMEM; goto out; } =20 - ret =3D rk_timer_probe(rk_clksrc, np); + ret =3D rk_timer_init(rk_clksrc, dev); if (ret) - goto out_probe; + goto out; =20 rk_timer_update_counter(UINT_MAX, rk_clksrc); rk_timer_enable(rk_clksrc, 0); @@ -272,33 +240,34 @@ static int __init rk_clksrc_init(struct device_node *= np) clocksource_mmio_readl_down); if (ret) { pr_err("Failed to register clocksource\n"); - goto out_clocksource; + goto out; } =20 sched_clock_register(rk_timer_sched_read, 32, rk_clksrc->freq); return 0; =20 -out_clocksource: - rk_timer_cleanup(rk_clksrc); -out_probe: - kfree(rk_clksrc); out: /* Leave rk_clksrc not NULL to prevent future init */ rk_clksrc =3D ERR_PTR(ret); return ret; } =20 -static int __init rk_timer_init(struct device_node *np) +static int rk_timer_probe(struct platform_device *pdev) { if (!rk_clkevt) - return rk_clkevt_init(np); + return rk_clkevt_init(pdev); =20 if (!rk_clksrc) - return rk_clksrc_init(np); + return rk_clksrc_init(pdev); =20 pr_err("Too many timer definitions for '%s'\n", TIMER_NAME); return -EINVAL; } =20 -TIMER_OF_DECLARE(rk3288_timer, "rockchip,rk3288-timer", rk_timer_init); -TIMER_OF_DECLARE(rk3399_timer, "rockchip,rk3399-timer", rk_timer_init); +static const struct of_device_id rk_timer_match_table[] =3D { + { .compatible =3D "rockchip,rk3288-timer" }, + { .compatible =3D "rockchip,rk3399-timer" }, + { /* sentinel */ } +}; + +TIMER_PDEV_DECLARE(rk_timer, rk_timer_probe, NULL, rk_timer_match_table); --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F3233F8C5 for ; Fri, 27 Mar 2026 18:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634781; cv=none; b=AN8gusvNyz55DEyWkuM9iCY3Ibj4TfzsCLp5BeOIhvM1DzM/kih4aKALuzfsM/+XkBgihpoM82Q+PU4XAd5i8eaVTPcA7Ls6o+5+nWqkHzAgLRkfAy/rZF73sNQ4RVMTa1myuTGiSBxZOmq/Sdj4wRXef/UBu+F+mnZOorWkI0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634781; c=relaxed/simple; bh=vEdr7EPXzpO1kaiix0EvAxi+W/Op3ANhnxGGu30cNiw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dquaCtftDXEpA8zf/dCg5kmjg9sLq5TujX4PsKoOxYgmk1G8UnMk4bkqnC84O6emsBbw6T5iVJSW2/W4D1HqdDcG72+qXzNfVaEpXFaCnUsJ9MOfDl5ZyCwJT2XUMtgK4v8LmQJq8y4yuCO5I2yWwRXVQxebrD0cL/cfMGqdvD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kz6FOGk+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kz6FOGk+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF1F9C19423; Fri, 27 Mar 2026 18:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634780; bh=vEdr7EPXzpO1kaiix0EvAxi+W/Op3ANhnxGGu30cNiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kz6FOGk+OERUDmvQU1+cq2Uwi/EiM8UC86DkHBXk7qfGwwB/CawDoMnGy+AC4+L5J Yt5SXRAVbbJpO6escW35Tm6XOKOrUiY06JhhiJED2jQPGfH0GdNtXtgV1+AsbcENCi JHm3z1Y+0jb0TvXREIu9a6txY0iAtdnBC4qHtOWUjzbqsKlYyv8wCYc4hokT4ZDtWP wZChpp+2gQUFDJ7oh/ZmNTGoqzRkSvTVO6uXemmNIqIkny1CRkax6J9fxLOh8pc+ZS q2GM07HdPKiQ7b1B7RoOraULkdQ6PKWIXBBfSjvF1HfwdzbnoX8SuYh1gLQZ6Fm+oL 1ItltE2xgrF5w== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org, Heiko Stuebner , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) Subject: [PATCH resend v1 6/7] clocksource/drivers/rockchip: Add rockchip timer module support Date: Fri, 27 Mar 2026 19:05:58 +0100 Message-ID: <20260327180600.8150-7-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now the TIMER_PDEV_DECLARE() allows the driver to be compiled as a module. Add the MODULE_DESCRIPTION and the MODULE_LICENSE left for the one converting the driver as a module. Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocksource/timer-rockchip.c b/drivers/clocksource/tim= er-rockchip.c index 486bbffba464..61433b295882 100644 --- a/drivers/clocksource/timer-rockchip.c +++ b/drivers/clocksource/timer-rockchip.c @@ -271,3 +271,5 @@ static const struct of_device_id rk_timer_match_table[]= =3D { }; =20 TIMER_PDEV_DECLARE(rk_timer, rk_timer_probe, NULL, rk_timer_match_table); +MODULE_DESCRIPTION("Rockchip timer driver"); +MODULE_LICENSE("GPL"); --=20 2.43.0 From nobody Thu Apr 2 15:35:57 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CB93FFACC for ; Fri, 27 Mar 2026 18:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634783; cv=none; b=ngSx7Xbtxr8L901u/Jx89YNVcMbhk/NCoK8TOIMuw3tQaLt81t3h0RQ6bdDR3mRiwRIvBSnCh+a1Cy+O1VoU5x8Ir+h82WnHhpPSeCUEM1eyO/LCcZOJlz/7iatWdRSCxt8PVEqfNaXmiCvfsucnbtqcB9xFA6cjEi6K3JhSISQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774634783; c=relaxed/simple; bh=SQ5nAKYuYrS/ghYaKZeLV4R3AbXgYqFqYO/0dF0j/aU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gk/n4kW3ISFPav8izzivEsk+M+YRfhpJ7fQscmwZjDMa/In5HmC/TivfUzLKTBK2uF0yeamsng9ZRtE6fI1bRTR5CypHCc40cGSZ5obH4WzcnQHO1NkMj5KXNMmu5U9sekR+wH5mMjMFw733vMp7ZwvD+TbnCu0L0/AMVRvHIlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J62FzuDy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J62FzuDy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A763C19424; Fri, 27 Mar 2026 18:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774634783; bh=SQ5nAKYuYrS/ghYaKZeLV4R3AbXgYqFqYO/0dF0j/aU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J62FzuDyQjAfe2CmByAg/9OicqC2Qhlin0Mt4N0DNcl+PmdXmHgqQx44jcszbDvCj jceQqQMCDX25i6FZgPh+SrGMaqOQqPRgrPhh1+L66qoPe5FiCHF32GZH82wZ4WRo7W gM7OSb3VonUawBh+29f4TWYawkkjGx8RErbrVg9CFPAO9ol794Yxs7BenPI6eaJ7Fa U6gsXTpKIoohcmIOlKtpbozydS7QZZ3JVplEvu/xfmlQO/mA1p50ZXG2NY1Jv0Ai5g Ca342+DpnJSnEDawEFITMl3C94xsRMInfCF3I2tOYS21BEIdudgBHkw4uxYOtneP6j AL22MLxGmQXWw== From: Daniel Lezcano To: daniel.lezcano@kernel.org, tglx@kernel.org, zhipeng.wang_1@nxp.com Cc: shawnguo@kernel.org, jstultz@google.com, linux-kernel@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH resend v1 7/7] clocksource/drivers/mediatek: Convert to module support Date: Fri, 27 Mar 2026 19:05:59 +0100 Message-ID: <20260327180600.8150-8-daniel.lezcano@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327180600.8150-1-daniel.lezcano@kernel.org> References: <20260327180600.8150-1-daniel.lezcano@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now the TIMER_PDEV_DECLARE() allows the driver to be compiled as a module. Add the MODULE_DESCRIPTION and the MODULE_LICENSE left for the one converting the driver as a module. Signed-off-by: Daniel Lezcano --- drivers/clocksource/timer-mediatek.c | 29 ++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/timer-mediatek.c b/drivers/clocksource/tim= er-mediatek.c index 7bcb4a3f26fb..f5de5f397730 100644 --- a/drivers/clocksource/timer-mediatek.c +++ b/drivers/clocksource/timer-mediatek.c @@ -215,8 +215,7 @@ static irqreturn_t mtk_gpt_interrupt(int irq, void *dev= _id) return IRQ_HANDLED; } =20 -static void -__init mtk_gpt_setup(struct timer_of *to, u8 timer, u8 option) +static void mtk_gpt_setup(struct timer_of *to, u8 timer, u8 option) { writel(GPT_CTRL_CLEAR | GPT_CTRL_DISABLE, timer_of_base(to) + GPT_CTRL_REG(timer)); @@ -281,7 +280,7 @@ static struct timer_of to =3D { }, }; =20 -static int __init mtk_syst_init(struct device_node *node) +static int mtk_syst_init(struct device_node *node) { int ret; =20 @@ -302,7 +301,7 @@ static int __init mtk_syst_init(struct device_node *nod= e) return 0; } =20 -static int __init mtk_gpt_init(struct device_node *node) +static int mtk_gpt_init(struct device_node *node) { int ret; =20 @@ -337,5 +336,23 @@ static int __init mtk_gpt_init(struct device_node *nod= e) =20 return 0; } -TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init); -TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init); + +static int mtk_timer_probe(struct platform_device *pdev) +{ + struct device_node *np =3D pdev->dev.of_node; + int (*probe_func)(struct device_node *node); + + probe_func =3D of_device_get_match_data(&pdev->dev); + + return probe_func(np); +} + +static const struct of_device_id mtk_timer_match_table[] =3D { + { .compatible =3D "mediatek,mt6577-timer", .data =3D mtk_gpt_init }, + { .compatible =3D "mediatek,mt6765-timer", .data =3D mtk_syst_init }, + { /* sentinel */ } +}; + +TIMER_PDEV_DECLARE(mtk_timer, mtk_timer_probe, NULL, mtk_timer_match_table= ); +MODULE_DESCRIPTION("Mediatek timer driver"); +MODULE_LICENSE("GPL"); --=20 2.43.0