From nobody Thu Apr 2 15:37:42 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A562E8B81 for ; Fri, 27 Mar 2026 13:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617619; cv=none; b=SwYFHx1hFntA49eYaC1O9VbE6K+/DtHVfHmWYhDccaOv1RZWH16V5qD9Amr4eXvuZJNMcb26oYJyjZWZRhgg8JsbROccKLj3/BCwbVcUCrwxrlNwH+fNfyzfDbyNd80qUffMr5uCJddDyiUsbJTpIRz9CW1MhqPJeLhsbT9LFdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774617619; c=relaxed/simple; bh=mYDyEdwaOHmI4Hh6dZYMLc76NtWtmx2dTFjPem+09pg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bUZXkFjPGE/cXLY6X1B3X19aLcysquMwvEHjFkvyw62kvglUPa5jXFhPUAORg3wJ7GEyIChvNPw9lL74fRFdTnr61xC7NyEwcNxae9v7jUrMns0mwE3eHH0CLQxEb+CcRDoM9wbRuDY+tqq5OIyiTkpphU0ljC+apfnWXvyAYus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FH7Kb4WQ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FH7Kb4WQ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48541edecf9so26219565e9.1 for ; Fri, 27 Mar 2026 06:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774617616; x=1775222416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5qWuKKWOMZ6gKR//HOxGZ0ASuj2+0dB9DBea6XpSnPE=; b=FH7Kb4WQcRj04DA26uELNqArvMY6vUV+xVvS5DrI+pS1zeBQxWuQvPMqLCcNJe3ddA 8HYDrRSgjQ0NmqT34C5zPxgJPMr96AcT6Icd9UMhFHIad3o3vcxtgyUcEBXu0/clJJ3x yi2DirifB5K6Hd8avOHT2BH0nZdFzdOhhwbUh6mdEfaOYTG9ie7XA39cQih7EkE4aPIE 2PbovApcpzdgB9PlGFLvvZdsaWB6OAuOEGS8CgtedfYdlPAFfUSqhL/Vgd917qzj/GYW kbtTDIROrLFkOJC67nsXrVQLtyEKmbtMcN9b/8BuOOBWS6UvK9jxtIqsNpdT7UUJ0dNQ 5KGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774617616; x=1775222416; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5qWuKKWOMZ6gKR//HOxGZ0ASuj2+0dB9DBea6XpSnPE=; b=qbEoO84e62NarngGZ0FsKypznfdLVdtTRpwCAjDpQbU8kohrACK7/wqnsDzHoOCHU5 r9NmtAwls3GU4zOF+3Hxau6gBd+RNtuj4VkbI0IctrD7zSZHcgTAubZaM03koJ8YjoFH JKODvYxeaKWng7s5SsbrPFGvGQBbeHy4rV5ZL1yQwAdxW7/6OxF+QyOX0FSU5Xx9DtEz eNwelIKGFttygPsuiwhNqdhluXg2RZvkqJ5J1Gt+fQTLlgBlVC7YG4sh3OshsN375jg+ t9Za1XYpQSItmLSK5b42Mdow0hLy5FZohKhkkNKaTcijeCAyWvQ3mXKn8QVYXZqy16T+ PA/Q== X-Forwarded-Encrypted: i=1; AJvYcCW8suw6TUP4H8yTSfzXHMJfRwgFQF1PJQG2PrnOepL9QN6effe+ZwhV/QeW1KiS2wnkb8ltaIwJWjzojtI=@vger.kernel.org X-Gm-Message-State: AOJu0YxjresaQSNt1y9YY+rVmBvZNNjlxgxDvTrNBqFoqECk/1HjS7Wd vRJTlNObBc4op/CjoY/hvIMsF2gVDhUXTnRdOZ5F1jbYvfwun5JZTPe6QyZcEjxIklH4Uylqo7o wNxuk X-Gm-Gg: ATEYQzxjIfrx75aQNBJ17xHMp2rW5Z9DMaRNTmVpMHInOvZanC1Ts+R4rJFLi4QwD+L i/jH8ELCiO+iE4iFhAbJchyMXdAUZDfmtkueNSSJ6EhIpmF77tHKZpnm2/tcQqy4jr+FpduvQmM CXpchwO9Scds4LCF/OLlBYW6wicqYJW5zDVgMMJeua6/+py0ggzuY1oZmttVjCokmN3KMgQfrJQ jsUZYgr2DSVPsqnkskV+SOmKShoeq+V+Kcme+EcDM32AC0/4XHEzaRFFwYIW6A4qpAsEV8IfHH8 winjxLR050Y3joMb/XMOv+rXH8sbJbIdJKoHuAk2zBWq4yrWM1l1XY4lVRp9pNGvxIAOB98/0zi bofkue7OQZoc9AQvl75ThTLOPrKb9KeBdttAslQp0UXh9cGMHobakZ4wMEbDop9vB6nt6TF5NQu ShMV6GTlTY2YnoLORSIsU0uF8erptBSWx9 X-Received: by 2002:a05:600c:a4f:b0:485:3ee1:eba5 with SMTP id 5b1f17b1804b1-48727f32177mr40759025e9.27.1774617616152; Fri, 27 Mar 2026 06:20:16 -0700 (PDT) Received: from vingu-cube.. ([2a01:e0a:f:6020:85e4:ca27:7d44:213c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df85csm20995715f8f.28.2026.03.27.06.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 06:20:15 -0700 (PDT) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH] sched/fair: Use sched_energy_enabled() Date: Fri, 27 Mar 2026 14:20:13 +0100 Message-ID: <20260327132013.2800517-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use helper sched_energy_enabled() everywhere we want to test if EAS is enabled instead of mixing sched_energy_enabled() and direct call to static_branch_unlikely(). No functional change Signed-off-by: Vincent Guittot Acked-by: Shrikanth Hegde Reviewed-by: Dietmar Eggemann Reviewed-by: K Prateek Nayak Tested-by: K Prateek Nayak --- kernel/sched/topology.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 43150591914b..5847b83d9d55 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -273,7 +273,7 @@ void rebuild_sched_domains_energy(void) static int sched_energy_aware_handler(const struct ctl_table *table, int w= rite, void *buffer, size_t *lenp, loff_t *ppos) { - int ret, state; + int ret; =20 if (write && !capable(CAP_SYS_ADMIN)) return -EPERM; @@ -289,8 +289,7 @@ static int sched_energy_aware_handler(const struct ctl_= table *table, int write, =20 ret =3D proc_dointvec_minmax(table, write, buffer, lenp, ppos); if (!ret && write) { - state =3D static_branch_unlikely(&sched_energy_present); - if (state !=3D sysctl_sched_energy_aware) + if (sysctl_sched_energy_aware !=3D sched_energy_enabled()) rebuild_sched_domains_energy(); } =20 @@ -388,11 +387,11 @@ static void destroy_perf_domain_rcu(struct rcu_head *= rp) =20 static void sched_energy_set(bool has_eas) { - if (!has_eas && static_branch_unlikely(&sched_energy_present)) { + if (!has_eas && sched_energy_enabled()) { if (sched_debug()) pr_info("%s: stopping EAS\n", __func__); static_branch_disable_cpuslocked(&sched_energy_present); - } else if (has_eas && !static_branch_unlikely(&sched_energy_present)) { + } else if (has_eas && !sched_energy_enabled()) { if (sched_debug()) pr_info("%s: starting EAS\n", __func__); static_branch_enable_cpuslocked(&sched_energy_present); --=20 2.43.0