From nobody Thu Apr 2 16:58:15 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86113245012 for ; Fri, 27 Mar 2026 09:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774602341; cv=none; b=osina8C7p8D+cwu87ZB6NLXeiKreO90SgXIeY6DyclcajdTlyKgmxdlvoqYWUbSpTLTEqYRHAekEc65jyX/dDbDdXHKOmkJ30lqK+xKRPrVLiAx1TJAjm5lUx+8+Q8q2+EsoBA9J98oRnIA/bDJtEOWZQ49HYiK/DM4KelWPDsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774602341; c=relaxed/simple; bh=iPyv5IYlDNVCZISXWMfrOwvgL4SKc7iIpzuF0gcSDsM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BwoZAIuyvfgIwgLNVadRcubq4z6ZwhLtDaBJsetoTFheYQWdEFhFmfFQnXjsm2RdTgVYiAoA/be9+tqFdKwMwVuaQCxXAKIhWI7I5AF3yGLoONAKFlH1cXlSID2WhN24NL4CVvTWtwz0fwp2HZba1smPDFtxUHO7mrIONUGJBDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DU2eFBgz; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DU2eFBgz" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b062069f80so11076545ad.0 for ; Fri, 27 Mar 2026 02:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774602340; x=1775207140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IPPZ5j067D2XHcRsSiauJ3ctRc5sWeqt0BIIAF/OocQ=; b=DU2eFBgzOKkRxDYSCP6+ZxLA9+Dy/nR2SqnHyd/P3GuJhof1crItQT59fdEHxHbVR9 SBcmKtMqirb3j810QAIq30cLPXQbycnEKfcp77QyaFiWtwhSlqcjFzL7N4mkosopExAB G0cI2iFFfbFhX052r5ITk1rVeW3elE8gydBAwo50ONa54XyfMgpuLfVn2tnQh+DDMVKN NTg5D8ueSAbKIl5qqKqAb+6dxdv5oXjh4jNWvpfZLiEjOiR/vN6tOnzOV3C54fByJTF+ 5IaA5m52+dwWP4Sb54Krp6Mau/DOL3S7s+E+mMgl8G87VZOo6Iop6CG33u7zpQ+CMbSw KGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774602340; x=1775207140; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IPPZ5j067D2XHcRsSiauJ3ctRc5sWeqt0BIIAF/OocQ=; b=cYyCZ+nF1Qnw5We3KdF/gieodybO0VO5VLQrPVnS04Ib0DO7ZyOmmTf1gaPit6hzV/ J+0dT0WFkayfUa2KLxn7tThsVNC1ar6EXgpj7i5Q5uht6Enl2BgToO/+kEW8O3vQonjz xcnSUAp0RtLVPOjuTca5wW/zs1AdDhsmVoGgTlCZmdIjjke9Tg/VOkctyGIM8LPB6AZ4 ZV9g0U9BmptUmMpQvE92JgmLtgyKI3JIHjb93qdUp8jgn0niHuSmbGmGKBrMYnq7ixWm wycm9fnHKi0nBD7oZix4FKcbWBojsIwkOA4lAhjMN3Rrm1NpSYjwqD/mTUNDQfXeK+iP eIzQ== X-Forwarded-Encrypted: i=1; AJvYcCVwcNHwKF7fm9+9Nm4gbwD5F0CYnZY1FQbciyxhwUIWLakrIqXu9gWQI5xJaa64otZSOmm9fPC96Kx36eg=@vger.kernel.org X-Gm-Message-State: AOJu0YyY5s+Yvi8+wfVHX8Qm2GUgZ1ougsMRbn7Lgbn719JFj1cGfCtg d5FId2xvrnvnoicjCCWgvcx/V4IrCVVL/qAyzLq0TY26BhwxfaQtqcu9 X-Gm-Gg: ATEYQzygEuRAMwKN4ABqgtEUTmloYKVWQt321aKfL+u2OzmciCKThNvzlmd+QvNv9ii EC8kEs92FGwPND+xVYkQ/dTjMRZr313TmKSkJTFl6anzkhn2cxvt5aGAlUfYGVE682xLBJ/e2/Q j8IjLF31hMFK19uVQ9HHJgvDliQ393c5f2wbeH476N/OPnUGwduD4k0zzQR3jxeiRgZRrCqNFVp OSAhWne+hUVkGaPgDnxMVCEv/eHqytcdzRBNMTtTMYyDPv1tVJpZJs01873NfwpIvbG4vlY+nmd oet+Kx61UDMgx4ozHu7YTGLmG8zIrj3c2nF5oxzg/0cYx4NFKJhvNCQxmCgEwOulrwrWfJUJ6i9 4dX19Ab6b4c4cz9WVxSfcfePgoccqWsvpkcxEYO8HnM45BGEyfBAklI7PuPUGFwwF1wK9fyq+7j mzjhwJLp2sWbQP68oJAOilvF2/UrqZ+tmCUxUQe/nPNxtyLrvDL0TunPEHuiR4W+1h3rDMhvNGZ Go= X-Received: by 2002:a17:902:c946:b0:2b0:7a27:bb2b with SMTP id d9443c01a7336-2b0cdcc6df4mr21500755ad.34.1774602339718; Fri, 27 Mar 2026 02:05:39 -0700 (PDT) Received: from toolbx.gk.pfsense.com ([103.70.166.143]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e643sm57767015ad.41.2026.03.27.02.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 02:05:38 -0700 (PDT) From: Gopi Krishna Menon To: rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Cc: Gopi Krishna Menon , daniel.baluta@nxp.com, simona.toaca@nxp.com, d-gole@ti.com, m-chawdhry@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] thermal: fix error condition for reading st,thermal-flags Date: Fri, 27 Mar 2026 14:35:24 +0530 Message-ID: <20260327090526.59330-1-krishnagopi487@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_property_read_u32 returns 0 on success. The current check returns -EINVAL if the property is read successfully. Fix the check by removing ! from of_property_read_u32 Fixes: b9c7aff481f1 ("drivers/thermal/spear_thermal.c: add Device Tree prob= ing capability") Reviewed-by: Lukasz Luba Suggested-by: Daniel Baluta Signed-off-by: Gopi Krishna Menon --- Changes since v1: - Add Fixes and Reviewed-by tags Note: * This patch is part of the GSoC2026 application process for device tree bi= ndings conversions * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device= -Tree-Bindings * Changes have only been compile tested drivers/thermal/spear_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_therma= l.c index 603dadcd3df5..5e3e9c1f32f8 100644 --- a/drivers/thermal/spear_thermal.c +++ b/drivers/thermal/spear_thermal.c @@ -93,7 +93,7 @@ static int spear_thermal_probe(struct platform_device *pd= ev) struct device_node *np =3D pdev->dev.of_node; int ret =3D 0, val; =20 - if (!np || !of_property_read_u32(np, "st,thermal-flags", &val)) { + if (!np || of_property_read_u32(np, "st,thermal-flags", &val)) { dev_err(&pdev->dev, "Failed: DT Pdata not passed\n"); return -EINVAL; } --=20 2.53.0