From nobody Thu Apr 2 17:16:40 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C60035DA50 for ; Fri, 27 Mar 2026 03:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774581103; cv=none; b=TYB+zyCNVN6uIWU+RNsgI6Sv0OzqbuZDd387q+rYLw6H3InVrOZmN4T/AFDEOK4rOv7MVNeNNlo00Qi+nx0x5f+A0KZe0Or6LoxNyQzT+AecOTo2Lw3UAhdrTegikumN6tyruF5S8UppCjDa3G6iAsFC47XQeOMkBJkbMy8YEoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774581103; c=relaxed/simple; bh=QkjwDNLU1ABX0Ft705q7KqAb5BCgK3MbUdDxV0HZ7+Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MVxyyvy5O8hOcic6O9CQjfqt+ud3oeHbWXLkNql1dy0nG+ZT+NP2PxJJmoLYHU+6xYiTDuBBiTa5HmiHI6xjrbCbIiR9us9rN9/6oMTHrGj+IBY/sIvtY/oYlRZT9L38EeBdG01QsuoiYO1bdPXgcg9/Sms31SRf4DRPY+vw0bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tx+VZ2o7; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tx+VZ2o7" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35a1d4a095bso1005343a91.0 for ; Thu, 26 Mar 2026 20:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774581101; x=1775185901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Gn8u2bV5RkBbQyfrHGQqH64e/HJb6NIZaM30XiYhXM0=; b=Tx+VZ2o7ovYtHn5lrMIpGzyB8hbheUCp5V68xuMXmezT4D7rpxVlnkTx+oqbS3lpk3 xP6lmQr474oB4+lQL6909PT13xM6Cbs4lQwpe5cv4HzQMoJoBXOjhL5rdp/Nmp/KCe5k uQqHuMeiV75UM/P3inUWwW//KcZf4plEJh5oQyscxQQpdeL7gxdd4X1dajqTBkeGTXKD V6pBc7l/qjqaTnKhCaG73u8aahI0Wlnj59AVIT45yUR5t1m+vXi2Z/IRZbT37k4o7M+g 6tJO2VYEqUndxkzOcGqe1Zi0pFTweDmIywzECAo6uJp1SgTIERm9PgM0AoUSew3kZjoS yaQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774581101; x=1775185901; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gn8u2bV5RkBbQyfrHGQqH64e/HJb6NIZaM30XiYhXM0=; b=TxcIp7f+DpJ4KBpH8RkOctxldfgYKoUiNTqwewkZw1Dm6zCDtIp1XN0v3QBCe5zKJl b/ecpHqOepiYyNEtgOERMJvJPU1gebNDtEzU7qccje7M/1L9r5KE0iivCE5ym/tO0kcQ /GaMdd6duPBnuVHbKZp6MdCFOiXfldI3O0bZPb6ojfrrUGEVX+5r599B5aPpUExEHCUl M/tW8b4BZYEzaXOS0fkcBA7daSP7phZBUzli/jUt/bIR8wwgUdtXC8GpcQ8XyDHn+/9d HznUQeWtHTHfFmol0QxOMfDLLGWjxHiSqOrySPRpaCqZvUz/WIVGTBftQTb43Dv1Gs7k FTgA== X-Forwarded-Encrypted: i=1; AJvYcCVWIDEGfF5+02rOBReBYIzqGxd5E8693XrtlT01ZnmBgsSNDEQ1o8juXGou/jfXVeVDltJkPCNUKumFjkk=@vger.kernel.org X-Gm-Message-State: AOJu0YwaNFUi25UZEEaRmYa3FoPVKpq/xQaLYxXVpqkFfxqW9S+dbG83 /STSHBMNlcvCxyvsW7bzH6BUFCvCl1orZ0sGhcfR99TBN+vP2x3iNA8B X-Gm-Gg: ATEYQzxLi1/7q8bvQ2GmvrHTPwLUS6I/WUpsbnfhvMRILAzFzATK68Yc93C9zTH+tMu cBmlOUyVTEZlJClBS6fMU/9vr123SBwS1dIo5RjptwvB1VWf1smepzhUNUDWTIQ3d8SJfSstF6+ /XxgFGVoyAnCRGONvkwNJwSR8AnyXMEAWnEeyWQCoy73yvd/0MuGXd4KrrKbmlKrly6YeUfVqPg qUtQF+iu/LZopMAm+VvaL0hhyhQz4fIPqeaWy1RebQLMEAqwmDQCnRAAFDssvqnW1A3m+xOmXk0 8L02hy6c2xJnOwrLjQnKbW2CI5Pe/ITHmAL9RuMDA7Jg54L3FiIMqAf7DgRGdLTVGy+GrVW19eg FXKGudHHBWdOX7yy4wfEkER8MqXzQ0ihSKUV4QGbmIbG7xIavGfM9cDMo+Ph90kATVaI9IrYldo zHCeNJZnrRymL13JmqEf5XvWc= X-Received: by 2002:a17:90b:510f:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35c30b82d44mr675549a91.2.1774581101418; Thu, 26 Mar 2026 20:11:41 -0700 (PDT) Received: from localhost ([223.233.85.60]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22a4c364sm4023189a91.3.2026.03.26.20.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 20:11:41 -0700 (PDT) From: Anushka Badhe To: andriy.shevchenko@intel.com Cc: andy@kernel.org, anushkabadhe@gmail.com, gregkh@linuxfoundation.org, hansg@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org, sakari.ailus@linux.intel.com Subject: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c Date: Fri, 27 Mar 2026 08:41:06 +0530 Message-ID: <20260327031106.10386-1-anushkabadhe@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GP_TIMER_BASE is only used in gp_timer.c and it does not need to be globally visible. Move its declaration from system_local.c to gp_timer.c and make it file local by marking it static. Remove external declaration from system_local.h and its usage in gp_timer.h This fixes a sparse warning about global visibility and cleans up unnecessary global exposure. Signed-off-by: Anushka Badhe --- Changes in v6: - Mark scope of GP_TIMER_BASE static Changes in v5: - Move GP_TIMER_BASE definition to gp_timer.c - Remove extern from system_local.h - Remove include of system_local.h from gp_timer.h Changes in v4: - Remove unrelated block comment style fixes Changes in v3: - Add commit description - Fix subject prefix to staging: media: atomisp: Changes in v2: - Fix block comment style (move closing */ to its own line) - Merge split GP_TIMER_BASE declaration onto a single line Note: * This patch is part of the GSoC2026 application process for device tree binding s conversions * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device= -Tree-Bindings .../media/atomisp/pci/hive_isp_css_common/host/gp_timer.c | 7 ++++++- .../media/atomisp/pci/hive_isp_css_include/gp_timer.h | 1 - drivers/staging/media/atomisp/pci/system_local.c | 6 ------ drivers/staging/media/atomisp/pci/system_local.h | 5 ----- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gp_= timer.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gp_tim= er.c index d04c179a5ecd..0c1b67988dd9 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gp_timer.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gp_timer.c @@ -11,7 +11,12 @@ #ifndef __INLINE_GP_TIMER__ #include "gp_timer_private.h" /*device_access.h*/ #endif /* __INLINE_GP_TIMER__ */ -#include "system_local.h" + +/*GP TIMER , all timer registers are inter-twined, + * so, having multiple base addresses for + * different timers does not help + */ +static const hrt_address GP_TIMER_BASE =3D (hrt_address)0x0000000000000600= ULL; =20 /* FIXME: not sure if reg_load(), reg_store() should be API. */ diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/gp_time= r.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/gp_timer.h index 94f81af70007..e651d9ef1114 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/gp_timer.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/gp_timer.h @@ -21,7 +21,6 @@ * - local: system and cell specific constants and identifiers */ =20 -#include "system_local.h" /*GP_TIMER_BASE address */ #include "gp_timer_local.h" /*GP_TIMER register offsets */ =20 #ifndef __INLINE_GP_TIMER__ diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/sta= ging/media/atomisp/pci/system_local.c index a8a93760d5b1..8d4fd80f8984 100644 --- a/drivers/staging/media/atomisp/pci/system_local.c +++ b/drivers/staging/media/atomisp/pci/system_local.c @@ -83,12 +83,6 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] =3D { 0x0000000000000000ULL }; =20 -/*GP TIMER , all timer registers are inter-twined, - * so, having multiple base addresses for - * different timers does not help*/ -const hrt_address GP_TIMER_BASE =3D - (hrt_address)0x0000000000000600ULL; - /* GPIO */ const hrt_address GPIO_BASE[N_GPIO_ID] =3D { 0x0000000000000400ULL diff --git a/drivers/staging/media/atomisp/pci/system_local.h b/drivers/sta= ging/media/atomisp/pci/system_local.h index 970f4ef990ec..2bd46f5123fb 100644 --- a/drivers/staging/media/atomisp/pci/system_local.h +++ b/drivers/staging/media/atomisp/pci/system_local.h @@ -53,11 +53,6 @@ extern const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITO= R_ID]; /* GP_DEVICE (single base for all separate GP_REG instances) */ extern const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID]; =20 -/*GP TIMER , all timer registers are inter-twined, - * so, having multiple base addresses for - * different timers does not help*/ -extern const hrt_address GP_TIMER_BASE; - /* GPIO */ extern const hrt_address GPIO_BASE[N_GPIO_ID]; =20 --=20 2.43.0