From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC12C3128D9; Fri, 27 Mar 2026 01:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575792; cv=fail; b=bCRUnOotwj1ZWb5Nx2eIVYR297Q2K7BqhIfc4V4b7Fi8O+ajyGeBRSEXnvUYDSENXpmloK7/ojk2etBaFL+2B604s5tCPFltxWyLDdUCgx1uA1ip5u2OEJT4GKqCsrINZy99YarGoooXsBQXcQrPKrWa9t2jifJ7+B/mp+9AiQE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575792; c=relaxed/simple; bh=2ZK+I1QUNlvdXZ+KuPfOpRDbCFlsmezOhD8RTWnqbPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FckpVZGfAlEv3Kc7Wgv5cQtnTJAJacxYWtDxLndnqeGe0TwAnlJRcMtekCKk5KSxpdj+/8aCRAEPYuBMHRM0nnuKEMZnMWWHI/V/zQPdGNXHNYiVaSPhTbk757TQQT5vPbjAzFFayhhidqQ3TMMSmVBlAhMi7SP0dgdPSYsr+ug= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WMirXuoc; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WMirXuoc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hHm00YlGaktiH8QEe8haK3gQb2suyoXTvrm3pyZJuupS1Fl/GIENLSt8kfMmz9Nayj/1kTl2M/2tKtIejvYf+CUz7viQaZQt5Pp8WDekYuiPeZj41Z1d6H6nLgHh8nomf5nTgkuV8nCEC+id2Qr9EfEraeZ70JB3mmVcTLKSmKeH/eJTZ6y6iFcm3m6JJ74GTEa9UhpiWIexBI48RJC5ewmH6pJVgcUNEF+nJdErQ9o+QtHdd3YQ8cu1k+4xVmm2moJiyrUGkUpBx7bIX+lW0Joshg4H9ZddFII07hUNC5RnAM4u3dmKjsJWmaHPZxtjhtrzZi9dvDCJMs3ZaGI7DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IHrWTxcvcz/ah0eCjmkygDNgSOCoI0wu2JxMZZ29qB4=; b=lemlaJg/mjbXu7OYumCFMr3cFdhxI4xqQ24cL/jE1M7ZTegVBq067MFqNKwhqcPehwHSF8c4fPnfzzAg8K0Gkz5r7Q+uPa+iJKVGt3Hmp4ZstSvlCcbYSb8a7HfXrH07QI4sJZyfLJ6+awec6BGGDONf88H1yJKcONFZYCxukaGSb8fXT4WT00u8dBzefkwSeYtoU5imbdFs8cpVYH9EVf6Urh45QTRMcvaCmHi9wQh6muZRtodnodiPq2v6gr2HRxiJ3hfK/oXK6k27YXESFmXOe8Ez2WYaVL7kiclVMrN9/SnJWf7pyUfGed20Fgn7KZnBmoR6NA2ZrRntKw17hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IHrWTxcvcz/ah0eCjmkygDNgSOCoI0wu2JxMZZ29qB4=; b=WMirXuochUqR9RoVHTtWQDAsHDTOWpM4BY3B4VRghWWrwENVx7UCeGY03dCw1o27bwtew4c7f56raTJv6Hc9pMRRbllMvKLigtR10Z4UJ9oFy1axgzagnSJmMpA6UXBt5wxt0sUyqP0uVFaFkiB4glr3wmf/0MsAIfCnSJl9f+06J/q2+pL/u+x0JcmYK3kpuDh9/SCqmqUJIzPmdNbzSQKQFWkRI5zKG8QFpMBgsTy2Kz5DNbZ2DSFpNH6jqKcYecuySkY9fNHN1SeAhMO63P+HlPSzgqwoGQwJl2Kqruel1jlK4kDA5E4fNrLBhx96AjzA0Zw9ez0zhRMHHnVg9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:06 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:06 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 01/10] mm: remove READ_ONLY_THP_FOR_FS Kconfig option Date: Thu, 26 Mar 2026 21:42:46 -0400 Message-ID: <20260327014255.2058916-2-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0361.namprd13.prod.outlook.com (2603:10b6:208:2c0::6) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: cc2b3601-15d3-4018-e749-08de8ba23123 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: b+edGsDDRmxB9JAnBizMSizOq1eX1KgXAC9KIXEvbvKg1RKvpocskVu6+FBom1l3sQC5upZUYhSv0bW2LMqYYz2zDSdI19nDL20LDlZkLuT74/upQTrtueBvsMqmZ0uMQxfe7B1/JPh+JpKtIhbxPb0eqk2inV19iSJyA5aQB2i5UdbysHlujTWH+iQIxXCUn7dYv2pLOe8EeP7E9IWkblDwEqA9J+v9SFZGABg6e3IKKiVag9sCPZGnjKDKIIq3ZypL8c3QVpaULvLmKLP1PFlbs6vDJLX2aQq7ZdAKBtsIUf+HvF2t00f2NJaS1daiNnEPT8fE38lsRP1FQA/UM8/DOb423vqqLs4vVAb73BIrUKBxxiS7R3pb2l58RvXaDx0Lb6rVet993CdJBX3B1QwesZXaF9NwI7qlINHZOQsQJKYoOod2+6Mkw7R5KB8n+6w7J7zv8fSGJD5OnOb9ERXeT5i7W6d5+ekANv5CJBR/SQYsn2K7FIN6PomnIX7OMpshLJt7j/yvRZXf4XBSnFqXgK2XZHOJK1OF1+TZWWYyUGH9Susfk2IlgIKgcrxLc7bJuN3eNOxmsz0g3hHeDBZ9V0Jm0u3Wbg5xRGJvurEUaVy7eCEBWxHV06D2ByIuFFVCx11qUYU+/XLcZjqnh0En+a4Rbl+LWX3tXfCLrlFr6fZQqd3NrBkJmSqUqsU8UMk1XaO7LufdSOleoRIj0oAPpTmBVcttyKIV0Fg4qQc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yfvtZ2olPJ7ZG/YgcPd1DLcFJhd1IBxyizFW+sRBZQsKGbwsNhiToS+Achmf?= =?us-ascii?Q?IG4Tb2DLG5DqS212AYqWl69YQvFnxCk1qevN9wlqi1MZ3Nhf48CmsEXSeGFl?= =?us-ascii?Q?lNCGd/scByE2T7R9+TmkI+mFBYeXb2LlLrEs4WoGSLYrrpFSHN/GEDShYTkA?= =?us-ascii?Q?5pfAgtPgi8dpzH7BYJ7shLSXnm1YmYWTgig+2Sc2RAZOX0DSlNEH13Wy6SAx?= =?us-ascii?Q?K4rpHzjA41bXlFBRhCQT7FPT0Dh/t2jvyqXp1gQ59oJayi5ZIHDixbv37Di8?= =?us-ascii?Q?BGIe6YFLaRL60u3IAQd16FZM/jSYCrDlBKLmm6JfMgxz+pE1PDFDSAoL5o/a?= =?us-ascii?Q?AZ8Ao8PS0Y32xrFsJ04L7Dx/T3Auty4GVFnYcDLG0jzZ+TrDGd8BuVqZFXOX?= =?us-ascii?Q?W8zlaNd1nS1nXEnAbUtSaoQ5GgGOKa8IAaF8B9W7+kXo3Ycq7UhE4U8uyZ6K?= =?us-ascii?Q?9qjNdTU45fMnq/DJB1YXUHJuoDIKXTK/32uHuWqfzuHm5CbsFyw/3OBMKhzG?= =?us-ascii?Q?pGMuBD9QV3Kav3tQrzj1yW7wbeXvO+E9QZqDWqXPCes8XrbrOiDeNfqu37I8?= =?us-ascii?Q?2PoIktIzWaAYEqYaZP/gHk6stMkbj5lVFgXWDLyKBD6ufVpQZYDGqIHJS/KG?= =?us-ascii?Q?ygoibbyo+PSa1V3NZeFhLTeWzvjaoOVeEYzhkUAT6lt4WV8VYMCcMi2yWfEf?= =?us-ascii?Q?/iEYI5ER9P33t1Jmbg8lwYU/zlx9gbXMJKm0lhuHWgT5g/xtsBIElsGfQs1h?= =?us-ascii?Q?asNCOZb+kUT+3vuxeHHFb3Vx7lUFWqgU4zvSGIUZIOY7eleOmqh3AWlYM19p?= =?us-ascii?Q?2pVXKC1Yc92CfbkKhRfDFukk6bLbFAECdJC1oktrPENjxjbThHM7fFAWI899?= =?us-ascii?Q?uN7lbuwjmHc157R+MhsMxXYswxH9XB3ettwoE1fYL4AYeftM1HSbBBhJmB2v?= =?us-ascii?Q?zVTomgMqXoQEZiBBIZOTzadILZk6J3qfrIoCohAY5tva2OCQYHu3Bo5G50Gp?= =?us-ascii?Q?NtCMUVWd+WM0XR5GsszWdBx8BTwvIS+gwcilmCrHsts6+/xxc7MyQ8ObolDf?= =?us-ascii?Q?b4MAf+X0k4+RJ2PHbSS6YE56O9h0NuqSkWsPSxLgo3TgNmDJ6YNoKfgUcoPf?= =?us-ascii?Q?zhCi8e8xl2cUY6W+UPRGowsbid7/iPAGUQOFz0DYWYbJOZ/mQCFKoO5R/H0l?= =?us-ascii?Q?vYxTcE6YMcxSeisYxkXmwUJ2qbYRnXCZunWKkPycnoxCiPRCnqwyUuw5Zsvq?= =?us-ascii?Q?IhJl1bYyzIzJgB9O9Vk3DIcEplFZZOMIujMXoZmduBuaX3207qHp2rXozb65?= =?us-ascii?Q?DZyLcsx3+WMneB4bGdvFuajEIaju9UTDMsBhp8CM1/yoqyKxC+can/8cbWRD?= =?us-ascii?Q?w5yqk7Kpq9RrAeFXbVTe7H6a/arUd6xNM/e+NJnCujGcCdPIzjyAcF72deAe?= =?us-ascii?Q?pmnLeFnXo5h6oeTPGLW2nQzoaNG1/a97wRILLT4QjRprIvevbh+VXmIldptI?= =?us-ascii?Q?SNBWC5twiLrezBt3rR9Z3aXkk1Izx4rVjW5JgoWlUSN/8Tpp0pjgyy7u6Ltr?= =?us-ascii?Q?BFXDWVQqdRzAOv+vVQytUumG+9DiY+1hHMG0ZtiBug3cP1Fp81Raf8vXoGgi?= =?us-ascii?Q?fshORGxaocbi8fKsTq171Fk3MwxxpiEGVBYamQfCXcNVXBMLNB13nlJfFNlc?= =?us-ascii?Q?WU164pxinmm6rcPoaukDv6NowblXKwJYm4ACeffaiam8j9Bn?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc2b3601-15d3-4018-e749-08de8ba23123 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:05.9479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v5eleq0P7XcRMZC+vtRHOpr67Qn3ka7oaIHWSQ7NPtLs4xLZ37NPFUEI90RXi+tX X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" No one will be able to use it, so the related code can be removed in the coming commits. Signed-off-by: Zi Yan Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/Kconfig | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index bd283958d675..408fc7b82233 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -937,17 +937,6 @@ config THP_SWAP =20 For selection by architectures with reasonable THP sizes. =20 -config READ_ONLY_THP_FOR_FS - bool "Read-only THP for filesystems (EXPERIMENTAL)" - depends on TRANSPARENT_HUGEPAGE - - help - Allow khugepaged to put read-only file-backed pages in THP. - - This is marked experimental because it is a new feature. Write - support of file THPs will be developed in the next few release - cycles. - config NO_PAGE_MAPCOUNT bool "No per-page mapcount (EXPERIMENTAL)" help --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B29319858; Fri, 27 Mar 2026 01:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575793; cv=fail; b=LLqgf6Gh8JFKIdHpTVl4xdOrvrpRoKBMRr5hApH+KWxavslYF+b905MKSiEjK58HrbFsxQDJQuISRjXwTzEYuXjJUoJtwTA+WRau0h0p8Drxwlp6LHbOtemg+229w49FsZKt0n/aKiNRiTm95n2wKaqIx02LNsxK5WuSjQca9LA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575793; c=relaxed/simple; bh=Wizyhv/O2SUXgJo/4RND4XynlXxrthuBlkhthlaI1mU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hkoFsPaDM9p+XYb6q/1t4lAGUCwVWsBJSnhit6GSjeF4zl9VUcEzIxn8sYfevHISvu7tZN16eNJkdWg5on6veUQnWMFY2Oouh7at8aquHYveEY+fB4exNeYmCKV/jPOVocOrk1GnAgdHGAG96sp00u7e90nneodB7+RPnzerEW0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fVU5uYis; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fVU5uYis" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OCVQTQUWHTMAlAmqdaGwisfw9djlyqKYpf8MI6BULPMpsXuhncUfnDOJ3Dt9IAM1PYmNhOKBVYQdFEbTiRTxK4Yq1Gp5PjqA+YpS4wrHFCcHRUNW3O/3lfbayptL1WcNadQTcoL+pOmRYQtcRTyl7pg4vgspFCEwAJREz/+mCt2plBigTPXunkyV4jcAxu2OHNAUhSG2LqRRfG6TG3ztu06y7PHzZS3RD/CTWwD28YxHKfyr7eecGa+1lTa/annXxPWUEmq4H/XrIq3elm10rwRhA4E0Bm/dfltm/6hwiidqGgrEiQDZLUaOR8Y+vUtmzGu+09hrju9sTXV8CVvICA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VTkf814KTbAKcjKFZWTyPVHXuunVLktqolPhScWqans=; b=LyweZxSpTdyuhrEzbVpzRedWhn4u0RRF5ABWNTeJyyNQ1zrOqJ8BS/JO3CkOS74jc8bjVgq8voYqNjKspm4UjrzeRpfLyrdKEjBIEdCBgo9ZG6ff4YsP7/Gp3Xm/XmQV0ndoE2m/d4wIHExKUAyVitaMTgpoRbnWIRasHbrHjcgTiNfg3uPmhzAYzNLlonQOON5B4SKTq0Nt7w5hz+gFpxfTX895Tr5loC655sqZRi5550di+J3iGDJGpBAVc6QexcOCCq4259vjRAu2oGwhwcqyH6DVFa4irdpuPgsGi4aknp7FMmo8lAsHJcD2cm/yZZ+SH267QuImFjq/ByLFEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTkf814KTbAKcjKFZWTyPVHXuunVLktqolPhScWqans=; b=fVU5uYis0tgO6m8A5lItYEDdqkjMA1LAdS/+abWvxjP2JIV0THGjJVY+sfFUTv820Xj8ccFtneBG+n1K+aBo8dSCPKBccQKabG49eiz/NnmjQ3KoqWNow5SV9EJxcu9pQ/CebJYIkSYrWFzKwGCqUAc85iOlH6WhSo72lvhYT2pvMukD8XZe5607jYlvzDXsVnkhBQVTV0PgEHO1MZpBC2G1KBobpgGz3KzGqiPAzjFlzMtUKAXj+0pWWy8GySHq3c8EBeGOg5IxDj5asus/bW2RPKxbarZhQ2e4Jp+DKNvBW+AQVnBCejoD5fFdU8JcWwFVoGr1JepKQM4Sjr+ESg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:07 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:07 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 02/10] mm/khugepaged: remove READ_ONLY_THP_FOR_FS check Date: Thu, 26 Mar 2026 21:42:47 -0400 Message-ID: <20260327014255.2058916-3-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0035.namprd03.prod.outlook.com (2603:10b6:208:32d::10) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 1295896f-2a72-4475-4af3-08de8ba231db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: aFWIFoREAFsHe3Mh5Op4FfCsSya7bnZgI0V5NkttdZRFUEVvyESmLGW7ZZLlp3g0wJrq2cTRNipO+aA9bEtYfdqoCL3fKHghGNrKK0TJgCZzL4CJsozSdwEduzRlATNt5/evKNQ348d5YaV+R8o8hXCHsCA7zW1WZI0xm7xHU9XyCNymCJs80ooKSwq9be0C2iZ/ez9m/yvm2+Dq2Apbsnw9G/mIDeMDqMl6CTt7Zbn9U/LYUYAL0s+BL/0tsLvqCiIw9f+oGHfuFYM/a8AupPbxKXq4dF2RcSbFAsEU6jZ1Ol+9EbygsVDCb5sySBPXTJ75JQNfMPsVfc5DRzdtifvAk2ZuwZkFH6p0vO58Qem4wxymQb6XKFhIfd+TiM4QQRXC7NrlmD5CcC8KDIPhf1hdQaxCoypmbhFgzPqGmgJIVtObR1sHzTepdLHWrv/aMnCVU8K7y7DVffZlfEAWvLxlcBg4uI3WGdx72m7q5vy2vym7reSAEZY7QSr7pbi83SW73easvsHG+VxR7nXzcXU8/558pD1Gw1iIhOA7SLvtN/Y66SfdZLGgfT4dpYzddFasE+CsZ4rF2hkUlUwaGwxmHcdvgBXdy4LWQfEJ0YQhTnyewt7cTOOdQdBDDZsPelB/fNo/P9KtH319yHM5zEu0E7APSWl0hMTPdJlLod/YiyrxLVksAgPqw09mzsD/CSeqWIkAMxHHfX1Q31qbuOES6f0J0cbdYN2VXYibEj0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VB+bMButzeP96eFyZ/yipb75SGm3QoVOuYDolVoPiyXDK4qUfFB8j7ZGixJp?= =?us-ascii?Q?5huDoXY8sWzBTNoDO0sCuWL061hOmzlU5D/7R9yh9715dT7bG3JENwOc2vEt?= =?us-ascii?Q?dhF3nZNSUJKGd3fsJ7R5bao05hb9Uy9nikD7dBmRMUinAXDZp7pZcgTSmW4K?= =?us-ascii?Q?PPNnXmqfTe+ktNagmaioU/vFBDMjjdPRRKw/W1+Kknhpn7jnph12bdx7RvPh?= =?us-ascii?Q?9G+Q3wlRzn5hUgl+eXT1vJw6cVC5rpF8jH8r95d+7X7BhInkHKb4N+lJ1m/Q?= =?us-ascii?Q?FwshJdmn/UZMvOUHamJfiRAe0u73y9RHuhcqY5W11Z8YwH8x9VYvCdHoyVon?= =?us-ascii?Q?tFcXC9VxgVmTv2qDB5E3N0fJTmTPIrNNg+077wWZWnHL0XHl2x/5AkMn6f9a?= =?us-ascii?Q?Sb2TSyAd+W//xXvPzV4Zg9MvCJWARZ8HlHghNJVm0MVKapOAGDIvTpTJpIGc?= =?us-ascii?Q?BuaBrRQz1p7MeLL/RJU3nk6D5gYADWzNGLKfydbtwp4jAvXioF6Voy1eo2oA?= =?us-ascii?Q?hKq5ZFGLv2uVrVuZQB052X5CM2YZGZQ/neJbzLfYihe79k/NLMqDM5WoHWgx?= =?us-ascii?Q?H3P0LpPvILDrR1sSxdQrIHI/REfk5TV6fItIimYd/GcJvNTRWLoyNQML7PQO?= =?us-ascii?Q?HGC/HveN9782wDtL9/rbBDHvqb/zdUVBLwD77GeCQFsjLsixC114nA0RTZGB?= =?us-ascii?Q?aT8fJ7dJFLXpGQwBJsxTuV8KO/YMhtDMkvRayvAcAcI7vYdv7mmnWIPgR/9K?= =?us-ascii?Q?+Z5m6Xt2u1rK+JaFEe6xnn8rZMRzQj4v2NbuSS49haeIIiSYeaEeld65RMo2?= =?us-ascii?Q?i3n1UsnQf4NTn/irM8uE2CWBFtMHpsdwk/qHEbYTdNlpxVCqczONwoNmRVGO?= =?us-ascii?Q?WyMYgQK5EcdvbnEkZaTwwJ1xBuxrwbRBJ36Cl7zDDL8LG4/lQaDxYUZW9ZEq?= =?us-ascii?Q?1T+xwfTE0QU5Z8WwR+0ofPMASVe5u98St+J79G0u3hLEqyeRq2MxmtaxlJww?= =?us-ascii?Q?je2dl0gAvhYm0FCNFFRUFpPtTQppeck8ksjkGUCW9upkg0yJgIjwTvOOtM+S?= =?us-ascii?Q?Xq+v0+E6SSDUqEjva5JQ1BT6ggIVfjtz1toDSCLhVyxE+LvFG5ZCR3TCNfv2?= =?us-ascii?Q?ZqOBQ4I6/eooLWTfl/yGcmBnOrFL80yyXtQSoXEl1ObPESF6zktoiCedOm7x?= =?us-ascii?Q?vvEPYzjA+XbPjKKwq3OF0BBKboXa3DOMVA+na0pzI/u9tP+CT1HWSNZc00Mh?= =?us-ascii?Q?uEC8xp6PyiW419GUh9X06+Pth+SI9xmSyxOtMpPB2Tb6AK+z8hOAWlNi1lYI?= =?us-ascii?Q?leY+2ZvC2ytJWKnP26ISMZaiDq1ZIDmL9E4JiuurdSXQqYZsOqVV+qXbse+E?= =?us-ascii?Q?Zk4yAVsCRmCJSO2r5yssu8ZVMxijgA8Ta/dzO2DJYSWOR+8XQGC9BbTFirjK?= =?us-ascii?Q?iZP8WeK6EgPDDodL/pt+6Q+BykZ/lgP+MRQFwnwIcvDmVRLphvk1Bgy2qAZ4?= =?us-ascii?Q?Zj3GY++snROxi5z8HOCw32zctJ/w+dKpCN71enS5cky0Hs7NKqZiQvTf4A5u?= =?us-ascii?Q?oiui+grgtFNsz8872p+TPHMTyr34MShhENwHaOV1Ltd8ubQCvdKWnJ0Z+r15?= =?us-ascii?Q?QAptaCn1YB3owbdc5HRS4BY4470q6F2AyvwdPcxjuuN+kiRl2aTE8Sk5VjFO?= =?us-ascii?Q?/CbpK3lKAFmGNoHlHOKBc5FuMugrzZkmfXwvw+N3KoIDBiyW?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1295896f-2a72-4475-4af3-08de8ba231db X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:07.1441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a/UC/5UyBF+vZhMvAvc7H1vkVXiXfnJDquLPnp8mSovCizdtBbzDU+dryFKdYIH2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" collapse_file() requires FSes supporting large folio with at least PMD_ORDER, so replace the READ_ONLY_THP_FOR_FS check with that. shmem with huge option turned on also sets large folio order on mapping, so the check also applies to shmem. While at it, replace VM_BUG_ON with returning failure values. Signed-off-by: Zi Yan Reviewed-by: Lance Yang --- mm/khugepaged.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index d06d84219e1b..45b12ffb1550 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1899,8 +1899,11 @@ static enum scan_result collapse_file(struct mm_stru= ct *mm, unsigned long addr, int nr_none =3D 0; bool is_shmem =3D shmem_file(file); =20 - VM_BUG_ON(!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && !is_shmem); - VM_BUG_ON(start & (HPAGE_PMD_NR - 1)); + /* "huge" shmem sets mapping folio order and passes the check below */ + if (mapping_max_folio_order(mapping) < PMD_ORDER) + return SCAN_FAIL; + if (start & (HPAGE_PMD_NR - 1)) + return SCAN_ADDRESS_RANGE; =20 result =3D alloc_charge_folio(&new_folio, mm, cc); if (result !=3D SCAN_SUCCEED) --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D953264F3; Fri, 27 Mar 2026 01:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575795; cv=fail; b=bKhjr1+YM/TvLrO3bSfb98l2l51a7XzMZqymfYrawwtXp/+ndFRYbA5mIL0m7EsIUiaxjRCjhA8DWgbutzcEtcGQdoJc51YfxPPUWaF2lTg5CzODmRzpDaQ+gniiIPYkR/HAnp66oe8bqk/NLzBFAfdCwHXEZjN7ppZc6cOzTKk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575795; c=relaxed/simple; bh=rFGpbS6tdW42WJ7Sa6HEQ8X52uoqny25agkpwho8WYA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=IQ+ua+FRv04OjMSxyOSAXR2EjA5nGIN3UnbOdzy/2GnwTtEegFQNG5TK23k/pKRBDfnRiqC8YTZPCAkM6qJPd0hxc2ncDL+9YC3P8b+0nlymFSNAVffFGWB9qponc0hwe3Q/110TWH2OPSY51+Uln4USwQigqfJcD0k6rQD8tKo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=UBxXRzMW; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UBxXRzMW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVW2ce9+BQOw+9mjRZ1O+Fin7dveBitSms3x8cyjZz6H+Tiu8cb5awtlSqUPKElZWIKZ0wmZvyARTakyEPKNVrs7qFferm+s1fdM7ku/T2jZFFNFohMO82e3R3EXEzpvAJc8yLhDn74+WlKGx6WFN28szsWmGg4oqGBEhLku2mfhUtmY4Teu9AJ0zKUZ4bxSqPJB7dsVYf3dsMK1jASF/3qCdrwSPDXoIeVCSq10x0FrlA7DVehUnUArregsnzodxvqU4iKwDl5fGFZJzbVjqVVmq/kh4yzVYk+PGtxNHPipV5+3lClzEML/cu8txwsmyBfa4gHQj60MblmbrE0LQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8WtjKqeAnMSTiZeunDBBxM5WbMXam7k7WhfDEW6fjg=; b=ZtCU5rsjOm0A7aKey5nX61zHqCVdJNiVlp3K3ctkFXJL5LGrisjSVR5quKbBOQhJA9LTcRAPGaaF22f7RZa1Kf/K+e6hzLhKUfzRAvb5J7/EdagZa+7Qpb4XxKDaoNl3BaSIL+uKhfrZ3WZqP2oEj9jWTWrdrxGx3Pa4qaXbz2zwDQce3ikM5CYo1DmCrotX5FrDEDKYw2eIRRmzav+/YilT4LDGy1bGCE4N+JwvVTuk+vZJ+GJXklHeUAF9f/3Jzbs2OIT7t/9mjqdlEIUUKoU8731jV9dpL81A2TGJpNq6UFFYE2InPP6KlaBmvgnMlypyuJgQljNBn/+KMvl6Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8WtjKqeAnMSTiZeunDBBxM5WbMXam7k7WhfDEW6fjg=; b=UBxXRzMW4ucFIKATEK0XpZdtkZrsbY5SI1NGZkOmP5hebar0bApK+rym4eGTXL8rSbD3Ae6hTwPC+ge6tqm88hKV3NhyWlD2EEJEUxkm6FoInkU3NxloVzgriqkGpNU2/K9m/9hYITbWhNRi9Pbgpen72dki0DiN2cdrtkyVPYfdZWoz5fqJIsgw5SUupR1UP3Wl8wsCalVOKprKYX07nZKK84LLvGA65bQ9BsdOSi/M1p75S3mGX657MKSP4/+j12JMXY8vVCRobhrf/9biswG1rP9pnXn8gJ6EvgQ8qWEhtylekQ/EVCOW1DFf7sfLYqAIrkktzbuIvhi6O8U5uQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:08 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:08 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 03/10] mm: fs: remove filemap_nr_thps*() functions and their users Date: Thu, 26 Mar 2026 21:42:48 -0400 Message-ID: <20260327014255.2058916-4-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0378.namprd13.prod.outlook.com (2603:10b6:208:2c0::23) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f5b485c-62a8-4932-266c-08de8ba2328f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: O094KnarKjbuKaes/vnjCYnk+orUicZYpaOpwqAdayMUbvexH2z8KIlUox2RyCTLWHlhpaIFHW4j6dXLX0B/VEZWXpbPyMppZCiLOzOKhcOM1AsNBXmwz6koHCUKuaIfucB0jxlzNb9UaA+snQpizw316Wd3LwpwE8B1EifDhxW3XsMXxvJcy+GkLn3dP57p1KnerApyJM1LO57be1SWyrVpBZPaqeq+t//PxVDeXd8wddYf0s0sp5Qt30w6nQ7IQ1tRzy/h5LZokaKMEnFh+5Tgzj/+X25IAWlsYAymPjC4snbNR/xlWx52E+Jih+W7fJqJTWMF7/DxA+MgPMDZlu5J0Xd4OrDNLtOUMNkMV0tDxcvUdZfY3RbcpARXnG9nvOtTQj3LwvKHD8tTYM0PTqqJRm04rLE0vVssmmkS+hPuZn93Q6X1UascZdUl+xeBeZbMHOCM1vuvZVV35JFCzPPtTSOMl8zA6nB3SrfWsTOlSqFqt2CvMYPskqSCm3yZ3TkPw2KFDn8+Akwpu9CoIL4biAV9rC9oBNMI/xpiJMEj2VzSNNl91UtHQ1K6tMXD/IJLp6OHMf3aznEYsHP7AdfZE7TGtGR6hYzvYJO4l/ibsvUZFDUWHoaVLfPqmBPbZbtEjJ353nNcTn2Jkfr9cqMgEa5w4r8fcVUqObRai3z4PJfH/WEuoEGOWL3gRU8J4/fN1W5jvvl4tPIqKDwYAGV8PZgwfXVclyzNaG763HU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F5as28cpigp1CliPrFqxBBOOjv3AeDSiDw6XL2Aomh6KCjp/rkMQEKA+nc2x?= =?us-ascii?Q?jNOfXX5nR2m69IZjjWX/Mp6iAyreuXeGF3cED9QHDiK3oNUCYgIFPnpO2yCO?= =?us-ascii?Q?+7D/YnKtb/292NBbGfCU0zizjotkqoBBsDVgI+qrIXb4XNjz8IQToOqW+Gve?= =?us-ascii?Q?sys33ithExpFzbJggzkxDPOYA9I2ca2a/IPYExio3e3R/Yoj5yQVzpIJfx95?= =?us-ascii?Q?PqREFeryrnT4wn0i4TiGYUT/RL/1H+/6M66TFk5yb4Y8V1/hvey4oQMJNPWF?= =?us-ascii?Q?gWNgScDrqWfeD4Wr8rvrP6t3j6zJRSRc4+4LIVDEbkTbYfkCOU3bKwBsjv9M?= =?us-ascii?Q?bVZIDBmbCGu4QpjN1nsNaM2fOWHk48DsjnMRvueSj2XWJR1JjNs7b/3rOCj4?= =?us-ascii?Q?shealzSb8UXpqkgcg0EP984d5Tzuf6dR7gcGLv+HMA+qoJ/C3CFXBcmdRG8L?= =?us-ascii?Q?Guv3m+hT+TOuHp7fMGKGC1hKrZuCum4VeCkQDzk7ds3Y+F148DJdWsIMWmfl?= =?us-ascii?Q?aDof0CQGivpZ/7uIhrIYd4hPL1CJQKsLXAl33Fhx4nsAt9isCzBwCv8JvxPC?= =?us-ascii?Q?f5dARxx2AfTymmSF7ItSNLOjESV+Gt6vdpuTi+mvYojR4dh3YV6hIRWf/y8/?= =?us-ascii?Q?49oOwPa4A49krEgZiwLYI/GbLmuCC9rePIcSvGC/jD5xVyDnsLEPnUcPU3yi?= =?us-ascii?Q?EKypGUo1pOJb76mSpMlBPUiRtQA4YC4uwcbL50/OXE+ANvR07S79OJIYVKcu?= =?us-ascii?Q?JbZTf2PFgUMEmR7TQ7X8IC50sABMlTRB1+buKPbuhEMEJ29DaInG4bstF3Ta?= =?us-ascii?Q?nDRx34NKZqmpMZCBxhgRrYrUafNT/uJpbl96eFY5IgZ7UheXrxNKGHLt6ovs?= =?us-ascii?Q?wz/FIJL73gL9eB3aVgSxFGd57KGLqXB2U88pxsJTrLHbpqLvtqcXQhnTq8WS?= =?us-ascii?Q?Dy+8qKY6gzUDmWks0w2xWvawAGRdtUL7aiAgFmKqWnmJd+MfMKj+JvNpc6Zr?= =?us-ascii?Q?1v30UwDFMnYe/Q3nOT+4wKXwuA5KeHQH4WMRHYZkqYwpbS+DH0ov+o9UiuuU?= =?us-ascii?Q?9DxH+h3OjgM4932y6dC8zMZY+S5HOR4HBbWBe+qezVQ5ov7N3qmHXOzjV1jG?= =?us-ascii?Q?dRjBNio/+ZQ9MwpzvZ1dP9ac533qcUuzcOaqoR9dPV8Q6tzNYJd96t73zfnl?= =?us-ascii?Q?F1xg2BD7rdd0xQaLgTQUaggbLF+6WEZXs1o2ChenBQeN1crPqSgyea2oUUba?= =?us-ascii?Q?uwaoJDco4n0W+10gLFKjbvVZl+WHOdIH2lukUW515iK+XVqdTrquTptaFXiG?= =?us-ascii?Q?IIFUBnKMvwTJ0TVA9GK/yeuTnZTbbzfU9bVSiD7mZhCJ/aa76b+CeUOSe042?= =?us-ascii?Q?kSUuyOdVprZBGdnX2Hsi6NtUBzLCq8VkOvEMV2P1qMpzpkz+Ng4mpFtGtLgh?= =?us-ascii?Q?Bv8DsjUbF09o6Q1zkfq1EVJ8pLRjMaUmpEpQ/1xF6/JN9t8YUILaJrBBuJ9a?= =?us-ascii?Q?97Ani/vLst6Ypg5oflSodVjqrKbGJGBaIjT+Vx8nOkWFefxbBBiutuP8+4sw?= =?us-ascii?Q?aGZgKYMZEu5wPwEpfH+P4dco6bTU4DI4bO5NIwWfTi20rzQ+mX4Mh/j/9J2S?= =?us-ascii?Q?QUZF104M44A9rXx/MoJZ59Rae+HGvYJNCIDbnsoUG9BuRiD8F+IXqKF6i/YG?= =?us-ascii?Q?1E1SyMoMJWaBbFro4+DIXLHwM5hU2wKlLFecMGBTVJ8mxBwj?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5b485c-62a8-4932-266c-08de8ba2328f X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:08.3736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ELgQZ44u6oYxsr7wRWYmmG5lAbd+zL2UpVZ+xV0GzeNFZrCu8Oo2E51HDS2kpKct X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" They are used by READ_ONLY_THP_FOR_FS to handle writes to FSes without large folio support, so that read-only THPs created in these FSes are not seen by the FSes when the underlying fd becomes writable. Now read-only PMD THPs only appear in a FS with large folio support and the supported orders include PMD_ORDRE. Signed-off-by: Zi Yan Reviewed-by: Lance Yang Reviewed-by: Lorenzo Stoakes (Oracle) --- fs/open.c | 27 --------------------------- include/linux/pagemap.h | 29 ----------------------------- mm/filemap.c | 1 - mm/huge_memory.c | 1 - mm/khugepaged.c | 29 ++--------------------------- 5 files changed, 2 insertions(+), 85 deletions(-) diff --git a/fs/open.c b/fs/open.c index 91f1139591ab..cef382d9d8b8 100644 --- a/fs/open.c +++ b/fs/open.c @@ -970,33 +970,6 @@ static int do_dentry_open(struct file *f, if ((f->f_flags & O_DIRECT) && !(f->f_mode & FMODE_CAN_ODIRECT)) return -EINVAL; =20 - /* - * XXX: Huge page cache doesn't support writing yet. Drop all page - * cache for this file before processing writes. - */ - if (f->f_mode & FMODE_WRITE) { - /* - * Depends on full fence from get_write_access() to synchronize - * against collapse_file() regarding i_writecount and nr_thps - * updates. Ensures subsequent insertion of THPs into the page - * cache will fail. - */ - if (filemap_nr_thps(inode->i_mapping)) { - struct address_space *mapping =3D inode->i_mapping; - - filemap_invalidate_lock(inode->i_mapping); - /* - * unmap_mapping_range just need to be called once - * here, because the private pages is not need to be - * unmapped mapping (e.g. data segment of dynamic - * shared libraries here). - */ - unmap_mapping_range(mapping, 0, 0, 0); - truncate_inode_pages(mapping, 0); - filemap_invalidate_unlock(inode->i_mapping); - } - } - return 0; =20 cleanup_all: diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index ec442af3f886..dad3f8846cdc 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -530,35 +530,6 @@ static inline size_t mapping_max_folio_size(const stru= ct address_space *mapping) return PAGE_SIZE << mapping_max_folio_order(mapping); } =20 -static inline int filemap_nr_thps(const struct address_space *mapping) -{ -#ifdef CONFIG_READ_ONLY_THP_FOR_FS - return atomic_read(&mapping->nr_thps); -#else - return 0; -#endif -} - -static inline void filemap_nr_thps_inc(struct address_space *mapping) -{ -#ifdef CONFIG_READ_ONLY_THP_FOR_FS - if (!mapping_large_folio_support(mapping)) - atomic_inc(&mapping->nr_thps); -#else - WARN_ON_ONCE(mapping_large_folio_support(mapping) =3D=3D 0); -#endif -} - -static inline void filemap_nr_thps_dec(struct address_space *mapping) -{ -#ifdef CONFIG_READ_ONLY_THP_FOR_FS - if (!mapping_large_folio_support(mapping)) - atomic_dec(&mapping->nr_thps); -#else - WARN_ON_ONCE(mapping_large_folio_support(mapping) =3D=3D 0); -#endif -} - struct address_space *folio_mapping(const struct folio *folio); =20 /** diff --git a/mm/filemap.c b/mm/filemap.c index 2b933a1da9bd..4248e7cdecf3 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -189,7 +189,6 @@ static void filemap_unaccount_folio(struct address_spac= e *mapping, lruvec_stat_mod_folio(folio, NR_SHMEM_THPS, -nr); } else if (folio_test_pmd_mappable(folio)) { lruvec_stat_mod_folio(folio, NR_FILE_THPS, -nr); - filemap_nr_thps_dec(mapping); } if (test_bit(AS_KERNEL_FILE, &folio->mapping->flags)) mod_node_page_state(folio_pgdat(folio), diff --git a/mm/huge_memory.c b/mm/huge_memory.c index b2a6060b3c20..c7873dbdc470 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3833,7 +3833,6 @@ static int __folio_freeze_and_split_unmapped(struct f= olio *folio, unsigned int n } else { lruvec_stat_mod_folio(folio, NR_FILE_THPS, -nr); - filemap_nr_thps_dec(mapping); } } } diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 45b12ffb1550..8004ab8de6d2 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2104,20 +2104,8 @@ static enum scan_result collapse_file(struct mm_stru= ct *mm, unsigned long addr, goto xa_unlocked; } =20 - if (!is_shmem) { - filemap_nr_thps_inc(mapping); - /* - * Paired with the fence in do_dentry_open() -> get_write_access() - * to ensure i_writecount is up to date and the update to nr_thps - * is visible. Ensures the page cache will be truncated if the - * file is opened writable. - */ - smp_mb(); - if (inode_is_open_for_write(mapping->host)) { - result =3D SCAN_FAIL; - filemap_nr_thps_dec(mapping); - } - } + if (!is_shmem && inode_is_open_for_write(mapping->host)) + result =3D SCAN_FAIL; =20 xa_locked: xas_unlock_irq(&xas); @@ -2296,19 +2284,6 @@ static enum scan_result collapse_file(struct mm_stru= ct *mm, unsigned long addr, folio_putback_lru(folio); folio_put(folio); } - /* - * Undo the updates of filemap_nr_thps_inc for non-SHMEM - * file only. This undo is not needed unless failure is - * due to SCAN_COPY_MC. - */ - if (!is_shmem && result =3D=3D SCAN_COPY_MC) { - filemap_nr_thps_dec(mapping); - /* - * Paired with the fence in do_dentry_open() -> get_write_access() - * to ensure the update to nr_thps is visible. - */ - smp_mb(); - } =20 new_folio->mapping =3D NULL; =20 --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC7D313E2B; Fri, 27 Mar 2026 01:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575796; cv=fail; b=Vhsy9jzN4jXHqTywcuILXj8hXg1EhVEkijkmoXJ17MufisMVbkLLzXH2bL6kdorK07/KXZNIhNsg/5Hdy4JnUld3BAIX9iBYzT4Aoxzb55sGyKXu3UMUdQjTqj0zXghgENJkJubY7mI7qSutuAGS7JLRQGPZnGtPFkjqGA65CYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575796; c=relaxed/simple; bh=G+mtyIIddNKFU9uVPmuG229YgXbxmtjsw2U0uXYDTj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AxnuqQQtF8VO+/fpn85eMlWKYVMEOIPmqu1R/7QYe8Z6yf+TKjcJeniqZQqpE5cNSiQoYOdN1Upl1uH1AqPmqO17L3zxZuOYsFvTVZ9USF28nAJZd4Kfp4IsGfQ1XC5cELuqOH3yf7AGqW95m61pWUJQBp1AouI+Zo+m0gBt0/4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ka1ndSTf; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ka1ndSTf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bFIaeul7VonZLDabQVhk/kQua8SRYz7bdPRDNlRqiRt7LQCzSfaJBU/deJMjR8Dn1BhLOM8dS6IaQQSADejlzrAEjy6HvN83UN9vFqKAvm4VJz633pnf3ngYR5sf6kjmmkZYPUAXqAqgrG2ov7BM7tDyf7vtPTLwANDAodcqkid71ujZkbTrCJCA06ZXT+eePDKkVwV6giW+yM6q3c0NATsVnL7l5W1cTl1l17ig6lU1W21nI0qWbEHYfWMbhPZ24gA0jSNvQs5/UmwS3NDXdFp8lHPza6YibM73nYZSfbxrHrM4Xyy7w5M1rX/KNbirmDtgpNsOHzT1YELTJXdXZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2WaMiXzr0SQ6SLYDBfpHefvZxYslS1JRPY1XuHrOOE=; b=U9DKo7hP75q4ahpZrMaVm3kKy7MZ87Od/WeXbI0kWtRqkPH7JkyK/vB0ssOMkS7u0wGtxLwkpDyp09ZVe3mG7bvHFqViscp+reKz6q38zRwBLZmgG45VODY/biaCqhBL/Oc0Bxbb1CeJdAjz0adUYopeYbR++rpE5RfFJ3IXEquvKJO1tVkD+fUSSoqg5E4CC3dLKC0TAyWOPBA/KHbg12kiwBLPxL4BsFiEgiBq4WYZFe3ggfeM7tK/2TKz9I+V28ia/1BWmRxHiiAdMdJROSKTm3l9ZS3oflsomp6RR2VRCIGY8Dffho7jxbqlVQ+EXZ+pSt6iJZOg8ARiep3k2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2WaMiXzr0SQ6SLYDBfpHefvZxYslS1JRPY1XuHrOOE=; b=ka1ndSTf3RR1aAUBB457Se3s1kbAmwlUN+SAjMjENeNxBDuDoRAya7AzGvfCxzj8tcv3aALjNSBQCySX98eo2CNAbxMiEs6ISmMOejoBCU4mTrJq/Ip8XPR3EQhrXRYWQO2JeasCgwQHhv294FUY8v1k1mSxn99Do68NW8/akD9YKmoD1disbRRDya9r2BDI4vd83WjGxktuywaZKc1k067sKYTIE/WkulHeG11pwr7JyUJbw8pmf3GS7allDTmwnoPh1+sFhy+JclT6NvtKge8pqRQ3epQpTlKlXixqnccY3MUKB+piV/zjR6373DCFq8icCBDk+rZk8ujbJrCRyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:09 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:09 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 04/10] fs: remove nr_thps from struct address_space Date: Thu, 26 Mar 2026 21:42:49 -0400 Message-ID: <20260327014255.2058916-5-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR06CA0009.namprd06.prod.outlook.com (2603:10b6:208:23d::14) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: db36ec20-ec60-4b58-506f-08de8ba2336e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: gV2ZM9J8L1wuBkxN3QDI7B4yx6VhEQV/DZ7CnmKbadYsGVGCHTUfO7iLBOOcScrmmSvw3O7ehA35ZGz7vP+5rkCT8McfewjENtg5m912PTsITnMhMlt5uJQpyFN2/vonr5in2tWxxiG7Vzmb3fueuwi4KcQ7iNFoCVjArQf70Zyhr8G036lhXemrV08RZ1TWmkE+BoNpOGmVGohHY4ZFdEYP3QzWaCAzrEDiJxoLiiqB5H0Utw7APADa+LmrSsHvIku6kq9hskCQ44ZDiM4Sp5EGaghlhdXlqU3UkCUEn0sTCjbs1s2gs2f8VdB2Oqqv1xTI8h1W4WkjFSb6zfCG/8r01CZ7qXKbLY/LU4usPSULGT46quqSAQXlK6dKJ2hadEy/EwVemIxS5keZxkTvkPhTBMdRIj/5o3I5ze4cBEIm/RrKVHPY95bLZ8cm38Ek2iJGfbV/G/Txz4/ObJnVf4eZJ6dwpO6hYddNyT6Hc0XUU7a0c6RvCkn2abj4y1+SJEoPyLTj8sgLJVCYQF5c2WWbLFYxGpDFThBysjh67vBtDngFk3g4Z9IZqcpHe9ZRhtwOyP6ULMGf/jkHuili/YEy9QoN7XinRFm2BJHuzbCU3URjpZdVQAxk6c2I1UXw+5WQy8T3KHl7DHNFmFi8qzEvNGiFIrWO1n6tv3FJIa/hrOxU+lQhJvUMR5ao7bj+D4BoYBgj+uxB1SH3BoEmrazFsblLYeY6WEn4bWx+gw8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M1ahI4UexvoPqOnycmAlpz+nJQi6Prnwg83Al7KUpzcVs7iMpGLhqimLLbWA?= =?us-ascii?Q?tFvh0BI2rtHhGKClDchsP6FRMp51hcByI+UwtQwPsa0tKVNmHis7YGXH820B?= =?us-ascii?Q?lSs+vIMF1UKzxRPZ5ufxT6I5P0Q1Tj+8uPndCOP4lnFmywiRJFIVZHtAwMcG?= =?us-ascii?Q?tT+XZkm9hF4W/CCGy8QJgMiEgRrdhxIHsRf/Jl/QMJJhLdaoEm3A73DrAmrT?= =?us-ascii?Q?N+smrrHPX6QJjTKMizPDeBlpkR/o2X631sxm6F5ezs4bIcoQQjHXYRKJLWlt?= =?us-ascii?Q?K8l2dWaQTdy/6YcuCpSB1RrMq0wVypmyy/zHCTxDDcEQ/558O1xBqd+FxGKm?= =?us-ascii?Q?n0HPTvCwk1kEUnj3z5zUS6Q8ifEf4iIOq012hrevUQ+F+YoBbYUMd7U8ygp5?= =?us-ascii?Q?EJe9yLSY7dXk7E4R/H3II4dEtjjk6wOzVuDcCuAMWD0cxZ7zxGFYyM+JgpbH?= =?us-ascii?Q?R1oOGOh4FzBzLJGoHEfjqpyemMAEdFYLXdfXWsTH2F9DZ8636e2Efxv+FtNe?= =?us-ascii?Q?H7dpCYUxvARwhEvwILPNI9c0AuZwNwTgVzUc8KvvbXXrcoYTdHG+C5yljfs3?= =?us-ascii?Q?euAkrPI0WC52PIl6y0wkHwSEU2s9VO2kilw5JbvXTpm2uzpvO72IDe+p9UhI?= =?us-ascii?Q?9PfEd+itauO/cnjZe1lLn1GG1L82rZn0gM8zoMSEu/vcrXXj2y36+GRmqwc1?= =?us-ascii?Q?AQvGdjUBf9eZ9eKTZpKoljJcvt5UhkjSqSVFo8YbrtXw1hizSfmiVpzwJnZT?= =?us-ascii?Q?u9s2/Lfj8it9EWsbP4iJpPaalUEwF5ki1jbWZXGVbze5kKTCVt6dDhuX3rv8?= =?us-ascii?Q?J4794GZgtN3LBHXlFjfKn2S55fAwykoNKGFRnLV+sajVIvLe+IFc5/kBn5uq?= =?us-ascii?Q?eRl9l4leEe1Nz0jPqZ8nnkGSB7Mht6xfZ1Iqvjuz4v9+/1Uk+ZOMgY8Tzxug?= =?us-ascii?Q?Fs8FYvJa2Z0kF6VQ32c5T9FmPnWJXpNko05mL+C2OaYgtBDMcH63o/3FKnGW?= =?us-ascii?Q?gD/3jvlNy0y+O9iXg63o4t6fRrV8Z4WqbkW5BdYAmrIPMPj0BBp+NALdjgfg?= =?us-ascii?Q?9MwZM6aCop6Q1IueQq1qzwvqcy3t7BQ3kyfaAEaNslQlJp07cCRu86fQcCRo?= =?us-ascii?Q?rapXhAjGD1gzk4jJFJVsxVhdsHgk5r5HgmrsP6A9afZtEg0FlDOVsqlPSg+w?= =?us-ascii?Q?4gUttzBKmFHcenfdpZ+pPR3qR0ks/+9bz0swkUnXP3UlnANpdj9FpfHtVAro?= =?us-ascii?Q?FqzFpC9PyTF7CnlpGuBwpQuvrwccdlrufNImph1LvdDUOpVQGzk9FMmtofFz?= =?us-ascii?Q?bVzmkNdfzjUHhDmTCqr0kTzU/9eEdwvYo6nggWgJf68JDVFw2qCSSraXNLSH?= =?us-ascii?Q?lX9YDe0ucj8PSr42s7TooGt6f16o2/W+957jtdr5S4YN1zNCD4F2jA8K0A5c?= =?us-ascii?Q?VPoqcHL1PhbDxPJQ5UIVap/mFssiMdMduk8AcpSOXMJAFE+eP0EzbJ8lJnOo?= =?us-ascii?Q?9H+qWtmMsqjymDDmqz5LyiLaktmr3DOUsIqE3NuR2CcgG2gRZYb0vjRaNB1c?= =?us-ascii?Q?s8nzYTnuB2PVm6qTTb6l+ZzZ1wt9JnQk4gVcp3FsQkC5Gglsy6cJOpwBvq2B?= =?us-ascii?Q?OLSDYSzHGrVfQms9NfUjlzlPJeMiQJjsV3c+JVovivy22H9O40rS0eQQndqw?= =?us-ascii?Q?AMtrEyfKxG/S37TjXnt5UQSo1oZQcnqBH7VA1u7HwdmPG2RF?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: db36ec20-ec60-4b58-506f-08de8ba2336e X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:09.8017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XFr+OdopehM+lWczBuRN9svtjsl3SMy2VJlzlEd9YF4g0tqawv9oEZCyZ4/v/qDR X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" filemap_nr_thps*() are removed, the related field, address_space->nr_thps, is no longer needed. Remove it. Signed-off-by: Zi Yan Acked-by: David Hildenbrand (Arm) Reviewed-by: Lance Yang Reviewed-by: Lorenzo Stoakes (Oracle) --- fs/inode.c | 3 --- include/linux/fs.h | 5 ----- 2 files changed, 8 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index cc12b68e021b..16ab0a345419 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -280,9 +280,6 @@ int inode_init_always_gfp(struct super_block *sb, struc= t inode *inode, gfp_t gfp mapping->flags =3D 0; mapping->wb_err =3D 0; atomic_set(&mapping->i_mmap_writable, 0); -#ifdef CONFIG_READ_ONLY_THP_FOR_FS - atomic_set(&mapping->nr_thps, 0); -#endif mapping_set_gfp_mask(mapping, GFP_HIGHUSER_MOVABLE); mapping->i_private_data =3D NULL; mapping->writeback_index =3D 0; diff --git a/include/linux/fs.h b/include/linux/fs.h index 0bdccfa70b44..35875696fb4c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -455,7 +455,6 @@ extern const struct address_space_operations empty_aops; * memory mappings. * @gfp_mask: Memory allocation flags to use for allocating pages. * @i_mmap_writable: Number of VM_SHARED, VM_MAYWRITE mappings. - * @nr_thps: Number of THPs in the pagecache (non-shmem only). * @i_mmap: Tree of private and shared mappings. * @i_mmap_rwsem: Protects @i_mmap and @i_mmap_writable. * @nrpages: Number of page entries, protected by the i_pages lock. @@ -473,10 +472,6 @@ struct address_space { struct rw_semaphore invalidate_lock; gfp_t gfp_mask; atomic_t i_mmap_writable; -#ifdef CONFIG_READ_ONLY_THP_FOR_FS - /* number of thp, only for non-shmem files */ - atomic_t nr_thps; -#endif struct rb_root_cached i_mmap; unsigned long nrpages; pgoff_t writeback_index; --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9042318140; Fri, 27 Mar 2026 01:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575798; cv=fail; b=Foid3YtV2mF2ODKnT0XAHSoBLVxIzg04JSE4mFQCdaZ12ihiRjvwL8nBWH2dk6uAOl11KJRKrOu1Uk7udjsv99YLeXKpCWn7GoUO8k5fRq7/ty12l9FLrBasFh7pvB6sfacx7m54AbrH3RQrGWvxG7FBRfThJN4UbmRAt7Tcc8c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575798; c=relaxed/simple; bh=rXC0JHI39eZltG97tBA2UjB5XXBNKSnOpV0mBekO8G8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hpRPGp/3D+YYIAizszh3JtGfthLcgGw9S2fSntcNID1eJUPDRZWs7NHn7M6wDPGLNFO08frS8nH9RwSdF32myamLrW+MCcZxQKix1/65eMDJ1ETZ29AuUx4MCSVyMoXlTS8kTzcxDC7yvGPpREA8wEBR73WrUBb7fyU/T4Z5Nwc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WPlaD5oy; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WPlaD5oy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G5J5xd7lt4l6t0tMA5iyhvUQN/f0JSQXisNd2sJ78zlnaGv3hFN/0fFqsc4UO66DZnSX8/AZ2pVQkQ44K/JTPexYwcMzbDQdVMBXjI2kbbY4AZ98dsfsjbSDF1gAbCRBgx+UXxZhh2yw7WgWZdP0DeRxFkQNgGoIGoK4uURpLxXFwPLcEwsTV6uMYxDreVn3X/YOwPIBWS4Qf1KjhDgN11qELkTih+awRnHr4jLjB8nyRjUiNM7yXeOWVEaWagqbKIFBe09XI1bU/X/QaAlDT//7eY9E9N42+LMoWNPKZ/wkJ1Z10XTc/jVo4t7vSpNYgYRoNLVv6W2iXQ1r8uRi+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vyKTgQ83LLLb6ncoRmDmURZxAiCIJUZ9eOAD9u3gWE8=; b=jOPwcrIf69SsXmnvtVClAxXYD/apzY6DzzwYZ/r8Ys4NvRVepjWT7WlxSZRLbVBl7ElsDW9Rfh5k7N0swcUxDOiCxNR4qa5k/f69WR5YxpjedeGyTDATm2oCPuK50qOGqhJXCpCmZV6LmEI8kIZxu3ITtPgoOajJDg61mWtHfE8P32TiUqoig9S0SvjKCCAsYBEvc5EbpH4kdLnN83ie0in6XFoDdHA90UTZ/ripM+TQ7Z0hdbt9WEAHjwoxKF3dxX716cyWPh44o8yUMq0AwBlSJ+8Vbs4z4qXfhDiVD+aNGiZnkJINE5I31j0+/FKaUlklAYrZuQkPZYGyB9zuUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vyKTgQ83LLLb6ncoRmDmURZxAiCIJUZ9eOAD9u3gWE8=; b=WPlaD5oyj/X9S/hWosOvnKLlUWpOdt76yKXoUidiU8uyJrbjc46Cf6lGvFpiiyMyOgjwbSOwoMyxTQ7YBwdNN1b6L0obLLAtCOut3UE2/YbguChjhJIrELC5QSQ4dhPtgl3c22fdHGlVh3Jgp2XtZJV56f3OwVD48WfoE7w0+CH9TK0AiEyUZWnsooSWDgOIczBVQQxH1P44scosfrAGZQWoEQWuOOzK59AGeWG3DmgGkZM/xlBKsDjD4zlBiwjhUawY2cFsyEmekuoWy1a8aWJnRhMQ35KO9DuUFMj8mm8JtxDCm+NOVt5RT5pOMMy5RDcD585jGqGRTXYO7xsbbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:11 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:11 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 05/10] mm/huge_memory: remove READ_ONLY_THP_FOR_FS from file_thp_enabled() Date: Thu, 26 Mar 2026 21:42:50 -0400 Message-ID: <20260327014255.2058916-6-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0153.namprd13.prod.outlook.com (2603:10b6:208:2bd::8) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 87d06398-3d63-43fa-2cf1-08de8ba23454 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: uyTOVabxsCcg1//nS23wi0RRUpHwJZzUGzj8i+5F5yFi8R80p9XCvuhMkhKFxE+ffSykcvoGWc/+OfxfM2ZyQZSNVJuj4M/ma/Rw4EWSQ2kymRop5rtDA217Bl35I7mvZ3dKEmClcwilixwDoSuhl4tr2cJMZNoqHtHj1aY+FDvGHulb8vxeOMuBcsXMB1xRXq4Ja3b+vUR/uKbN2QcPlmbLFavdolhNwmXhJPHRNC64LXYkLVrQCbGpxCqAyHxrqVKTA376N92j1Ak147+mGBCh+Pn2YDuUWnH7qeiGm3+yyNPDAUDaY+Am34U/LNvvkqKl2bqI5rCKaVI/Dpt7SXqvAl6JOxqbv8AvDAArZklxr5MbS9/sSUBkVfgmpgy5oPsBGqUYeguxs519MpmqXF2u/PFDloUSKy7DqtWu5rwp6oh2xK1dy3cxeCh8Wa5DW6PzqGY0uCNYEQsRxgHodkZ1Tl4PqvtEppQIlQbHiO0sNdjJNocrHrFltKot/kT1np9b25bb2/5nhaaAdo935aNKII/AU5aUEE4DYvB8cPu4/V+Id824vCeo283rRslibrRBZeZemfYtYon79ft+IzyMnsqnFO5sVxI6nkb3sTbbIkYwRY+koFMKaSJmbPunFjhp+l0sqR0YDqu0oTzyqDd+J8IKG8X7X6/2v+XfPrht5d+wA4N+dw4d8NHkVwEcJSrLxBRNIKlYajZSGRT3aAkJkTYWg3oQ94wl9B/Vav4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vGndVa/eBqc+etG88qnAoPFs0giUbpT1luq/Yo5IU2aevjm0qT6YIhduHQ7r?= =?us-ascii?Q?dCuY3KFNxqNXoR80Wqg6DcHnS8087/+LQNO+ncF/R1E3/mpUQ4DrDTEOBQ9w?= =?us-ascii?Q?0P4stXwIlcnteAkRYXmRjGT8XR8XEfVfM0ox2DekFOMmKm/jY1RrJ+Ub0zAU?= =?us-ascii?Q?NDC4L/AAfrip8CaefGihE1rADAAwi3yZwYJXVMwGFB50H/WG68yPDf1vPlNJ?= =?us-ascii?Q?h24pGLc0vu+yenu8FUX7gew/oY2mMZ8bR+eN81ZjiHMvn4Xj9o2fJ/O+NKUR?= =?us-ascii?Q?wTWXQBRcxJHuhOUPtdeMzG2/KBssPn3h56h/xWoDRSNXu2hNp4DMIrkTt0zM?= =?us-ascii?Q?G0yY+4jbwiOrJtKvEfuej8AD6jHHqQtn7F0oEF2mSVafBpSC712tlMNLXILK?= =?us-ascii?Q?jVeVpbBXjne/RN60juebas9Pws2mRJ5D+PtrTpwgDfFP/mOHEFSNaH18+ESA?= =?us-ascii?Q?t4VS+LKb4V/l4VQai6FHv3gSjbB/LQAH5Yfv+uFfDqkLtCumLFxStKPDbygX?= =?us-ascii?Q?0Jr04NJbYuPuobjPugucM+a4MpRBFRsjPH7ZjdQJ7d4Hd4qZARBS6a6BqFiy?= =?us-ascii?Q?Fd8jejusvLtDHB/p6LJ5hvfmitgwt35vwILz5/D/sHbWmyt19Pz2t7xH6BZE?= =?us-ascii?Q?nrZRDTMCCJeB3OQ7EpeXAAMXRElObmnNj9T13ymWRjupjlEeI3dIUPI+Flt+?= =?us-ascii?Q?AdXU/5BSrhG5Tn12xC59vIoEDx+26zbjzlxkkEMzavnl/KrP1ctvGIcGc2MQ?= =?us-ascii?Q?6pZmGUaXQ+l3ojTCuY2ldJlvWB/paGk5WM3uI9L3sZPbDYQ5m6Liu0ErHaKG?= =?us-ascii?Q?T2YlvsBoB8mOfIfx57ErsHfIb8itqHts79CGVCP4rCMkyq/Y5LR3/OH6unyX?= =?us-ascii?Q?YaTCnRHNc43VPXOgxC6Iyfi++/2oxQgaW5S3PH/n6flhtCbKcxI+vUCoUbNY?= =?us-ascii?Q?t60WmvefZxFg5NZPgN3fiwTac5MWzZkLUii9r5Ea/8BSy8tsurLAf6y7koDO?= =?us-ascii?Q?KNxOzuhyn8YbRdfuGXAWvC3B3i/dwr1f5Y9TjPVAhojv9u3K94Nifbzm8E/s?= =?us-ascii?Q?Wi3QOzO/DfUMLh3dp60d11RMYPfY3AyJyXofcXohvYaXdrmEP12apUNfwlms?= =?us-ascii?Q?8dMMTlVZkeYuT3dDzP1+WRwSkV7Knp4+E3M4V8L9Dz4A3L3bf2EbOGLoSdC2?= =?us-ascii?Q?fcAb08uhJUKYQO51DQDheTZKW+8sXgcRL5czi80rdrmK0koSCnTG2zaUuVRk?= =?us-ascii?Q?Odm3glEWmagLK70wbnsPzy8Ry+8kiocMW0CUtbEH5G7NgrTje8eXMBSGg+NT?= =?us-ascii?Q?PvVLnuvt66ZSa1fegtMJmZKFiY5r2tHhuJh2INUS8ZxnM4C+NNCgXnrVfn0a?= =?us-ascii?Q?m0eyeY3XAutVH8aLqd6wuJBWT5m/gKuZToKPUV3j1PAZljIYemBCUAMbNubb?= =?us-ascii?Q?u1YY9zjTO+8Wt2Q48LErpv8USCWE/oA45FiwLfQR0Ho2H5lKKNKb0NHlK17q?= =?us-ascii?Q?jRJPMQjVi1atMB1J/Rw02Nf1DyNi0fBu5bbumrYwu2oYusaG+FveL8ZR41of?= =?us-ascii?Q?qaAq/+i/M/fHdBQ4Gp6zDBjv6RvzNlF+TE1YXM2a6J02HWUoUI1yWlVECM80?= =?us-ascii?Q?kX7UpO3CnMqJ4tjnDFO4zmI0fPuXAl02vqAQ2Wf0BVlQn+E4uASKARO09lcz?= =?us-ascii?Q?Hls/zpqAerni4oHnlUcFTVQTRpDn4g11VVT3D4TMNVfsn69q?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87d06398-3d63-43fa-2cf1-08de8ba23454 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:11.3512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VFekZCG7ZVFfiM6akiIBo9NXALPTLeMxLgxPJXmDHLcN1+jy0i7bLGCMQI57LqCU X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" Replace it with a check on the max folio order of the file's address space mapping, making sure PMD_ORDER is supported. Signed-off-by: Zi Yan --- mm/huge_memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index c7873dbdc470..1da1467328a3 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -89,9 +89,6 @@ static inline bool file_thp_enabled(struct vm_area_struct= *vma) { struct inode *inode; =20 - if (!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) - return false; - if (!vma->vm_file) return false; =20 @@ -100,6 +97,9 @@ static inline bool file_thp_enabled(struct vm_area_struc= t *vma) if (IS_ANON_FILE(inode)) return false; =20 + if (mapping_max_folio_order(inode->i_mapping) < PMD_ORDER) + return false; + return !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode); } =20 --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B83332EBC; Fri, 27 Mar 2026 01:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575799; cv=fail; b=T3h8oyDRHwpxKFeYWWwYiD7zX64MMSgomAQOR8XNcOQq7/gHU95GYaU/2MkYj1OqYJan3TQVxBvvDpScMNqiup3nn3bmCeOLUUuKSWLHqOAJYCnrImrYBT/EIfX2n1nQyj4eyZjU2VnCHa9c0bKoFcEVS39uLwT70M5l7qfooso= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575799; c=relaxed/simple; bh=MKutWTflCDzb6/XA2uefuWVhd6eNy+IKpNtcjMyqVPg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AowV/bKbzwx/re2yif/D0N+Cb9kvL5HfbcoHEGx3ipZjkEWjaA3SippvRME5a2MNmKRQmT5tcFbkEnFGqguXfH+ACCGIJBnsvgC9OuiWozlHJ0yL5SuOfFDalR4+OiZZXnN/4EQPMyT7JhZQGxFQQ/6yj38j61Eh1HS7Nw8wWQE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QASeVphB; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QASeVphB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B2ITwmA5kfDtbtZ6uWfB6lUtESSvo36T6t6z43dikF2QeNseltD3FE+73HrCXUkZ6wgjhQr+1XbWozYmfZ9k9fKwB2+bso3l6KRSqXiOSxvcqK+I2pyFqefMk7ftSS6D9AVocXGYYXJbTzmd45u6oMhRbXZGy0iaDmdgWjYA9iBye/90hLAXfqJDHqFBqx7K59DCrxBigWPGKQkOThWADl0uD+Hn6Nz6xJUnD2aurL405XKqK2yKWesSDK6m/dew6GF0z5ntEYukMQQrjz1HlCDm/vC6vJ75OOxv/CfQuOlosTufjSb62ZyA1P+/XvYxmeT01V6fVdwJXeaYARyr5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oOQ7A6je51Fv1X2GQXdHO1MZyQrpIbFKGewMFHxLhI0=; b=It3vi6hgjKz/6JzvlCI45ZS17FP8WE0D2E/VV9UcvREDf/U9veQZPCxB+jBuwbzup8tfXRL09QLBCvHHfaa3h0QR+YWE+1NhDwid92lDTlmDag1yiWhcYI1VcDTDNZe2RA3Zi+Quj+lKc+uBmTZZk6EmPmgIRhYlg7NUFdo8NMNetFS6OfZjT3ms/3NeLyq+9JtIO1xrzSFF93fnBjPCOmo6XlT4tzjPrCzUi3kC/P6eN3rA6SpgUpWCviU+3+kallaCDBIvXHiMI0oe07a2MaWcV4eT8bnIJby8g2TSvHsIHMJZ7hYLU0fYFq0IHioc6wnx7RB7HKxM+g4Cj4KOjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oOQ7A6je51Fv1X2GQXdHO1MZyQrpIbFKGewMFHxLhI0=; b=QASeVphByR1RUQX3yoz5AhGF0iEijzKMjtXKCGfSN8szXQgca37LSqao7XYtWKmO50AQrSBe1nPNSjgwJALyXsmAPUYjM7QQW+AwbUcMSX0AAsdoxkT4ZS5x2Lfcfhcj60PE+VmaXuhFTcRZsX3my+jEgWxmZ7q0motZZffqwlDe2n9fhlKR4mLYoa6NBnBxbARa3M5diC1it168fWxeyZfpHEcQlQcNONnhtgw+8RLfwE4ZGtnWGm9fLCgAAEFOR+si7CXxDrkuSJzui4PiBDeE7o6Gpg6RrJNhZ8FkcCehZabul170nJWzTjsF2RImdQeuQLw0D/Wx9HMabDYV0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:13 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:13 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 06/10] mm/huge_memory: remove folio split check for READ_ONLY_THP_FOR_FS Date: Thu, 26 Mar 2026 21:42:51 -0400 Message-ID: <20260327014255.2058916-7-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR06CA0012.namprd06.prod.outlook.com (2603:10b6:208:23d::17) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 71df9c0c-8736-4573-3391-08de8ba23553 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: M/5qczl8ERkxUbTn09heFWFuMiMITzStUSzcXI5ReTlCQIMUO8x4IeuS1GJ1PZ6KvYSC2HraYusu3i/jMOZqaRwukaYGGKzQo6oXnYX/QPrRyNoAaGnmb1smuwjA10/GP6/cnOBXcKJteP2ICzQmsuYaYeXiJEZJKUyDMYUWubI9BwHn9sK52BxctieBkLy5Q0wL/7GsQ04JeSicWVTmz28JtLO7eDlcc10DSBtKx8if5976/xIq4VCf7i9QM2uILAPx74UtnxG0srK+9FvvHuFSF1a/is1fofb2/g3oUkCx2QK8Lttl1O8ghd5mExqE4Tx0ZWrxubvF3RJ9Rwj7FqjRH8dQZw9e2P/BpesLZKSMKZRQlcV0QH7NVwSWRd6xHTe6R9oMyxTtqVUolvOLau6gVH+sm9Yvwka35d53XzHdabw/J21i1DjLg1RXSzxArtc9dDZHWRp2Tuf1kRLWKZi+Ml+NHEv+XCvTiZwfAgo6cCnF4TyEfxMLl95DAPcBv1SJ6DXRZMifK59iPXHy/EpCrQeGlEDFSO/jr4wQdpQzB1X/ZaWA8FfLYhRtksGum3VgW4Y+WRBUzIbdEJNbFWAGYAMfaB51fC6Ldkqhtf9cna/1pC0eYzu8l6ZfOGMLBvc/Sev4hSFiCN1Wc+AnvyWrtB0sHUYN5H4p2lcaefjukqzRrfOMLI6iONg6C9jOBj2/zKR7cP5NbmXdcNTJ39g0DjCCQaipo+AbXiGuyPw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oxs5I9LHaaRrT4GcTERb/PRA1zdP42YvzKDPRAK5Ccx6dpME94lm/NiGNIri?= =?us-ascii?Q?//GLpDm1u79ZyFDEZwP4XwEDkWg0FGz1RT7UmCLcLH0LW3cD8AF3Z/dGfwX8?= =?us-ascii?Q?sWkw3uuQB19BQNtqRgRBeBoPU9jjYOIyqamRpZGvTCu/1FLeBb52qJw+y0/h?= =?us-ascii?Q?2M5/zspOjKyxx/Q3IZ7cym+Vh8Z0ASvouXoq+RPYZ1xUbl2CrbN3LsSJIPcI?= =?us-ascii?Q?CVC/KQFAbbCbUNZmF1yrltB0JXfnga+PotcODxKi+lKwQnG9qG+CVYrRsuaC?= =?us-ascii?Q?sRgtxX2SOhVgoKCHzY1WaY4dU1kyQg6tSGznrhLAaqTSIunLAalnmQAmMOBq?= =?us-ascii?Q?EeQwiqA/ErjlHcmUyY5a4bgWNI9e/vgsaM3wP05hA7ZuYo6MXhpyDG1/DuVo?= =?us-ascii?Q?jYXwVcK1cKogtq/kGpiw4uQYTLbAQGJrvDoj29FB6E7celSdb3RGSACe0RgP?= =?us-ascii?Q?lIYsgGzwJ0b6xSumxSGiipO7+YDPZZjY/1jO54drk3G8uaAO/UQZ5mUu4IW5?= =?us-ascii?Q?XxPnvAWMaCtMbyAne9rNqrUgBTTN5/FAWHhqPDTIk/7JSEbi3wovQhKYkiVw?= =?us-ascii?Q?PHdo1hAODtrTS5CevDaFSKvgL/1Nfx3wI461SOVuC4yubIHth14TzQAiUMnY?= =?us-ascii?Q?8Cj06qUfJbSk9C9Uj1RUUEGvYkGHM0HFfryPD7PIrfGPYNzept4Bthj0N3b9?= =?us-ascii?Q?bqz4um49j0UUbFVD6L8AH63y7by/6BB0uy/eI7dxWp9UOgTpRfhnnpg04ziq?= =?us-ascii?Q?FVMTmfvS2TYC7g4AR9pTv+waPQujb6PwjiAsX5YreNEkXKYrAzfvvOeeVhJr?= =?us-ascii?Q?q238Ye2+Ougr6l3/QFk+ya5k6Em1Bs5eFiWdbBbx+e22NF0pqSMoW6gAn9wM?= =?us-ascii?Q?/bqK0JYVp0OaM/cDf7DbB8PdN/ppg0Xxw4oD1KFy1plIxD7dDdjBjqnMHK/2?= =?us-ascii?Q?zqOsTWnxXnmnlnaMprhkdQbJsXejfvr6oRe0nLu75k5T88qJ6k2K/2rYO2Qq?= =?us-ascii?Q?rNlEsbfIsZIhPvVEFzIYQbnqkNiHsYJx4iG9clLKymKE4G8vxyeRiO1S6Jyo?= =?us-ascii?Q?FZD/KxNWQsZ8c0cQ7+d17aAj3tkaxwPrj1azXsubH1wiaTuC8dxbLmlqw53J?= =?us-ascii?Q?F16APko/JdpROsLEIScPDQgtvvnhLzoVs+vXf+zV6Icl9MuwwtHzhpHRavZR?= =?us-ascii?Q?Shjz06p94WPRvDBDmtRBDoGxinEDTbkrRkYNqlPvKTip5tKt2RInAFunaxyd?= =?us-ascii?Q?k/LRM61hb5Ri4+4Dps2TLhzfibP7oXs8VDEZ4rE9BXQH0fU7k4oJ9adiIWTU?= =?us-ascii?Q?lbqnV+gZ62XpTj0FrKTB2Hjsitwit0rINt619N/gUNt2JsYzFtqk5Do/FafC?= =?us-ascii?Q?VnWJYSMGrv59cFmdnUFLzqlBBf3hfA2qbOBu5lsXVGKZeLA4kJLgF2ElQWM7?= =?us-ascii?Q?DPl4+HQIizBtLs0cDg77nmuZdko0xbeFsdSlV7DmDUWrvyDeUlun7hjHxS9r?= =?us-ascii?Q?7zQT9YlG7EwyJiHmZZN/aap96wfx56xvK96k/g157u0QDRR9hhpHkhzk0VgQ?= =?us-ascii?Q?R/3Z+IJehuLihThcAmlL3JN01WgoAtl7Cr2mmF9/bQdl939jr10TwbXpge6m?= =?us-ascii?Q?l+kXRMWzKtWMyC2TmOQJEwLMw52Z5ERnmp39uFaRv1KsV21gvw+VlR+mnc33?= =?us-ascii?Q?0PpYBAQgWBWOfpJOX6T+b4YCj8BglTaoD4uUx4RxRFWWHUsF?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71df9c0c-8736-4573-3391-08de8ba23553 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:12.9891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: efQRywZvIcJvoRcrtR1nPttwOk7ugJCW1ikJKITugWrmWqjyF39L6ocGjAB3jKdK X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" Without READ_ONLY_THP_FOR_FS, large file-backed folios cannot be created by a FS without large folio support. The check is no longer needed. Signed-off-by: Zi Yan Reviewed-by: Lance Yang Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/huge_memory.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 1da1467328a3..30eddcbf86f1 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3732,28 +3732,6 @@ int folio_check_splittable(struct folio *folio, unsi= gned int new_order, /* order-1 is not supported for anonymous THP. */ if (new_order =3D=3D 1) return -EINVAL; - } else if (split_type =3D=3D SPLIT_TYPE_NON_UNIFORM || new_order) { - if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) && - !mapping_large_folio_support(folio->mapping)) { - /* - * We can always split a folio down to a single page - * (new_order =3D=3D 0) uniformly. - * - * For any other scenario - * a) uniform split targeting a large folio - * (new_order > 0) - * b) any non-uniform split - * we must confirm that the file system supports large - * folios. - * - * Note that we might still have THPs in such - * mappings, which is created from khugepaged when - * CONFIG_READ_ONLY_THP_FOR_FS is enabled. But in that - * case, the mapping does not actually support large - * folios properly. - */ - return -EINVAL; - } } =20 /* --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A686233688A; Fri, 27 Mar 2026 01:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575803; cv=fail; b=nA0VUNeSaYkZCZiGlt/X7yZwNPbqtrkJwEYENsQfGbF5EVPcl3U0r/rI0j4bKDOlFhcrmYeCSg4BreSSuCfinGiY9ketgxr1VttkvdgjUQa1IcUadVOAp+WXAOv9NIyBKMTO0/nZbg/LfVm/8W0dJ6mT8iq7TQPNAR9sVlj7NAc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575803; c=relaxed/simple; bh=VAVbRNc9IxU4dYRSZHKYlFQ/eArrbGPwYUFLyM40AFc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HWmodkUi5BXjjyjOKgZlve51VUTsswCEJsWyLwsDzq7G3UEQmACVOHr61ms07Y5olpCvZyz4j1Fes54S3bRDr5wjGYRQ6Gh2nDRTQ9EEJCdNyNoIKSE7EPkkqZ9clhCOwlJLuJ+Z8ylb4g6ceMVkiZ40YmAB3Y12H/5ThVvPock= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HyKTIwAj; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HyKTIwAj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=exLO2Mr3ioKahVJzgt71dsqLDQh9EOLQwJ7z5ucFZvJEnSEXx5xVAT0Zeg72iIOakahRzWV5moMveYDsqdD8hJD1/OMzdMYKSFeU75ykmJ+0SvZP7vM3utMR9xufHBbg0fBBRXS+z5IJa6hvVoTZG2VVxkZ7/OKMnJd4ygPWtdymWfPKxGX/T3+7wYzvP9bI2JI0Xro2c4r1qf4cpahMcQ4kERddV/+9VkT+z+bw7OzUxvxjjsX4NY1yfPi/ALmfv+K/Mc975ZAJ8UmlD9eyBDVLuKOb+VuCy6rQW5wM3i11/bSahP9CDNXK0FUD7H4z2VbLZnDMm38a8DY9Yx/0cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bY6vie+DM6LyPUx3LThLrnzn+NZ0QOuiiUTObE5GGT8=; b=DVzrrFuAAcl4CAC5M8GNu+kovtfd5P0TSYl+EaGK+Ea/eG6htH/QBvaBwGYFl/LX9FI3cxLI2HMNs09hG6pHOejnGgfvyF9JVwSEL20nyvzAvFF2ZXFRKnQITwJJvU7GejSUMAp1HeEtERz7v4XJ1nM6peCs+O7ADXdNv1GQU+gKktKcyxyFUZBmuJuw+s56AppQ7uztPNWHHW6t5W82Gcmkuyzlfl+kj26OIAPiA7YtzuCKety9l5hjYRxTUC7xPHZDcviiQOvY6iElt5whajgNyz4SdbjPk5fVlhmFtn7e/UeR8oYE5icoCO9UgtKrPoxEr+0J27kf24YOqvAjIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bY6vie+DM6LyPUx3LThLrnzn+NZ0QOuiiUTObE5GGT8=; b=HyKTIwAjweyHa07cus4/u+xaCcXj6EHSXd9OzvhijIW6G37540xQhgRfmDQ64n489E7fV5P5YQKid1JsvzVIOoPYLkpA/bX2s69wWsKQgPM5aWRsyNJsDc7S9VueJ8L0DiZz9xTtL77bYLp6Mjjsq0ZGgk4pc45hrCUiSPxNM7K/buYIpXGwH0tp9GLZl5XMYKjUfun2gQ0M0PvyvXf+dgUHzhtixizxxrKIpryVCAT61vmn0o2Q9McHn7sg1vZbO1y7e6w72TmbxHm0vky/fpGrn858AVNPdEYcJoC3VP82Wmb0c2QxMBRnsqNRPqwDvRkh/GGBUnjEtRvLRzgMyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:14 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:14 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 07/10] mm/truncate: use folio_split() in truncate_inode_partial_folio() Date: Thu, 26 Mar 2026 21:42:52 -0400 Message-ID: <20260327014255.2058916-8-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P223CA0014.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:52b::26) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: d737b191-00ba-409b-fa8f-08de8ba23627 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: AhYr675sEyTqwUG/G+sfT4Mc//YgtQjl5urnU6R33ngg7Kqu7eeMDUA2LuEvbe07MajacFQzCEHjzUbzqZE5CvjZhLaMQ7jWqYHPK9luD6Nvm/pFJ5aF4/v0UPxsGvZQbUBhIVbQdAj1SHp1QVfYarAp/Hgs5nghFG8y1NCBxUB4PxahF3zYDJ7clmqCCS2ah4wRsI8cHFkh6mfhEtlXGTEphTXP1jjIfTxrvWuujPwOpPm/dI6SFii8ibNLzvaZOSGe19TNPuPSFPqDxRVxTD97GKTTXEKHhquNPGs+Ynwbpyyq/2cQjYsXumLAg78YpUmRqw47Y/eLGkjFi7SofB31C6ZC5WU9sb1rerQuGnqedfcOE2jxYqv1rI7OG0xzrO70LCwnAyQaejLMgOO43OkYGZhEmWoNbttEUgBxW3FYuqyhsDfqoWGMseLRUVH8vbHOep8/Kl92tDGBrXEjyL2Pfs7tsgXKhYYhRYyixVmSwd4tL8JqZ6xR5OuijEKHKUXc2hCI3zDoTi9zpCLWP3xOM31VjrsyR1KMNeUzzzw3/kvXJAdEj+4sCNj3+WTFFfZRD/e9/N1d8Tmh+wOjxrJtgPgAaLx46uq43jdfgoX6FNdZIM+WquoXEdXxdQc9zurxWSW/9MXjAhxOyLhGKJpEsJgjHi3jEoj8elvEk4KGeJc8xTB153vU/dMEsCCVa3MeJlQ0z49llwC7oHtMaoxRzxhF4Y8vgxqWkigB96E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pxCgFOdVK5WTv5ozbGgjJAsx3QX3ZRqfnmAGJnMC5fh9rnODGpECePLe0vDv?= =?us-ascii?Q?W2OrUmeL6Tty0VxRq9zIx7gt/7k1jMC/VzTf82iIQxZPVehy8Rw4CS5YfLrG?= =?us-ascii?Q?rROutK8M8vbHBQl6I+OQhSw4GHGhrrzSFy0rSJeqokBgPUNk6ksyGXLeULjY?= =?us-ascii?Q?S2MvIJ5wpslCUgQr6FyM9yMncKvqT7rEiV5scfVmwx88aMOSt7I9RwKjl647?= =?us-ascii?Q?Dt9zGxeiMdU0cCL1JfU2BkBYA7HCV9vgE2ieCXemWkz5L+VCo3y/8S3JXm5n?= =?us-ascii?Q?vV3zuvFKKPYOA+pobfTaT2NBIdWImKHxf84NWyvMXcopfMi1dNkTX6JEsPgh?= =?us-ascii?Q?bCYyyfiNyKeHlmOiyodbloGKzucTcxEVe/0HuGeIdoTZ17S9NDl0CBmPFiQ5?= =?us-ascii?Q?nUIX5f5mhaSu0joRa5PxzwZhYvMO82t+ZebATizqYk76SOY9W+uE1jq9QnEo?= =?us-ascii?Q?yX9ipiJHxLjRnttLVPHyisj8W+sGtRJ5B9/k3nGZzP900y1AlfVUGim157Cp?= =?us-ascii?Q?A2hjLk5qrufBPq4j552O46DoTds61IZFQVp5SrAzQ7a1kJZqzxTSdAjODKJI?= =?us-ascii?Q?XrVImsUDakZ4dRqyWwoGizwYGB7oi0BOzNeBXqUfyXKUFEUevkDafiJOvHSd?= =?us-ascii?Q?MFpRZ9R8kPetZvMTdp9oV0EF35/8wh6UU41uz4a8LRr07qxWJfL+BRaw7YfR?= =?us-ascii?Q?eAuzZP9yalytWtM5hayNvGd9NgXUJwc9mhA62Z4A7a8bgezfL0FVlDqHqHgG?= =?us-ascii?Q?kpOlXn2IBA5+Wiq+rKx1j0LfTFELb9sKIjtjrQfERxnudd76vBevjHcCscEN?= =?us-ascii?Q?I+ARA5335l0am57km9YzSPEvkYWcemzEqmFyhc8RsT+Obes/Y00kfMf+pMio?= =?us-ascii?Q?aI4LGiqteQ/xgxzPmjpB3YJS+iYtx1ykShtTAy7ISvZkglKXYLOa7XL+3OmM?= =?us-ascii?Q?3GLAkEdNG2jC/iw8Y3Q3wAqvVoiOUgWHGEbbiUdWBsc9S0fHEcI772tTLWzE?= =?us-ascii?Q?P4UN7Lkl8gQgN+/Zu0zxD7+B35Zqi2MXIlnmkYbm8bQIRsR9oAkObQEbYSNv?= =?us-ascii?Q?PpqkfOEHMe8Ng/Eemj1DNQ3SRYjwShcp8YTNEtD3moxnevxrjV5PVwiUtfbM?= =?us-ascii?Q?jJM13ojRCHGQb4XYGNH0Airs4I3BPauSUrI/FE2rCWEqZad8jDpr08lOuGRG?= =?us-ascii?Q?dT4H7SGQTUR6HqOSJ7cvcy3UJx8kbQISyb1Nny946Ziy/mCQS7CL/NMOauOe?= =?us-ascii?Q?2qOVjc5n9wjoAi6L0935rYQI7X1PR72fx5HLPSaekJHwGO37stSoon98dHdt?= =?us-ascii?Q?tWW/wksorvXc2r7nxs7sGbnq6aen6zTcI1LK8DQl11ywHjmoGbYMjN8YE5w6?= =?us-ascii?Q?MRZfpdFtQp2m+ewPnf0CIwyzG4QS5eH5Dtk7khA9klgZGh5Rglr9z7i7cyGk?= =?us-ascii?Q?OcQTMS+5bxhJgd4NXRM5fGTyY7Hv1cflUcLjbjHoC/x5/Mvi8z6dYjMPjEco?= =?us-ascii?Q?KjRD+M1BsPhO/vGj1lmsQp3tgvExsZQY3G8e4a2zj0OQ2s65V4sUbA1iGNCR?= =?us-ascii?Q?YnCFILukbmEOD8/SlGj2xNlSH1wg+0PQ7jZpndx/xYhr9VHRukdlLIN5T42e?= =?us-ascii?Q?2hJEaSUxEFF+i21zlmzPpiK71XDvoPg2F8PP5E8esf8S/5M28jXnQvJE0O5Y?= =?us-ascii?Q?pBeSbIs4CxfJIlgx9Hq78kLO2OVGJoW1aYt+QViEIW9xGj4u?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d737b191-00ba-409b-fa8f-08de8ba23627 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:14.3665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LqDFAsiX+MpdKnH5VdHSTf8zL1JfX+r0D7NTy6HJ9xDqUHCKQIuueVLJJJuPOZCF X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" After READ_ONLY_THP_FOR_FS is removed, FS either supports large folio or not. folio_split() can be used on a FS with large folio support without worrying about getting a THP on a FS without large folio support. Signed-off-by: Zi Yan --- include/linux/huge_mm.h | 25 ++----------------------- mm/truncate.c | 8 ++++---- 2 files changed, 6 insertions(+), 27 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 1258fa37e85b..171de8138e98 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -389,27 +389,6 @@ static inline int split_huge_page_to_order(struct page= *page, unsigned int new_o return split_huge_page_to_list_to_order(page, NULL, new_order); } =20 -/** - * try_folio_split_to_order() - try to split a @folio at @page to @new_ord= er - * using non uniform split. - * @folio: folio to be split - * @page: split to @new_order at the given page - * @new_order: the target split order - * - * Try to split a @folio at @page using non uniform split to @new_order, if - * non uniform split is not supported, fall back to uniform split. After-s= plit - * folios are put back to LRU list. Use min_order_for_split() to get the l= ower - * bound of @new_order. - * - * Return: 0 - split is successful, otherwise split failed. - */ -static inline int try_folio_split_to_order(struct folio *folio, - struct page *page, unsigned int new_order) -{ - if (folio_check_splittable(folio, new_order, SPLIT_TYPE_NON_UNIFORM)) - return split_huge_page_to_order(&folio->page, new_order); - return folio_split(folio, new_order, page, NULL); -} static inline int split_huge_page(struct page *page) { return split_huge_page_to_list_to_order(page, NULL, 0); @@ -641,8 +620,8 @@ static inline int split_folio_to_list(struct folio *fol= io, struct list_head *lis return -EINVAL; } =20 -static inline int try_folio_split_to_order(struct folio *folio, - struct page *page, unsigned int new_order) +static inline int folio_split(struct folio *folio, unsigned int new_order, + struct page *page, struct list_head *list); { VM_WARN_ON_ONCE_FOLIO(1, folio); return -EINVAL; diff --git a/mm/truncate.c b/mm/truncate.c index 2931d66c16d0..6973b05ec4b8 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -177,7 +177,7 @@ int truncate_inode_folio(struct address_space *mapping,= struct folio *folio) return 0; } =20 -static int try_folio_split_or_unmap(struct folio *folio, struct page *spli= t_at, +static int folio_split_or_unmap(struct folio *folio, struct page *split_at, unsigned long min_order) { enum ttu_flags ttu_flags =3D @@ -186,7 +186,7 @@ static int try_folio_split_or_unmap(struct folio *folio= , struct page *split_at, TTU_IGNORE_MLOCK; int ret; =20 - ret =3D try_folio_split_to_order(folio, split_at, min_order); + ret =3D folio_split(folio, min_order, split_at, NULL); =20 /* * If the split fails, unmap the folio, so it will be refaulted @@ -252,7 +252,7 @@ bool truncate_inode_partial_folio(struct folio *folio, = loff_t start, loff_t end) =20 min_order =3D mapping_min_folio_order(folio->mapping); split_at =3D folio_page(folio, PAGE_ALIGN_DOWN(offset) / PAGE_SIZE); - if (!try_folio_split_or_unmap(folio, split_at, min_order)) { + if (!folio_split_or_unmap(folio, split_at, min_order)) { /* * try to split at offset + length to make sure folios within * the range can be dropped, especially to avoid memory waste @@ -279,7 +279,7 @@ bool truncate_inode_partial_folio(struct folio *folio, = loff_t start, loff_t end) /* make sure folio2 is large and does not change its mapping */ if (folio_test_large(folio2) && folio2->mapping =3D=3D folio->mapping) - try_folio_split_or_unmap(folio2, split_at2, min_order); + folio_split_or_unmap(folio2, split_at2, min_order); =20 folio_unlock(folio2); out: --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 372AA322527; Fri, 27 Mar 2026 01:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575808; cv=fail; b=O7rFF6TCCmVheX0U5tNBUpAx2mX+9USO9o5rDh2+rgCIkd+5BfcB2qQdqcUlfFfLpwvtsXklnrrjYMEZj4jLLGZXhwyV0DRJ9ggaTzxCBrck7jGuWquVs+bG3hHHtlSsVW3MN+p/rA7yLgho8nQaYrRLN8sptNp4esOxRHYDeTk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575808; c=relaxed/simple; bh=xJ1bVa54/gfYSfMzfc0wJvPJXNZTUflGAaNh6wIbHyk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MeEnlDpHAxfHn/VjlUfgtwSEKUlEnAX5EqnENhi95d32A0ENMQ1rallyYBCqy+ffnwyKUz/PEuBT8wuV+HU75VNgug1Vg4fojzBqjDK9cJ4NP3AEnMaUI8CLcx/mIbV4tLkRgNSxPpoHRkOsTlrjnryLkmXMrj0JEBV3gDHyuLI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NJ58xcq9; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NJ58xcq9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KiGmleYSRDinvWazzNy2RSi3CGMT6FP86K4ntjaRFosWI3qvFjqzppORYpyHyuBNjsScdV31EZQ//Pq5daC9VlElnNiag2dscFWbLu2HtEOPuzTmX27jUdBk1yeY+xS/apl0pUUZg2se+8hIXK6bF2Z69IpdEyI1xcwkyCBI4/dvkSwHqCLgEm8D+Ff9p9MtDorT+EYs0K8qnAlq68QNGhGotnXEzP7rYN09XGF7MGsBVvYO1Tn5g8fNu20CR8rksvnQZfySYV87OKwPqSV/lXErmLAv9xYaCKgYaIMygzDbmhVoHo8zBMBNjPcg/U7Ycgya1Ez6UnkMH9jbM+nuyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+HC3XRSMhUBoGzAwri26E5aQw8VzOyP1Ks5RR/GuQ4=; b=XAbc4/QcRFS6XA2KBxazsSnTRiOLNc7p221R5ULxn3vdhEMnebwd10PAVgyeix3cxRM+himoAc0/Ysh4Ui3XxOI1uKqiFRYywsH6vYu/f6FRi032OjC+FTqnh3byx7vc+L41l/dMM1QOpmWG6IdCGEv0s+MZ/KGAbSC3nAjXzDTkOE0CI4qKog8XxHKUMF/bdXZ6mBbjTALlcBOd6dojtMa7Vy2xMCxlvHA7iDkLtoEHLuOriXPfaGX7cy8PzssEzwqi8Ba4fnS4K6Iwzs0kQXULXlywmkXR/HFkxD8YqnxhmQM5vsPPr5FU9V+gXcdG935DOdhAqVoYvXJjfI2LdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+HC3XRSMhUBoGzAwri26E5aQw8VzOyP1Ks5RR/GuQ4=; b=NJ58xcq9o30ZXA8q4hizHfrJ6wZsGEFRxIvcUkKeX39s0uhUA0R8PqZVYYdqe77Y7ektG+YTadXDEGKHLKieqMVLw5REU+dwWt7R9xvnLDlkZbZfsuUwghkiLaN3+keneC5K3wWcSDGe1i6I5h1e7A0qOJrtqQgCc9StNCtHUSZBI/7sMZzHWA7YDGwomKNC+aVoDUgDpkAnNrJrU9AGwdxxjUtflRUBsrLzFjbQPPVKTrLjJH9QhTS7NhZUDYuO4bgZKguWSiQcYD7K8Ia7R/nKRLyaw+d56EKIXX9BPcUeULGW8pRrPuicaN17kEoIXtlnUlTAMHqrbae07J/QGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:16 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:15 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 08/10] fs/btrfs: remove a comment referring to READ_ONLY_THP_FOR_FS Date: Thu, 26 Mar 2026 21:42:53 -0400 Message-ID: <20260327014255.2058916-9-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR06CA0011.namprd06.prod.outlook.com (2603:10b6:208:23d::16) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aede310-12cf-47cc-cc96-08de8ba23704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: vMQIkhgKWoYNHr5LNKTbVwd2xVm1ksEzJz7KIY58ABK0/1oGeO92VoNZpEZ3R9NJYz81v3F0w9O78PK7pDpeTo5sfPxmYgRVI5diQUyyFXj3SAKbXbUwnwi2Fjj+MIPKu14Q7D/Yqio9xurJe16YddGdUs2VevfhgnR9P+oF5n7Odr2rLnyd2N8h2oczoOa0lZuLQMrcx1Yd14rokCLk1G3ZFeFGLvsGR5wxBtoYdgW5VpZOkYiCKFB+x7HNbyycqLUSlhB4ip9rm3s6mKmZ3HpbOIKc+GlWtey4NhgFzRon/rdKK3xUFe7tKgt8+uHKCRH3j7PeTxIohP/AgNHlRsuijys/McNT+JEv58VL+4y2IwOnRxPVyg1Rj6bb3JcK/R4pd0G4hxa3s8yme6TpPec3N+ygdvCvjislK9C2m7dkN8DfhDMSKmkaBIglCHv/ckQRbCPXlTa4X9byZ+wmn0uhfSTZBc3w3+lqErX0rICft5n9tGvZVx6H++cFPlirw1mCCKtYC9qiq0zhYgUfhH24x5kMfWWGf5IjOojXki7ndjk2S8NZylJbKcp/fFdS/CqqpySFi7PX+twNGghYs7EXZr4izVtAa9QVFkib5KBWMklTOHWS951i8fXsITelwqYyNnaZGwrP9aQ7pc4UBd7UooH2W1p8Pu9krntMiS+ONcKhNK/qOGD5TnbT2+2x7tJpHrEzV+dfPlMexG1uvAyxy6V4hBOsMFD4Dsf5pBw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UCXJy8ONDP32eK7tI0YTQr4qPSwc99gDZekxXABkZXHAV7KcjE6NcvXra2Um?= =?us-ascii?Q?tBLRojJDZL+8SBDJI+yIrGrNggH2qgPWRHnQCJ2H6Be+DPTHhSK3Dd9PgkUh?= =?us-ascii?Q?VLlY61JYedkUsQmhsJ3TmwH5u27wOfcSR+mfAUa5noFcZJJEmvVQgPhmfyG6?= =?us-ascii?Q?WkPA9ArD1+idfICvO0UqfOxtsCUMA6w99UaFa9ErkKE7F2ST/PbZZYxw3nXH?= =?us-ascii?Q?IpCPVXh9gPmTiYdYZps7ZWdGK3qb/2lbGHvdTawfT8Vim8zu2+de5XFcYQEo?= =?us-ascii?Q?T8Y5w+mUxLUcfVrFSTTzAInJuN31BDWuHYwwK68lafEGNA53KCjOo0d6qk4H?= =?us-ascii?Q?7V57Sk51ddvGP/baFE3Yn+kUSI+ekxPkantbUHFGnuaH3GsyvX/G9dBgf/Xu?= =?us-ascii?Q?JkdqqKwqCXIluUSnmZHMzoyR52tHwFjpXE5GsYTcIl5XjttkvMCrEa5mVIED?= =?us-ascii?Q?sUX/ndBrIos2RoGmDjheQex1qrGN2J7NMg++8diNKQaN06ciVr5J798CkWVE?= =?us-ascii?Q?ogiFGEEv7VzD20LrPqrREEDw7n2V1XyaxYWraygUvk7aRRXRopNUkWzwGs7g?= =?us-ascii?Q?P+YD7Lp/7IeSNyvpxPC0eINxnOngU2SXzNgnJsSzjaYOr81uNtViEviLBfQ2?= =?us-ascii?Q?qxzjioyvx0qLC232uokNo6/1XYL36uORqlmwVfJWQxB9ysgOtm1m4urbg+IQ?= =?us-ascii?Q?k195H3JxWLPoJ874iQM3jfzUs70ypma7+MdQ/mVqsNOYQSoHXw0eoVpsJf1k?= =?us-ascii?Q?xSYN991uyavwRNr1/H/IQgBdsk8Uj1utEraLw+pSxHQ11TSz8r4gaS60F6/q?= =?us-ascii?Q?BCBtXc9mSqLVTD14xevTsbrqRcLdqCoqz6KbcvFBQx2J8UEoL5aYFB1WcpFs?= =?us-ascii?Q?Mdf3LdHNNXCr+2YxXBr10Fc576m96WNw/figLE8sBOrxGe1hsyAIFK/IB4M2?= =?us-ascii?Q?RpZIjYUB+ArPqvhCDJgvq/i4GxeCW5urNyn1yJT/JBl3Y8AzBe/K9Ux4lIoc?= =?us-ascii?Q?qTynffZKxk2K6U5UdtqvviLqE1DIt7f4IQwnJg8czfvbX+jEnyXc930Npg0c?= =?us-ascii?Q?JTM31ozVat3MW/OTOMumaNqHxb8w3ZjRrlpLILgaNKbxmWBL/Q4CvIjtSWtg?= =?us-ascii?Q?4c650UgN6e7Qx5RfjeYul32hAdskr5E56354iPHXhKVap4uHhIfJNvhusaYv?= =?us-ascii?Q?JWelVWrdfOoWOZry/FDa8yx9+AgLMx2+gnnNVYCzeTyYEE5QeU1YlgtbLuGB?= =?us-ascii?Q?Kwcco8bhZLl3GQO2rq1PJqemuGo0pb3XNjBPu1zNJ4s1M1pZrOynIdWt25uy?= =?us-ascii?Q?ezVzsUwJCQHmqC7w6Dnl/zK8WrWj0GkEpIqq/WfU4n/bY3qIFfUGIjqM7OSV?= =?us-ascii?Q?wt1cuIEOf2aHpp3PdKU/RtiaXDfJcQv0jppFkmhjwOO5DPJSRNKyHTppHv/u?= =?us-ascii?Q?NdSUA3+pJ0fLcGPoBAqz3/Z3DAmUYdy8xbjqHWAVpBwfgO5DmQ7uCOkSwKsU?= =?us-ascii?Q?YnAmNA2gMCLDQU4vfscNfHVmIQnC1qFh+dk2+IBxCo3aQxArFvtB2OENJb6N?= =?us-ascii?Q?GuEaRqAf98oF+5xpO25QZiLqyHwQ94EYTtFsTp1MXwkJNS7m4619BA3V69LI?= =?us-ascii?Q?7dcAYSVJDoEvJhJpsC22SP55l0EgnHAYjJAmzTvEaY7E3QujWXDQARotVK/+?= =?us-ascii?Q?YX3FCeQOSOHv0/45yY7EPpheygP139vi4vVMyUSaYm7kVup1?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aede310-12cf-47cc-cc96-08de8ba23704 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:15.8834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tuc8Nc8qT5NcjAj+DKp47f1pzQkm7ElgnXVgO/jVU1lu8TmlYmYBJgD2UlFMaGKZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" READ_ONLY_THP_FOR_FS is no longer present, remove related comment. Signed-off-by: Zi Yan Acked-by: David Sterba Reviewed-by: Lorenzo Stoakes (Oracle) --- fs/btrfs/defrag.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/defrag.c b/fs/btrfs/defrag.c index 7e2db5d3a4d4..a8d49d9ca981 100644 --- a/fs/btrfs/defrag.c +++ b/fs/btrfs/defrag.c @@ -860,9 +860,6 @@ static struct folio *defrag_prepare_one_folio(struct bt= rfs_inode *inode, pgoff_t return folio; =20 /* - * Since we can defragment files opened read-only, we can encounter - * transparent huge pages here (see CONFIG_READ_ONLY_THP_FOR_FS). - * * The IO for such large folios is not fully tested, thus return * an error to reject such folios unless it's an experimental build. * --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F4EB317715; Fri, 27 Mar 2026 01:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575818; cv=fail; b=p/FSZPsJNOQPqFekhvLp51EXIywZlpflfnJFDVT+YyeYJMSYKz0lo328og9r3ApFQBuYTjLXRvE8C6zD3yslAaDEvXG30f+8isM9G5RuXAXKvHBTFeVjeTXMtanOEtsbVLngbC9hGXcNV0WYpucKHf6XuW+kgnbN6rnxgeTDh9w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575818; c=relaxed/simple; bh=kl+nhqAgppA1Mp/gMWSttAhKOmjMPtelEgmQnKlvprQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=S4STzTXKf6zBqhe/wnPqZ2D+Iska0KY0V0j65ntl1LQAUQvuCLMbnmmYIChcrS5TO+oFjdGJJOBFCLkgX7YE7+K+M4+DDu65nwwlPqOs75cgTA+AfcPeBdJ2MBMbJVpm3ZbmqGaHeN4/6+UnOceKt7xE/gD/IberhK5hTDp+OFA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=prYngYaI; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="prYngYaI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PJn/Kda43XZ8Clk9H2f56V3BznoFjYhp0X7WVU3klbFCEK1a2d/whALeVs9FZlW7Gs8hg7Nvq06Zn0nnsCN97Aarv+n9HvIVx01XFRbD+4p/1KSESvf51VWdnAsAPFRtGpiy8I+Fc7ADl5wb3QRCJyjnabTPo/VVma24CBMFYEtbVz/N8v1ezPk7Xnf4oIryS81F09faUtszOVYTWl6d7hVg1Wkm6rIeygbbChExGvNilAJR3shAd47GQ8PznWhXpOAZvoQtQ9xeD4+QCHVEe6qTE5OTmRnDgKndChjZ5bslz83PQDc65Q2ag3+Gbpdc3ttHQe/jKssKxqlYViNe+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4pPDdKDPyAnyBEpPwSyNQ9WAtdgTQNUESex29jy0624=; b=Z3FL9awDpAZkDnFdSOHYaD2dLLJ3PTTouwxgO1c0ZD2jMrxXlgn9rmbCAQ5fzQry2ibHKpo5ZZFrvFuY+zzZzC1SMrhoEIoDeWMM5qIGkIw6O+5cS5Jp4J5Ybgqndev7RhxHDyVZYrNn3w6kcSIQKAdYDtuqb/jBr96LOMBFXPdq9Q5HSvgFBUYMrX954g8+D4oEQE4Wh1aUNiQVqGT7igFu+on9tZrBy1+B8d/Rb0cp1PwlRHw083a/HCP0MNt+Z7tjFtg0bwzZi+dVcBCz87INJrmPGRSP2kJejmUx2YHYZS6EJEw9nNU+FDGylfLoRPWcaxUiRvhr71sFOomj3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4pPDdKDPyAnyBEpPwSyNQ9WAtdgTQNUESex29jy0624=; b=prYngYaIvjm4gIGs1R7nl0Z6cB93v5l4sDwFlRXoM5rTONnDoUO/F4W3044kk2AMknKK0GFh+E0+d5vz+hF0zHLguYLN9+Atri6jJpW0V5apHKFdHPhwyVYNt3GR5hrhB+TJQUa/at/Aex0OZ+ApLOQ3Psbdhy+JQy1fNwV8QNrfSaEwpoEKrBls2WLz+WG+iuv4HE3S2Wnx2AajqiP/d+d0t1q6PCmHPvwHuzwMTnt323EI4HmnuBQhoWOMs3M431x2RWXFR7Il4a2C10GEPAArUlYyj2NWUu1Cv9APXprmOWkOR7k6qNZ5+KG2zZBwwNzyK4S5899yJK0j7Rx+Ow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:17 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:17 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 09/10] selftests/mm: remove READ_ONLY_THP_FOR_FS in khugepaged Date: Thu, 26 Mar 2026 21:42:54 -0400 Message-ID: <20260327014255.2058916-10-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0170.namprd13.prod.outlook.com (2603:10b6:208:2bd::25) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 566478f4-4fc3-407e-f271-08de8ba237d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003|20052099010; X-Microsoft-Antispam-Message-Info: Cx2DSosfIFXz2lehPtSHbIRklR5unMvgz+X2jbymk6eI/0OZWCKGMAQ+I+NqwRwhvgQtEW7A/zVQuNLl+yQaT1L4BTApm/A8IBW/QrZ0IB4Lepq1imfMpUs07xd7sbeRg1ge0WctWJU3/+bZO/hg3OskEhOJAyV+7QmpQCUIAFDQq7sjSmBk8djsAFn49aSxFfs1wB0Er2QJFUjr4iyvNNOSc+IToZLxkW9m1EumOr+x+jI6TMxFta1u/sG9rchoGej8EFyJWA2y4DetB/nRaA6onjNYFETaWtwI0/zQSkWaU9RtbMAOqiE5ODn3I5zJHRVdhpA2nkaf98wT1y2o1NE+vJvAcwjRKbSEj+HiqLu83kSyolaRmfVsoktkY+60/6zOjUnklFg1WxePj97Eo3lDUlbjjWAko40IQJaVD1hqHHSIWsTHobhKzErd+ik17BbJRDwsSie5csLAvigqJMWOjsUBhwfqWEFEt3adHRYX/Hu5OirpC9xXjFA1aB5eAUkfoRqlXdUV81NL0x5NI2n2GA75K15a5SQ7R/WUjJ+OjTD2abUIQ7CiYOi/xSPM7zhXD4bLUffwAwaNRfSXIyh5pYKlUP2gXaItBBXjQcgBrJuLTPKlvddGUywO/oHWQfRA287GZauSzhE6cC4NShDsolhIcwX4Fzy/tLoL6sSiGD/cn3d7JdLezc6vcXmYKIhVTn06WI0H/i3gHiFMmqdFWwYoFj3Y5ynz3zhme+4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003)(20052099010);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?arAQ7HlyJCh8MDihvbyURJL5WU5sYK6Y/qHnHia/76agM02zwqnd/F50mWw6?= =?us-ascii?Q?nicIeq4lf+Jftth19hDFpCiHl2pC04goheNlWF3la6JLEKGE/YGvHVTIA+CK?= =?us-ascii?Q?E82LgOU6FqHBpS3P44wQN10C86tUlwLyAJupl9DJhJ9t6pC4YWHYyxJtL948?= =?us-ascii?Q?1BDVbx6AnHTUofTTaOXAqLSJOyAeQSWwZlzBjhUwCJRzaZTH0lasvZSFNt3F?= =?us-ascii?Q?9RWwYvkcixTgXVE4RRHtBwmvD5Iw37thijX0qhE79lkFAS4V9VcfHyn4e/sM?= =?us-ascii?Q?st4IrYuHail/JB2BV0DYI5aTjwxSHLJEdntY3fZLrzpm6IQ3+ESiXpLmqL59?= =?us-ascii?Q?mdB0KMnKSs3FX2NFZ94PIxXJGsbnZ/ef5IeRgu0ZhvDmjgagB2JItPUhCD5b?= =?us-ascii?Q?V5ZxvIro8kiY8VJ85nzdlW64riKIxJ7Z50Is6q2kVA75pq1Wk4MwpPP+ey7h?= =?us-ascii?Q?M63nCD9TQHYrzJX/O9IxHVPJ4G2vqPgqEl9s5uR5yjtQLJiL10ER23xBtMeq?= =?us-ascii?Q?0+dac5lDLK8G/vaz5lK4zL+L4xJHWFUe3blGMTlVUr6TKkv5UFVZzTwSoQz1?= =?us-ascii?Q?hEsyk81n8fjVeIIYdCZyRHCfvVvI3HOrgxb7iEmiKt624sSKM8VlSbiCen+j?= =?us-ascii?Q?DKfUKV5ebqHMugUYUwNaA6J+p/BlLF5jsTZvaYYULM/A4ORjKWQkSJywpyRE?= =?us-ascii?Q?gfGZSxa/et8o9B35gjZ9w89pw9/GAyWMh4bwuRWfhymOv9S0j2OfivA1N8S1?= =?us-ascii?Q?qh8x7oXopqaSOd/cWfVkugzvjge9PNH3DqKDTElAyJ4kjvSAbQFFAxqhCtQD?= =?us-ascii?Q?qSA25wLzzK1v8TI+2B1sW6V5OekNAaoz1lXbM0czSPXqiUZRwbw5zwEW2z2D?= =?us-ascii?Q?idESve3AWh0Cbjtj9U1q3j+Kg/+7yYKSpIRJQyQ7UVjbY4mSSvTWwxa65nmG?= =?us-ascii?Q?Ho7N9wFTD8Jazy01cWgU0rc2mOwEuU6M1+vD5msaSUFDdRISennDRpZ41utZ?= =?us-ascii?Q?10MdxNydbxKbu3pzQNiazb3505QIwErZtzD9LzO5NUK0nAyo3aR+Mvg0qsdn?= =?us-ascii?Q?/eHko1yrr18tkmyShib+nUhIwBVJ2wBo0jixLdwAynnIbDur+CgkcIpsSS0g?= =?us-ascii?Q?YHmF8tzn9JAS9dApB3eQ0mYGkv3tEaq7L7UyLIIWKtLT5TzChx9Gv1YuxbUv?= =?us-ascii?Q?FFzkfBosgnNk+IihgKI0lCWdWU7M53FlZAH07yHgzWcY4Ala9CI2PsyhoMVE?= =?us-ascii?Q?b0PP3esyYhRxFIM3sV03dCiAL9LFE6aBsaDTS/dwd3OVzXendnLxxuTG/RPu?= =?us-ascii?Q?NS/hMOivR1Qyg8939n10T7ba4Km2Tue0+fHe+cnWH/FeY+De0WQQZYG9cBxf?= =?us-ascii?Q?QBr6Nrhegde47JgrLzrxi5RcPLvFWnqxM4GxBagCMSOAON7PYQbTy7eo494z?= =?us-ascii?Q?Z3ofXH+vmtZ5TV4/ufcOjhbuw/Cyu0em6m/kQjJDEj1/LdOtp9XPKd0Ra0q4?= =?us-ascii?Q?zy62a8E4yQSl3iM4IulGFE/d1ilHpvZ24uBwQDEO7esQlhz+5oZUXW4RPg8E?= =?us-ascii?Q?xSYScfPuVWEXcSMAzaaC2AX5PYWL6+L/3Nc9KNRTOwoSg7Rbga4QeID+Ny1a?= =?us-ascii?Q?Y3qdw8lHs/MZYLTeM8iRMThg/yvvjfZLbvrmLx0cUrlKNe3yGyGU1LWnfnym?= =?us-ascii?Q?lEmyN000VC/Bm4/QyhxgTjn5Dy/tOtjipjGQk3i91fUAN85o?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 566478f4-4fc3-407e-f271-08de8ba237d1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:17.1793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CiuNygqRBIGvkj9u4JqFsTszFE5Sgeflx5hSQEw93+8pkH5cNVS+NoD98z09eWst X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" Change the requirement to a file system with large folio support and the supported order needs to include PMD_ORDER. Signed-off-by: Zi Yan Reviewed-by: Lorenzo Stoakes (Oracle) --- tools/testing/selftests/mm/khugepaged.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selfte= sts/mm/khugepaged.c index 3fe7ef04ac62..bdcdd31beb1e 100644 --- a/tools/testing/selftests/mm/khugepaged.c +++ b/tools/testing/selftests/mm/khugepaged.c @@ -1086,8 +1086,8 @@ static void usage(void) fprintf(stderr, "\t\t: [all|khugepaged|madvise]\n"); fprintf(stderr, "\t\t: [all|anon|file|shmem]\n"); fprintf(stderr, "\n\t\"file,all\" mem_type requires [dir] argument\n"); - fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built with\n"); - fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=3Dy\n"); + fprintf(stderr, "\n\t\"file,all\" mem_type requires a file system\n"); + fprintf(stderr, "\twith large folio support (order >=3D PMD order)\n"); fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs= must be\n"); fprintf(stderr, "\tmounted with huge=3Dadvise option for khugepaged tests= to work\n"); fprintf(stderr, "\n\tSupported Options:\n"); --=20 2.43.0 From nobody Thu Apr 2 19:00:06 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010035.outbound.protection.outlook.com [52.101.56.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAFC5314D21; Fri, 27 Mar 2026 01:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575820; cv=fail; b=lkmZrIvv/UQn8HS2ipjf9PZcwKuywQRoT0qjciGcifv+QaAAKkhLsNi9hZWUESZUEW3Jxvwhzirkn8GON5tPXTxXZXhH8ofl49ut9N1PyqWfNavUMBB0KtCWv0cbOp5inCViY3a6oseoy1YG5rkw8ZBYUW+j44wtz/vqoYCJL84= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774575820; c=relaxed/simple; bh=lSPfCbD2yvDjg0xeuJm643jvV0dHdThI8TgrcSoET94=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Lo69l1TQoWjX/hNU+zzTNnQUyYV8Y1T/0OuSGA26r8XfXtwl+0A4aRCixrcIhX/YE3fmh2+IO0qYTK1hE8E37Ih8m1zV3ZzRsH5pozaujlw8fCCyUO1cHy+cMC4lxtrEzjDD6onn/L/b2SmjqOOzATA9Id7Pb0J2OyKTr24fsmQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=UQZUL3++; arc=fail smtp.client-ip=52.101.56.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UQZUL3++" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rl5xKBTQphUqIEVMfzo0p8+BFUtnH+j7qznw+ghESBLLnBe/4Tc52NRow8qmNyYZNR6tvynL0NKP9GedauSZr2ci/CeqcVra0L6YJtP/qUE8y8Hx3JniVL0nFzVvo1q61/75vm1hbNPdC82wznvk/KWnlwSjL7z76/sIug2rkX5GXmhN2l6JGq1Fcte4Y6LC42nY5h5AYlrIGoovQvSAHtw4nd7x7h9RSysu4aNA9Ojp5etsIdb1VWavq1qKw39Cvu9mfcrIShCZpa+cz1ZetKuiajzo8ESqInU46MJlr4dVx/8L7HXbWEmVF8HQ4gw9NrriIbNGgvRgrGmPH9T6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoBCnPTeqfrm1QRjZz+gi0AjIAZR252PiL2hmCWGEaY=; b=iyfSX4qho/jeMc73JvYJJ3nVhtHeXOtEwVO129oNEdFCu7SnlFwCkchW7RpEo+655pDOX/DAzIVn3mSRGTFUZZKbuD41IzKqoTeOO7sWQyoebL62ddfTopdi5nv0M7e/KupvMRd1VGYtbhRTKY9oZafzqHbIFmhl0QW82xK7d5O38LAAG4YzSSP/FATZoAlQHSvNpRmq1BDrjxfvXM1tW0nnhmZ24pYPATe900TxR9AsaWwbH3bf3JEzaVThZMtpcc6d62sEhRGdiyvDiB/vqTGUAXxRn5VWrz0LXmkKDxCrwBwVYLLAqbFgAR13to4eUEFiaXmVPCsygPKLrhuXog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BoBCnPTeqfrm1QRjZz+gi0AjIAZR252PiL2hmCWGEaY=; b=UQZUL3++YQ3NfvMLOvwM3QbCz6BslWYDcdE70PGm+oSKbLgR02fFOtUOx83Sy4zKtXcW3M9N2YwYBGPGx01zOj1EtuxOgmXCk93bA2HNXSE9c8qA2qIhz586bBNK1X6VwK0GJ5rSu04Lfu0qa5ax1oJ2yzxGbiNS48OYdX5ylb9GMgMei0UtolNsZA2ORjX6XuG00K+b8LmmNMlIb6PonNt58Ro3DqXXNNmxQe38auh5YBISonYF0JzsFSPAu4/XVoyUJOIMnsk2HjjmlahulvHvJ1yKVWIps0D2vMFuLH4NDzomJGM5wpc2l1pK50jwS5Lqua7yxgHHxLRYnQFI3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Fri, 27 Mar 2026 01:43:18 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9745.007; Fri, 27 Mar 2026 01:43:18 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 10/10] selftests/mm: remove READ_ONLY_THP_FOR_FS from comments in guard-regions Date: Thu, 26 Mar 2026 21:42:55 -0400 Message-ID: <20260327014255.2058916-11-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260327014255.2058916-1-ziy@nvidia.com> References: <20260327014255.2058916-1-ziy@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR06CA0011.namprd06.prod.outlook.com (2603:10b6:208:23d::16) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 312556cf-704f-47c6-b613-08de8ba23879 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: Tk47kEW4NnuyyTr4m1HQJQUugyodlLPp7btXs9+EmtyRZ9lEnXUezw9+JTNc+9hqy5yOlUTV2qlI3G873eUlVK8/2Manmfvi1OT+Q38miPH4oUDWu4suH5i31BZiVJ8a7hk5qFgTCSHmxr+N+e11W8FS2i/9XJMEyd2RBhzInt0Z7vc6fLmiMERoB42d5tt/g2DsdbGnauW3Hl7+BO0DYeRE2aEG7+XUYsEGnH6p7wJzcDn4PdImcNe8y6gZVOHWVRP2i5kiFxzplab6YU2FBK5jQo8DIKLCosU/K0u8sZg9uKfnMUShHpH5IfHgy1ao0pIwTrgeAgu3az2Ch22BG/Q8rsbgWrN/rIjbdicAX6R+o41VVj8C/H1JumgqupSTNJ5f/0hPlNLlfy0qmvm5gt1qhB1zdSC/L99RY1FJj3gP4GCCex/qJOCUOXNcnmcN+ax/37uoW0SE1GHjQa8u274nYhS7FruQfiyzl6GDDmFDuIatYRVps8p4DvDWY/GkbEeVp5yvsNZ9e8aunw6pzQCWGR6A8QamQWc40iaUYHuYKYK76BH1cujuWDAOYjjwE4uUmga7HBjPPYeH/YKT4IHHUD/lLADBJOi8C1y5albEj5O1eSBHaSfhEUZUi9KPxHNNIQh2Chw/HHmurFtJceLWwKR1A3I4g84WnsQPjX8w1ip9dVrMZ36YW60LW8AEhX31Qy/7aQHpJIWxpV+YSFc97V4leJIfm60OHchbPbs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fnq2hejq+/u39/bXN4tmzSNvyEbwf7GeZXbrXJ/aCIYO2EQBvc4rulTly3iU?= =?us-ascii?Q?cFlM3fn63lrTlaUlFlkBkeN36ke4hn67ZM/pDUyj9I72DWtmxDWR5Tj43Z6F?= =?us-ascii?Q?dzplQ9gmEc5IsXSF40n5srCJdGyX8rDTCQ9ZdjLfkUWLJD/LZFHWPvyz5o1/?= =?us-ascii?Q?vp51ecwsw7mkv12OAqYGLr5P4Nl2Ayl6CJhlKQ8l9qzSdajLm5aomvurAuxx?= =?us-ascii?Q?lsJ9njOulkRIiivI1AfQKd37yMoxmiG4ucOFcCc1BkPO2XthulaeHa0YEqmw?= =?us-ascii?Q?KTb3ffe9Ow7tlomm05J0nCU7fDcK6hsEfF/uIpUeCAJpYfnQLFepmMq+LJvX?= =?us-ascii?Q?/dDCCSsZ1d3hwd4d+lafWk10tUVZkvldADOSjEKe6PlIJausvJ2qiSp7JXzT?= =?us-ascii?Q?vZdKcIsDPqCPoJxytmIz4MBl1FrCFga9ERZxjsLo24S+GfpQTGoVHuFKt0+z?= =?us-ascii?Q?5K9+RoswTNDdtnvi3vADXIJmPzSeEn95Pw9Qb5+/QkHjIOkM5LxNWxrOJaFF?= =?us-ascii?Q?4guhFcAJ1uYLUdekZOxuvIqFRJEhgb8szHwZG0R5bKUnni6a4gNSgYRp8eSu?= =?us-ascii?Q?XJ0qqxLEbSsCGYh8BF747W52EuXE0VqP6tkMmuWIeWusLwE7h/nunU5dwbax?= =?us-ascii?Q?6hcCHztUx3D+ym7DY0t3mUaI8Im9rbHsdb6HvEtd8bRCdOfyMsngUuJ++xqi?= =?us-ascii?Q?REvtjlLiK+rKAaqSsOl3sSqYUOLPGDUozDmg8d2H2CxbZletIfoJti3jDOCw?= =?us-ascii?Q?0fz0TMYclpRGRGYD7KnVTkQb5e+/Yy1+sAdpl8XAEHaM/2umI8yo4vijInhf?= =?us-ascii?Q?xz2mIGr9WYL1vIow/jmQasu3KW8XdmgP3yOGO18IoTCDeKfReBMUoXyn7i7s?= =?us-ascii?Q?earvUhSKXl9wE68P9B36n2w5P9+nPQAVJE8XpKt9F0qjC69hNmvdzNHW8t1j?= =?us-ascii?Q?7SgV2PyosuIARkMm9/+ZG/tEVWOuVHE0udNIIHVpucaKjlvLLeieV2z4lE2k?= =?us-ascii?Q?J7BWrSGzlZm+M/puw4rlK8ZfDtC2q7To+fk8cx/LE/Wcye5ZrwA6YkOEGWrO?= =?us-ascii?Q?vxuF5TOZA7Ebv0rz2f+gmP1UerSvWM5/JPPpp95qtmvX/qJHNXsN0+7+DeW7?= =?us-ascii?Q?kO3INbdTWbUvj4fTtgNMbnuSZwKew9/bWQYK9YbXqc8zv3yaoQZ0cbtw0lqY?= =?us-ascii?Q?jMRCE34FMlq0v7Vwixn/OSypDDLjiUd/vExKPiin8cvqrV9w44IgpTQhyLDl?= =?us-ascii?Q?5kel3earHl98HahgtjdKgVDp/rT1ODL+3pZ7EbAOHiCda6wjy1QBZdOb+3m0?= =?us-ascii?Q?K+pXNTNqsXXOQdKTxLbH4D3RIabU+leq2uBkHuknHoM/KfF73uwky7wy/9qU?= =?us-ascii?Q?cPujYnDOo2PLaStKCg+GR81FgWl4VLlq4oK26u7rjR48Qn2NCruDcZo1VGiW?= =?us-ascii?Q?ngSfySlFGmuVR6P4zECH4d21vZCzj2xy8RjaZUklL775YLWAAwpZgsNB8p48?= =?us-ascii?Q?ClWcMhHoTtNr5fjD2d5xE4qYtEs3F+uUtIJf4JooVkgtswKrsdNcIGjqfcJd?= =?us-ascii?Q?AbdVXuAb+lRvSLsgv38JPcHNV/xo+/bG90GLQv1GJnN50DVJ44O0LdoBKXZ/?= =?us-ascii?Q?eJPwz5/Ck/wBPcLklGVSopS5PlP4menwOuMMjzsk6MXkeB07b/q7IUY1WbeA?= =?us-ascii?Q?sApms+Z52MDL2NlsixL01EqiMEFWcbNLsX2aQjUrRsjQNrYN?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 312556cf-704f-47c6-b613-08de8ba23879 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 01:43:18.3242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3UdKMNYytQ4Xb5lYWs+/HtvGqIXBwmQVzQcyiycwtxGfxExwboDvXD8CokPhJzpN X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 Content-Type: text/plain; charset="utf-8" Any file system with large folio support and the supported orders include PMD_ORDER can be used. Signed-off-by: Zi Yan Reviewed-by: Lorenzo Stoakes (Oracle) --- tools/testing/selftests/mm/guard-regions.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/guard-regions.c b/tools/testing/sel= ftests/mm/guard-regions.c index 48e8b1539be3..13e77e48b6ef 100644 --- a/tools/testing/selftests/mm/guard-regions.c +++ b/tools/testing/selftests/mm/guard-regions.c @@ -2205,7 +2205,7 @@ TEST_F(guard_regions, collapse) =20 /* * We must close and re-open local-file backed as read-only for - * CONFIG_READ_ONLY_THP_FOR_FS to work. + * MADV_COLLAPSE to work. */ if (variant->backing =3D=3D LOCAL_FILE_BACKED) { ASSERT_EQ(close(self->fd), 0); @@ -2237,9 +2237,10 @@ TEST_F(guard_regions, collapse) /* * Now collapse the entire region. This should fail in all cases. * - * The madvise() call will also fail if CONFIG_READ_ONLY_THP_FOR_FS is - * not set for the local file case, but we can't differentiate whether - * this occurred or if the collapse was rightly rejected. + * The madvise() call will also fail if the file system does not support + * large folio or the supported orders do not include PMD_ORDER for the + * local file case, but we can't differentiate whether this occurred or + * if the collapse was rightly rejected. */ EXPECT_NE(madvise(ptr, size, MADV_COLLAPSE), 0); =20 --=20 2.43.0