From nobody Thu Apr 2 18:47:46 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD293AE1A4 for ; Fri, 27 Mar 2026 10:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606953; cv=none; b=FqrZFKd78L90QNqH4DsBa6daGAuhJatdjq8wkC1NzWvYhwIdVhqSL5vixCsMo7i9xLswZdahem/PlKNRDOHfyPDQ/wUUjnCcJJfYh+RZGJkJtRaw3DzEkYH+L2H3sJQd5mPb1ncb5o1jWi2W/m+pUVcNzZo7vtUYkYVo15p+nqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606953; c=relaxed/simple; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V2NaHjUIyN+oX9oUZs6gUUMmCmAbWZC6k6Xp5orvay84ajPJcLUBcgo8jgUzoXHL0rDR3rl8vvwrLavddTcYO4ANmmSToXSMtmv2J2ai0YiD4vsQNx7fBtuJCaOCR5a03ElYrxwA33vHEn9p7o8mrefePFdfOTbd56SKB/8wTVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=SiN1tJT0; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SiN1tJT0" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4687720B1; Fri, 27 Mar 2026 11:21:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774606868; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SiN1tJT0hFvNS3ysjzsXqbYqc/EEBbHz3ZtiAtVIaztL7HHD/e551eSP0YJySNaJs eDFW3o3aDd7sdSUQgpliaDKJoDWYSE2WsozxDZ1OInJQw2gxeb3+m008QeRhteL3D9 TELffqDpRfIow9qLS3N0OFB5NUP6TE7VGOUoFvK4= From: Tomi Valkeinen Date: Fri, 27 Mar 2026 12:21:52 +0200 Subject: [PATCH v2 04/12] drm/bridge: tc358762: Configure SYSCTRL first Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-tc358762-fixes-v2-4-3589d3c45f4a@ideasonboard.com> References: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> In-Reply-To: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1636; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpxlpbnS/v6u6HoN7+ye5GmbfvoMUY/5yECTcmj E0EwEamAJuJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCacZaWwAKCRD6PaqMvJYe 9XnqD/0WFsh2fl9+hlduIhlAVLv/pWYjHgzuqadKDfi8t4JOYTfVb9b4VIhU8SyPJCjztiS5OpF 5wCXxROkYsQ+Oe04gnmxYqWdEclYe38Ef0AJvvxr8x4chyP0q7CscEwxPH+db41m0/O2Q1vWZYx +imhtDtZj41qavHHQPrXtWdmcQl1DL70qvkhR6YXf0QOyd6C/T0Lx1PT9y/yEG6fFbX7ZurNpN5 jg7g30bZM7CfjJ0lA55NgT/NYR2f+k2SVGBlL7NhDEsaXZp6D6Xq9tazh1BvcsiDpnprWhGSKtr X+Cx0CxB3zCoYoYMd+Tk2N7+SoUbaoKd7PKfvub85A9SNIkoFV8o17Hfhim9C6lnf6eFzp96Pqo Ds1gEvfnMQGHXOdRuEkMyDFD063GlYMKKUz8Cb++KPWz2sj5csDjLUnwp5y3Csu6EGhBGN+GmKx aZGolaRtp7q7qm9J6AEz+j0N30bkUpmcudxeUsWn1l4SUtRljCVaJ/+sH3aWa1dOFWGeyq8rdoX Ke0u6AbI0x4nD+7Yj4R1Yir8Oe7vsw8SsjnmelDEC4v13pHlcafgCx7gQG4j6cBzN35/DF8VaXA 9blOZkiZ3D7989AARk2aq/M7PsyVePqh+LnX9G7Ic1SUXEilRZ5qHlZnKHGxuroIqOtU75hutVZ eLFZdbLthEeq4dg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 SYSCTRL affects the DPI output and the clock tree, but we configure it late, when the DPI output is already enabled and clocks are running. Move the SYSCTRL configuration to the beginning, before anything is enabled. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index cbedffb7a705..053579591dba 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -134,6 +134,13 @@ static int tc358762_init(struct tc358762 *ctx) { u32 lcdctrl; =20 + tc358762_write(ctx, SYSCTRL, + FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) | + FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) | + FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3)); + + msleep(100); + tc358762_write(ctx, DSI_LANEENABLE, DSI_LANEENABLE_L0EN | DSI_LANEENABLE_CLEN); tc358762_write(ctx, PPI_D0S_CLRSIPOCOUNT, 5); @@ -157,13 +164,6 @@ static int tc358762_init(struct tc358762 *ctx) =20 tc358762_write(ctx, LCDCTRL, lcdctrl); =20 - tc358762_write(ctx, SYSCTRL, - FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) | - FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) | - FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3)); - - msleep(100); - tc358762_write(ctx, PPI_STARTPPI, PPI_STARTPPI_STARTPPI); tc358762_write(ctx, DSI_STARTDSI, DSI_STARTDSI_STARTDSI); =20 --=20 2.43.0