From nobody Thu Apr 2 19:00:59 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B2A3B3BE9 for ; Fri, 27 Mar 2026 10:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606964; cv=none; b=Dc74npvw+H+kW/vyXr28ftCccNeIOkYI+wDaOG2ohfVlz/MwSNmDqIR+/v77ucKg7X2sMVPl9ihSBJnSrnGGnSRURKo2f/BUsiv7QD/FtNEPqjXTtnxUX4lJeVmuHX9vIuV8PWVYvF/2e0uIG/8ahPOT3mTKiJfKn54vNNqIjBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606964; c=relaxed/simple; bh=vJa1wHX0BnyPQsL6cv2chd2cFvvWt5+Mje7IlZp67Qk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=igrY4xbZtEZVWSSQyt5ts8PIDregYGpUftfqE17Q1YCdl0BfOnQNLMIUSDvDilTL07q3aCsPLwiu64t/v0j51Q6DB2/JIJH6FB2bkkbXczFljBmnBfea9uSAdZrrWkWSS8KjNogLekjMHAZN6osmrQ5HHJ+A1tS9bkDkSaGBsUo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CaG4DDru; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CaG4DDru" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EBEC7CA; Fri, 27 Mar 2026 11:21:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774606874; bh=vJa1wHX0BnyPQsL6cv2chd2cFvvWt5+Mje7IlZp67Qk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CaG4DDruDXmo20yo1VBfBXU7zpTpMKEik6AEt75SeolORQpL+3Zx7HV9aEesWzOVh Qzwpfd6XHfICltX+CLaAmf5OCB+xSc3Fo9rzVF+ozFzrmxXYSoH6lHCI9t8Fopo/Wr tZYTF6Frqe8fh3kd/AZlFei6OCHF8jEOYMGYAOL4= From: Tomi Valkeinen Date: Fri, 27 Mar 2026 12:21:59 +0200 Subject: [PATCH v2 11/12] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-tc358762-fixes-v2-11-3589d3c45f4a@ideasonboard.com> References: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> In-Reply-To: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3084; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=vJa1wHX0BnyPQsL6cv2chd2cFvvWt5+Mje7IlZp67Qk=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpxlpdALRp4f/55SnqSwKMz6Q60bp0KmlGLO3dL s5zcAl8SGOJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCacZaXQAKCRD6PaqMvJYe 9U+6D/4g0z7ApAIWaHQcBBJ59qkyCMTzDtExdYKYMf8rzNeo5douYdL/QRkMBMv005Vjkm2fOVD /LMGAet06tuTjlV4+XhJjFfGm12Y4arBboyD2WHywYWjas2RVasstOOyL94NCmkvsckT0aXg1/P Y4QJW+m9d1OLQvf3EsreEro73mFnMTLm4GRranW1J/7biTN+SJkriJNnjZpZyoBotkbgAyTs+Dh RxtbmfgfHO/tDeaP2F/DMKni6ouYJg1XUbE03PumvZqWhISGOBFC40SEJTiaqcQ0YZSkzu/8mEZ il0oWH2h66p1uLyRQUcejPpmi5lzXl94I3DlpSQePkuIwmly+2f1M/QiR75k6zhirTn4avAlqwM 0svwJe7Q+XiC8t31gP7kQRnfvLMqzQh+SKUXbfYrVoLCK1HLlkhTKNDTooXpaTm7un45JJ97eya IYIphant18pszZfH6L7NXfmUHbvEWGTfKKFAwQ4/ThrpqPDIJ7JfoWd/6ePMJ3M+Fy+vRaQrZkX z1ueuI7RWlVSVbTD+6QALj3/FzqfSQWTvHhXI+iR3a8JUGxzBqP8sR2mpztNu+sjI7C7M6pVvOt AVSGSGgvVwdYe6Sf2oTY7lW4mFY5/+l4Gx3XA5nuLmByi8UFSFgyIm42WIx/8sAQwn0XCVWeugr IMrT0v499/Prfyg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 drm_bridge_funcs.mode_set is deprecated. Drop it and get the drm_display_mode from the atomic state. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index 1e16d5b2d5fe..eba910ce8bd7 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -98,7 +98,6 @@ struct tc358762 { struct regulator *regulator; struct drm_bridge *panel_bridge; struct gpio_desc *reset_gpio; - struct drm_display_mode mode; bool pre_enabled; int error; bool use_vtg; @@ -186,9 +185,18 @@ static void tc358762_enable(struct drm_bridge *bridge, struct drm_atomic_state *state) { struct tc358762 *ctx =3D bridge_to_tc358762(bridge); + struct drm_connector_state *conn_state; + struct drm_crtc_state *crtc_state; + struct drm_connector *connector; + struct drm_display_mode *mode; u32 lcdctrl; int ret; =20 + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); + conn_state =3D drm_atomic_get_new_connector_state(state, connector); + crtc_state =3D drm_atomic_get_new_crtc_state(state, conn_state->crtc); + mode =3D &crtc_state->mode; + /* * DPIENABLE has reset default of 1. Make sure we don't output on * DPI until we have finished the coniguration. @@ -213,7 +221,7 @@ static void tc358762_enable(struct drm_bridge *bridge, if (ctx->use_vtg) { struct videomode vm =3D { 0 }; =20 - drm_display_mode_to_videomode(&ctx->mode, &vm); + drm_display_mode_to_videomode(mode, &vm); =20 tc358762_write(ctx, LCDC_HSR_HBPR, vm.hsync_len | (vm.hback_porch << 16)); @@ -237,10 +245,10 @@ static void tc358762_enable(struct drm_bridge *bridge, =20 lcdctrl |=3D LCDCTRL_DCLK_POL; =20 - if (ctx->mode.flags & DRM_MODE_FLAG_PHSYNC) + if (mode->flags & DRM_MODE_FLAG_PHSYNC) lcdctrl |=3D LCDCTRL_HSYNC_POL; =20 - if (ctx->mode.flags & DRM_MODE_FLAG_PVSYNC) + if (mode->flags & DRM_MODE_FLAG_PVSYNC) lcdctrl |=3D LCDCTRL_VSYNC_POL; =20 tc358762_write(ctx, LCDCTRL, lcdctrl); @@ -265,15 +273,6 @@ static int tc358762_attach(struct drm_bridge *bridge, bridge, flags); } =20 -static void tc358762_bridge_mode_set(struct drm_bridge *bridge, - const struct drm_display_mode *mode, - const struct drm_display_mode *adj) -{ - struct tc358762 *ctx =3D bridge_to_tc358762(bridge); - - drm_mode_copy(&ctx->mode, mode); -} - static const struct drm_bridge_funcs tc358762_bridge_funcs =3D { .atomic_post_disable =3D tc358762_post_disable, .atomic_pre_enable =3D tc358762_pre_enable, @@ -282,7 +281,6 @@ static const struct drm_bridge_funcs tc358762_bridge_fu= ncs =3D { .atomic_destroy_state =3D drm_atomic_helper_bridge_destroy_state, .atomic_reset =3D drm_atomic_helper_bridge_reset, .attach =3D tc358762_attach, - .mode_set =3D tc358762_bridge_mode_set, }; =20 static int tc358762_parse_dt(struct tc358762 *ctx) --=20 2.43.0