From nobody Thu Apr 2 19:01:00 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F40853DDDC5 for ; Fri, 27 Mar 2026 10:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606966; cv=none; b=oNAW2Y+gG71d41Kg2JwHSau95JarCaAn2ilAhvpRxMB7QiJWjgW8byqVCfMaompbIOdJCimQRiVzxJDftYkQJIsdBvAkrpQh96rSUIRX+Cf0F1RNXS19Fe8HcjxZHY0WIjXGaYHBzzR/+dRcYXU5fcjU0ArsnekwxHlExeOk37Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606966; c=relaxed/simple; bh=/wdYP29yBAv6ikCOExFakd/hehiH5b+5E6ONbsAki38=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oqU0WMTCLfK65wn8xjP8HzwMGikgspuxAJPrFshy0AYyW6sh8s1aikH4Olf//EGh06caHwyq/wOT2osBVzEuwpKPyioUa38kMgxT7h9VgLKXTAwXyl9EjT5/YuJOZz8OoEfJNvf10rdX/J3Ck6S5MBJDFPb9g25z9DPgVnDSy6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=t+nDMpF/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t+nDMpF/" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 176FA304F; Fri, 27 Mar 2026 11:21:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774606873; bh=/wdYP29yBAv6ikCOExFakd/hehiH5b+5E6ONbsAki38=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=t+nDMpF/MU6Aq532lYu07N2+sh8BmpOBLodDpW6GLoCEsLQjOdY36S94cQEYgRM8x uu61LrzINOycvPf+UE6rWFZxhlmu/92w5zCu/RLqyBpC+0ClFvvIHlYjB4Xmf0DD1t 2wUwSxYmy4ONt1F9I4mdxwet2/4ys0C1AX2qcBWQ= From: Tomi Valkeinen Date: Fri, 27 Mar 2026 12:21:58 +0200 Subject: [PATCH v2 10/12] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-tc358762-fixes-v2-10-3589d3c45f4a@ideasonboard.com> References: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> In-Reply-To: <20260327-tc358762-fixes-v2-0-3589d3c45f4a@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3796; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=/wdYP29yBAv6ikCOExFakd/hehiH5b+5E6ONbsAki38=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpxlpdG7mPfZ0SeX9Q5HixxCR+5kY+AYB4RW1Ow ojTUGrAesuJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCacZaXQAKCRD6PaqMvJYe 9TwlEACszbbb6s8v/xP0hoefZ0fwTo4yHWtl2O48ofhemzDUGdVV7IaRYrsRbqaP17QSogGyAcn OE2U1vUgILHVXtjo8/UI6Jb+/XoMkyPUBkBj4LsYOygqf/kNmETYw2XW9HyThUZvyjqJm4h+8B8 lnfxP3WAKLjuoMcp722eCPUfbckGXWnnkUy+ST0r+NT/D0QmN38UCXm/rPvw0WG5U/7LrPqvIkb cVrFv4RNqu9ndDJT7C0i5rTBSJ4ArOlUEiZW+izAizUkEmtOwjVuKgxWivr8Z1idy8Rr8C4r+SK kMiVpSSF2uCXCB0io7qFRWTJFndoSF/Te/R0An/n+vpe3Hnem+LBsLcv9cHGfYK4k9h+R8Fy9KB X0X0jSEmVSg0bdImlsC3QwoPYOQdni6YupzQzZ5+XMvI8W+uWk7GqruFVaShn+NTV6rkwIJVlY1 qC29e+eXfEhhptpuQCARVDoZsg2y/7hFKPY5gJDzey/cIxwLjQ9g08oczpFH+yqtW4Y2G+LYIuQ 83Urux4k35TH0TXf5A7pFdyMQQzMQ3PF8OxhGdIobBtrTwQwHMMsd9aJFjmMQNHvwbGoajiCP7c CPxfn7jyilBZAuD0R9zlHBS/U6FCyBty/QV2Wd+DmwrD3USp4CupcjjkONmzgg9YYsGrjTsma/y ir84avC/DVRMffw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 The only thing tc358762_enable() does is call tc358762_init(). Inline the tc358762_init() into tc358762_enable(), for simplicity and to make it easier to improve the tc358762_enable() in the following commits. No functional change. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 104 ++++++++++++++++++----------------= ---- 1 file changed, 49 insertions(+), 55 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index 26999b97edae..1e16d5b2d5fe 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -138,9 +138,56 @@ static inline struct tc358762 *bridge_to_tc358762(stru= ct drm_bridge *bridge) return container_of(bridge, struct tc358762, bridge); } =20 -static int tc358762_init(struct tc358762 *ctx) +static void tc358762_post_disable(struct drm_bridge *bridge, + struct drm_atomic_state *state) +{ + struct tc358762 *ctx =3D bridge_to_tc358762(bridge); + int ret; + + /* + * The post_disable hook might be called multiple times. + * We want to avoid regulator imbalance below. + */ + if (!ctx->pre_enabled) + return; + + ctx->pre_enabled =3D false; + + /* Turn off the DPI output */ + tc358762_write(ctx, LCDCTRL, 0); + + if (ctx->reset_gpio) + gpiod_set_value_cansleep(ctx->reset_gpio, 0); + + ret =3D regulator_disable(ctx->regulator); + if (ret < 0) + dev_err(ctx->dev, "error disabling regulators (%d)\n", ret); +} + +static void tc358762_pre_enable(struct drm_bridge *bridge, + struct drm_atomic_state *state) { + struct tc358762 *ctx =3D bridge_to_tc358762(bridge); + int ret; + + ret =3D regulator_enable(ctx->regulator); + if (ret < 0) + dev_err(ctx->dev, "error enabling regulators (%d)\n", ret); + + if (ctx->reset_gpio) { + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + usleep_range(5000, 10000); + } + + ctx->pre_enabled =3D true; +} + +static void tc358762_enable(struct drm_bridge *bridge, + struct drm_atomic_state *state) +{ + struct tc358762 *ctx =3D bridge_to_tc358762(bridge); u32 lcdctrl; + int ret; =20 /* * DPIENABLE has reset default of 1. Make sure we don't output on @@ -203,60 +250,7 @@ static int tc358762_init(struct tc358762 *ctx) =20 msleep(100); =20 - return tc358762_clear_error(ctx); -} - -static void tc358762_post_disable(struct drm_bridge *bridge, - struct drm_atomic_state *state) -{ - struct tc358762 *ctx =3D bridge_to_tc358762(bridge); - int ret; - - /* - * The post_disable hook might be called multiple times. - * We want to avoid regulator imbalance below. - */ - if (!ctx->pre_enabled) - return; - - ctx->pre_enabled =3D false; - - /* Turn off the DPI output */ - tc358762_write(ctx, LCDCTRL, 0); - - if (ctx->reset_gpio) - gpiod_set_value_cansleep(ctx->reset_gpio, 0); - - ret =3D regulator_disable(ctx->regulator); - if (ret < 0) - dev_err(ctx->dev, "error disabling regulators (%d)\n", ret); -} - -static void tc358762_pre_enable(struct drm_bridge *bridge, - struct drm_atomic_state *state) -{ - struct tc358762 *ctx =3D bridge_to_tc358762(bridge); - int ret; - - ret =3D regulator_enable(ctx->regulator); - if (ret < 0) - dev_err(ctx->dev, "error enabling regulators (%d)\n", ret); - - if (ctx->reset_gpio) { - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - usleep_range(5000, 10000); - } - - ctx->pre_enabled =3D true; -} - -static void tc358762_enable(struct drm_bridge *bridge, - struct drm_atomic_state *state) -{ - struct tc358762 *ctx =3D bridge_to_tc358762(bridge); - int ret; - - ret =3D tc358762_init(ctx); + ret =3D tc358762_clear_error(ctx); if (ret < 0) dev_err(ctx->dev, "error initializing bridge (%d)\n", ret); } --=20 2.43.0