From nobody Thu Apr 2 15:37:43 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F931448E0 for ; Fri, 27 Mar 2026 12:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774614613; cv=none; b=QDn34DCA+K9vPbNB4xkLcl8fVabgWxz1mVZvPEsjFunWPRw52d+qUWbprv2Amw+LLl7PI0r1X2+9RqmBm5b4tuUn1Ox03/5kGxHT7nPHRD6qWGUmru4tIuWt5lL64pmn20NLQ4LdZexb00rIznZBgiMV7dJtc5GaPiYX2gc+x3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774614613; c=relaxed/simple; bh=i/3kdVJVAfSV04QzJDFfmhiJONWZj2rQa3Q7sVnDl4E=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=l522iNgy+vkISK9z2JiBk6KOdZEXUrgx2TnVC20Nk7Y9jgEW+WC7nGSD/aVErt3LgsR6AWzh/Cst8KFfDMejY2plVh4MWEJ3Q764m26MPd/ebDkJjWYhkTtWWGsFZqZTHuk5RbRAxBS+z20ld5nCCHjkQLk31T+w15EkrVfYQaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BlfYnuGV; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BlfYnuGV" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48542d5aa9eso17118725e9.0 for ; Fri, 27 Mar 2026 05:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774614609; x=1775219409; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Kzs6brRuokL8MFn6Q0aOgw6+CROkqpQkMmoZ8t0dyos=; b=BlfYnuGV7aFpjiRNu7OtUo8v2GQ8i6mlnANsNVb5m26l5s5BfrAp2dQ07jog0tFzUi bvYbVlPPSJD75JKUVzYTNwHn3FCGNwooULk825Xgbyb9HSzkUPkZ/mShBr1xhHPrW0sY dUolzNsgkxCzRao0oNPZlmT5FjDWGw/gTZ8M8tCtrKVGXB84q1hDHmlTTl4GjLjL7+Gq EA1nJCEJMELjDwEcl6//9AFHu7SkUKIAMUl2Dcg+X9avRk0tdHSGN68F5eZZ6fkxmJuM 0Hyk3XpdJCWFfNT/PZ5oeIfZ0BPJIlyq2mEJmDiVf9bmRtvOpUhENp4Teqr1ErFiLPbz CdWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774614609; x=1775219409; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Kzs6brRuokL8MFn6Q0aOgw6+CROkqpQkMmoZ8t0dyos=; b=OVadSb5SY9vjqABLqie3V4Ize4HMzK0XR5+0HLrTFerbZMw4P7UYSfnXFFnvq8SggD +Z7StfaV120+JdAFkeen4vuBKEoKcDwN+ufKrU3IEM7M1kvZpz2jqDmg8j07WMKvoHBp vRPCcBSqe8xJS6ZV1kiHYvnOdi4a5wGFct4qHhJ1wXv38yKVqtqkSkoAis9EVrRXqQdn IyFrSoCefutZBVZRSS6Lgzmy3ApPWBhtqbNkKwE1n0QZ7iE8CquiwGIvKgDHJ3UKWUZG 3WkxgC8d2u3Bxql0hizXqQ7T+vDkXvidyAbTAYC9Kc6UQZBlWQZ05zIJ52xphqCfOaSu DZTA== X-Forwarded-Encrypted: i=1; AJvYcCVIBBbOwqUp1bX/U0KwWeBXCWD6/oAROqUXf5/QDIdWFUgpu7ygg4DEiNyFePUO0VBS1LddMTdyjLKf7lg=@vger.kernel.org X-Gm-Message-State: AOJu0YypHrZKLcqI4S/zoG9R55PxEo9VZ8vKwtmrjURgZFIzy/fsoKnz zmj3GYOReRy5/SCd3LMni/XZqoHdx8HCKvT+E8WGRlZIPUpWtyBvvzENtbfWGhnTXYWsj9gBJNh YO/chrdknCJGUJA== X-Received: from wmon22.prod.google.com ([2002:a05:600c:4656:b0:485:29bb:91fc]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:c4a5:b0:485:3ae8:2231 with SMTP id 5b1f17b1804b1-487280a2507mr34925675e9.30.1774614608985; Fri, 27 Mar 2026 05:30:08 -0700 (PDT) Date: Fri, 27 Mar 2026 12:30:07 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAE54xmkC/x2MWwqAIBAArxL73YKpFXSV6MN0tYUoUehBdPekz xmYeSBTYsowVA8kOjjzvhVo6grsYrZAyK4wSCE7oWSPfK4UjL0x+IieL3Rtq0gpLWbtoWQxUdH /cpze9wOkvrzfYgAAAA== X-Change-Id: 20260327-iwlegacy-gfp-fix-d553e3340b4f X-Mailer: b4 0.14.3 Message-ID: <20260327-iwlegacy-gfp-fix-v1-1-b83e4db0bd66@google.com> Subject: [PATCH] iwlegacy: 3945-mac: Fix GFP flags in allocation loop From: Brendan Jackman To: Stanislaw Gruszka Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Do not latch these flags, they should be re-evaluated for each iteration of the loop. Concretely, rxq->free_count is incremented during the loop so the __GFP_NOWARN decision may be stale. There may be other reasons to require the re-evaluation too. Suggested-by: Stanislaw Gruszka Link: https://lore.kernel.org/all/20260327115739.GB16800@wp.pl/ Signed-off-by: Brendan Jackman Acked-by: Stanislaw Gruszka --- Transparency note: I am 100% taking Stanislaw's word for this. The bug being fixed here hasn't been reproduced and I don't have a way to test this patch at all. It does seem to make sense to me though and, well, Stanislaw is the mantainer :) --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/w= ireless/intel/iwlegacy/3945-mac.c index c148654aa9533..e8ae6687c08ec 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c @@ -979,9 +979,10 @@ il3945_rx_allocate(struct il_priv *il, gfp_t priority) struct page *page; dma_addr_t page_dma; unsigned long flags; - gfp_t gfp_mask =3D priority; =20 while (1) { + gfp_t gfp_mask =3D priority; + spin_lock_irqsave(&rxq->lock, flags); if (list_empty(&rxq->rx_used)) { spin_unlock_irqrestore(&rxq->lock, flags); --- base-commit: 0138af2472dfdef0d56fc4697416eaa0ff2589bd change-id: 20260327-iwlegacy-gfp-fix-d553e3340b4f Best regards, --=20 Brendan Jackman