From nobody Thu Apr 2 15:41:20 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8428271471 for ; Fri, 27 Mar 2026 13:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774618834; cv=none; b=qTJkpOLTB7n0hnjEXy5CuFwgXh13tzg6aaJwe+/30XJAESfE7LFEz8l4tnGdyxjeKEo82Q/6Gy2L9Rwd6YDoyyu3qw07Ocv9XQA/3h/VW+s0QQsKrivEvQIAMUbMnGGPy1fNRKeXs/XQrsS/9s+dZqOO/JgsvlQ4Y2s+3M5mycg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774618834; c=relaxed/simple; bh=Zq+m9dJVIo2v68WullWUqqT5ifZ/SvtweJdsXJz+yJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=SE5Ok5AAOZ0CS9t7RtLJJNfoeNTKapQWSsg/XkcEHD2Bn9BRrXTAVepOuyFj+lonSkGPGzyOcQzps5iXfzZOS9xkNECDHhxRGvRJuTq0pae+4K2lBFiwM5TguvHcaeqQIHQVMZMmCV0l1xOFEJXg5MCTfbD3QQ7qIZKTsNa2J9s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e49UHcVa; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e49UHcVa" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c742723c863so1322548a12.0 for ; Fri, 27 Mar 2026 06:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774618833; x=1775223633; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=tZms32AMXN/AmcpUuOOCmOM7b07bBIpZ39KVWJt5CaE=; b=e49UHcValTkav8Kao3STFOujVrUn03JciZNncZAPnGDR+wSmsX95O/ofiFTuffYaca AAdLtkdOSJaMAGmkWQCCYCZcKtS7W9RPLmibUQY1lur7zbRvsrPBcp7UzyxlqUwjxdN/ kDicstqxSU/0bJ2zTNbji2W+HkjQPC3NbxklxzWwv22EQ3rH4SUgUb/qaD/D5wzHHKQe RQR/HU9MLeA55z7kl+qQ2l3lKayq99lgCngY9F44bce45+GIPBGirxQkYA9zlP34eo3K /jL0hbFJMP+TBF2qdQtcj6Plwa9BT2VW1JkPVOMQma8ZIk8l1Qhx/TEcp2ulqodr0X4u gYpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774618833; x=1775223633; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tZms32AMXN/AmcpUuOOCmOM7b07bBIpZ39KVWJt5CaE=; b=N1mc03Bq8hS8hfz8Pd5jsPGLF4Rgb9E4VVO6s9xPmgtfZeRzSRjvgCQyvUDEOWjFM6 xDdArcMwqXSu3wVAzdJA/onGEGeU4Gs4hrVU1NP6xeKQx1H4ptKFKVfeZBgcm0aXq/h6 DQOfPAYS/p5pF4HaztEcixvINIlv6nPpKCvudljGWGBYe42cCbAAwdyw1MN1lmLIULA+ LbrYrrZdoYKcuvhRMsn4oNzQH61aOcmfd2icq7cmn3Mck7Cf1qcI/k9x+gAGfeAHeIui aby7nSJzNL5tP1jts1Zspz9GM/nK/LHyySRZyvcX9G06tbml4JB4FBEiNRe3fBWCQQaH mzVA== X-Forwarded-Encrypted: i=1; AJvYcCWjp7ty+YexbTU4ADnqGob1h37lqHpv80CybUcIOpR2nbYN1ETP0c8iANmW5VYeEap1AlB2DM5Sxycl2oU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf4qBYI2g+w9DZEG23FfqhH/AY3stmAa2WeW9zZNxyhOUhGIh7 optAgeMNze0inorFrRZVIzNE76rwHI2QMe08XYViT99pSRVLQB2ZXOg6 X-Gm-Gg: ATEYQzyP5KXRy8dv/BX3dGEw24L6QYLvBNEyfLgH1jIM0wk09AyA4BPiq1IGO0c1EPe 5ONGc9EgUbJ530u+YIlMQgEFWxvmL8v+kiPL9QkDIbpssi12eP/b4VUFXbhkSK7POn3FDx96olO E/Jw1lJhH2IYYz3LaBOnDtDuHL1FroDXGT8jFq90A7KEteo6BNTSo/QLgHMidqwz2Kxj/9IUKbL KOjOMoy2Iur7cBaw91sI5Mw9+21bXUiPp89U+JeKT3pSRz1TvIepzuQ/qbHb9k7ddpjh3cniozX x9FINfLjZ0+salmSbN99JdmeGBWcQVZhol3IlPgiRqBgK9RZ/NaCpD69vjZp0KSvv49GfBvcVen ax9KaWadNFzqIlOLU/YEfxVvbEg+u4w51DPNYq6zummePWui7/zAEPLwuFtwEyKpmcDBRthYff3 /VZ7aMFAen2hY5+p/Va/am5m/lEqg0DOB4B3/t X-Received: by 2002:a05:6a21:33a0:b0:398:9662:110e with SMTP id adf61e73a8af0-39c8780d9f0mr3250210637.8.1774618832802; Fri, 27 Mar 2026 06:40:32 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76737f28d6sm5448685a12.6.2026.03.27.06.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 06:40:32 -0700 (PDT) From: Felix Gu Date: Fri, 27 Mar 2026 21:40:30 +0800 Subject: [PATCH] ipmi: Fix sysfs file leak on maintenance_mode creation failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-ipmi-v1-1-d4a4417140b2@gmail.com> X-B4-Tracking: v=1; b=H4sIAM2IxmkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyNz3cyC3ExdEwtTw9TEZDNjA9M0JaDSgqLUtMwKsDHRsbW1AF6G/WN WAAAA X-Change-ID: 20260327-ipmi-4851eac6305f To: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774618832; l=1115; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Zq+m9dJVIo2v68WullWUqqT5ifZ/SvtweJdsXJz+yJY=; b=o+8RrY2Bi/ux+w/j5Me1BbBOrT+MyrSdxl59uizXeiUi/HvaSnO7ZCpn57Y3tsF3o8NpH8EKe 40IqXLbo1BkCXF1hszpqm7OFh81Gi0N/KQhJ76TAijIiycyEdwt11vP X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When device_create_file() for maintenance_mode_devattr fails, the error handler only removes nr_users_devattr but forgets to remove nr_msgs_devattr, causing a sysfs file leak. Fixes: 627118470fcc ("ipmi: Add a maintenance mode sysfs file") Signed-off-by: Felix Gu --- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index 869ac87a4b6a..f59db5df69da 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3734,6 +3734,7 @@ int ipmi_add_smi(struct module *owner, sysfs_attr_init(&intf->maintenance_mode_devattr.attr); rv =3D device_create_file(intf->si_dev, &intf->maintenance_mode_devattr); if (rv) { + device_remove_file(intf->si_dev, &intf->nr_msgs_devattr); device_remove_file(intf->si_dev, &intf->nr_users_devattr); goto out_err_bmc_reg; } --- base-commit: 66ba480978ce390e631e870b740a3406e3eb6b01 change-id: 20260327-ipmi-4851eac6305f Best regards, --=20 Felix Gu