From nobody Thu Apr 2 18:46:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC8D3AA4FD for ; Fri, 27 Mar 2026 10:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607496; cv=none; b=jX/AF/zO91iq4pdP16iUA+o13DRzQ+Ve340uEokxx+Y76F/+7391hcAPYAQHBkkt8lsU1gnrnpbCnZo2nRMY+o2hQXpkJ6xP1IqPSup/l9L43Y1hpQbEfmRdmy+NPBp1E99O+fQ8gY/NR1taxFUczS8TU2fVDZPI5REDeDUeA78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607496; c=relaxed/simple; bh=cvNWbcJEPu+X1KGHjftcUVfo5YRpAWfGsNOyThkztWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mNobzcWd+yzc1DReYtfkqThp2H9QOONpO1LREuO1KpitYhibPwTzvOHX1uymNXAJ+5OPAUnxL2P3gqn9lrE27zB+qV6eKtlRB55FDZJKVUgN7NiJqkE6MdZ9rzaJ9Ez2Lb6f9xLS+tkFDepCVvuBZziCnYKzSGOgKBYqKU74/as= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SmWbzjcZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S8gzVmVE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SmWbzjcZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S8gzVmVE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6vpBj298526 for ; Fri, 27 Mar 2026 10:31:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kRfsS1H0OfXi/OKjLlmM2I3kRnvciT3vVPcYJHJok3w=; b=SmWbzjcZVkYgjVN9 MLM6h3QZF2ZmScn8YT9cO58rAtkjmvg1Jjvqi/e1sspoHrzJ+rbL3ixNk/TxWnku nNeJb7DsuPsBWgRORmotZkUpGPjU72EgSvwDJYnERTM/TSXJ7IWMxEn0IJvqavu4 MJ/1dwlaHiFbBx7wh3AjU+N9FgcyTRyK0ay3PU6H2iJDcgKyeHWnvztwlggTJ6tv tAYyHUTmxIjrZvWkOcZZllTXW55LujWvY4vJrJlRSHB6N76JzF0u8sAy6Szhnjhd MdCkaIznZAtpScleTJTPBNeTf+4v8x1goUbm79in71FB5cMBAtIOXYLo/EVCMTPX WjtFog== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bd8tpp1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 10:31:33 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-56ba3652e5dso1060062e0c.0 for ; Fri, 27 Mar 2026 03:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774607493; x=1775212293; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kRfsS1H0OfXi/OKjLlmM2I3kRnvciT3vVPcYJHJok3w=; b=S8gzVmVEZRrpPlGo1eskq6O+jkJXdukx8FlI1LxwxCEOa9FYsPgTAWrwW4m5P+aDbR hp3RWqxxwWjwiXf9E29xllAlWlMxtvzo4WacS1Psay84SBOGVOCA3ACMU3+F4k+gwldy Mtb585lwSuZ6Xfwkd7ZuCKoU3maoXfv3N4BhBhY6wY4Cae0TKjpdkEFyONqNZYdfPAFr jzspeuLTzSeLQyxSBOnw87yZouAYMAK/nmKLuFaCyKHxtcAedyiNv9g0KeOs1BqE458W PN11bSjm3GBVBW1bMdMyQ7RkdhfM59RC5WC2PoYBV74GlkpsdKnk7ygPImGWK5watg5y pU+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774607493; x=1775212293; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kRfsS1H0OfXi/OKjLlmM2I3kRnvciT3vVPcYJHJok3w=; b=ab/+NuO7fsGdrQkaOZH/qGt3MeuQLfLlYuDDZFoF0PO6lMY6O0wBsXMMp6NzdKQoOj 6nd2M7F27NzVaph665m2uIZW1NrTPYtG0mDEt/YFP2BK23/cFM40K1Qi3yN3ClnVQAbp 0GAKVx1wbymVGM+c6w+hl8xO0GEbryCX6PpPWPw3gOMGUN3BOYTp0iJRAba+mitNiPbC 1jcVzFgUHO9mZoVMNh8l6/VkY3+SIa0TqduGjg/fUhZtbBZPLoluEMoCMm5ntR+8IlBf WPx18Iia2g81P4Jig60lwfMkSzMozKlhC/++53lVNpsJEmd+b4oUyxs8rscA4y4Rqbw/ 4T3w== X-Forwarded-Encrypted: i=1; AJvYcCXpoDlRU27BbLsAWJkead3DQpwKHMP4Xr9+8IecO6UgSQif0jVfeUZBOd/+txHWro+1JJt6q1tlrXnZ5QI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6k4Etdbgm1TNmGvDfbceNH0AHeUozFoj4lIqHPdJ69NBWWlrS j4Spdk5XxQJUWIoXHq6s+Wf94WgpQ305SnNLH2dwilV2ADjNF5w+zssIYrrLgVCz9DDLGL1NSp4 wMXc5G56Mf+0z+FMbxAGzNOgKOGjYxOa7wHXoLzNJiiSTcL0tdNyWehRLSlO0CBXfFAY= X-Gm-Gg: ATEYQzxQ7te9DiqTHavdoOVm9JJx85p+H8x0jTLV0LcjijN3vC2M4UAb5aDuYdaJP3m cp38Gv725ugkymS6FV0sTRoVGFYFjEMxHBbmx+LgYBEO3i2vkdVP3SNhJrRIdnJsa238lBZWCJL vN9PanNnEgj20LUM7RVzdlANxrDtnJ7yqUxYUe5tClbREgNwjxLObtvlcw4R1pGA9MtCGscKNzv lZ8uH3s9mqbKo85aofl6NRS/4gxJFJ1DnHNuy+3T48RtsgGmP6F9r2L0RmgW97K43dL0NcUy9eg WyEaxrmH33PksWzGbCQU1BhhJ8O7LPG2KdZCabzebvuUm3N2dXv9wUJ1Ivi+t+bu9zcC+BgvW4r 0IrxVtBM7NuOeu/ir39bswQc4Pyq2V3t6FHcZ2oHnFS5Zd3ZWjH8= X-Received: by 2002:a05:6102:8026:b0:602:b1cf:80d5 with SMTP id ada2fe7eead31-604f9070848mr641322137.8.1774607492816; Fri, 27 Mar 2026 03:31:32 -0700 (PDT) X-Received: by 2002:a05:6102:8026:b0:602:b1cf:80d5 with SMTP id ada2fe7eead31-604f9070848mr641306137.8.1774607492316; Fri, 27 Mar 2026 03:31:32 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:94ec:a3a:baff:9151]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919588e6sm13382138f8f.16.2026.03.27.03.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 03:31:31 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 27 Mar 2026 11:31:12 +0100 Subject: [PATCH 2/4] gpio: aggregator: stop using dev-sync-probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-gpio-kill-dev-sync-probe-v1-2-efac254f1a1d@oss.qualcomm.com> References: <20260327-gpio-kill-dev-sync-probe-v1-0-efac254f1a1d@oss.qualcomm.com> In-Reply-To: <20260327-gpio-kill-dev-sync-probe-v1-0-efac254f1a1d@oss.qualcomm.com> To: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Koichiro Den Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5044; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=cvNWbcJEPu+X1KGHjftcUVfo5YRpAWfGsNOyThkztWg=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpxlx7/LwnXz655ObLQ1uxB4C2yqxOC9hpMFgFZ FQSh4Sn4uqJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCacZcewAKCRAFnS7L/zaE w7K9D/9OPshfbXmeEOYpJy4frYd3hQfDF7xgiCMX4+XAL/LpWN+rvWWIls7yN+emtf9OAZ7IKpm Xoh3Grl56GxlBaDpSXfnCNOhIgHUJTgPVsnsGFwr57fz0mcZrRB4hrlu+bXZwXCQsG6raVFlqsv TmNBSjmH/7DSP71y7OmnC0ZU+KKr8wZo5O7p5U8xuhA36wzLPx5GgWkJo7PWIN//ie686kK/Fse WcDHRnAAn2/fUaE6WpeUz7wKTcwtQCavkhTRCa168yKWcrJ1Gpghrq7+lBVGHvd8EAJshd38KQH ie0P6LYygePSh1yWcRKpEwWLv0XFAFL90sG62NkcyEe0qeWg6kYcUgzOS797bmn2PUEQpF3cOpV nO2xU/JgVnP7k1JaOuLGIFhNehwvUsewV9k/On23skZxhGgwiuddBqE/AJ9YvMu/RTUHaX8tvxG /dYoiFalySxv1a4BbM4voU70I145sx7+8ZVmO0mCaO+VvbIcUKG2tZgIJEjepZsdiWNmqRlXTAi 9V9zVQgMt0AgOOhuUahmdjrC3YT0s3KkSwP8S5VL4idlhH8F1tBpgHPuMi9bBtjKP1JiuMZRcyY Cb7IwuaIo7dGR+SQG7HkZY3udgGCkoL7VonU5SXkMjpPLSWOERRfTxVH4XrSW/Fwd9xLwIeuYn7 sFqe58CYYuURMeg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA3NiBTYWx0ZWRfX5OD5i/wu7H+p m3BbQjGhgDOJnEnYwx+z7bFFG976Vb+/rpFZ4iRO8oEIhQ3ZKFdsYDV0QYuCCXVo83Yv/9/bBKf /eCOG5JmSDpCEzRz+8/PexDLncFONgOdomMvpolAjt2pBgrOvN00502rXSTznc3BdncXOeVnHj7 NOyl2M8ZrCxKq2ak03CuYU3/OdW9Sn0J/8EtDTHgUb6vISif9H8oZOaXHWaBaPBcdWihEQH3by+ UPonl6Gsz0Bw3KqBp44GUUSwVQZuwZBquO7YsaptstQ3bLLj/pY017pXtQSKcywh1QhsJXkxQzN yA7aRPLDd27mAoT6yoENcJ705BVt8KCFech0PdCy7ALC6H/mwh2yDoHH0b6+UEmQZAxga5EMi4D EbLdwX9sb7LAVzqKaJSkwLbdIEKts9FuLGBMfRcp3WmGYy2V0c028fmcUYo96m8SLPKuOMw5hYo HY3sjF6b/RLswi6jXOg== X-Proofpoint-ORIG-GUID: GMcoISiIgCQoMMhg4nD097v4Y7Y6G7Wr X-Authority-Analysis: v=2.4 cv=BZrVE7t2 c=1 sm=1 tr=0 ts=69c65c85 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=DQLobAsLdNT4mewj-18A:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-GUID: GMcoISiIgCQoMMhg4nD097v4Y7Y6G7Wr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270076 dev-err-probe is an overengineered solution to a simple problem. Use a combination of wait_for_probe() and device_is_bound() to synchronously wait for the platform device to probe. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/Kconfig | 1 - drivers/gpio/gpio-aggregator.c | 38 +++++++++++++++++++++----------------- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index a603406cb2e53a89e1da6214a3c1c256d5246be7..09db777938f3723e5dbd895dd1b= 30d39a21a2da1 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1984,7 +1984,6 @@ menu "Virtual GPIO drivers" config GPIO_AGGREGATOR tristate "GPIO Aggregator" select CONFIGFS_FS - select DEV_SYNC_PROBE help Say yes here to enable the GPIO Aggregator, which provides a way to aggregate existing GPIO lines into a new virtual GPIO chip. diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index 9adf3228c12a84e098ab7ffd543fcad58951ba99..5915209e1e2168b0932de4d16af= f38074b889c2b 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -32,8 +32,6 @@ #include #include =20 -#include "dev-sync-probe.h" - #define AGGREGATOR_MAX_GPIOS 512 #define AGGREGATOR_LEGACY_PREFIX "_sysfs" =20 @@ -42,7 +40,7 @@ */ =20 struct gpio_aggregator { - struct dev_sync_probe_data probe_data; + struct platform_device *pdev; struct config_group group; struct gpiod_lookup_table *lookups; struct mutex lock; @@ -135,7 +133,7 @@ static bool gpio_aggregator_is_active(struct gpio_aggre= gator *aggr) { lockdep_assert_held(&aggr->lock); =20 - return aggr->probe_data.pdev && platform_get_drvdata(aggr->probe_data.pde= v); + return aggr->pdev && platform_get_drvdata(aggr->pdev); } =20 /* Only aggregators created via legacy sysfs can be "activating". */ @@ -143,7 +141,7 @@ static bool gpio_aggregator_is_activating(struct gpio_a= ggregator *aggr) { lockdep_assert_held(&aggr->lock); =20 - return aggr->probe_data.pdev && !platform_get_drvdata(aggr->probe_data.pd= ev); + return aggr->pdev && !platform_get_drvdata(aggr->pdev); } =20 static size_t gpio_aggregator_count_lines(struct gpio_aggregator *aggr) @@ -909,6 +907,7 @@ static int gpio_aggregator_activate(struct gpio_aggrega= tor *aggr) { struct platform_device_info pdevinfo; struct gpio_aggregator_line *line; + struct platform_device *pdev; struct fwnode_handle *swnode; unsigned int n =3D 0; int ret =3D 0; @@ -962,12 +961,23 @@ static int gpio_aggregator_activate(struct gpio_aggre= gator *aggr) =20 gpiod_add_lookup_table(aggr->lookups); =20 - ret =3D dev_sync_probe_register(&aggr->probe_data, &pdevinfo); - if (ret) + pdev =3D platform_device_register_full(&pdevinfo); + if (IS_ERR(pdev)) { + ret =3D PTR_ERR(pdev); goto err_remove_lookup_table; + } =20 + wait_for_device_probe(); + if (!device_is_bound(&pdev->dev)) { + ret =3D -ENXIO; + goto err_unregister_pdev; + } + + aggr->pdev =3D pdev; return 0; =20 +err_unregister_pdev: + platform_device_unregister(pdev); err_remove_lookup_table: kfree(aggr->lookups->dev_id); gpiod_remove_lookup_table(aggr->lookups); @@ -981,7 +991,8 @@ static int gpio_aggregator_activate(struct gpio_aggrega= tor *aggr) =20 static void gpio_aggregator_deactivate(struct gpio_aggregator *aggr) { - dev_sync_probe_unregister(&aggr->probe_data); + platform_device_unregister(aggr->pdev); + aggr->pdev =3D NULL; gpiod_remove_lookup_table(aggr->lookups); kfree(aggr->lookups->dev_id); kfree(aggr->lookups); @@ -1145,7 +1156,7 @@ gpio_aggregator_device_dev_name_show(struct config_it= em *item, char *page) =20 guard(mutex)(&aggr->lock); =20 - pdev =3D aggr->probe_data.pdev; + pdev =3D aggr->pdev; if (pdev) return sysfs_emit(page, "%s\n", dev_name(&pdev->dev)); =20 @@ -1322,7 +1333,6 @@ gpio_aggregator_make_group(struct config_group *group= , const char *name) return ERR_PTR(ret); =20 config_group_init_type_name(&aggr->group, name, &gpio_aggregator_device_t= ype); - dev_sync_probe_init(&aggr->probe_data); =20 return &aggr->group; } @@ -1471,12 +1481,6 @@ static ssize_t gpio_aggregator_new_device_store(stru= ct device_driver *driver, scnprintf(name, sizeof(name), "%s.%d", AGGREGATOR_LEGACY_PREFIX, aggr->id= ); config_group_init_type_name(&aggr->group, name, &gpio_aggregator_device_t= ype); =20 - /* - * Since the device created by sysfs might be toggled via configfs - * 'live' attribute later, this initialization is needed. - */ - dev_sync_probe_init(&aggr->probe_data); - /* Expose to configfs */ res =3D configfs_register_group(&gpio_aggregator_subsys.su_group, &aggr->group); @@ -1495,7 +1499,7 @@ static ssize_t gpio_aggregator_new_device_store(struc= t device_driver *driver, goto remove_table; } =20 - aggr->probe_data.pdev =3D pdev; + aggr->pdev =3D pdev; module_put(THIS_MODULE); return count; =20 --=20 2.47.3