From nobody Thu Apr 2 15:39:00 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA213876D6 for ; Fri, 27 Mar 2026 19:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639967; cv=none; b=uvSclk+8UaSR+zuuI0dOosYe0/KnLdClmwW8EkwyfFV3OmDBxzLAovCAGw/kf1yk0++rBOLc+8tNKvKWpa/BmqGatQTcQ5FGGc+A/J3BhifwaIRwblJWpCraFm/8eIRCw5CWHpj2JJ2a0a6KBc0oy/yztHSYo7ieD81b15/DJaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774639967; c=relaxed/simple; bh=6+2kBP0xFMlyP7Rqf4y/vpPGQhqSzW8u5Cx4E55/a6I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DGbbl3HYRMqR4hqjISHlY5OLzdhw5lKVxS3D92JIrJL9nxhG7e0RVvH5CcXrT2UYfXv+0cECDD4AlblODtx2xU+UVqXlyz6we7BeSu2uKstYEa8P5Cj1lqbDjaxN8Rs0WOabzvWbDzhqOB06m/TVvRTiAKuKJH3X8B5gNZSHZt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MWJoMl4E; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=I/uQPNtu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MWJoMl4E"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="I/uQPNtu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774639957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F2Xju4230th3m0bCLEm7u/PVwZF8WftpyZTqnsQeR4Q=; b=MWJoMl4ED2C9daSc5xT/fzeVnPc8LaXa2Fr0CosQQhTPeqC/5B5Jdc10SD+Gq0fPT1Awde u/SeVbuFv/SWUuK7tMCcgMTbMmk5QcgMGtRQT9JZ8h1N9DliZpFYnNZa5/WG5R8MUQzz2E Xs52aofttW4utUN8RABzFBtyp7TRFGY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-7IAfcX1HP_K6n2I6J86Y_g-1; Fri, 27 Mar 2026 15:32:35 -0400 X-MC-Unique: 7IAfcX1HP_K6n2I6J86Y_g-1 X-Mimecast-MFC-AGG-ID: 7IAfcX1HP_K6n2I6J86Y_g_1774639955 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b44f7b7bbso73357221cf.3 for ; Fri, 27 Mar 2026 12:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774639955; x=1775244755; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=F2Xju4230th3m0bCLEm7u/PVwZF8WftpyZTqnsQeR4Q=; b=I/uQPNtu5pkryilhGBv2We+zfqtfmphvTl/FoMLHKYV6mNSXKAbRLv+h3Z5bVnx3+/ Dk/4kVtaNRkipAJFFykl4XLSsLByUZ0EMC0sFB78VZmwDUnIljdOYOGp1QobfM8RcQsf K0SznOI06v6QRGw6UFTQk8q5z+NNk6uwGUDjJnaBy62bXvEJbRyiaIIxEZpPkbkI7dj1 m+IJXZXmFxDRI/pd8ai5RaxE85IaCS1xzmEkjKfzT5eD4LUvsHv8VhBT8okxIbqwVGsF e6FFm5KajO9CyKKTv0hLcsriEEzuaYc5cCDURI+SDBn6q00Lk3+WyPHbnulOej7xx4KD 5jHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774639955; x=1775244755; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=F2Xju4230th3m0bCLEm7u/PVwZF8WftpyZTqnsQeR4Q=; b=GdBlg+FpI77BYu8ATCchmA4GzhKZhCQgY8K18P9IqZz8ogDGZuxx7eSfSv1fbbf07r ZUjZjmQDetsPab/lVIA/T1Nj8zxctbCz3kswlSx/YAtX5S7idX3l9XYBPlI15NtEdjnA e98+S+CqdIdeymrJ8vIKRWCP3t57tFjqHrku3AxDlKi82nefdw3B7Ue0n1g8Bz6kdzV4 kfsLt3zVigAFE8v4myjaPn94uBi+o+jgvNKxMbULtCB0RNKTJgMXvBnCBooCJnqb60s5 2MSVeBw4FsFbf68SqfxtLhyk2HLEGEDK93B8ng2s0uPNxni0MLV6oWd19rGn8HbJRx6n LpjQ== X-Forwarded-Encrypted: i=1; AJvYcCXUmcQmqL2ZQvWBLX5Rf2BWHIFrEF8zF6tZ0zWWX5CPzXp53NlDvh4vhax5O4fCW8cy7uOdbWx8GXuqzVA=@vger.kernel.org X-Gm-Message-State: AOJu0YwIXcxwEn0W59RhfI2UvRrCBBG2GwF2CzWHFkQURM0uwFDX5dgs ZtCcBN83/lIWcCouppEKcPxDK2fIfmhv1msEzmL3QRRHIlDiC3N50Eyxe/n0N7ItwRjPTpo2Rkw kLUMAubdvaKfOnmBmo8VwoFXmn3IFV5SbOJZN/xUWvcU5uc+V2EuC3ge40OBdGsllrQ== X-Gm-Gg: ATEYQzwoYgAf+Ruut/GmpWZnSTwPQrBNxTm83FCNQFE2YCkg6p+apYX4mBCKdC2dFgg hZywm5SvuziOSv25fB9vBFu4E8+eBJkpJGkfCXNqvYVAMAruaix1mTP/xEfhd93YkUnpHVYVYlX a2jjm0b5+f798Dhp/Tr22cOP1g405Ls+lI/yH7p1rew4o/jVfx6vrkO49tnzccJ2+pg5ZtnBoYO 4pSuzKeT2Kh1ccDuZRC8jGwEmHEJClGel733CLpSrD1FZDoJ9CCww2GKX5zl/HtJoS/fhm2gJ7P FMuD1B/9ZCQ205MH/4ppAm4InEqnfIxigjbuMs1mdmutJOzl4eO/gakRhDedT1Q5sxfn5VmZzRY YdotRyjLZ8N/SIPDzbt2LrP9hrVhuo6LzRDRrOXmoLPyyXOTSA7q/80JwD4oN X-Received: by 2002:a05:622a:10a:b0:50b:3d9f:3846 with SMTP id d75a77b69052e-50ba38e6dcemr49601351cf.50.1774639954664; Fri, 27 Mar 2026 12:32:34 -0700 (PDT) X-Received: by 2002:a05:622a:10a:b0:50b:3d9f:3846 with SMTP id d75a77b69052e-50ba38e6dcemr49600981cf.50.1774639954182; Fri, 27 Mar 2026 12:32:34 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50bb2c678e9sm2037551cf.6.2026.03.27.12.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 12:32:33 -0700 (PDT) From: Brian Masney Date: Fri, 27 Mar 2026 15:32:03 -0400 Subject: [PATCH v8 8/8] clk: divider: test: mark some tests as supporting only v1 negotiation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-clk-scaling-v8-8-86cd0aba3c5f@redhat.com> References: <20260327-clk-scaling-v8-0-86cd0aba3c5f@redhat.com> In-Reply-To: <20260327-clk-scaling-v8-0-86cd0aba3c5f@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Alberto Ruiz , Brendan Higgins , David Gow , Rae Moar Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2823; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=6+2kBP0xFMlyP7Rqf4y/vpPGQhqSzW8u5Cx4E55/a6I=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKP3XaK2NLdx2Ugd9FG46zFttpNfQH3G/Vtzj+auNB1b cSR/W0CHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEwkxZuR4Z1U9auiv38O3d02 O9fZo3DqhruMAQ9KTJxcdTcwKa9+fpmR4ezTjYt17+2Z+LzTfuKuj/7fTnyT8/fiemN2p2pjMYe ZNxMA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Mark the tests that only support v1 negotiation to make it clear exactly which behavior is under test. Link: https://lore.kernel.org/linux-clk/aUSWU7UymULCXOeF@redhat.com/ Link: https://lpc.events/event/19/contributions/2152/ Signed-off-by: Brian Masney --- drivers/clk/clk-divider_test.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/clk/clk-divider_test.c b/drivers/clk/clk-divider_test.c index b55c822dfff018452f0a3acd4ad7ccec6f1259d4..e985b19a2b5ea4b8e7a1ba78631= f7ba3a19f625b 100644 --- a/drivers/clk/clk-divider_test.c +++ b/drivers/clk/clk-divider_test.c @@ -59,6 +59,15 @@ static const struct clk_ops clk_dummy_div_ops =3D { .set_rate =3D clk_dummy_div_set_rate, }; =20 +/* + * clk-divider.c has support for v2 rate negotiation, and setting the pare= nt + * based on the LCM, however we need to be able to test just setting the p= arent + * rate based on the LCM, and not set the v2 rate negotiation flag. This i= s to + * demonstrate existing behavior in the clk core when a parent rate that's + * suitable for all children is selected, a sibling will still have its ra= te + * negatively affected. Some boards may be unknowingly dependent on this + * behavior, and we want to ensure this behavior stays the same. + */ static int clk_dummy_div_lcm_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { @@ -184,6 +193,7 @@ static void clk_test_rate_change_divider_1(struct kunit= *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + /* This test is expected to work with both v1 and v2 rate negotiation. */ =20 ret =3D clk_set_rate(ctx->child1_clk, 6 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); @@ -216,6 +226,8 @@ static void clk_test_rate_change_divider_2_v1(struct ku= nit *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + KUNIT_ASSERT_FALSE(test, __clk_has_v2_negotiation(ctx->child1_clk)); + KUNIT_ASSERT_FALSE(test, __clk_has_v2_negotiation(ctx->child2_clk)); =20 ret =3D clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); @@ -252,6 +264,8 @@ static void clk_test_rate_change_divider_3_v1(struct ku= nit *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + KUNIT_ASSERT_FALSE(test, __clk_has_v2_negotiation(ctx->child1_clk)); + KUNIT_ASSERT_FALSE(test, __clk_has_v2_negotiation(ctx->child2_clk)); =20 ret =3D clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); --=20 2.53.0