From nobody Thu Apr 2 18:53:49 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10943B8BA8 for ; Fri, 27 Mar 2026 10:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774608726; cv=none; b=Q4kHNwmfu2MfdT9EeU3PL3ZF5L5S5DaulyVwNUPbzBunl0uG9uSC3YBEOlNfd+IH9XAu+II5oCjmm1jdWCHOy4ilv/cWDp8o+0zi1xlcd4NHkeQkHP0pldpRb+9A44OEavTieHZstsEfFvMg4F9LsXwYL8cFuc1J3zbZ1DMs4i8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774608726; c=relaxed/simple; bh=wM6wcfZG2Hp3NqdH/3MzNxHNKi1PZKPeYKr8ycK+xX4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d93yoHmyvssLCR5AWjpLApSLwVovr1x58yZc1uqC6ib3+MiCfwdcrrfrH3sun3hXCK0mo0mkk5BzuE8lxpLmR1lydO4siAkDpw/bKQFKklsBcEUCxaS1Bes8lA7iodkRQ2aeVKXsdriVrLud+E44Biwu2w2EsEXGCyoOcdNSfug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=YkbTOdsM; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YkbTOdsM" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D554201C; Fri, 27 Mar 2026 11:50:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774608642; bh=wM6wcfZG2Hp3NqdH/3MzNxHNKi1PZKPeYKr8ycK+xX4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YkbTOdsM4Yn3Ccl/zdQIi8qj/62sD5J7rOVv/nFgFCmfYWjz3qQ7lcRhgted3MA4c xvGlAzeRSY2qTU2lmr2H6yA65vQGnACGPq2xqE4ONQIg5ImomId0eDmIN2PmUmvbC/ khMZgjGGISuiot19C8oFDXOZGmUE5wTeYx+hNtc0= From: Tomi Valkeinen Date: Fri, 27 Mar 2026 12:51:41 +0200 Subject: [PATCH 3/3] drm/bridge: cdns-dsi: Fix mode and bus flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-cdns-dsi-fixes-v1-3-088edd40e97f@ideasonboard.com> References: <20260327-cdns-dsi-fixes-v1-0-088edd40e97f@ideasonboard.com> In-Reply-To: <20260327-cdns-dsi-fixes-v1-0-088edd40e97f@ideasonboard.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Devarsh Thakkar , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=wM6wcfZG2Hp3NqdH/3MzNxHNKi1PZKPeYKr8ycK+xX4=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpxmFNOdl1QHrBIbEK17SqSI9kTYbd47kW3xaTF RENgZU86beJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCacZhTQAKCRD6PaqMvJYe 9bxuD/0YSjl2TrOuCxS3KqXl96CShf05T1COvDWZ240nSYA/NLdQfH4sUXyuwCI1BxK20uRiLzr gL8O08bVVOj7YdojLwBEDVDdZ2wcnRcZine4b2oSL6DglEEooGH1KaucpDz5fMxxw3Rz+ksDMWx kDLcBvCpTsqrXsjSBcbqUONnNznzNuWr7NW9mhU203gIZbQYlUNBBVXDOwC5zzj60Lbl8LLpdES PZ2PHFjHdaYSUSzgvs+byZBOBvuTAAUglo4i6RUr6VpxSVQNFx1+xlGBwxJDN8yZAMoZAtV5nwD 3Iviyd8eJBCsls+3wOj4JTlUZE3JgtgzoD1hi32AjJd0YBJg04rpJP6e9Xqnj+jBOe0w+7dzgMp iZKGGBSZme57HAUR7YryDfqvxcWuUmwh6BygDpNtIG3CNfJu/2x5+IF8bNyLessXfIvnRNA0Cqb cCcdXnrDB2073zV+sJWEv+/GS3+0xj4TquU1AYjnprirHQv6b6jhCnGORMIMiqTyjob4K1Vpqce f9aRjRmf0Al/A4PXZLoFWv/w7bcTDXHPRWnKyNmIWaWnT1/921Hezg5PlcTe2/Ns/VL5BB6U+Cb wKVMIpTn1PRm3NuBKpOAjLs2UfRvvXiaMeBtzMsnqiG1Sz7HsiC6SbGdbCT90Iw0jwG3boygbGx uCjn7Gld8XdJNYw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 The driver adjusts the flags in adjusted_mode to force the source to send negative syncs. However, cdns-dsi also requires DE high, which is not handled at all. Add the correct DE high, along with explicit drive flags, via bridge_state->input_bus_cfg.flags. Also make the mode flags more robust: instead of passing the flags forward with corrected h/v syncs, just set the full flags variable, as there's no reason to pass any flags from the connector side to the source. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/d= rm/bridge/cadence/cdns-dsi-core.c index 439d56c69be9..ca95e7a6f61a 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -967,9 +967,11 @@ static int cdns_dsi_bridge_atomic_check(struct drm_bri= dge *bridge, struct videomode vm; long pclk; =20 - /* cdns-dsi requires negative syncs */ - adjusted_mode->flags &=3D ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); - adjusted_mode->flags |=3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC; + /* cdns-dsi requires negative syncs, and DE high */ + adjusted_mode->flags =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC; + bridge_state->input_bus_cfg.flags =3D DRM_BUS_FLAG_DE_HIGH | + DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE; =20 /* * The DPHY PLL has quite a coarsely grained clock rate options. See --=20 2.43.0